[
https://issues.apache.org/jira/browse/PROTON-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fraser Adams resolved PROTON-774.
-
Resolution: Fixed
> Fix warnings in log.c and url.c and re-enable -Werror
> --
[
https://issues.apache.org/jira/browse/PROTON-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245230#comment-14245230
]
ASF subversion and git services commented on PROTON-774:
Commit ed
Fraser Adams created PROTON-774:
---
Summary: Fix warnings in log.c and url.c and re-enable -Werror
Key: PROTON-774
URL: https://issues.apache.org/jira/browse/PROTON-774
Project: Qpid Proton
Issue
On Fri, Dec 12, 2014 at 02:37:53PM -0500, Rafael Schloming wrote:
> So what was the right thing to do here? I have to admit I struggled a bit
> with the git portion of getting the whole thing landed. The changes were
> (mostly) isolated to a subdirectory, yet whatever git incantations I seemed
> to
On Fri, Dec 12, 2014 at 02:15:21PM -0500, Andrew Stitcher wrote:
> On Thu, 2014-12-11 at 17:11 -0500, Darryl L. Pierce wrote:
> > Additionally, while working on a task branch, to resynch with master do
> > a rebase:
> >
> > $ rebase -i master
> >
> > rather than merging master down onto your tas
[
https://issues.apache.org/jira/browse/PROTON-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244760#comment-14244760
]
ASF subversion and git services commented on PROTON-772:
Commit c0
I'll stop spamming the lists with this message now - Evolution just stopped
trying to send it (7 times it seems) and so I couldn't tell it had already gone.
Time to get a better mail client.
Sigh, still weekend soon.
- Original Message -
From: "Andrew Stitcher"
To: proton@qpid.apache.o
[
https://issues.apache.org/jira/browse/PROTON-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-769.
Resolution: Fixed
Fix Version/s: 0.9
> Simplify the trace flag logic by only keeping
[
https://issues.apache.org/jira/browse/PROTON-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-771.
Resolution: Fixed
Fix Version/s: 0.9
> AMQP and SASL performatives are not validated
[
https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-770.
Resolution: Fixed
Fix Version/s: 0.9
> Refactor Proton C to eliminate the pn_dispatch
[
https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244749#comment-14244749
]
ASF subversion and git services commented on PROTON-770:
Commit 11
[
https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244750#comment-14244750
]
ASF subversion and git services commented on PROTON-770:
Commit d0
Alan recently landed a change which stops the proton library from
writing directly to stderr/stdout - this is a good thing (IMO).
However I question a couple of things:
1. This change adds to the external API and so should have been reviewed
(again IMO). reviews.apache.org now does work with the
Alan recently landed a change which stops the proton library from
writing directly to stderr/stdout - this is a good thing (IMO).
However I question a couple of things:
1. This change adds to the external API and so should have been reviewed
(again IMO). reviews.apache.org now does work with the
Alan recently landed a change which stops the proton library from
writing directly to stderr/stdout - this is a good thing (IMO).
However I question a couple of things:
1. This change adds to the external API and so should have been reviewed
(again IMO). reviews.apache.org now does work with the
Alan recently landed a change which stops the proton library from
writing directly to stderr/stdout - this is a good thing (IMO).
However I question a couple of things:
1. This change adds to the external API and so should have been reviewed
(again IMO). reviews.apache.org now does work with the
On Fri, Dec 12, 2014 at 10:56 AM, Ken Giusti wrote:
>
>
>
> - Original Message -
> > From: "Rafael Schloming"
> > To: proton@qpid.apache.org
> > Sent: Friday, December 12, 2014 10:21:04 AM
> > Subject: Re: Observations on the performance of the proton event model
> >
> > On Thu, Dec 11, 2
> On Dec 12, 2014, at 2:44 PM, Andrew Stitcher wrote:
>
> On Fri, 2014-12-12 at 14:21 -0500, Clebert Suconic wrote:
>>> ..
>>> On the other hand I agree that merging from master just before merging
>>> to master is irritating and pointless.
>>
>> The apache master can’t be rebased… Period! Wor
On Fri, 2014-12-12 at 14:37 -0500, Rafael Schloming wrote:
> ...
> > On the other hand I agree that merging from master just before merging
> > to master is irritating and pointless.
>
>
> So what was the right thing to do here? I have to admit I struggled a bit
> with the git portion of getting
On Fri, 2014-12-12 at 14:21 -0500, Clebert Suconic wrote:
> > ..
> > On the other hand I agree that merging from master just before merging
> > to master is irritating and pointless.
>
> The apache master can’t be rebased… Period! Work as you wish in your topic
> branch, your master or whatever
On Fri, Dec 12, 2014 at 2:15 PM, Andrew Stitcher
wrote:
>
> On Thu, 2014-12-11 at 17:11 -0500, Darryl L. Pierce wrote:
> > On Thu, Dec 11, 2014 at 04:16:29PM -0500, Clebert Suconic wrote:
> > > Rebasing and pushing is not a good option IMO. We have been using pull
> requests from GitHub and pushin
[
https://issues.apache.org/jira/browse/PROTON-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244658#comment-14244658
]
ASF subversion and git services commented on PROTON-772:
Commit a0
>
> I agree and disagree with this simplistic position.
>
> If (and only if) your task branch is yours and yours alone and no one
> has ever relied on it then you can safely rebase it. Actually I find
> that rebasing is a lot more useful to get my commits in a logical
> sequence of smaller work
On Thu, 2014-12-11 at 17:11 -0500, Darryl L. Pierce wrote:
> On Thu, Dec 11, 2014 at 04:16:29PM -0500, Clebert Suconic wrote:
> > Rebasing and pushing is not a good option IMO. We have been using pull
> > requests from GitHub and pushing them through Apache. It's working very
> > well for us.
>
On Thu, 2014-12-11 at 11:30 -0500, Darryl L. Pierce wrote:
> Would it be possible for someone (Rafi?) to fix the merge commits in the
Short answer is no!
I think you are asking for master's history to be changed and that is:
1) Not possible (fortunately) as the repo is locked down.
2) Not desira
[
https://issues.apache.org/jira/browse/PROTON-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244582#comment-14244582
]
ASF subversion and git services commented on PROTON-772:
Commit 7c
[
https://issues.apache.org/jira/browse/PROTON-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-773:
--
Component/s: proton-j
> No way to determine that link is detached (but not closed)
> ---
[
https://issues.apache.org/jira/browse/PROTON-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-773:
--
Summary: No way to determine that link is detached (but not closed) (was:
No way to determine t
[
https://issues.apache.org/jira/browse/PROTON-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244580#comment-14244580
]
Robbie Gemmell commented on PROTON-773:
---
Seconded. I had spotted this for proton-j b
Gordon Sim created PROTON-773:
-
Summary: No way to determine that link is detahced (but not closed)
Key: PROTON-773
URL: https://issues.apache.org/jira/browse/PROTON-773
Project: Qpid Proton
Issu
> On Dec 12, 2014, at 11:44 AM, Gordon Sim wrote:
>
> On 12/12/2014 02:38 PM, Darryl L. Pierce wrote:
>> On Fri, Dec 12, 2014 at 01:43:45PM +, Gordon Sim wrote:
>>> On 12/12/2014 12:16 PM, Darryl L. Pierce wrote:
I like the idea of pull requests and explicit peer reviews for changes.
>>
On 12/12/2014 02:38 PM, Darryl L. Pierce wrote:
On Fri, Dec 12, 2014 at 01:43:45PM +, Gordon Sim wrote:
On 12/12/2014 12:16 PM, Darryl L. Pierce wrote:
I like the idea of pull requests and explicit peer reviews for changes.
But it's above my pay grade to do anything more than envy such a wo
- Original Message -
> From: "Rafael Schloming"
> To: proton@qpid.apache.org
> Sent: Friday, December 12, 2014 10:21:04 AM
> Subject: Re: Observations on the performance of the proton event model
>
> On Thu, Dec 11, 2014 at 6:34 PM, Ken Giusti wrote:
> >
> >
> >
> > - Original Mess
On Thu, Dec 11, 2014 at 6:34 PM, Ken Giusti wrote:
>
>
>
> - Original Message -
> > From: "Rafael Schloming"
> > To: proton@qpid.apache.org
> > Sent: Wednesday, December 10, 2014 5:41:20 PM
> > Subject: Re: Observations on the performance of the proton event model
> >
> > On Wed, Dec 10,
> On Dec 12, 2014, at 9:57 AM, Darryl L. Pierce wrote:
>
> On Fri, Dec 12, 2014 at 09:48:05AM -0500, Clebert Suconic wrote:
>> In my experience there is no way to proper work with git without PRs and
>> peer review.. but that’s up to you guys.
>
> I feel like my comment, which was just a joke
On Fri, Dec 12, 2014 at 09:48:05AM -0500, Clebert Suconic wrote:
> In my experience there is no way to proper work with git without PRs and peer
> review.. but that’s up to you guys.
I feel like my comment, which was just a joke, might have been taken the
wrong way. For that I apologize...
--
D
> On Dec 12, 2014, at 9:38 AM, Darryl L. Pierce wrote:
>
> On Fri, Dec 12, 2014 at 01:43:45PM +, Gordon Sim wrote:
>> On 12/12/2014 12:16 PM, Darryl L. Pierce wrote:
>>> I like the idea of pull requests and explicit peer reviews for changes.
>>> But it's above my pay grade to do anything mor
On Fri, Dec 12, 2014 at 01:43:45PM +, Gordon Sim wrote:
> On 12/12/2014 12:16 PM, Darryl L. Pierce wrote:
> >I like the idea of pull requests and explicit peer reviews for changes.
> >But it's above my pay grade to do anything more than envy such a work
> >flow. :D
>
> Pay grade isn't relevant
On 12/12/2014 12:16 PM, Darryl L. Pierce wrote:
I like the idea of pull requests and explicit peer reviews for changes.
But it's above my pay grade to do anything more than envy such a work
flow. :D
Pay grade isn't relevant on an Apache project.
On Thu, Dec 11, 2014 at 06:47:06PM -0500, Clebert Suconic wrote:
> We do a slightly different approach. If you guys are doing git I really think
> you guys should consider it.
> > 1. create a task branch : git checkout -b my-working-branch
> > 2. create that voodoo that you do
> > 3. when done, re
On Thu, Dec 11, 2014 at 07:19:13PM -0500, Clebert Suconic wrote:
> Right but you can’t ever push -f on an apache branch. you can rebase as much
> as you like .. and it’s awesome I agree…
> But others would lose reference if you rebased and pushed -f.. that’s why
> it’s forbidden at the apache git
41 matches
Mail list logo
