[Prototype-core] Re: Official (or unofficial) compressed version of Prototype 1.6?
Prototype 1.6.0.3 unmodified + gzipped from Google's servers: http://ajax.googleapis.com/ajax/libs/prototype/1.6.0.3/prototype.js Firebug reports it's 31kb. On my filesystem it's 29,998 bytes. Prototype 1.6.0.3 minified + gzipped: Firebug reports it's 22kb. On my filesystem it's 21,564 bytes. Saved 9kb. * * * * * * Scriptaculous 1.8.1 unmodified + gzipped from Google's servers (includes builder, effects, dragdrop, controls, slider, sound by default): http://ajax.googleapis.com/ajax/libs/scriptaculous/1.8.1/scriptaculous.js Firebug reports it's 7 requests and 33kb total. On my filesystem it's ~30,235 bytes. Scriptaculous 1.8.1 minified + gzipped (includes builder, effects, dragdrop, controls, slider, sound): Firebug reports it's 21kb total. On my filesystem it's 20,246 bytes. Saved 12kb Include Prototype's 9kb savings for * 21kb total saved. * * * * * * * Prototype 1.6.0.3 + Scriptaculous 1.8.1 unmodified + gzipped from Google's servers (includes effects): http://ajax.googleapis.com/ajax/libs/prototype/1.6.0.3/prototype.js http://ajax.googleapis.com/ajax/libs/scriptaculous/1.8.1/scriptaculous.js?load=effects Firebug reports it's 3 requests and 42kb total. Prototype 1.6.0.3 + Scriptaculous 1.8.1 minified + gzipped (includes effects): Firebug reports it's 29kb total. On my filesystem it's 28,138 bytes. Saved 13kb * * * * * * jQuery 1.2.6 http://ajax.googleapis.com/ajax/libs/jquery/1.2.6/jquery.min.js Firebug reports 17kb. On my filesystem re-compressed with Packer 3 (var shrink) it's 15,142 bytes. Firebug reports 16kb. * * * * * * I don't see the trouble in providing a minified version. Every major js framework as had no trouble providing one. The only trouble I see is in user/developer relations when potential users get the impression that the core devs just don't care enough to provide one. (Even when handed everything to accomplish it.) In the readme_first.txt, included in the pack, I mention YUI compressor is compatible with Prototype's use of the $super variable and I provide a customized Dean Edwards Packer 3 (with $super support as well). I also link to articles about mod_deflate and provide a sample .htaccess setup for mod_deflate. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: new swap method for elements
Awesome use of nextSibling and parentNode! I have added my version which checks for the existence of the element.swapNode method (in IE). You can find it posted in the ticket. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: new swap method for elements
@Kangax I am not aware of any issues with insertBefore and table elements. I know that IE has issues with innerHTML and table/select elements. @EMoreth if nextSibling is null insertBefore will act as appendChild so it should still work out. http://developer.mozilla.org/en/DOM/element.insertBefore @Simon Here is my patch uses a 1 time check to fork for browsers that support swapNode. http://prototype.lighthouseapp.com/projects/8886/tickets/351-new-swap-method-for-elements#ticket-351-4 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Fwd: Where is the source?
The core devs are in the process of cleaning up the 1.6.0.3 release: You may check Tobies 1.6.0.3 branch: http://github.com/tobie/prototype/tree/1.6.0.3 - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Slidedown menu
I am not sure I see a right hand side menu effect. You should really post this kind of question in the user list: http://groups-beta.google.com/group/prototype-scriptaculous Try searching scripteka: http://scripteka.com/ If its just a hover effect a lot of the time you can just use CSS and no js, esp with anchor tags which support :hover in all browsers. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Element wrapper draft notes
@T. J. Crowder take some time to look at the jQuery source, it might
help with the wrapper discussion.
I was not suggesting that $$() return a list in some cases and a
single item in others. I was saying that
getter/setter methods would execute on the first matched item.
In jQuery (jQuery syntax):
$('#footer') - returns a jQuery instance (in our case it would be a
NodeListWrapper);
If you example the object it looks like:
NodeListWrapper[0] - div#footer (the html element)
NodeListWrapper.length - 1
NodeListWrapper.observe - method
NodeListWrapper.toggle - method
NodeListWrapper.each - method
NodeListWrapper._each - method
NodeListWrapper.show - method
NodeListWrapper.getValue - method
NodeListWrapper.update - method
the jQuery object and thus our NodeListWrapper will mimic an array,
it has a length, and index properties.
When you call a getter method then it executes on the first matched
item
NodeListWrapper.getHeight - execute on the first matched element and
not iterate over the list
NodeListWrapper.getStyle - execute on ...
NodeListWrapper.getDimensions() - ...
so $$W('#id').getHeight() - is the same as - $$W('#id')
[0].getHeight();
$$W('#id')[0] is an element in jQuery but if we wrap ours in a
NodeWrapper too then
$$W('#id')[0] would be the NodeWrapper
$$W('#id')[0] instanceof NodeWrapper would be true.
$$W('#id')[0].raw() would be the element,
now we can talk about if thats too many wrappers or what not,
but I think the approach of $$(selector)method is a good one.
Now we could do this:
NodeWrapper.raw() - gives you the element;
NodeWrapper.raw(element) - sets the element;
and the internal var _raw is private;
so that by the rules above if Prototype were modified $$W - $$, $W -
$
$('id').raw() - the element
$$('#id').raw() - the element (its a getter/setter so it executes on
the first matched)
$$('.panels').hide();
$$('.panels:first').hide();
$('myPanel).raw().tagName
$('myPanel).get('tagName');
There would be no internal raw item for the NodeListWrapper because
like the jQuery object
its items are part of its indexed properties.
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Element wrapper draft notes
// if source is a method
$$(css).source() - equiv
$$(css)[0].source() - equiv
$$(css).first().source() - equiv
you could always cache it
var source = $$(css).source();
// an array of sources
$$(css).invoke('source'); // OR
$$(css).each($$.source); //notice static $$.source method
$$(css)._each($$.source); // faster than all of them :P
if source is a property
//no soup for $$().method
$$(css)[0].source
$$(css).first().source
$$(css).pluck('source');
//get height of first matched item (equivs)
$$(css).first().getHeight(),
$$(css)[0].getHeight(), and
$$(css).getHeight() are equivs.
// array of heights (equivs)
$$(css).invoke('getHeight');
$$(css).each($$.getHeight);
$$(css)._each($$.getHeight);
//setters
$$(css).update(...); //sets all matched items
$$(css).setStyle(...) //sets all matched items
$$(css).addClassName(...) // does it to all matched items
$$(css).show().observer('click', ...); // shows all matches and
attached an onclick observer to all of them.
// get element by id
$(id).hide();
$(id).source() or $(id).source (whichever we decide)
$(id).source()._prototypeWrapperID //the id that the cache looks at
$(id).source()._prototypeWrapperID - [2]
// its an array with a number in it
because it wont transfer when you clone the node, this is how
its done in the current event system when element._prototypeEventID is
set.
We mod Class.create to allow the initialize method to return a value
so then:
Prototype.NodeWrapper = Class.create({
initialize: function(...) {
// ...
if (Prototype.isWrapper(element)) { // some check for wrapper
return element;
}
// ... resolve element from ID or whatnot
var cacheID = (element._prototypeWrapperID || [null])[0];
if (cacheID) {
return Prototype.NodeWrapper.cache[cacheID];
}
// set source, however that is decided on.
this._source = element;
}, // ...
})
The reason we name it source instead of element or dom
is so we can always know what the source of a wrapper is without
having to guess if its an
Element wrapper to check for element if its an event wrapper to
check for .event.
we would know its always .source.
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype's use of global variables
Johan, when we say wrapper we don't mean a div in HTML. We mean instead of extending the native DOM elements $(element) - returns an extended dom element $(element) - returns an instance of a ElementWrapper class the class interacts with the element but does not extend it directly. see kangax's new thread: http://groups.google.com/group/prototype-core/browse_thread/thread/c05add9fabd5a00c - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Element wrapper draft notes
Kangax looks good.
I think that it should be $() instead of $W(), but for the purpose of
clarity during the
discussion the use of $W is fine.
I think that any method that returned element, will instead return
NodeWrapper.
Any method that returned an array of elements will return a
NodeListWrapper.
(In implementation I think $$() should be used but for discussion $
$W() will be used
to avoid confusion)
$$W('input:not([disabled])').highlight();
$$('input:not([disabled])').invoke('highlight');
I think we should follow jQuery's lead here and extend the
Element.Methods and Enumerable methods
to the NodeListWrapper.
$$W(...).each, $$(...).without, ... $$(...).hide(), $$(...).observe
If the node list returns 1 element then methods like $$
(...).getValue() should return the value of that element.
(this is how jQuery handles it)
I think $A should return a ListWrapper, maybe ListWrapper could be the
$super for NodeListWrapper.
ListWrapper would have methods of Array Additions and Enumerable
methods.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Element wrapper draft notes
@Key Snyder - correct I was assuming Array.prototype was not extended
and that we were using wrappers.
@kangax
I don't think there would be confusion with things like $$
(..).getValue() here.
Keep in mind users do use the equiv of $$('#myId') and that in those
cases you are expecting 1 result
so the desired behavior of a readAttribute, or getValue or anything
getting a property
is to return from the only matched item.
jQuery takes $('input').val(), (our $$('input').getValue()) and only
returns the value of the first item regardless of how many elements
are matched.
If you want an array of values then $$('input').invoke('getValue')
would do.
I think millions of downloads and that its popularity among casual/new
programmers
speaks to its ease of use.
Anyway I like the direction things are headed,
can't wait to start hammering on code :).
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype's use of global variables
@kangax
Whatever the name is I think it should be used in all wrappers.
This makes it consistent.
If you want to check if a wrapper is of a certain instance.
if( wrapper instanceof Prototype.Node ) {
//wrapper.raw
}
else if (wrapper instanceof Prototype.NodeList) {
//wrapper.raw
}
...
I like using the get/set methods
element.get('tagName');
element.set('disabled', 'disabled');
might blur the line between attribute and property though.
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype's use of global variables
If a cache is to be used it can be uniquely marked via the same
approach as elements in the event system
element._prototypeWrapperId = [arguments.callee.id++];
the id is unique and doesn't transfer if you clone the node.
var instance = Prototype.Element.cache[ element._prototypeWrapperId ];
if (instance) return instance;
This would work well with this patch (allowing Class.create to return
a value).
http://dev.rubyonrails.org/ticket/11481
Some host objects may not allow the addition of custom properties
though, and in
those cases they wouldn't get cached.
I like having a common property for the wrapped object (+1 for the
suggestion):
var el = new Prototype.Element(element);
el.raw, or el.obj, or el.wrapped, or el.source.
I kinda dig el.source
We don't have to worry to much about naming conflicts because this is
a property of the wrapper instance and
not of the Element host object.
I like the imports idea. I think adding custom prefixes is a bit
much though.
(or maybe its just the method name that bothers me)
Checking if the object you are dealing with is extended is as easy as
if (element instanceof Prototype.Element)
There has been reports of Prototype loosing the properties assigned to
String static object when dealing with Flash's externalInterface
(flash/js communication)
I think using a wrapper is pretty painless and we can see this via:
var text = $.str(text);
text.strip();
I also like Kangax's idea to use $A for wrapping arrays, it feels like
the natural choice.
var arr = [1,2,'bob'];
$A(arr).each(function(n) { ..});
As a bonus I think we should follow jQuery's lead and allow
$$(selector).hide() or something. If $$ is a selector wrapper, I would
want to be able to do
$$(selector).hide() instead of $$(...).invoke('hide') or instead of $$
('#input')[0].getValue() - $$(...).getValue();
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Roadmap for 1.6.1 (My take)
I haven't seen the official roadmap for 1.6.1. So here is my take on it. 1.6.0.3 was a bug fix release. I see 1.6.1 as an optimization and new feature/API release. I see things like: * Use of documentFragment (Huge IE boost in spots), * Use of _each instead of each in places were we can * Remove the event onunload mechanism for IE (I have a working prototype of it) * Avoiding wrapped methods internally (Element.method(element) instead of element.method()) * Implement hasOwnProperty for Safari 2.0.4 (can finally use it in the rest of the code) * Make $H(...).include() work properly * Pass optional conditionals to methods like Element#show, Element#hide and others) * Optimize the Template class. * Make Element#getStyle automatically convert units to px and handle the inherit style. * Use of Dimensions class * Create various methods where needed: - Object.isNodeList() - Element#isOrphaned - Element#getNumericStyle [cssToNumber] * Ajax Fixes: - Network error fixes - Timeout added - Abort added - Detect when status 0 is allows (when its ftp or file protocols) I am sure I missed a few, but the good news is almost all of these listed features/modifications have already been programmed. We should be able to create the tickets and unit tests rather fast. Do yall have anything else to add? Here is a list of tickets currently marked to be addressed for 1.6.1 (not nessesarily included in 1.6.1) http://prototype.lighthouseapp.com/projects/8886-prototype/tickets?filter=page=1q=state%3Aopen+milestone%3A1.6.1 - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Roadmap for 1.6.1 (My take)
Also utilizing element.ownerDocument more (this will help in compatibility with iframes). Maybe a Element#getDocument(), getBodyElement, getRootElement. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Need some testing and or cleaning up of the Element#relativize method
Here is a Lighthouse ticket: http://prototype.lighthouseapp.com/projects/8886-prototype/tickets/197-code-review-of-element-relativize-git-core --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Need some testing and or cleaning up of the Element#relativize method
All right :), http://github.com/sstephenson/prototype/tree/master/src/dom.js#L578 As you can see there is a bit of code in the git core that I think should really be examined and cleaned up or commented. //Why do we do this? var offsets = element.positionedOffset(), top = element._originalTop - offsets.top, left = element._originalLeft - offsets.left; //Why does this work with this in var isAuto = /^(auto|)$/; if (!isAuto.test(element.style.top)) top += element._originalTop; if (!isAuto.test(element.style.left)) left += element._originalLeft; //Without it unit some dom_tests (unit tests) fail. Any ideas or insight would be great. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Latest Git - IE6 cumumlativeOffset issue
Hello Ryan,
Thanks for the example.
I used this favlet to run the site using the git version of Prototype
and I do see the issue under IE.
javascript:var
s=document.createElement('script');s.setAttribute('src', 'http://
www.protolific.net/prototype-git.js');document.body.appendChild(s);void(s);
I should have some time during lunch today to see if I can make a
patch for it.
Thanx,
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Latest Git - IE6 cumumlativeOffset issue
Can you provide a test snippet? You can compare the differences between the two versions here: http://www.protolific.net/step-by-step/24.png As you can see in the comparison the new version does not allow document.documentElement to be returned as the offsetParent and the old one did. I suspect that is whats causing you problems. All other browsers return document.body and never (that I have seen) document.documentElement, so this is making it consistent. When you provide a snippet I can properly see if this is the case. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
I think that the css:loaded would probably be the best way to go so it doesnt delay the dom:loaded event Opera uses the disabled approach (what if a style sheet it set to disabled in the html though?) and Safar used the length approach. The length approach may cause issues with import as this test page points out (the length is reported as 5 (because of the import) and there are only 4 stylesheet elements http://www.quirksmode.org/dom/tests/stylesheets.html - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Improving String.strip performance
Also some other performance tips: http://www.sitepen.com/blog/2008/05/09/string-performance-an-analysis/ disccomp, feel free to submit a ticket and a patch for the current String#strip http://www.prototypejs.org/contribute - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
Diego, Is line 394 ok with a specific check for Opera? http://github.com/jdalton/prototype/tree/master/src/event.js#L394 I heard Opera 9.5b doesn't have that issue (but I think that may be getting to granular). My main goal with the browser sniff is to avoid unnecessary iterations of the dom on browsers that don't require that check. Also is the stylesheet check needed for safari on line 422 as well? Thanks, JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: emitting normal HTML events with Event.fire
I think Prototype should support something like this, though I am not sure if your patch is the best way to do it. I will have to look at it closer. I flagged the ticket for 1.6.1. Also Juriy has his version of simulating events - http://github.com/kangax/protolicious/tree/master/event.simulate.js Your patch does seem to dictate if the event is cancelable or whatnot out of the gate, while Juriy's has all of the cancelable and bubbles set to a default value. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
Thanks Diego, Good catch on the timeout, clearing the timer variable is probably the right way to go :) So maybe we I should remove the Opera check considering other browsers may support the HTML 5 spec as well. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Suggested utility method(shortcut) $T for getElementsByTagname
IE has issues extending XML Nodes.
See http://dev.rubyonrails.org/ticket/9709
You must use Element#methodName instead or make a wrapper for it:
Something like:
(function( ) {
var methods = Object.keys(Element.Methods).inject({ }, function(m,
name) {
m[name] = function() {
return Element.Methods[name].apply(null,
[this.element].concat($A(arguments)));
};
return m;
});
window.XMLWrapper = Class.create(methods, {
initialize: function(element){
this.element = element;
}
});
})();
function $xml(element) {
return new XMLWrapper(element);
}
or Something
usage:
$xml(node).readAttribute('foo');
Maybe tie the wrapper in with a variation of Andrew Dupont's
bindable extensions:
http://github.com/savetheclocktower/javascript-stuff/tree/master/bindable.js
However, it wouldn't work for methods that extend child elements,
that would require modification to the Element.extend method.
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
Diego Perini, in IE dom:loaded is a custom event, custom event use the ondataaviable event as a vessel to ride the event bubble and other things. that is why you see that. use event.eventName instead of event.eventType. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
Added the following updates to the event system in my fork: Fix issue with how IE wrappers.dispatcheriterates over list of wrappers: http://github.com/jdalton/prototype/commit/bfa0ea8da441d53983dd4223248991b3329ab93f Add unit tests for the wrapers.dispatcher fix : http://github.com/jdalton/prototype/commit/2008f6afe2a92d023f557300e4475f70f5162ca6 Increase speed of wrappers.dispatcher() : http://github.com/jdalton/prototype/commit/fb073dd6a24f0d8242cc7b402c76beaac25a4f3a Add proceed variable to the arguments.callee.defer call in the addEventDispatcher for the window load event: http://github.com/jdalton/prototype/commit/de8bda109963bcd7b92e0d7a480c3954fc6c24b8 - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
I just looked through the code and realized we were handling the IFrame issue :), thanks Diego for pointing that out :). --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
Hi All, I haven't read all the posts, but I have applied Samleb's patch which uses the doScroll jQuery method and fixes the first-in-first-out order. I have also fixed the window onload triggering before dom:content loaded and fixed the multiple window resize calls for IE. I have tested the patch and it seems to work for me. I have used it in my current applications without issue. Using the doScroll approach seems to also fix the seemingly random IE7 fail with the current 1.6.0.2 implementation. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: DOMContentLoaded for IE
[#9394] window onload executing before all of the contentloaded observers are executed: http://dev.rubyonrails.org/ticket/9394 Patch 1 http://github.com/jdalton/prototype/commit/4d4ca98fa6f8994b873984f1485c5b496fadecb8 Patch 2 http://github.com/jdalton/prototype/commit/038aca8ed75a65a3438ec52a4c2f93a5b1efaada Patch 3 http://github.com/jdalton/prototype/commit/dada5cee7e8a959dee2ea82961981ee2261130a8 Unit Tests http://github.com/jdalton/prototype/commit/527dc7ea92f98cff14b43153a4ac3500cee51527 Changelog http://github.com/jdalton/prototype/commit/253332aec4c9e4a97630eeb2d3f8b367696fc24e -- Also -- [LH#64] Safari now has DOMContentLoaded event, use it: http://prototype.lighthouseapp.com/projects/8886/tickets/64-safari-now-has-domcontentloaded-event-use-it Patch http://github.com/jdalton/prototype/commit/1b7289aef2fc86dc584be83aa8717158c3e15fce Changelog http://github.com/jdalton/prototype/commit/c29474cd439d5c3b9766f7d9da7e07d1428794bc I think jQuery handles the iframe issue via using parent or top or something. We should probably do the same (I am not familiar with the issue and haven't had time to read up on it) - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: GIT's equivalent of the ChangeSet number.
I don't think GIT supports the keywords in files like revision and others. I remember wondering that myself. After a quick google I saw a post on the git mailing list that shot down the idea of using the key words. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
Patches here: http://github.com/jdalton/prototype/commit/723c26518392d838cf9ec368eddfba0c1874bac1 and http://github.com/jdalton/prototype/commit/8eaae75066531993eba13df5eb1469016435843b they need unit tests though :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
Patched to work with getValue, setValue. http://github.com/jdalton/prototype/commit/3b03b76660bc29ba5d8a6ef4e06c99c8faded107 Unit tests: http://github.com/jdalton/prototype/commit/101d23d64aba2c0c459c97fa684a9079a7beb140 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
The getValue and setValue, use the Form.Element.Serializers anyway. So when I added serialization it adds the getValue and setValue. The browser sees the innerHTML of the button element as its value so this is consistent. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements
Thanks for the tests Geoff, I have uploaded them here: http://protolific.net/memory_leak_testcase.zip I patched the Prototyep 1.5.1 file. There is a second file named _prototype_1_5_1.js which is my latest git version compiles (so it is really 1.6.0.2+ with the patch in it is as well. I still get the memory leak with both patched versions. I think it has more to do with the number of nested frames than it does with String#escapeHTML. When I close the child window the memory usage drops down (I am using the windows task manager and looking at the IE process). When I refresh the child window the memory usage does not increase (this shows that maybe its not a leak). However, Drip suggests the the memery is never released.Wwhen refreshing the child window in drip it stair steps the memory usage. This may just be a Drip bug. In your 1 MB leak example you load Prototype js 4 times - 1000kb/4 = 250kb per page instance.(you have a body page without Prototype as well that is propbably using up some of that memory as well) Can you try the tests that I have linked to and confirm that the memory spike is still an issue with the patches applied (maybe check the patch to see if it's applied write). - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: simple suggestion
I think kangax used to have something similar in his: http://github.com/kangax/protolicious/tree/master/helpers.js Though I cannot seem to find it now :) - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: out of memory exception in last version of protoculous
Turns out it was a firebug bug and not related to the compressed or minified files. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements
Patch addresses the memory leak: http://github.com/jdalton/prototype/commit/0353246ac2ad439260905799798f0069d9a7d0ca Patch addresses other issues with escapeHTML and unescapeHTML: http://github.com/jdalton/prototype/commit/6010a300c39b0c66394706e9edb8b110b5932d9e Unit tests for the patch: http://github.com/jdalton/prototype/commit/1fcf26a2810da2e8fee7323e1613dfad094181f8 I think there may be other places where we attach elements, I will see if I can duplicate this over the weekend. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: out of memory exception in last version of protoculous
Hello Rauan, Which version of protoculous are you using, (1.6.0.2 + 1.8.1) protoculous-shrinkvars.js? Have you tried using the regular prototype and scriptaculous. Can you try to create a reproducable test for me. Also for future reference please send questions to my gmail account. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Why document.domain in isSameOrigin?
Please submit a bug ticket: http://www.prototypejs.org/contribute - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Utility method and frames
Hello Steffen ,
For future reference, this post should have gone to the users mailing
list:
http://groups.google.com/group/rubyonrails-spinoffs
Here is a patch to make Prototype more iframe friendly:
http://dev.rubyonrails.org/ticket/11475
Your usage of the dom:loaded observer is incorrect.
Should be something like:
document.observe(dom:loaded, function(){
$(parent.document.body).select('a.csh-link').each(
I believe both documents should be on the same domain as well. :)
- JDD
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Timeline for supporting native array methods?
Hi Richard, I was a little bummed by the switch at first as well. Now though I am beginning to see the cool side of it. For example before when you wanted to contribute you had to make a patch that would only work for the current version of Prototype and probably not the version that was in SVN (SVN is very picky about patches). With Git and GitHub you can create a forked repo of prototype. Commit your changes to it and send the core devs a pull request. Then they merge the changes into their repo :). Also this allows you to target a specific dev or group of devs and there are lots of options with Git. GitHub is hooked into Lighthouse (Prototype's new home for bug tracking) as well. It is command line at the time and the GUI's for it are very very basic. I am still learning it. I did have some issues getting my fork to pulldown, turns out I needed to log into my pull address via putty first to get it to save some registry info. Here are some links: Windows version of Git: http://code.google.com/p/msysgit/downloads/list Helpful links: http://www.sourcemage.org/Git_Guide http://www.kenegozi.com/Blog/2008/04/01/gitself-take-one.aspx http://github.com/guides --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] JDD - my github fork for patches
I have started moving over some of the patched from trac to my github fork: http://github.com/jdalton/prototype/commits/master Please let me know if something should be dropped, altered or modified in anyway. I am currently sending pull requests to Tobie only, should I be sending them to others as well? So Scripty doesn't feel left out I will send a couple patches it's way too :) http://github.com/jdalton/scriptaculous/commits/master (At the time of writing I have not pushed anything to my scripty fork) I don't know if you all can pick n' choose the commits to apply or if it cascades all the previous commits when you accept a push. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: ie try to load 'http://:/' right after prototype 1.6.x loaded
This was originally used to allow this method to not have to pull down a real file and to avoid https issues in IE. This ticket: http://dev.rubyonrails.org/ticket/9394 Patches it to use a different method (maybe one that is more stable with IE7 as well) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] pdoc-scriptaculous svn repo started.
I have started a pdoc-scriptaculous google code page. Visit the user list post for more details: http://groups.google.com/group/rubyonrails-spinoffs/t/32b29609203e209e --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype: AIR compliant?
You can lead a horse to water but you can't make em' drink :). --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype: AIR compliant?
Here is a patch for it (I modified 2 lines of code): Please test and report back on the ticket if it works: http://dev.rubyonrails.org/ticket/11530 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype: AIR compliant?
I tested the patch and it turns out that the eval() in the Selector class isn't a problem becuase Adobe Air uses the compileXPathMatcher() and bypasses the eval. The only issue must be the evals used for scripting and the patch takes care of those as well. Other than that I can't see an issue with my Tests. Have yall had any issues or did you just assume Prototype wouldn't work? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype: AIR compliant?
Prototype does seem to work out of the box with ADOBE AIR.
The script insertion that the patch for Prototype.exec()
provides does not work under ADOBE AIR, but it does not error out
either.
If you want to eval code you can do somethign like this though, AIR
allows:
function exec(code){
new Function('', code)();
}
//usage
exec('alert(Hello World)'); //alerts Hello World
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Prototype: AIR compliant?
Prototype has been using the compileXPathMatcher() for xpath support since 3/09/07 http://dev.rubyonrails.org/changeset/6366 There shouldn't have been any issues with it since then, unless ADOBE AIR didn't support XPath until recently. Reguardless Prototype seems to work just fine. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Ajax.Request.success() request abort bug? (FW: Ajax.Updater Question)
Also a different patch for solving the same problem. I check the window.location.href and the url of the ajax call to determin if its file or ftp protocol then allow zero or not. http://dev.rubyonrails.org/ticket/10030 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Ajax.Request.success() request abort bug? (FW: Ajax.Updater Question)
This ticket here: http://dev.rubyonrails.org/ticket/11434 mentions asolution for dropped connections in Firefox. It might work on other browsers as well. Basically they attach a callback to the onError native event handler of the transport. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: String.prototype.exec()
I have updated it with a version that reduces some overhead by using closures, thanx kangax. Yes Prototype would use Prototype.exec() instead of eval inside the ajax methods. http://dev.rubyonrails.org/ticket/11284 http://dev.rubyonrails.org/ticket/8112 I don't think this form of code execution is allowed by Adobe AIR either (I think they block script insertions, don't hold me to that though). I think AIR does allow eval in some cases I believe for things like json . The only place that needs an extension to work for AIR is in the Selector class. Since a lot of the code is based off of Ext's selector class the ext- air-adaptor js might be useful in creating a prototype-air-adaptor companion js. http://www.adobe.com/devnet/air/articles/introduction_to_air_security.html -JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: String.prototype.exec()
You are right, it errors because of appending the text node. appendChild must be used to trigger the error :) Here is the modified code. http://pastie.caboo.se/169837 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Prototype: AIR compliant?
With all the buzz last week and this about frameworks being Adobe AIR compatible. I am wondering if the Prototype Team has tested Prototype with AIR's new security model. I know prototype uses eval(), 3 times: String.toJSON(); // should be ok in AIR Ajax.Request.evalResponse(); //could choke if not JSON Selector.compileMatcher(); //should will choke on AIR Also I noticed some frameworks like jQuery had to adjust their browser sniffing code for safari to include something like: !/adobeair/ i.test(userAgent) More info about the AIR security model: http://labs.adobe.com/wiki/index.php/AIR:HTML_Security_FAQ You might use Ext's air-adapter js and as a guide because it modifies DOMQuery's compile method to avoid the use of eval(). -JD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
A two parter: 1) Would that mean t modifying he dom.html unit test to test for this? 2) I ran the unit test with prototype 1.6.0.2 downloaded from prototypejs.org and in each browser diff tests fail. Does this mean that there are issues with the current code base that are still needing to be resolved? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
I suspect the unit tests are tailered for the current revision in svn.. time for me to dload rails... or manually compile me some js. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
Rock! Updated the ticket, passes the dom.html unit test with flying colors. Also added a modified unit test that contains tests for this ticket. The files of importance are ie_attrib_patch.diff dom.html http://dev.rubyonrails.org/ticket/11092 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
i will ass ^ $ no need to go looping --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
this patch doesn't solve the issue entirely if you have a child element with the id=parentNode and the parent element tries element.parentNode it will return the child with the id parentNode. bummer. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
http://dev.rubyonrails.org/ticket/11092 updated the ticket with an alternative fix which works for everything except child elements with duplicate id's. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
woopsie *add, and ticket updated thanks Ken! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: readAttribute() differences IE and Firefox
ticket + patch for the bug: http://dev.rubyonrails.org/ticket/11092 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] updated Selector.findChildElements to defer to [node].querySelectorAll() if it's available. [PATCH]
I modified Prototype to allow for the use of native CSS selector support. http://webkit.org/blog/156/queryselector-and-queryselectorall/ I have attached a screen shot of the performance boost running on the nightly build: http://nightly.webkit.org/files/trunk/win/WebKit-SVN-r30154.zip (built on Feb 11th 08) You can run the tests for yourself at (they are the same as David Smith's) : http://www.protolific.net/slicktest/ Performance boost of about 80%. Ticket and Patch: http://dev.rubyonrails.org/ticket/11085 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: protopacked
Hello, Please direct future questions to the email sipplied in the readme_first.txt. If you are referring to the base 62 encoded x_packed.js versions, that appears to be part of Dean Edwards' Packers code and I would not remove it. - JD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: protopacked
I really suggest usig the varshrink versions and gzipping them. You get the smallest file size most of the time that way and no clientside delay for js decoding. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Please add missing documention:
Hi all, The following methods are missing documentation: Element.setOpacity(); Function.argumentNames(); Function.methodize(); Thanx, - John-David --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: ProtoPacked v2.17: Prototype 83%, Sciptaculous 84% smaller
Additional note: Protoculous also allows the loading of additonal js files like Scriptaculous via: protoculous.js?load=addons --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: ProtoPacked v2.17: Prototype 83%, Sciptaculous 84% smaller
You can gzip the var-shrunk versions (which isnt decompressed so its faster loading) and the filesize goes from 27.5kb to 20.4kb or so. As I said above it was enough to add the Effects.js from Scirpty and still be lower than normal Prototype gzipped. :) - John-David --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: API Request: Function.argumentNames(); Function.methodize();
Thanks for clearing that up. I knew what the first one did but not the second. I was actually stating that the API docs dont have these in it. Could one of the core team add these methods to their documentation. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Enumerable Map() oddity.
Hi guys,
This is really not a bug but I thought I would bring it to your
attention.
$$('[type=radio]').map(function(el){return el.next()}); // = [label,
label]
$$('[type=radio]').map(Element.next); // = [label, undefined]
The map method is passing 2 params to the iterator.
This makes the Element.next() go nuts cause its second param is used
for sibling offset.
In PHP array_map only passes the value and not the index.
It makes since for Enumerable.each() to send both, but I think map
should be left to just the value. I image there are more cases where
this sort or error would occur.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Enumerable Map() oddity.
Thanks Sam ! :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Bug in the compressed and formatted code
Thanx xinze, In the readme_first.txt file I point out that I had implemented some patches from various tickets. I goofed the patch on that one. http://dev.rubyonrails.org/ticket/8843 should have been: results.push($(query.snapshotItem(i))); I will fix this bug and release a new package when time permits :P - John-David --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Alex Arnell Inheritance thread.
I figured I would create another post pointing to Alex Arnells Inheritance thread (per Mislav's request). I am interested in his additions and approach. I dig the private vars and the ref to the class as well as the instance and parent. Alex Arnell wrote: Here is a Pastie link to a concrete example. http://pastie.textmate.org/90584 Alex Arnell --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
