Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file30040/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
The promised comments have been added to the patch. The refactoring of the
pre-existing tests is not part of this patch. But I'm uploading this now as the
patch does fix the issue.
--
Added file: http://bugs.python.org/file32960/issue-15518-1.patch
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29745/test_filecmp_layouts.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Reformat the filecmpdata directory layouts diagram.
--
Added file: http://bugs.python.org/file32961/test_filecmp_layouts.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29746/test_filecmp_reports.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Reformat the filecmp test report matrix.
--
Added file: http://bugs.python.org/file32962/test_filecmp_reports.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Formatted test directory layout.
--
Added file: http://bugs.python.org/file32963/layouts.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Format the martix of test reports.
--
Added file: http://bugs.python.org/file32964/reports.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Eli Bendersky added the comment:
Thanks for the heads up Chris. Since I'm a bit busy myself lately, it's fine to
wait until you have time to complete the patch. I'll review it then.
--
___
Python tracker rep...@bugs.python.org
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29758/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
I'm uploading a new patch which gets rid of the temp_cwd calls as suggested in
the review. The patch is not complete in that the explanatory comments
suggested in the review and revising the pre-existing tests have not been
completed yet. However, I want to
Eli Bendersky added the comment:
Thanks, looks much better now. I left a couple of small comments in the code
review. Other than that, it makes sense to me to update the existing tests to
follow this scheme as well. Thanks!
On a related note, since you've obviously studied the filecmp
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
I replaced issue-15518-1.patch. I believe it now addresses all the concerns
expressed thus far. If reviewed favorably, I will extend it to clean-up the
pre-existing tests to address the concerns noted about them, especially since
the filecmpdata directory
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
The attached file test_filecmp_layouts.rst documents the directory and file
layouts for complete test coverage of filecmp.dircmp report methods to aid in
review discussion of patch.
--
Added file:
Chris Calloway added the comment:
The attached file test_filecmp_reports.rst documents the reports generated by
filecmp.dircmp test methods if the directory and file layouts in
test_filecmp_layouts.rst are followed to aid in review discussion of patch.
--
Added file:
Chris Calloway added the comment:
The attached patch issue-15518-1.patch replaces previous patch proposals for
this issue.
The patch implements the suggestion to factor code common to report TestCase
classes into a common base class BaseReportTestCase. Apologies for not having
that in the
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29747/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't
need super().
--
Added file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
A lot of the code in the tests is devoted to building the tested directory tree
and populating it ( _setUpDirectories and related functions). You keep building
and deleting this tree for every running test.
I think that a better idea would be to just create
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file26635/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
OK, I got to participate in my Python user group hack night this week where I
actually got to work on my projects instead of spending all night helping
newbies on their projects. I used the time to refactor all the previous patches
for this issue on which I
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29681/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
Replaced patch to fix a few under-informative test messages.
--
Added file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Yes, that's why I opened it. Feel free to submit patches if you think I'm
moving too slowly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Eli Bendersky added the comment:
Chris, your reply seems to indicate that you're irritated for some reason, and
I'm not sure why.
I was simply going through my open issue backlog, and since this is something
I'd like to see fixed, I noticed that you said in October that you have some
patches
Changes by Ankur Ankan ankuran...@gmail.com:
--
nosy: +Ankur.Ankan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
___
Python-bugs-list
Eli Bendersky added the comment:
Chris Calloway, would you like to pursue this issue further?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Calloway added the comment:
I have a number of patches for this issue I have worked on during a few local
Python user group hack nights. I have not submitted them yet, however, as they
require some expository material here in order to illustrate how they address
Jerdonek's points. I
Eli Bendersky added the comment:
Moving to 3.4
In 3.3 we won't add functionality to filecmp, but in 3.4 we will, so the new
tests should go there.
--
nosy: +eli.bendersky
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
Chris Calloway, let's move this forward. I want to see more tests for filecmp
ASAP.
Please address Chris Jerdonek's points in a new patch made vs. fresh default
branch (3.4), at this point cding (before the test_cwd thing is done). For
testing code,
Chris Calloway added the comment:
Well, really, the reason I'm deferring is to get the patch accepted, because it
seems kind of unacceptable for standard library modules not to have full test
coverage. So far, I don't see evidence that the issue has even been triaged. Of
the three approaches,
Chris Jerdonek added the comment:
Of the three approaches, regex, cd, or decoration, which do you see as most
likely to be accepted?
In my limited experience, I think the patch most likely to be accepted is the
one that changes existing code the least. That would mean adding to the
Chris Calloway added the comment:
There are at least two ways you could deal with this. You could change the
working directory to the temp directory in setUp() and change it back in
tearDown(). This is a common pattern in the tests [...]
Alternatively, you could save the temp directory
Chris Jerdonek added the comment:
However, I would like your blessing to continue with assertRegex in this case.
Sure, you can proceed that way. :) My suggestions were just that --
suggestions for you to consider. And I am not a core developer, so my approval
won't necessarily get your
New submission from Chris Calloway:
The filecmp module has no tests for the following methods of the dircmp class:
report()
report_partial_closure()
report_full_closure()
The attached patch provides those tests. This issue was suggested in issue
15454. Future plans for these tests are
Changes by Chris Calloway c...@chriscalloway.org:
--
nosy: +cjerdonek
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
___
Chris Jerdonek added the comment:
Thanks, Chris. A couple high-level comments.
I know this isn't the prevailing style of the existing tests, but it's
generally better if each unit test tests just one thing. That way, for
example, if a test fails you know more precisely what is not working.
Chris Calloway added the comment:
Would it be possible to structure things so that you have tests like
test_report(), test_report_partial_closure(), etc?
Yes, I would prefer that structure. I was just being consistent, as you said,
with the prevailing style of the existing tests. I will
Chris Jerdonek added the comment:
The tempfile-generated directory names are part of the report method output
and are not known in advance.
There are at least two ways you could deal with this. You could change the
working directory to the temp directory in setUp() and change it back in
41 matches
Mail list logo