Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

> On Jul 7, 2015, at 12:42 AM, Serhiy Storchaka wrote: > > What if so->table was reallocated during the iteration, but so->used is left > the same? This change looks unsafe to me. FWIW, the mutation detection code in the iterator logic has always been vulnerable to being fooled the way you d

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

Just thinking out loud here, but could you devote a single buildbot to the cause? It would only ever try to build from the "crasher" branch. When a crash is discovered like this one, you can do whatever is necessary to merge the code and a crasher test case to that branch. It would then turn red. M

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, Jul 7, 2015, 12:17 Zachary Ware wrote: On Tue, Jul 7, 2015 at 2:03 PM, Ethan Furman wrote: > On 07/07/2015 08:15 AM, Serhiy Storchaka wrote: >> This will make harder to notice (and fix!) other regressions. > > I don't understand what you are trying to say. If a bug is worth fixing, > i

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, Jul 7, 2015 at 3:16 PM, Brett Cannon wrote: > The test could be marked as an expected failure in the interim somitnisnt > forgotten. True, but in this case things would be a bit more difficult since the testcase segfaults rather than just throwing an exception. -- Zach _

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, Jul 7, 2015 at 2:03 PM, Ethan Furman wrote: > On 07/07/2015 08:15 AM, Serhiy Storchaka wrote: >> This will make harder to notice (and fix!) other regressions. > > I don't understand what you are trying to say. If a bug is worth fixing, > it's worth having a test so we don't have to fix it

Re: [Python-Dev] Issue #15014 - SMTP AUTH initial-response (beta exception requested)

On Jul 07, 2015, at 02:53 PM, Terry Reedy wrote: >To me, the main question is whether you are sure that your proposal is the >right fix, or whether you might reasonably do something different (with the >new arguments) if changes were reverted for the present and you two took more >time to think ab

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07/07/2015 08:15 AM, Serhiy Storchaka wrote: On 07.07.15 17:33, Maciej Fijalkowski wrote: On Tue, Jul 7, 2015 at 3:08 PM, Serhiy Storchaka wrote: There is no haste. Only developed branch is affected and we have enough time to fix it. No buildbots is broken. Then maybe a good option would

Re: [Python-Dev] Issue #15014 - SMTP AUTH initial-response (beta exception requested)

On 7/7/2015 1:52 PM, Barry Warsaw wrote: Larry and others, I'd like to bring your attention to issue #15014. This issue added arbitrary auth methods to smtplib, which is a good thing. Implicitly though, a regression was introduced w.r.t. RFC 4954's optional initial-response for the AUTH comman

[Python-Dev] Issue #15014 - SMTP AUTH initial-response (beta exception requested)

Larry and others, I'd like to bring your attention to issue #15014. This issue added arbitrary auth methods to smtplib, which is a good thing. Implicitly though, a regression was introduced w.r.t. RFC 4954's optional initial-response for the AUTH command, for authentication methods that support

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

The overhaul of the development process is still on hold while I deal with trying to get settled in new city and starting a new job next week (writing this on a tablet because I don't even have a computer ATM). My hope is everything will settle down enough that I can pick up the work on trying to u

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

Nick Coghlan wrote: > It's OK if folks aren't interested in participating in the noisy early > stages of that process - that's why the activity was long since moved > out to a dedicated list. It's not OK to make the jump from "I don't > consider participating in that to b

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07.07.15 17:33, Maciej Fijalkowski wrote: On Tue, Jul 7, 2015 at 3:08 PM, Serhiy Storchaka wrote: There is no haste. Only developed branch is affected and we have enough time to fix it. No buildbots is broken. Then maybe a good option would be to add the crasher to the test suite, so the b

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

On Wed, 8 Jul 2015 00:10:09 +1000 Nick Coghlan wrote: > > It's OK if folks aren't interested in participating in the noisy early > stages of that process - that's why the activity was long since moved > out to a dedicated list. It's not OK to make the jump from "I don't > consider participating i

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, Jul 7, 2015 at 3:08 PM, Serhiy Storchaka wrote: > On 07.07.15 15:32, Maciej Fijalkowski wrote: >> >> I kind of thought that python does pre-commit reviews (at least seems >> to apply to most people), so in case someone is completely exempt from >> that, maybe he should read python-dev or w

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

On 7 July 2015 at 21:49, s.krah wrote: > > > Erik Bray wrote: > >> On Mon, Jul 6, 2015 at 6:21 AM, Antoine Pitrou >> wrote: >>> On Mon, 6 Jul 2015 14:22:46 +1000 >>> Nick Coghlan wrote: The main change from the last version discussed on python-ideas >>> >>> Was it discussed there? Tha

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

Erik Bray wrote: > On Mon, Jul 6, 2015 at 6:21 AM, Antoine Pitrou wrote: >> On Mon, 6 Jul 2015 14:22:46 +1000 >> Nick Coghlan wrote: >>> >>> The main change from the last version discussed on python-ideas >> >> Was it disc

Re: [Python-Dev] What's New editing

On Jul 06, 2015, at 09:32 PM, Raymond Hettinger wrote: >FWIW, it took me 100+ hours. Doing this right is a non-trivial undertaking >(in modern times, there are an astonishing number of changes per release). >That said, it is rewarding work that makes a difference. Indeed. During distro Python

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07.07.15 15:14, Guido van Rossum wrote: FYI, do we have any indication that Raymond even read the comment? IIRC he doesn't regularly read python-dev. I also don't think code review comments ought to go to python-dev; the commiters list would seem more appropriate? (Though it looks like python-

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07.07.15 15:32, Maciej Fijalkowski wrote: I kind of thought that python does pre-commit reviews (at least seems to apply to most people), so in case someone is completely exempt from that, maybe he should read python-dev or wherever the reply is set to? That also does not explain why a crashin

[Python-Dev] Review/CI infrastructure status (was Re: cpython: Tighten-up code in the set iterator to use an entry pointer rather than)

On 7 July 2015 at 22:31, Guido van Rossum wrote: > A simple way to address this would have been to CC Raymond on the issue. But > the reply-to header probably makes that hard. Agreed that post-commit > reviews don't really scale to our size. It's hard to teach old dogs new > tricks though. I now r

Re: [Python-Dev] What's New editing

On 7 July 2015 at 01:38, David Mertz wrote: > Hi Folks, > > I hereby volunteer to write "What's New for Python 3.5?" if folks on > python-dev are fine with me taking the job (i.e. I ran it by Travis, my boss > at Continuum, and he's happy to allow me to do that work within my salaried > hours... s

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

It's more complicated than that. FWIW a crash reproducer doesn't mean it's a common or likely crash. Apparently no unittests broke. Also, please give Raymond time to wake up (I'm in Europe, but Raymond is probably recovering from a three-day weekend in the US). On Tue, Jul 7, 2015 at 2:32 PM, Mac

Re: [Python-Dev] Importance of "async" keyword

On 7 July 2015 at 06:08, Sven R. Kunze wrote: > I would like to rewrite/amend it to work asynchronously with minimal effort > such as: > > def business_new(): > content1 = fork open('big.file').read() # wraps up the calls into > awaitables > content2 = fork open('huge.file').read() # and

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, Jul 7, 2015 at 2:14 PM, Guido van Rossum wrote: > FYI, do we have any indication that Raymond even read the comment? IIRC he > doesn't regularly read python-dev. I also don't think code review comments > ought to go to python-dev; the commiters list would seem more appropriate? > (Though i

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

A simple way to address this would have been to CC Raymond on the issue. But the reply-to header probably makes that hard. Agreed that post-commit reviews don't really scale to our size. It's hard to teach old dogs new tricks though. I now realize that my main point, however, was that Raymond and S

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, 7 Jul 2015 14:14:49 +0200 Guido van Rossum wrote: > FYI, do we have any indication that Raymond even read the comment? IIRC he > doesn't regularly read python-dev. I also don't think code review comments > ought to go to python-dev; the commiters list would seem more appropriate? Well, do

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

On Tue, Jul 7, 2015 at 11:24 AM, Mark Lawrence wrote: > From https://mail.python.org/mailman/listinfo/python-ideas > > > This list is to contain discussion of speculative language ideas for > Python for possible inclusion into the language. If an idea gains traction > it can then be discussed an

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

FYI, do we have any indication that Raymond even read the comment? IIRC he doesn't regularly read python-dev. I also don't think code review comments ought to go to python-dev; the commiters list would seem more appropriate? (Though it looks like python-checkins is configured to direct replies to p

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On Tue, 7 Jul 2015 12:04:34 +0200 Maciej Fijalkowski wrote: > I must say I completely fail to understand the procedures under which > python is developed. If the change (unreviewed, just randomly applied) > causes crashes, then surely it should be reverted first and continued > on bug tracker inst

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

I must say I completely fail to understand the procedures under which python is developed. If the change (unreviewed, just randomly applied) causes crashes, then surely it should be reverted first and continued on bug tracker instead of lingering (and the complain sitting on bug tracker)? On Tue,

Re: [Python-Dev] PEP 493: Redistributor guidance for Python 2.7 HTTPS

On 07/07/2015 03:10, Stephen J. Turnbull wrote: Cross-posted to redirect discussion. Replies directed to Python-Ideas. Erik Bray writes on Python-Dev: > On Mon, Jul 6, 2015 at 6:21 AM, Antoine Pitrou wrote: > > On Mon, 6 Jul 2015 14:22:46 +1000, Nick Coghlan wrote: > >> > >> The main

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

Maybe such issue can be detected if Raymond uses the bug tracker for code review? I remember many cases where Serhiy and Raymond collaborated successfully and wrote better code thanks to the code review. Victor 2015-07-07 9:42 GMT+02:00 Serhiy Storchaka : > On 07.07.15 05:03, raymond.hettinger wr

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07.07.15 10:42, Serhiy Storchaka wrote: On 07.07.15 05:03, raymond.hettinger wrote: https://hg.python.org/cpython/rev/c9782a9ac031 changeset: 96865:c9782a9ac031 user:Raymond Hettinger date:Mon Jul 06 19:03:01 2015 -0700 summary: Tighten-up code in the set iterator to use

Re: [Python-Dev] cpython: Tighten-up code in the set iterator to use an entry pointer rather than

On 07.07.15 05:03, raymond.hettinger wrote: https://hg.python.org/cpython/rev/c9782a9ac031 changeset: 96865:c9782a9ac031 user:Raymond Hettinger date:Mon Jul 06 19:03:01 2015 -0700 summary: Tighten-up code in the set iterator to use an entry pointer rather than indexing. fi

Re: [Python-Dev] cpython: Minor bit of factoring-out common code.

On 07.07.15 05:08, raymond.hettinger wrote: https://hg.python.org/cpython/rev/5088f2cd6293 changeset: 96866:5088f2cd6293 user:Raymond Hettinger date:Mon Jul 06 19:08:49 2015 -0700 summary: Minor bit of factoring-out common code. +if (rv < 0) +goto erro

Re: [Python-Dev] raw_input prompt not printed on sys.stderr

On Mon, Jul 6, 2015 at 11:45 PM, Clement Rouault wrote: > Hi, > > While playing with non-standard sys.stdout/stderr, I noticed that the > prompt of raw_input was printed on stderr (not sys.stderr) (see > Parser/myreadline.c:120). > > I found an issue (http://bugs.python.org/issue1927) from 2008 ta