Hi,
On Tue, Feb 01, 2022 at 10:19:12AM -0500, Éric Araujo wrote:
Hi,
Le 01/02/2022 à 07:25, Martin Dengler a écrit :
The fact people are assuming bad faith and spilling ink about those getting
involved with that extremely-underserved part when contributors are sorely >
needed is
Hi,
Le 01/02/2022 à 07:25, Martin Dengler a écrit :
The fact people are assuming bad faith and spilling ink about those getting
involved with that extremely-underserved part when contributors are sorely >
needed is counter-productive.
I disagree, the original message was a good-faith
of the triage team to do).I'm only a triager (like Nikita), but I really
don't see any problem here, personally.Best wishes, Alex
Original message From: Nikita Sobolev Date:
01/02/2022 04:14 (GMT+00:00) To: python-dev@python.org Subject: [Python-Dev]
Re: Increase of Spammy
On Tue, Feb 01, 2022 at 12:35:02AM -0500, Terry Reedy wrote:
On 1/31/2022 7:31 PM, Nikita Sobolev wrote:
Hi, my name is Nikita and I think that I am the person behind these spammy PRs.
Link: https://github.com/python/cpython/pulls/sobolevn
I also encouraged multiple easily reviewable PRs from
Am 01.02.22 um 01:31 schrieb Nikita Sobolev:
Hi, my name is Nikita and I think that I am the person behind these spammy PRs.
Link: https://github.com/python/cpython/pulls/sobolevn
As a typeshed maintainer, Nikita also "spams" typeshed with PRs. I
highly appreciate those PRs, which I am sure
On 1/31/2022 7:31 PM, Nikita Sobolev wrote:
Hi, my name is Nikita and I think that I am the person behind these spammy PRs.
Link: https://github.com/python/cpython/pulls/sobolevn
Nikita, I don't know if the OP was responding only to your PRs or
others, but I other people have seen truly
Hi, my name is Nikita and I think that I am the person behind these spammy PRs.
Link: https://github.com/python/cpython/pulls/sobolevn
First of all, Lrupert, sorry for all the noise and inconvenience I caused to
you personally and to other community members! This totally was **not** my
If you feel bad impression, sorry about that.
The mentee who cc me is under mentoring period. Since tracking all of
mentee’s activity is impossible, I requested him to cc me.
This was for checking his labeling is valid or not.
Warm regards
Dong-hee
2022년 2월 1일 (화) 오전 5:35, Lrupert via Python-Dev
On Mon, 31 Jan 2022 at 23:29, Greg Ewing
wrote:
> Or they may just feel that it's better to organise their changes into
> a number of small, independent commits rather than one large one. I
> wouldn't be too quick to jump to conclusions about people's motives
> here.
I've found that highly
On 1/02/22 5:47 am, Lrupert via Python-Dev wrote:
This gives
a bad impression to others about their intentions (constant contribution
of trivial / low quality stuff with little-to-no-gain to achieve a
higher number of commits, since it is a visible metric).
Or they may just feel that it's
On 1/31/22 8:47 AM, Lrupert via Python-Dev wrote:
> This gives a bad impression to others about their intentions (constant
contribution of trivial
> / low quality stuff with little-to-no-gain to achieve a higher number of
commits, since it is
> a visible metric).
Two of us have already
Okay, now you might as well state which person you are talking about. Who
says their mentor hasn't encouraged them to do this?
On Mon, Jan 31, 2022 at 12:32 PM Lrupert via Python-Dev <
python-dev@python.org> wrote:
> > Gaming the system doesn't end up working well in the end anyway. The
> first
> Gaming the system doesn't end up working well in the end anyway. The first
> time the gamers try to get a job interview and can't explain how they'd do a
> code review—something GitHub says they've done hundreds or thousands of
> times—the whole thing will fail.
Observably, it feels like
Ah, now I see the section on GitHub user home pages. Honestly if employers
just take a glance at that they get what they deserve. I don't want to
worry about this, there are enough real problems.
On Mon, Jan 31, 2022 at 8:48 AM Brian Curtin wrote:
> I was using points in a more generic sense,
I was using points in a more generic sense, making your "contribution
activity overview" look nicer—I wasn't sure if "points" was an actual thing
or not, so maybe I'm speaking out of turn. Mine shows 70% of my actions are
code review, then issues, commits, and PRs are 10% each.
On Mon, Jan 31,
Where does it say that a review gives you points? The GitHub blog post I
saw about the subject only mentions commits.
On Mon, Jan 31, 2022 at 8:16 AM Brian Curtin wrote:
> On Sun, Jan 30, 2022 at 8:42 AM Mats Wichmann wrote:
>
>> On 1/30/22 04:45, Inada Naoki wrote:
>> > On Sun, Jan 30, 2022
On Sun, Jan 30, 2022 at 8:42 AM Mats Wichmann wrote:
> On 1/30/22 04:45, Inada Naoki wrote:
> > On Sun, Jan 30, 2022 at 7:37 PM Irit Katriel
> wrote:
>
> > Some people may do "approval without review" to make their "Profile"
> > page richer, because GitHub counts it as a contribution.
> >
@Lrupert
> - Add coverage to X (tens of them, as separate PRs)
I think I know the PRs you're referring to. For the record, some of the PRs
tested hairy code paths in the module I maintain. I would have less confidence
backporting bugfixes touching that code if we didn't have those tests (the
On Sun, 30 Jan 2022 at 20:36, Steven D'Aprano wrote:
>
> On Sun, Jan 30, 2022 at 08:36:43AM -0800, Jelle Zijlstra wrote:
>
> > Agree, the count of 1.6k open PRs is not a good look for new contributors.
>
> How does that compare to other comparable open source projects?
How it compares is a
On Sun, Jan 30, 2022 at 08:36:43AM -0800, Jelle Zijlstra wrote:
> Agree, the count of 1.6k open PRs is not a good look for new contributors.
How does that compare to other comparable open source projects?
Number of open PRs per KLOC seems like a more useful metric than just
the number of open
El dom, 30 ene 2022 a las 2:40, Irit Katriel via Python-Dev (<
python-dev@python.org>) escribió:
>
> A non-core approval changes the label from "awaiting review" to "awaiting
> core review".
>
Interestingly, it also changes if a non-core dev requests changes (e.g.,
see
On 1/30/22 04:45, Inada Naoki wrote:
> On Sun, Jan 30, 2022 at 7:37 PM Irit Katriel
> wrote:
> Some people may do "approval without review" to make their "Profile"
> page richer, because GitHub counts it as a contribution.
> Creating spam issues or pull requests can be reported as spam very
>
On Sun, Jan 30, 2022 at 7:37 PM Irit Katriel wrote:
>
> If people spam the approvals (i.e., approve PRs without reviewing them) then
> the distinction between the labels becomes meaningless, of course. Though I
> do wonder what the motivation for doing that repeatedly would be. My basic
>
A non-core approval changes the label from "awaiting review" to "awaiting
core review". I find this useful, and occasionally filter on "awaiting core
review" because it indicates that at least one other person found the PR
sound / interesting. I would not like this to change - I think high
On Sat, Jan 29, 2022 at 7:38 PM Inada Naoki wrote:
> On Sun, Jan 30, 2022 at 12:03 PM Ethan Smith wrote:
> >
> > As a non-committer, I want to make a plea for non-committer approval
> reviews, or at least that they have a place. When asked how outsiders can
> contribute I frequently see "review
On Sun, Jan 30, 2022 at 12:03 PM Ethan Smith wrote:
>
> As a non-committer, I want to make a plea for non-committer approval reviews,
> or at least that they have a place. When asked how outsiders can contribute I
> frequently see "review open PRs" as a suggested way of contributing to
>
As a non-committer, I want to make a plea for non-committer approval
reviews, or at least that they have a place. When asked how outsiders can
contribute I frequently see "review open PRs" as a suggested way of
contributing to CPython. Not being able to approve PRs that are good would
be a barrier
On Sun, Jan 30, 2022 at 10:39 AM Ethan Furman wrote:
>
>
> > And lots of non-committer PR reviews that only approve.
>
> I have seen this. Quite irritating.
>
We can prohibit approval from non core developers. Do we use this
setting already?
On 1/29/22 3:14 AM, Lrupert via Python-Dev wrote:
> As someone who is watching the python/cpython repository, I'm very used to
see lots of traffic. But
> lately there have been a surge of spammy PRs which are about the same,
generally very trivial subject
> but individually fixing each
29 matches
Mail list logo
