Re: [Qemu-devel] [RFC 1.1] Fix "qemu" in documentation for version 1.1?

2012-05-02 Thread ronnie sahlberg
On Thu, May 3, 2012 at 7:04 AM, Stefan Weil wrote: > Hello, > > the QEMU documentation (*texi, docs/*, maybe more files) still > includes lots of examples using the executable name "qemu" > which is no longer supported. > > Even if a future version of QEMU will provide this name again > (maybe as

Re: [Qemu-devel] [RFC 1.1] Fix "qemu" in documentation for version 1.1?

2012-05-02 Thread 陳韋任
> I think man pages and html documentation should be as correct > as possible and therefore suggest replacing "qemu" by > qemu-system-i386 (or qemu-system-x86_64, any other > executable, or randomly selected executables?) in *texi. How about qemu-system-YOUR_TARGET? Not everyone use x86/x86_64,

[Qemu-devel] [PATCH 6/6] qemu-timer: Fix limits for w32 mmtimer

2012-05-02 Thread Stefan Weil
timeSetEvent only accepts delays in the range which is returned by timeGetDevCaps. The lower limit is typically 1 (= 1 ms), so the constant value of 1 in the old code usually worked. The upper limit can be as low as 1 ms, so the latest changes in QEMU's timer handling which introduced timeout

[Qemu-devel] IPv6 bonding in VM doesn't work (was Re: bonding and IPv6 "doesn't work"?)

2012-05-02 Thread Amos Kong
On Wed, Jul 13, 2011 at 1:15 AM, Chris Friesen wrote: > On 07/12/2011 10:25 AM, Tomasz Chmielewski wrote: > >> On 12.07.2011 18:14, David Lamparter wrote: >> > > Your bonding peer is probably looping those >>> packets back on the other link, most likely because... >>> >>> Bonding Mode: load bala

[Qemu-devel] [PATCH 5/6] qom: Fix memory leak in function container_get

2012-05-02 Thread Stefan Weil
Valgrind reported this memory leak which occured very often. Test scenario: qemu-system-i386 (no arguments), only BIOS started, terminate with monitor command (quit). Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber --- qom/container.c |2 ++ 1 files changed, 2 insertions(+), 0 dele

[Qemu-devel] [PATCH 2/6] arm-semi: Rename SYS_XXX macros to TARGET_SYS_XXX (fixes compiler warning)

2012-05-02 Thread Stefan Weil
SYS_OPEN is already defined in stdio.h of MinGW-w64, therefore the compiler complains when building for w64. Adding the prefix TARGET_ avoids that macro redefinition. xtensa-semi.c also uses the same prefix (but mixed case macros TARGET_SYS_xxx instead of TARGET_SYS_XXX). Signed-off-by: Stefan We

[Qemu-devel] [PATCH 4/6] hw/pc_sysfw: Fix memory leak

2012-05-02 Thread Stefan Weil
Valgrind reported this memory leak which occured a few times. Test scenario: qemu-system-i386 (no arguments), only BIOS started, terminate with monitor command (quit). Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber --- hw/pc_sysfw.c |3 +++ 1 files changed, 3 insertions(+), 0 dele

[Qemu-devel] [PATCH 3/6] qdev: Fix memory leak in function set_pci_devfn

2012-05-02 Thread Stefan Weil
Valgrind reported this memory leak which occured very often. Test scenario: qemu-system-i386 (no arguments), only BIOS started, terminate with monitor command (quit). v2: Use error_free instead of g_free (hint from Andreas Färber, thanks). Signed-off-by: Stefan Weil Acked-by: Andreas Färber -

[Qemu-devel] [PULL 1.1 0/6] Missing patches for QEMU 1.1

2012-05-02 Thread Stefan Weil
Hi Anthony, here are some of my patches which were not committed up to now, but which should be included in QEMU 1.1. Only the last one (qemu-timer, which did not get any review up to now) is w32 related. The first one was discussed a lot, but then forgotten. All other patches were reviewed and

[Qemu-devel] [PATCH 1/6] target-mips: Remove unused inline function

2012-05-02 Thread Stefan Weil
Function set_HILO is not needed anywhere. Signed-off-by: Stefan Weil --- target-mips/op_helper.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 5627447..66037ac 100644 --- a/target-mips/op_helper.c +++ b/targe

[Qemu-devel] tracetool parse problem for parenthesis in format string

2012-05-02 Thread Bob Breuer
The new tracetool has a problem with parsing parenthesis within the format string. For example, add this line to trace-events: test_paren(int n) "(%d)" and you will get a failure when generating trace.h. Bob

[Qemu-devel] [PATCH 2/2] pci_bridge_dev: fix error path in pci_bridge_dev_initfn()

2012-05-02 Thread Jason Baron
Currently, we do not properly cleanup, if pci_bridge_dev_initfn fails to initialize properly. Make sure to call pci_bridge_exitfn() in the error path. Signed-off-by: Jason Baron --- hw/pci_bridge_dev.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/pci_bridge_dev.

[Qemu-devel] [PATCH 1/2] qdev: release parent properties on dc->init failure

2012-05-02 Thread Jason Baron
While looking into hot-plugging bridges, I can create a qemu segfault via: $ device_add pci-bridge Bridge chassis not specified. Each bridge is required to be assigned a unique chassis id > 0. ** ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) I'm proposing to fix this b

[Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes

2012-05-02 Thread Jason Baron
Hi, While testing pci bridge hotplug via device_add, I ran into a couple of qemu segfaults. The first one was caused by having a refcount greater than 0, in the object_delete() path. Once, I got past that error, I hit a second segfault due to the fact that pci_bridge_dev_initfn() didn't fully cle

[Qemu-devel] [PATCH V18 8/7] Add qmp support

2012-05-02 Thread Stefan Berger
Add qmp support --- qmp-commands.hx |5 + 1 file changed, 5 insertions(+) Index: qemu-git.pt/qmp-commands.hx === --- qemu-git.pt.orig/qmp-commands.hx +++ qemu-git.pt/qmp-commands.hx @@ -2142,3 +2142,8 @@ EQMP .args

Re: [Qemu-devel] [HACK] hda: expose microphone instead of line-in

2012-05-02 Thread Alexander Graf
On 02.05.2012, at 20:17, Jan Kiszka wrote: > On 2012-04-25 09:34, Gerd Hoffmann wrote: >> On 04/25/12 13:03, Jan Kiszka wrote: >>> Hi Gerd, >>> >>> I had problems with Windows LiveMeeting expecting a microphone as >>> input. But the HDA model only exposes a line-in port. The following hack >>> w

[Qemu-devel] [PATCH V18 6/7] Introduce --enable-tpm-passthrough configure option

2012-05-02 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger --- configure | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 84f7224..7920497 100755 --- a/configure +++ b/configure @@ -195,6 +195,7 @@ guest_a

[Qemu-devel] [PATCH V18 4/7] Build the TPM frontend code

2012-05-02 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- Makefile.target |2 ++ configure | 11 +++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index 1582904..cdf108a 100644 --- a/Makefile.t

[Qemu-devel] [PATCH V18 0/7] Qemu Trusted Platform Module (TPM) integration

2012-05-02 Thread Stefan Berger
The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabling for examp

[Qemu-devel] [PATCH V18 5/7] Add a TPM Passthrough backend driver implementation

2012-05-02 Thread Stefan Berger
>From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "Qemu Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch adds a passthrough backend driver for passing command

[Qemu-devel] [PATCH V18 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-05-02 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

[Qemu-devel] [PATCH V18 1/7] Support for TPM command line options

2012-05-02 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa

[Qemu-devel] [PATCH V18 3/7] Add a debug register

2012-05-02 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger --- hw/tpm_tis.c | 70 +++

[Qemu-devel] [PATCH V18 7/7] Add fd parameter for TPM passthrough driver

2012-05-02 Thread Stefan Berger
Enable the passing of a file descriptor via fd=<..> to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger --- hmp.c|7 +- hw/tpm_passthrough.c | 53 ++--- qapi-schema.json |4 ++

Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses

2012-05-02 Thread Paolo Bonzini
Il 02/05/2012 22:00, Anthony Liguori ha scritto: >> >> Not really, in fact this kind of class-side data is really bread and >> butter >> of all dynamic languages, and it's how most of them implement >> polymorphism. >> They have an associative array (method names -> method bytecode for >> example)

Re: [Qemu-devel] Sporadic AHCI boot failures

2012-05-02 Thread Alexander Graf
On 02.05.2012, at 20:14, Jan Kiszka wrote: > Hi, > > I'm running a Win7 VM over AHCI, rebooting quite frequently. Depending > on host system load, I'm facing a lot of sporadic boot failures (disk > not found), obviously in SeaBIOS. Could it be that some timeout in the > init code bites us here

[Qemu-devel] [RFC 1.1] Fix "qemu" in documentation for version 1.1?

2012-05-02 Thread Stefan Weil
Hello, the QEMU documentation (*texi, docs/*, maybe more files) still includes lots of examples using the executable name "qemu" which is no longer supported. Even if a future version of QEMU will provide this name again (maybe as a common entry point for all other executables), there is no qemu

Re: [Qemu-devel] Heavy memory_region_get_dirty() -- Re: [PATCH 0/1 v2] KVM: Alleviate mmu_lock contention during dirty logging

2012-05-02 Thread Takuya Yoshikawa
On Wed, 02 May 2012 14:33:55 +0300 Avi Kivity wrote: > > = > > perf top -t ${QEMU_TID} > > = > > 51.52% qemu-system-x86_64 [.] memory_region_get_dirty > > 16.73% qemu-system-x86_64 [.] ram_save_remaining > > > > memory_regio

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-05-02 Thread Stefan Weinhuber
On 2012-05-02 16:27, Christian Borntraeger wrote: On 02/05/12 14:54, Alexander Graf wrote: On 05/02/2012 01:38 PM, Paolo Bonzini wrote: On 05/02/2012 01:26 PM, Paolo Bonzini wrote: and everyone should be happy :). I would really like to have as little #ifdef TARGET_S390 code in QEMU. And #ifde

[Qemu-devel] [PATCH for-1.1] cpu: Update documentation and comment

2012-05-02 Thread Andreas Färber
State struct CPU had been renamed to CPUState, former CPUState to CPUArchState. Signed-off-by: Andreas Färber --- include/qemu/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h index 4291279..78b65b3 100644 --- a/include/qem

[Qemu-devel] [PATCH] sheepdog: switch to writethrough mode if cluster doesn't support flush

2012-05-02 Thread MORITA Kazutaka
This is necessary for qemu to work with the older version of Sheepdog which doesn't support SD_OP_FLUSH_VDI. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0ed6b19..e01d

[Qemu-devel] Heavy memory_region_get_dirty() -- Re: [PATCH 0/1 v2] KVM: Alleviate mmu_lock contention during dirty logging

2012-05-02 Thread Takuya Yoshikawa
During checking mmu_lock contention, I noticed that QEMU's memory_region_get_dirty() was using unexpectedly much CPU time. Thanks, Takuya = perf top -t ${QEMU_TID} = 51.52% qemu-system-x86_64 [.] memory_region_get_dirty 16.7

Re: [Qemu-devel] API for single stepping an emulated CPU

2012-05-02 Thread 陳韋任
> I am designing a virtual peripheral for Qemu, for which I need to single step > through the program on the emulated CPU (my peripheral will be some kind of a > debugger). My question is: is there an API to execute exactly one instruction > in Qemu? I've already found the *_pause and *_resume func

Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses

2012-05-02 Thread Anthony Liguori
On 05/02/2012 08:21 AM, Paolo Bonzini wrote: This little bit of magic is a bit too magical for my taste. Polymorphism relies on the idea that a subclass overloads base class members/methods. From the base classes perspective, it's unaware if a subclass has overloaded something (that's allowed

[Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-02 Thread Paul Moore
FIPS 140-2 requires disabling certain ciphers, including DES, which is used by VNC to obscure passwords when they are sent over the network. The solution for FIPS users is to disable the use of VNC password auth when the host system is operating in FIPS mode. This patch causes qemu to emit a sysl

Re: [Qemu-devel] [libvirt] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-02 Thread Paolo Bonzini
Il 02/05/2012 11:56, Daniel P. Berrange ha scritto: > I tend to agree - we have been talking about -blockdev for faar to long > without (AFAICT) making any real progress towards getting it done. I'd > love to see someone bite the bullet & have a go at implementing it Having a spec would help somew

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-05-02 Thread Christian Borntraeger
>>> Well, if guessing is a function >>> >>> guess_size(disk_size, block_size) >>> >>> then we would be able to do the same on an image file. Christian, would >>> that work? >> >> I think that the geometry values can not always be guessed correctly based on >> block_size and disk_size. >> >> Stefa

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-05-02 Thread Alexander Graf
On 02.05.2012, at 17:57, Stefan Weinhuber wrote: > On 2012-05-02 16:27, Christian Borntraeger wrote: >> On 02/05/12 14:54, Alexander Graf wrote: >>> On 05/02/2012 01:38 PM, Paolo Bonzini wrote: > On 05/02/2012 01:26 PM, Paolo Bonzini wrote: >>> and everyone should be happy :). I would r

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-02 Thread Luiz Capitulino
On Wed, 02 May 2012 09:08:55 +0200 Gerd Hoffmann wrote: > > diff --git a/input.c b/input.c > > index 6b5c2c3..47e6900 100644 > > --- a/input.c > > +++ b/input.c > > @@ -130,7 +130,7 @@ void qemu_remove_led_event_handler(QEMUPutLEDEntry > > *entry) > > > > void kbd_put_keycode(int keycode) > >

Re: [Qemu-devel] [HACK] hda: expose microphone instead of line-in

2012-05-02 Thread Jan Kiszka
On 2012-04-25 09:34, Gerd Hoffmann wrote: > On 04/25/12 13:03, Jan Kiszka wrote: >> Hi Gerd, >> >> I had problems with Windows LiveMeeting expecting a microphone as >> input. But the HDA model only exposes a line-in port. The following hack >> works for me, but I bet there is a cleaner solution. An

[Qemu-devel] Sporadic AHCI boot failures

2012-05-02 Thread Jan Kiszka
Hi, I'm running a Win7 VM over AHCI, rebooting quite frequently. Depending on host system load, I'm facing a lot of sporadic boot failures (disk not found), obviously in SeaBIOS. Could it be that some timeout in the init code bites us here? AHCI_LINK_TIMEOUT or AHCI_RESET_TIMEOUT? Just a guess, I

[Qemu-devel] [PATCH 6/9] qcow2: Don't hold cache references across yield

2012-05-02 Thread Kevin Wolf
If cache references are held while the coroutine has yielded, the cache may get used up and abort() when it can't find a free entry. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/block/qcow2-clust

[Qemu-devel] [PATCH 5/9] qcow2: Remove unused parameter in do_alloc_cluster_offset

2012-05-02 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index a747a88..7edc043 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -759,7 +759,7 @@ out: * restarte

[Qemu-devel] [PATCH 4/9] qemu-iotests: Many parallel allocating I/O requests

2012-05-02 Thread Kevin Wolf
This test case manages to let qcow2 abort because its cache is used up and it can't find free cache entries for new requests any more. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/035 | 72 tests/qemu-iotests/035.out | 392 tests/q

[Qemu-devel] [PATCH 2/9] block/qcow2: Add missing GCC_FMT_ATTR to function report_unsupported()

2012-05-02 Thread Kevin Wolf
From: Stefan Weil Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/qcow2.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ad46c03..8c60a6f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -182,7 +182

[Qemu-devel] [PATCH 8/9] rbd: add discard support

2012-05-02 Thread Kevin Wolf
From: Josh Durgin Change the write flag to an operation type in RBDAIOCB, and make the buffer optional since discard doesn't use it. Discard is first included in librbd 0.1.2 (which is in Ceph 0.46). If librbd is too old, leave out qemu_rbd_aio_discard entirely, so the old behavior is preserved.

[Qemu-devel] [PATCH 1/9] hw/arm_gic: Remove NVIC ifdefs from gic_state struct

2012-05-02 Thread Peter Maydell
Remove some NVIC ifdefs from the gic_state struct and its state save/load functions. This means there are some fields in it which are present for the NVIC but not used, but means it always has the same layout and can be pulled out into a common subclass. Note that the addition of irq_target[] to t

[Qemu-devel] [PATCH 7/9] qcow2: fix the return value -ENOENT -> -EEXIST

2012-05-02 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-snapshot.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 42f971b..4561a2a 100644 --- a/block/qc

[Qemu-devel] [PATCH 9/9] hw/armv7m_nvic: Make the NVIC a freestanding class

2012-05-02 Thread Peter Maydell
Rearrange the GIC and NVIC so both are straightforward subclasses of a common class, rather than having the NVIC source file textually include arm_gic.c. Signed-off-by: Peter Maydell --- Makefile.target |2 +- hw/arm_gic.c | 241 +++

[Qemu-devel] [PATCH 5/9] hw/arm_gic: Add qdev property for GIC revision

2012-05-02 Thread Peter Maydell
GIC behaviour can be different between revision 1 and 2 of the architectural GIC specification; we also have to handle the legacy 11MPCore GIC, which is different again in some places. Introduce a qdev property so we can behave appropriately. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |

[Qemu-devel] [PATCH 4/9] hw/armv7m_nvic: Use MemoryRegions for NVIC specific registers

2012-05-02 Thread Peter Maydell
Implement the NVIC specific register areas using a set of overlaid MemoryRegions in a container, rather than by having the arm_gic read/write functions use special purpose callbacks. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 33 --- hw/armv7m_nvic.c | 74 +++

[Qemu-devel] [PATCH 8/9] hw/arm_gic: Move CPU interface memory region setup into arm_gic_init

2012-05-02 Thread Peter Maydell
Remove more NVIC ifdefs by moving the code to setup the CPU interface memory regions into the GIC specific arm_gic_init() function rather than the gic_init() function. Rename the latter to more closely reflect what it's now actually doing. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 26

[Qemu-devel] [PATCH 9/9] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-05-02 Thread Kevin Wolf
From: Alexander Graf When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows expects it to be there. Since without security stuff implemented, the lock would be a n

[Qemu-devel] [PATCH qemu 3/6] move list of default config files to an array

2012-05-02 Thread Eduardo Habkost
More files will be added to the list, with additional attributes, later. Signed-off-by: Eduardo Habkost --- arch_init.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 152cbbb..62332e9 100644 --- a/arch_init.c +++

[Qemu-devel] [PATCH 3/9] docs: fix one issue in qcow2 specs

2012-05-02 Thread Kevin Wolf
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Kevin Wolf --- docs/specs/qcow2.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 65e6325..87bf785 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.

[Qemu-devel] [PATCH 1/9] qemu-iotests: ignore fragmentation information for qed

2012-05-02 Thread Kevin Wolf
From: Dong Xu Wang We added image fragmentation statistics functions to qemu-img several days ago, those patches will cause "./check -qed" failed. This patch will ignore fragmentation statistics information of qed format, and then "./check -qed" will work. Signed-off-by: Dong Xu Wang Signed-off

[Qemu-devel] [PULL 0/9] Block patches (master and 1.1)

2012-05-02 Thread Kevin Wolf
The following changes since commit 563987d0a799f90b58a575b190a57546c335191b: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2012-05-01 18:48:01 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alexander Graf (1): ATA: Allow

[Qemu-devel] [PATCH 6/9] hw/arm_gic: Make CPU target registers RAZ/WI on uniprocessor

2012-05-02 Thread Peter Maydell
The GIC spec says that the CPU target registers should RAZ/WI for uniprocessor implementations. Implement this, which also conveniently lets us drop an NVIC ifdef. Annoyingly, the 11MPCore's GIC is the odd one out, since it always has these registers, even in uniprocessor configs. Signed-off-by:

[Qemu-devel] [PATCH 7/9] hw/arm_gic.c: Make NVIC interrupt numbering a runtime setting

2012-05-02 Thread Peter Maydell
Make the minor tweaks to interrupt numbering used by the NVIC a runtime setting rather than a compile time one, so we can drop more NVIC ifdefs. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm

[Qemu-devel] [PATCH 3/9] hw/arm_gic: Move NVIC specific reset to armv7m_nvic_reset

2012-05-02 Thread Peter Maydell
Move the NVIC specific bits of reset to the NVIC's own reset function, rather than using ifdefs in the common arm_gic reset. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 10 -- hw/armv7m_nvic.c |7 +++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/ar

[Qemu-devel] [PATCH 2/9] hw/arm_gic: Remove the special casing of NCPU for the NVIC

2012-05-02 Thread Peter Maydell
Drop the special casing of NCPU=1 for the NVIC. This slightly increases the amount of memory used by its state structure, but removes some ifdeffery and means we can safely move the GIC state into a common subclass structure. Signed-off-by: Peter Maydell --- hw/arm_gic.c | 23 +++--

[Qemu-devel] [PATCH 0/9] disentangle NVIC from ARM GIC

2012-05-02 Thread Peter Maydell
This patch series refactors the ARMv7M NVIC so it no longer textually includes arm_gic.c Instead we have a single common base class which has the state struct, and a subclass for the GIC and another for the NVIC. As well as being generally rather nicer, this lays the groundwork for supporting a KV

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-05-02 Thread Kevin Wolf
Am 26.04.2012 12:45, schrieb Alexander Graf: > When using Windows 8 with an AHCI disk drive, it issues a blue screen. > The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not > supported by our ATA implementation, but Windows expects it to be there. > > Since without security stuff im

Re: [Qemu-devel] [PATCH] rbd: add discard support

2012-05-02 Thread Kevin Wolf
Am 01.05.2012 10:39, schrieb Stefan Hajnoczi: > On Tue, May 1, 2012 at 7:16 AM, Josh Durgin wrote: >> Change the write flag to an operation type in RBDAIOCB, and make the >> buffer optional since discard doesn't use it. >> >> Discard is first included in librbd 0.1.2 (which is in Ceph 0.46). >> If

Re: [Qemu-devel] [libvirt] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-02 Thread Paolo Bonzini
Il 01/05/2012 22:56, Eric Blake ha scritto: > What sort > of timing restrictions are there? For example, the proposed > 'drive-reopen' command (probably now delegated to qemu 1.2) would mean > that qemu would be calling back into libvirt in order to do the reopen. > If libvirt takes its time in p

[Qemu-devel] [PATCH qemu 6/6] move CPU definitions to /usr/share/qemu/cpus-x86_64.conf (v2)

2012-05-02 Thread Eduardo Habkost
Changes v1 -> v2: - userconfig variable is now bool, not int Signed-off-by: Eduardo Habkost --- Makefile | 12 +++- arch_init.c |1 + sysconfigs/target/cpus-x86_64.conf | 128 ++ sysconfigs/target/targ

[Qemu-devel] [PATCH qemu 2/6] eliminate arch_config_name variable

2012-05-02 Thread Eduardo Habkost
Not needed anymore, as the code that uses the variable is already inside arch_init.c. Signed-off-by: Eduardo Habkost --- arch_init.c |3 +-- arch_init.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 4008115..152cbbb 100644 --- a/arc

Re: [Qemu-devel] [PATCH 1/2] pc: add pci64 memory hole

2012-05-02 Thread Avi Kivity
On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > This patch adds a address space hole for 64bit PCI ressources. > It starts at 0x80 (512 GB) and ends at 0x100 (1 TB), > thus has 512 GB in size. This matches what the seabios is doing > (latest master branch). We should communicate th

[Qemu-devel] [PATCH qemu 1/6] move code to read default config files to a separate function (v2)

2012-05-02 Thread Eduardo Habkost
Function added to arch_init.c because it depends on arch-specific settings. Changes v1 -> v2: - Move qemu_read_default_config_file() prototype to qemu-config.h Signed-off-by: Eduardo Habkost --- arch_init.c | 18 ++ qemu-config.h |4 vl.c | 10 ++

[Qemu-devel] [PATCH qemu 4/6] vl.c: change 'defconfig' variable to bool (v2)

2012-05-02 Thread Eduardo Habkost
Changes v1 -> v2: - Actually change the variable type declaration to 'bool' Signed-off-by: Eduardo Habkost --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 1e5e593..eb3e088 100644 --- a/vl.c +++ b/vl.c @@ -2279,7 +2279,7 @@ int main(int argc

[Qemu-devel] [RFC PATCH 1/2] Implement netdev_set command

2012-05-02 Thread Vasilis Liaskovitis
This command can be used to attach a host backend network device (netdev) to a guest nic. Syntax is: netdev_set nicid netdevid This patch adds qmp and hmp support for the command. Signed-off-by: Vasilis Liaskovitis --- hmp-commands.hx | 14 + hmp.c| 10 + hm

[Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-02 Thread Eduardo Habkost
Changes v2 -> v3: - Actually change 'defconfig' type declaration to bool - Rebase against latest qemu.git (commit 563987d0a799f90b58a575b190a57546c335191b) Changes v1 -> v2: - Move qemu_read_default_config_files() prototype to qemu-config.h - Make defconfig and userconfig variable bool - Cod

[Qemu-devel] [PATCH qemu 5/6] implement -no-user-config command-line option (v3)

2012-05-02 Thread Eduardo Habkost
Changes v2 -> v3: - Rebase against latest qemu.git Changes v1 -> v2: - Change 'userconfig' field/variables to bool instead of int - Coding style change Signed-off-by: Eduardo Habkost --- arch_init.c | 11 --- qemu-config.h |2 +- qemu-options.hx | 16 +--- v

[Qemu-devel] [RFC PATCH 2/2] virtio-net: re-initialize tap device for new netdev

2012-05-02 Thread Vasilis Liaskovitis
When a nic's backend netdev device is changed, the tap device needs to be re-initialized for vnet_hdr and offload features. Also, vhost will have to be re-initialized. This is currently implemented in the virtio set_status callback function. Signed-off-by: Vasilis Liaskovitis --- hw/virtio-net.c

[Qemu-devel] [RFC PATCH 0/2] Decouple netdev from nic

2012-05-02 Thread Vasilis Liaskovitis
Virtualization management layers would like to decouple host network device (netdev) creation/deletion/setup from guest network adapters. This would allow to independently: - provision VMs with NIC(s) - create and manage network devices on the host First discussed here: http://lists.gnu.org/archi

Re: [Qemu-devel] [PATCH 0/2] pci: 64bit bits

2012-05-02 Thread Avi Kivity
On 05/02/2012 06:54 PM, Gerd Hoffmann wrote: > On 05/02/12 17:33, Avi Kivity wrote: > > On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > >> Hi, > >> > >> seabios (master branch) just got 64bit pci support. When running out of > >> address space in the pci memory window below 4G (0xe000+) seabi

Re: [Qemu-devel] [PATCH 0/2] pci: 64bit bits

2012-05-02 Thread Gerd Hoffmann
On 05/02/12 17:33, Avi Kivity wrote: > On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: >> Hi, >> >> seabios (master branch) just got 64bit pci support. When running out of >> address space in the pci memory window below 4G (0xe000+) seabios >> will map 64bit pci bars above 4G to make room below

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Kevin Wolf
Am 02.05.2012 17:37, schrieb Michael Tokarev: > On 02.05.2012 18:35, Kevin Wolf wrote: > [] >>> As I already mentioned, the virtio protocol has the same defect (but there >>> it is less serious due to usage of larger units). And that's where the >>> additional overflow needs to be ELIMINATED, not

Re: [Qemu-devel] [PATCH 1/2] pc: add pci64 memory hole

2012-05-02 Thread Avi Kivity
On 05/02/2012 06:46 PM, Gerd Hoffmann wrote: > On 05/02/12 17:31, Avi Kivity wrote: > > On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > >> This patch adds a address space hole for 64bit PCI ressources. > >> It starts at 0x80 (512 GB) and ends at 0x100 (1 TB), > >> thus has 512 GB in

Re: [Qemu-devel] [PATCH] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-02 Thread Paul Moore
On Wednesday, May 02, 2012 10:18:50 AM Daniel P. Berrange wrote: > On Tue, May 01, 2012 at 05:20:40PM -0400, Paul Moore wrote: > > diff --git a/ui/vnc.c b/ui/vnc.c > > index deb9ecd..620791e 100644 > > --- a/ui/vnc.c > > +++ b/ui/vnc.c > > @@ -32,6 +32,7 @@ > > > > #include "acl.h" > > #include

Re: [Qemu-devel] [PATCH 1/2] pc: add pci64 memory hole

2012-05-02 Thread Gerd Hoffmann
On 05/02/12 17:31, Avi Kivity wrote: > On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: >> This patch adds a address space hole for 64bit PCI ressources. >> It starts at 0x80 (512 GB) and ends at 0x100 (1 TB), >> thus has 512 GB in size. This matches what the seabios is doing >> (lates

Re: [Qemu-devel] [PATCH] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-02 Thread Paul Moore
On Wednesday, May 02, 2012 12:54:21 AM Andreas Färber wrote: > Am 01.05.2012 23:20, schrieb Paul Moore: > > FIPS 140-2 requires disabling certain ciphers, including DES, which is > > used > > by VNC to obscure passwords when they are sent over the network. The > > solution for FIPS users is to dis

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Michael Tokarev
On 02.05.2012 18:35, Kevin Wolf wrote: [] >> As I already mentioned, the virtio protocol has the same defect (but there >> it is less serious due to usage of larger units). And that's where the >> additional overflow needs to be ELIMINATED, not just checked. Ie, the >> protocol should be changed

Re: [Qemu-devel] [PATCH 0/2] pci: 64bit bits

2012-05-02 Thread Avi Kivity
On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > Hi, > > seabios (master branch) just got 64bit pci support. When running out of > address space in the pci memory window below 4G (0xe000+) seabios > will map 64bit pci bars above 4G to make room below 4G. > > This patch series carries two littl

Re: [Qemu-devel] [PATCH 2/2] ivshmem: add 64bit option

2012-05-02 Thread Avi Kivity
On 05/02/2012 05:02 PM, Gerd Hoffmann wrote: > This patch adds a "use64" property which will make the ivshmem driver > register a 64bit memory bar when set, so you have something to play with > when testing 64bit pci bits. It also allows to have quite big shared > memory regions, like this: > > [r

Re: [Qemu-devel] Memory API: handling unassigned physical memory

2012-05-02 Thread Bob Breuer
On 5/1/2012 1:48 PM, Mark Cave-Ayland wrote: > On 01/05/12 07:57, Blue Swirl wrote: > >>> Therefore I can't change it to my (modified) sbus_mmio_map() function >>> because it would break other non-SPARC platforms, and AIUI there is >>> nothing >>> in the memory API that allows me to move a subregi

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-05-02 Thread Alexander Graf
On 02.05.2012, at 16:27, Christian Borntraeger wrote: > On 02/05/12 14:54, Alexander Graf wrote: >> On 05/02/2012 01:38 PM, Paolo Bonzini wrote: On 05/02/2012 01:26 PM, Paolo Bonzini wrote: >> and everyone should be happy :). I would really like to have as >> little #ifdef TARGET_S

Re: [Qemu-devel] Poking a sun4v machine

2012-05-02 Thread Artyom Tarasenko
On Tue, May 1, 2012 at 3:54 PM, Blue Swirl wrote: > On Tue, May 1, 2012 at 13:33, Artyom Tarasenko wrote: >> On Tue, May 1, 2012 at 11:19 AM, Blue Swirl wrote: >>> On Mon, Apr 30, 2012 at 16:39, Artyom Tarasenko wrote: Tried to boot QEMU Niagara machine with the firmware from the Open

Re: [Qemu-devel] Poking a sun4v machine

2012-05-02 Thread Artyom Tarasenko
On Tue, May 1, 2012 at 4:06 PM, Blue Swirl wrote: > On Tue, May 1, 2012 at 13:54, Artyom Tarasenko wrote: >> On Tue, May 1, 2012 at 11:25 AM, Blue Swirl wrote: >>> On Mon, Apr 30, 2012 at 17:38, Artyom Tarasenko wrote: On Mon, Apr 30, 2012 at 7:15 PM, Andreas Färber wrote: > Am 30.04.

Re: [Qemu-devel] [PATCH] increase BlockConf.min_io_size type from uint16_t to uint32_t

2012-05-02 Thread Kevin Wolf
Am 02.05.2012 12:08, schrieb Michael Tokarev: > 02.05.2012 13:57, Kevin Wolf пишет: >> Am 30.04.2012 17:52, schrieb Michael Tokarev: >>> This value is used currently for virtio-blk only. It was defined >>> as uint16_t before, which is the same as in kernel<=>user interface >>> (in virtio_blk.h, st

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-05-02 Thread Christian Borntraeger
On 02/05/12 14:54, Alexander Graf wrote: > On 05/02/2012 01:38 PM, Paolo Bonzini wrote: >>> On 05/02/2012 01:26 PM, Paolo Bonzini wrote: > and everyone should be happy :). I would really like to have as > little #ifdef TARGET_S390 code in QEMU. And #ifdef __s390__ is > even worse, >

Re: [Qemu-devel] [PATCH qemu v2 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-02 Thread Eduardo Habkost
On Wed, May 02, 2012 at 04:01:55PM +0200, Andreas Färber wrote: > Am 02.05.2012 15:50, schrieb Eduardo Habkost: > > > > Anthony, isn't this going to get in for 1.1? I was expecting it to be > > applied before the freeze. > > You wrote you would respin it with s/int/bool/. :) I sent an additional

[Qemu-devel] [PATCH 2/2] ivshmem: add 64bit option

2012-05-02 Thread Gerd Hoffmann
This patch adds a "use64" property which will make the ivshmem driver register a 64bit memory bar when set, so you have something to play with when testing 64bit pci bits. It also allows to have quite big shared memory regions, like this: [root@fedora ~]# lspci -vs1:1 01:01.0 RAM memory: Red Hat,

[Qemu-devel] [PATCH 1/2] pc: add pci64 memory hole

2012-05-02 Thread Gerd Hoffmann
This patch adds a address space hole for 64bit PCI ressources. It starts at 0x80 (512 GB) and ends at 0x100 (1 TB), thus has 512 GB in size. This matches what the seabios is doing (latest master branch). Signed-off-by: Gerd Hoffmann --- hw/pc.c | 17 ++--- hw/

[Qemu-devel] [PATCH 0/2] pci: 64bit bits

2012-05-02 Thread Gerd Hoffmann
Hi, seabios (master branch) just got 64bit pci support. When running out of address space in the pci memory window below 4G (0xe000+) seabios will map 64bit pci bars above 4G to make room below 4G. This patch series carries two little patches for qemu to adapt it to the seabios changes. F

Re: [Qemu-devel] [PATCH qemu v2 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-02 Thread Andreas Färber
Am 02.05.2012 15:50, schrieb Eduardo Habkost: > > Anthony, isn't this going to get in for 1.1? I was expecting it to be > applied before the freeze. You wrote you would respin it with s/int/bool/. :) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jen

Re: [Qemu-devel] [PATCH qemu v2 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-02 Thread Eduardo Habkost
Anthony, isn't this going to get in for 1.1? I was expecting it to be applied before the freeze. On Tue, Apr 24, 2012 at 05:32:55PM -0300, Eduardo Habkost wrote: > Changes v1 -> v2: > - Move qemu_read_default_config_files() prototype to qemu-config.h > - Make defconfig and userconfig variable

Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*

2012-05-02 Thread Jan Kiszka
On 2012-05-02 10:40, Andreas Färber wrote: > Am 02.05.2012 15:24, schrieb Paolo Bonzini: >>> But that would leave Illumos broken. > > For the record, reverting would leave whatever Paolo was fixing broken > but would restore Illumos. > >> I'd rather apply this one. >> >> Please do. The right sol

Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-05-02 Thread Gerd Hoffmann
Hi, > Is this just a matter of removing the "if (pci_bdf_to_bus(pci->bdf) != > 0) break" from pci_bios_init_devices()? Seems to do the trick, at least the disks connected appear in the boot menu now and the seabios log file looks sane. The guest kernel has no virtio-scsi drivers though, need t

Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*

2012-05-02 Thread Andreas Färber
Am 02.05.2012 15:24, schrieb Paolo Bonzini: >> But that would leave Illumos broken. For the record, reverting would leave whatever Paolo was fixing broken but would restore Illumos. > I'd rather apply this one. > > Please do. The right solution for 1.2 is to understand the places in which > sli

  1   2   >