[Qemu-devel] [PATCH v2 2/4] target-arm: Add trace events for the generic timers

Add some useful trace events for the ARM generic timers (notably the various register writes and the resulting IRQ line state). Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- Makefile.objs | 1 +

[Qemu-devel] [PATCH v2 0/4] preliminaries for GICv3 virt support

This set of straightforward patches is a preliminary for adding virtualization support to the GICv3 emulation: * add a (nop implementation of) MDCCINT_EL1, since KVM will read/write it on worldswitch * fix some bugs in the GICv3 trace events * add trace events for the generic timers

Re: [Qemu-devel] [PATCH v14 12/21] option: allow qemu_opts_to_qdict to merge repeated options

"Daniel P. Berrange" writes: > If given an option string such as > > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind > > the qemu_opts_to_qdict() method will currently overwrite > the values for repeated option keys, so only the last > value is in the returned dict: > >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

On 10/12/2016 05:07 AM, Paolo Bonzini wrote: > > > On 12/10/2016 13:59, Halil Pasic wrote: >> IMHO this would: >> * allow us to keep the good old MVStateInfo objects unmodified and >> the semantic of VMStateInfo unchanged >> * make clear that VMStateLinked does not care about the calculated

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

On 12 October 2016 at 18:11, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >>

[Qemu-devel] [PATCH] target-lm32: fix LOG_DIS operand order

The order of most opcodes with immediates was wrong (according to the reference manual) in the (debug) logging. Additionally, one operand for the andhi instruction was completly wrong. Fix these. Signed-off-by: Michael Walle --- target-lm32/translate.c | 34

Re: [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro

> On 21 Sep 2016, at 19:15, Eric Blake wrote: > > On 09/21/2016 10:27 AM, Felipe Franciosi wrote: >> On GCC versions 3.4 and newer, simply using (void) in front of a >> function that has been declared with WUR will no longer suppress a >> compilation warning. This commit

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

On 12 October 2016 at 17:42, Michael Walle wrote: > Am 2016-10-12 18:35, schrieb Peter Maydell: >> >> but I noticed while doing the review that our LOG_DIS >> is wrong for the compare-immediates: >> >> LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, >>

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

Am 2016-10-12 18:35, schrieb Peter Maydell: On 12 October 2016 at 17:23, Michael Walle wrote: Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf wrote: > Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: >> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: >> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> >> This series adds

Re: [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

On Wed, Oct 12, 2016 at 9:21 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> Add InetSocketAddress compatibility to SSH driver. >> >> Add a new option "server" to the SSH block driver which then accepts >> a InetSocketAddress. >> >> "host" and

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

On 12/10/2016 15:55, Claudio Imbrenda wrote: >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { >>> +cpu_single_step(cpu, 0); >> > >> > This looks suspicious > why? we set all cpus to single step, since that is the default, and then > we clear the single-step

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

Am 2016-10-12 18:35, schrieb Peter Maydell: but I noticed while doing the review that our LOG_DIS is wrong for the compare-immediates: LOG_DIS("cmpei r%d, r%d, %d\n", dc->r0, dc->r1, sign_extend(dc->imm16, 16)); but the processor reference manual says cmpei's mnemonic

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > >> This series adds blockdev-add support for SSH block driver. > >> > >> Patch 1 prepares the code for the

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

On 12 October 2016 at 17:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- >

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

On 12.10.2016 18:23, Michael Walle wrote: > Both branches of the ternary operator have the same expressions. Drop the > operator. > > This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 > > Signed-off-by: Michael Walle > --- > target-lm32/translate.c | 2 +- > 1 file

[Qemu-devel] [Bug 1541643] Re: IA32_FEATURE_CONTROL MSR unset for nested virtualization

** Also affects: archlinux Importance: Undecided Status: New ** No longer affects: archlinux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1541643 Title: IA32_FEATURE_CONTROL MSR unset

[Qemu-devel] [PATCH] target-lm32: fix style issue

Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle --- target-lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> This series adds blockdev-add support for SSH block driver. >> >> Patch 1 prepares the code for the addition of a new option prefix, >> which is "server.". This is

Re: [Qemu-devel] [PATCH v6 15/35] tcg: Add CONFIG_ATOMIC64

Richard Henderson writes: > Allow qemu to build on 32-bit hosts without 64-bit atomic ops. > > Even if we only allow 32-bit hosts to multi-thread emulate 32-bit > guests, we still need some way to handle the 32-bit guest using a > 64-bit atomic operation. Do so by dropping

Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers

Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

On 10/12/2016 06:22 AM, Kevin Wolf wrote: Am 11.10.2016 um 17:47 hat John Snow geschrieben: On 10/10/2016 03:23 PM, Mark Cave-Ayland wrote: On 10/10/16 17:34, Eric Blake wrote: On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote: The hard-coded default alignment is BDRV_SECTOR_SIZE, however

Re: [Qemu-devel] [PATCH] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

On 12 October 2016 at 16:33, Thomas Huth wrote: > The condition '!A || (A && B)' is equivalent to '!A || B' > > Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 > Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell thanks

Re: [Qemu-devel] [PATCH v2 11/11] iotests: add transactional failure race test

On 10/12/2016 07:26 AM, Vladimir Sementsov-Ogievskiy wrote: it is almost a duplication of test_transaction_failure, I think it would be better to make separate do_test_transaction_failure with parameter and two wrappers Yes, sorry -- I missed that for this iteration, but I'll act on it for

Re: [Qemu-devel] [Qemu-block] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

Am 12.10.2016 um 17:50 hat Markus Armbruster geschrieben: > "Daniel P. Berrange" writes: > > > The traditional CLI arg syntax allows two ways to specify > > integer lists, either one value per key, or a range of > > values per key. eg the following are identical: > > > >

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a > ssh_has_filename_options_conflict() function which

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

On Wed, 12 Oct 2016 20:43:48 +0530 Kirti Wankhede wrote: > On 10/12/2016 7:22 AM, Tian, Kevin wrote: > >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > >> Sent: Wednesday, October 12, 2016 4:45 AM > +* mdev_supported_types: > +List of current

Re: [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it

Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their

Re: [Qemu-devel] [PATCH v14 11/21] qapi: add integer range support for QObjectInputVisitor

"Daniel P. Berrange" writes: > The traditional CLI arg syntax allows two ways to specify > integer lists, either one value per key, or a range of > values per key. eg the following are identical: > > -arg foo=5,foo=6,foo=7 > -arg foo=5-7 > > This extends the

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 2/3] arm: pmu: Check cycle count increases

On 10/11/2016 01:40 PM, Christopher Covington wrote: > Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, > even for the smallest delta of two subsequent reads. > > Signed-off-by: Christopher Covington > Reviewed-by: Andrew Jones > ---

[Qemu-devel] error reporting in functions

HI all! My questions is: what are general recommendations in Qemu for return code, if we have Error **errp? What should I prefer: errp, duplicated by int return code, or void functions with errp? void + errp seems good, just to not duplicate things. But it has a disadvantage of necessity of

[Qemu-devel] [PATCH] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

The condition '!A || (A && B)' is equivalent to '!A || B' Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth --- hw/tpm/tpm_passthrough.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c

Re: [Qemu-devel] [kvm-unit-tests PATCHv6 1/3] arm: Add PMU test

On 10/11/2016 01:40 PM, Christopher Covington wrote: > Beginning with a simple sanity check of the control register, add > a unit test for the ARM Performance Monitors Unit (PMU). As of > October 2016, whether KVM mode has a PMU at all is a tricky > question of which QEMU / mach-virt version is

Re: [Qemu-devel] Async savevm using userfaultfd(2)

On 10/12/2016 05:04 PM, Stefan Hajnoczi wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves

Re: [Qemu-devel] MTTCG memory ordering

Hi Stefan, Stefan Hajnoczi writes: > Hi Pranith, > I was curious about the status of your MTTCG GSoC work: > > I saw your fence series which implements the noop memory barrier/fence > instructions on various architectures, but I wasn't sure if that also > covers the case where a strong target is

Re: [Qemu-devel] [PATCH V2] docs: add PCIe devices placement guidelines

Marcel, On 10/11/16 15:45, Marcel Apfelbaum wrote: > Proposes best practices on how to use PCI Express/PCI device > in PCI Express based machines and explain the reasoning behind them. > > Signed-off-by: Marcel Apfelbaum > --- > > Hi, > > RFC->v2: > - Addressed a lot of

Re: [Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

On 12 October 2016 at 16:18, Thomas Huth wrote: > The condition '!A || (A && B)' is equivalent to '!A || B'. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 > Signed-off-by: Thomas Huth > --- > hw/block/nvme.c | 4 ++-- > 1 file changed, 2

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

Markus Armbruster writes: > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> "Daniel P. Berrange" writes: >>> Currently the QObjectInputVisitor assumes that all scalar values are directly

[Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

The condition '!A || (A && B)' is equivalent to '!A || B'. Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth --- hw/block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

Re: [Qemu-devel] MTTCG memory ordering

On 10/12/16 10:58, Stefan Hajnoczi wrote: > Hi Pranith, > I was curious about the status of your MTTCG GSoC work: > > I saw your fence series which implements the noop memory barrier/fence > instructions on various architectures, but I wasn't sure if that also > covers the case where a strong

Re: [Qemu-devel] [PATCH] socket: add atomic QEMU_SOCK_NONBLOCK flag

On Fri, Oct 07, 2016 at 10:55:55AM -0500, Eric Blake wrote: > On 10/07/2016 08:54 AM, Stefan Hajnoczi wrote: > > The socket(2) and accept(2) syscalls have been extended to take flags > > that affect the socket atomically at creation time. This not only > > avoids the overhead of additional system

Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

On 10/12/2016 7:22 AM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, October 12, 2016 4:45 AM +* mdev_supported_types: +List of current supported mediated device types and its details are added +in this directory in

Re: [Qemu-devel] PSA: wiki cleaned up

On 12 October 2016 at 11:48, Paolo Bonzini wrote: > I don't have the power to delete pages on the wiki You do now :-) thanks -- PMM

Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method

On Fri, Oct 07, 2016 at 12:07:41PM -0500, Michael Roth wrote: > Quoting Stefan Hajnoczi (2016-10-06 11:40:18) > > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial. > > > > $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ... > > (guest)# qemu-ga -m vsock-listen

Re: [Qemu-devel] [PATCH 3/4] sockets: add AF_VSOCK support

On Fri, Oct 07, 2016 at 11:42:35AM -0500, Michael Roth wrote: > Quoting Stefan Hajnoczi (2016-10-06 11:40:17) > > Add the AF_VSOCK address family so that qemu-ga will be able to use > > virtio-vsock. > > > > The AF_VSOCK address family uses address tuples. The cid is > > the unique

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

Markus Armbruster writes: > Markus Armbruster writes: > >> "Daniel P. Berrange" writes: >> >>> Currently the QObjectInputVisitor assumes that all scalar >>> values are directly represented as the final types declared >>> by the thing

[Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

Thanks for reporting this bug! Looks like this has already been fixed by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=1d5b128cbeeab638f772e ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 10/12/2016 02:07 PM, Paolo Bonzini wrote: > > > > On 12/10/2016 13:59, Halil Pasic wrote: > >> > IMHO this would: > >> > * allow us to keep the good old MVStateInfo objects unmodified and > >> > the semantic of VMStateInfo unchanged >

Re: [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor

Markus Armbruster writes: > "Daniel P. Berrange" writes: > >> Currently the QObjectInputVisitor assumes that all scalar >> values are directly represented as the final types declared >> by the thing being visited. ie it assumes an 'int' is using > > i.e.

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

On Wed 12 Oct 2016 04:30:27 PM CEST, Kevin Wolf wrote: >> if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_STREAM, errp)) { >> goto out; >> } > > Added a bit more context. > > This check is redundant now... > >> if (has_base) { >> base_bs =

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

Am 12.10.2016 um 16:33 hat Alberto Garcia geschrieben: > On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: > >> +/* Block all intermediate nodes between bs and base, because they > >> + * will disappear from the chain after this operation */ > >> +for (iter =

Re: [Qemu-devel] [PATCH v10 10/16] docs: Document how to stream to an intermediate layer

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia > --- > docs/live-block-ops.txt | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt >

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

On Wed 12 Oct 2016 04:23:05 PM CEST, Kevin Wolf wrote: >> +/* Block all intermediate nodes between bs and base, because they >> + * will disappear from the chain after this operation */ >> +for (iter = backing_bs(bs); iter && iter != base; iter = >>

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This patch makes the 'device' parameter of the 'block-stream' command > accept a node name that is not a root node. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. >

Re: [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > This makes sure that the image we are streaming into is open in > read-write mode during the operation. > > Operation blockers are also set in all intermediate nodes, since they > will be removed from the chain afterwards. > > Finally,

Re: [Qemu-devel] Async savevm using userfaultfd(2)

* Stefan Hajnoczi (stefa...@gmail.com) wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves

Re: [Qemu-devel] Async savevm using userfaultfd(2)

On 10/12/2016 09:04 AM, Stefan Hajnoczi wrote: > John and I recently discussed asynchronous savevm and I wanted to post > the ideas so they aren't forgotten. (We're not actively working on this > feature.) > > Asynchronous savevm has the same effect as the 'savevm' monitor command: > it saves

Re: [Qemu-devel] [PULL 00/11] usb patch queue

n the git repository at: > > git://git.kraxel.org/qemu tags/pull-usb-20161012-1 > > for you to fetch changes up to d5c42857d6b0c35028897df8dfc3749eba6f6de3: > > usb-redir: allocate buffers before waking up the host adapter (2016-10-12 > 14:37:24 +0200) > > -

Re: [Qemu-devel] [PATCH v14 10/21] qapi: permit auto-creating nested structs

"Daniel P. Berrange" writes: > Some of the historical command line opts that had their > keys in in a completely flat namespace are now represented > by QAPI schemas that use a nested structs. When converting > the QemuOpts to QObject, there is no information about >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix memory leak in v9fs_write

On Wed, 12 Oct 2016 06:10:56 -0700 Li Qiang wrote: > From: Li Qiang > > If an error occurs when marshal the transfer length to the guest, the > v9fs_write doesn't free an IO vector, thus leading a memory leak. > This patch fix this. > > Signed-off-by: Li

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

"Daniel P. Berrange" writes: > On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: >> Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: >> > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: >> > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange

Re: [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start()

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > When block-commit is launched without the top parameter, it uses > internally a mirror block job. In that case all intermediate nodes > between the active and base nodes must be blocked as well. > > Signed-off-by: Alberto Garcia

[Qemu-devel] Async savevm using userfaultfd(2)

John and I recently discussed asynchronous savevm and I wanted to post the ideas so they aren't forgotten. (We're not actively working on this feature.) Asynchronous savevm has the same effect as the 'savevm' monitor command: it saves RAM, device state, and a snapshot of all disks at the point

Re: [Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

On Wed 12 Oct 2016 03:47:34 PM CEST, Kevin Wolf wrote: > Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: >> Use block_job_add_bdrv() instead of blocking all operations in >> backup_start() and unblocking them in backup_run(). >> >> Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

On 12/10/16 15:15, David Hildenbrand wrote: >>> +for (cx = 0; ccpus && ccpus[cx]; cx++) { >>> +cpu_single_step(cpu, 0); > > This looks suspicious why? we set all cpus to single step, since that is the default, and then we clear the single-step property from all CPUs

Re: [Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > qmp_block_commit() checks for op blockers in the active and > destination (base) images. However all nodes between top_bs and base > are also involved, and they are removed from the chain afterwards. > > In addition to that, if top_bs is

Re: [Qemu-devel] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > After a successful block-commit operation all nodes between top and > base are removed from the backing chain, and top's overlay needs to > be updated to point to base. Because of that we should prevent other > block jobs from messing with

Re: [Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start()

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > Use block_job_add_bdrv() instead of blocking all operations in > backup_start() and unblocking them in backup_run(). > > Signed-off-by: Alberto Garcia This has the same problem as mirror (dataplane must be blocked).

Re: [Qemu-devel] [PATCH 12/15] xen: Rename xen_be_evtchn_event

On Tue, Oct 04, 2016 at 09:43:41AM +0300, Emil Condrea wrote: > Prepare xen_be_evtchn_event to be shared with frontends: > * xen_be_evtchn_event -> xen_pv_evtchn_event > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony

Re: [Qemu-devel] [PATCH 14/15] xen: Rename xen_be_del_xendev

On Tue, Oct 04, 2016 at 09:43:43AM +0300, Emil Condrea wrote: > Prepare xen_be_del_xendev to be shared with frontends: > * xen_be_del_xendev -> xen_pv_del_xendev > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCHv2 6/7] spapr_pci: Add a 64-bit MMIO window

On 12/10/2016 06:44, David Gibson wrote: > On real hardware, and under pHyp, the PCI host bridges on Power machines > typically advertise two outbound MMIO windows from the guest's physical > memory space to PCI memory space: > - A 32-bit window which maps onto 2GiB..4GiB in the PCI address

Re: [Qemu-devel] [PATCH 13/15] xen: Rename xen_be_find_xendev

On Tue, Oct 04, 2016 at 09:43:42AM +0300, Emil Condrea wrote: > Prepare xen_be_find_xendev to be shared with frontends: > * xen_be_find_xendev -> xen_pv_find_xendev > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH 10/15] xen: Rename xen_be_unbind_evtchn

On Tue, Oct 04, 2016 at 09:43:39AM +0300, Emil Condrea wrote: > Prepare xen_be_unbind_evtchn to be shared with frontends: > * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony

Re: [Qemu-devel] [PATCH v3 6/7] target-arm: Make page size a runtime setting

On Tue, Oct 11, 2016 at 06:08:18PM +0100, Peter Maydell wrote: > Rather than defining TARGET_PAGE_BITS to always be 10, > switch to using a value picked at runtime. This allows us > to use 4K pages for modern ARM CPUs (and in particular all > 64-bit CPUs) without having to drop support for the old

Re: [Qemu-devel] [PATCH v3 6/7] target-arm: Make page size a runtime setting

On 12 October 2016 at 14:33, Andrew Jones wrote: > On Tue, Oct 11, 2016 at 06:08:18PM +0100, Peter Maydell wrote: >> Rather than defining TARGET_PAGE_BITS to always be 10, >> switch to using a value picked at runtime. This allows us >> to use 4K pages for modern ARM CPUs (and

Re: [Qemu-devel] [PATCH] 9pfs: fix memory leak in v9fs_link

On Wed, 12 Oct 2016 00:12:48 -0700 Li Qiang wrote: > From: Li Qiang > > In v9fs_link dispatch function, it doesn't put the 'oldfidp' > fid object, this will make the 'oldfidp->ref' never reach to 0, > thus leading a memory leak issue. This patch fix this. >

Re: [Qemu-devel] [PATCH 11/15] xen: Rename xen_be_send_notify

On Tue, Oct 04, 2016 at 09:43:40AM +0300, Emil Condrea wrote: > Prepare xen_be_send_notify to be shared with frontends: > * xen_be_send_notify -> xen_pv_send_notify > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add some ARM related files to the corresponding sections

On Wed, Oct 12, 2016 at 11:57 AM, Thomas Huth wrote: > The files w/cpu/a*mpcore.c are already assigned to the ARM CPU > section, but the corresponding headers include/hw/cpu/a*mpcore.h > are still missing. > > The file hw/*/imx* are already assigned to the i.MX31 machine, but >

Re: [Qemu-devel] [PATCH] 9pfs: fix integer overflow issue in xattr read/write

Hi Li, I agree with the idea behind this patch but I have the impression that some more work is needed. See below. On Tue, 11 Oct 2016 21:29:19 -0700 Li Qiang wrote: > From: Li Qiang > > In 9pfs xattr read/write function, it mix to use unsigned/signed >

Re: [Qemu-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions

On Tue, Oct 04, 2016 at 09:43:37AM +0300, Emil Condrea wrote: > The name of the functions moved to xen_pvdev.c: > * xenstore_cleanup_dir > * xen_config_cleanup > * xenstore_mkdir > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD --

Re: [Qemu-devel] [PATCH 09/15] xen: Rename xen_be_printf to xen_pv_printf

On Tue, Oct 04, 2016 at 09:43:38AM +0300, Emil Condrea wrote: > Prepare xen_be_printf to be used by both backend and frontends: > * xen_be_printf -> xen_pv_printf > > Signed-off-by: Emil Condrea Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour

> > +if (def == 0) { > > +for (cx = 0; scpus && scpus[cx]; cx++) { > > +cpu_single_step(scpus[cx], sstep_flags); > > +cpu_resume(scpus[cx]); > > +} > > +for (cx = 0; ccpus && ccpus[cx]; cx++) { > > +

Re: [Qemu-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c

On Tue, Oct 04, 2016 at 09:43:33AM +0300, Emil Condrea wrote: > Its purpose is to store frontend related functions. > > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea Looks good, once the comments on the previous patches are addressed, same

Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode

On 10/12/2016 06:33 AM, Artyom Tarasenko wrote: On Mon, Oct 10, 2016 at 11:41 PM, Richard Henderson wrote: On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/cpu.h | 6 +++--- 1 file changed, 3

Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

On 10/12/2016 06:18 AM, Artyom Tarasenko wrote: What I would most like to see, for QEMU, is an artificial sun4v compatible machine that implements a "hardware" page table walk. I.e. no use of SparcTLBEntry, but walking the page tables directly. Because QEMU can then satisfy a page lookup

Re: [Qemu-devel] [PATCH 01/29] target-sparc: don't trap on MMU-fault if MMU is disabled

On Tue, Oct 11, 2016 at 4:50 PM, Richard Henderson wrote: > On 10/11/2016 09:00 AM, Artyom Tarasenko wrote: >> >> On Mon, Oct 10, 2016 at 11:14 PM, Richard Henderson >> wrote: >>> >>> On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: if

Re: [Qemu-devel] [PATCH 1/2] 9pfs: fix information leak in xattr read

On Mon, 10 Oct 2016 10:56:03 +0200 Greg Kurz wrote: > On Sat, 8 Oct 2016 22:26:51 -0700 > Li Qiang wrote: > > > From: Li Qiang > > > > 9pfs uses g_malloc() to allocate the xattr memory space, if the guest > > reads this memory before

[Qemu-devel] [PATCH v2] 9pfs: fix memory leak in v9fs_write

From: Li Qiang If an error occurs when marshal the transfer length to the guest, the v9fs_write doesn't free an IO vector, thus leading a memory leak. This patch fix this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [Bug 1381642] Re: ecovec.c:66: buffer too small by one.

...and we don't build u-boot for the renesas ecovec, so we don't need to worry about updating our copy of u-boot to something with the fix in it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1381642

[Qemu-devel] [PULL 06/11] xhci: add & use xhci_kick_epctx()

xhci_kick_epctx is a xhci_kick_ep variant which takes an XHCIEPContext as input instead of slotid and epid. So in case we have a XHCIEPContext at hand at the callsite we can just pass it directly. Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PATCH] input-linux: initialize key state

Query input device keys, initialize state accordingly, so the correct state is reflected in case any key is pressed at initialization time. There is a high chance for this to actually happen for the 'enter' key in case you start qemu with a terminal command (directly or virsh). When finding any

Re: [Qemu-devel] Live migration without bdrv_drain_all()

On Tue, Sep 27, 2016 at 10:48:48AM +0100, Daniel P. Berrange wrote: > On Mon, Aug 29, 2016 at 11:06:48AM -0400, Stefan Hajnoczi wrote: > > At KVM Forum an interesting idea was proposed to avoid > > bdrv_drain_all() during live migration. Mike Cui and Felipe Franciosi > > mentioned running at

[Qemu-devel] [PULL 04/11] xhci: use linked list for transfers

xhci has a fixed number of 24 (TD_QUEUE) XHCITransfer structs per endpoint, which turns out to be a problem for usb3 devices with 32 (or more) bulk streams. xhci re-checks the trb rings on every finished transfer to make sure it'll pick up any pending work. But that scheme breaks in case the

[Qemu-devel] [PULL 10/11] usb: Fix incorrect default DMA offset.

From: Vijay Kumar B The default DMA offset is set to 3. When the property is not set by the consumer, the default causes DMA access to be shifted by 3 bytes. In PXA, this results in incorrect DMA access, leading to error notification in the USB controller driver. A better

[Qemu-devel] [PULL 03/11] xhci: drop unused comp_xfer field

Signed-off-by: Gerd Hoffmann Message-id: 1474965172-30321-4-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index d9ac1b4..3a035c8 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PULL 09/11] usb: fix serial generator

snprintf return value is *not* the number of chars written into the buffer, but the number of chars needed. So in case the buffer is too small you can go alloc a bigger one and try again. But that also means you can't simply use the return value for the next snprintf call without checking

[Qemu-devel] [PULL 05/11] xhci: drop XHCITransfer->xhci

Use XHCITransfer->epctx->xhci instead. Signed-off-by: Gerd Hoffmann Message-id: 1474965172-30321-6-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/usb/hcd-xhci.c

[Qemu-devel] [PULL 01/11] xhci: limit the number of link trbs we are willing to process

Needed to avoid we run in circles forever in case the guest builds an endless loop with link trbs. Reported-by: Li Qiang Tested-by: P J P Signed-off-by: Gerd Hoffmann Message-id: 1476096382-7981-1-git-send-email-kra...@redhat.com ---

[Qemu-devel] [PULL 11/11] usb-redir: allocate buffers before waking up the host adapter

From: Hans de Goede Needed to make sure usb redirection is prepared to actually handle the callback from the usb host adapter. Without this interrupt endpoints don't work on xhci. Note: On ehci the usb_wakeup() call only schedules a BH for the actual work, which hides this

[Qemu-devel] [PULL 00/11] usb patch queue

changes since commit 6b39b06339ee59559b31f860d4af635b046322df: build: Work around SIZE_MAX bug in OSX headers (2016-10-11 19:22:20 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20161012-1 for you to fetch changes up

<    1   2   3   4   >