Re: [Qemu-devel] [PATCH] spice: wakeup QXL worker to pick up mouse changes

On Mo, 2017-01-30 at 14:45 +0400, Marc-André Lureau wrote: > Without it, server-mode mouse is "slow" to update position: QXL will > wait until new display commands come. This is very visible with > virtio-gpu. Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] ui/gtk.c: add ctrl-alt-= support for zoom in acceleration

On Di, 2017-01-31 at 09:32 +0800, Ziyue Yang wrote: > From: Ziyue Yang > > Solving wishlist item at > https://bugs.launchpad.net/qemu/+bug/1656710 > by accepting Ctrl-Alt-= as an additional zoom-in acceleration. > > Using gtk_accel_group_connect to support multiple

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

Hi, > > It would be nice for this series to evolve to a generic QMP jobs series > > so that all background operations are visible to the client and a useful > > subset of management primitives can be implemented on a per-command > > basis. Both live migration and existing block jobs could use

Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange wrote: > On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: >> Currently qemu_chr_fe_write() calls qemu_chr_fe_write_log() only for >> data consumed by the backend chr_write function. With the pty backend, >>

[Qemu-devel] [Bug 1656710] Re: Please support Ctrl-Alt-= to zoom in

** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1656710 Title: Please support Ctrl-Alt-= to zoom in Status in QEMU: In Progress Bug

Re: [Qemu-devel] [PATCH] target/ppc/cpu-models: Fix/remove bad CPU aliases

On Tue, Jan 24, 2017 at 12:48:05PM +0100, Thomas Huth wrote: > There is no CPU model called "7447_v1.2" in our list, so the > "7447" alias should point to "7447_v1.1" instead. Let's also > remove the "codename" aliases that point to non-implemented > CPU models - they are really of no use here. >

Re: [Qemu-devel] [PATCH 3/3] ppc: switch to constants within BUILD_BUG_ON

On Fri, Jan 27, 2017 at 06:27:16PM +0200, Michael S. Tsirkin wrote: > We are switching BUILD_BUG_ON to verify that it's parameter is a > compile-time constant, and it turns out that some gcc versions > (specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are > not smart enough to

Re: [Qemu-devel] [PATCH v5 03/18] vfio: allow to notify unmap for very large region

On Tue, Jan 24, 2017 at 09:32:07AM -0700, Alex Williamson wrote: > On Tue, 24 Jan 2017 18:25:56 +0800 > Peter Xu wrote: > > > Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big > > region. This can be leveraged by QEMU IOMMU implementation to cleanup > >

Re: [Qemu-devel] [PATCH] target/ppc: Remove unused POWERPC_FAMILY(POWER)

On Tue, Jan 24, 2017 at 11:55:07AM +0100, Thomas Huth wrote: > We do not support POWER1 CPUs in QEMU, so it does not make sense > to keep this stub around. > > Signed-off-by: Thomas Huth Merged to ppc-for-2.9, thanks. > --- > target/ppc/translate_init.c | 22

Re: [Qemu-devel] Towards an ivshmem 2.0?

On Sunday, January 29, 2017 10:14 PM, Jan Kiszka wrote: > On 2017-01-29 15:00, Marc-André Lureau wrote: > > Hi > > > > On Sun, Jan 29, 2017 at 12:44 PM Jan Kiszka > > wrote: > > > > >> Of course, I'm careful with investing much time into expanding

Re: [Qemu-devel] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

On 04/01/2017 11:47, Jeff Cody wrote: > On Wed, Jan 04, 2017 at 12:42:53PM +0100, Paolo Bonzini wrote: >> >> >> On 04/01/2017 05:07, Jeff Cody wrote: >>> On Wed, Dec 21, 2016 at 03:07:07PM +0100, Paolo Bonzini wrote: On 29/11/2016 12:32, Paolo Bonzini wrote: > Cleaning up the

[Qemu-devel] [PATCH] ui/gtk.c: add ctrl-alt-= support for zoom in acceleration

From: Ziyue Yang Solving wishlist item at https://bugs.launchpad.net/qemu/+bug/1656710 by accepting Ctrl-Alt-= as an additional zoom-in acceleration. Using gtk_accel_group_connect to support multiple accelerations triggering a single menu item since that

Re: [Qemu-devel] qemu-pcc 2.8.0 linux-user segfaults

On Mon, Jan 16, 2017 at 04:03:21PM -0600, Aníbal Limón wrote: > > > On 01/16/2017 03:56 PM, Aníbal Limón wrote: > > Hi folks, > > > > I'm trying to upgrade qemu to 2.8.0 in Openembedded-core and segfaults > > in qemu-ppc when is executing: Hi Aníbal, I've recently encountered a similar

[Qemu-devel] [Bug 1622547] Re: qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

BTW, the patch posted in comment #9 works for me as well on qemu 2.8.0. Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1622547 Title: qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

Re: [Qemu-devel] [PATCH v2 02/16] softloat: disable floatx80_invalid_encoding() for m68k

On Jan 30 2017, Peter Maydell wrote: > I guess we need to look more carefully at exactly what the > m68k does for these encodings (maybe have a 'normalize value' > function which squashes them down to whatever the equivalent > non-weird encoding is?). On the m68k, the

[Qemu-devel] [Bug 1622547] Re: qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

Hi everyone, Thanks for your hard work on SPARC emulation. Almost feels like I got my old SS5 and SS20 back. What commit (if any) might I find the fix for SS20 in? Thanks, Vincent -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 07/17] nbd: convert to use qio_channel_yield

On 30/01/2017 10:50, Stefan Hajnoczi wrote: > On Fri, Jan 20, 2017 at 05:43:12PM +0100, Paolo Bonzini wrote: >> +aio_co_wake(s->recv_coroutine[i]); >> >> -qemu_coroutine_enter(nbd_get_client_session(bs)->send_coroutine); >> +/* We're woken up by the recv_coroutine itself.

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

On 29/01/2017 08:19, Ashijeet Acharya wrote: > Also, Paolo has a similar opinion to yours that we should fix it > instead of blocking it. He suggests to migrate only the device states > and skip all the RAM related stuff. Maybe he can explain it better > when he is available. Yes, there is even

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

On Fri, Jan 27, 2017 at 10:43:13AM -0500, Kevin O'Connor wrote: > On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: > > On 01/27/17 15:18, Kevin O'Connor wrote: > > > If an offset is going to be added, shouldn't both a source offset and > > > destination offset be used? > > > > > >

Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

On 01/30/2017 06:47 PM, Daniel P. Berrange wrote: > What is #PSBM-57554 referring to ? Is that some custom bug tracker > you have ? I'm going to drop that unless its something we need to > keep it must be dropped. Sorry, this is my mistake. Den > On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis

Re: [Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake

On 30/01/2017 10:18, Stefan Hajnoczi wrote: > On Fri, Jan 20, 2017 at 05:43:06PM +0100, Paolo Bonzini wrote: >> diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h >> index 14d4f1d..1efa356 100644 >> --- a/include/qemu/coroutine_int.h >> +++ b/include/qemu/coroutine_int.h >>

Re: [Qemu-devel] [PATCH v2 28/41] char: move QIOChannel-related stuff to char-io.h

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > chardev/char-io.h | 46 > chardev/char-io.c | 192 > ++ > chardev/char.c| 174

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

On 30/01/2017 08:39, Marc-André Lureau wrote: > The class kind is necessary to lookup the chardev name in > qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set > the appropriate ChardevBackend (mainly to free the right > fields). > > qemu_chr_new_from_opts() can be changed to

Re: [Qemu-devel] [PATCH v2 25/41] char: move ringbuf/memory to its own file

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > chardev/char-ringbuf.c | 249 > + > chardev/char.c | 218 --- >

Re: [Qemu-devel] [PATCH v2 24/41] char: move mux to its own file

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > A mechanical move, except that qemu_chr_write_all() needs to be declared > in char.h header to be used from chardev unit files. > > Signed-off-by: Marc-André Lureau > --- > chardev/char-mux.h| 63 + >

Re: [Qemu-devel] [PATCH v2 23/41] char: move null chardev to its own file

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > chardev/char-null.c | 54 > +++ > chardev/char.c| 23 -- > chardev/Makefile.objs | 1 + > 3

Re: [Qemu-devel] [PATCH v2 19/41] char: remove class kind field

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > The class kind is necessary to lookup the chardev name in > qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set > the appropriate ChardevBackend (mainly to free the right > fields). > > qemu_chr_new_from_opts() can be changed to

Re: [Qemu-devel] [PATCH v2 17/41] char: get rid of CharDriver

On 01/30/2017 07:39 AM, Marc-André Lureau wrote: > qemu_chr_new_from_opts() is modified to not need CharDriver backend[] > array, but uses instead objectified qmp_query_chardev_backends() and > char_get_class(). The alias field is moved outside in a ChardevAlias[], > similar to QDevAlias for

Re: [Qemu-devel] [PATCH v2 01/41] MAINTAINERS: add myself to qemu-char.c

On 30/01/2017 08:39, Marc-André Lureau wrote: > I consider to have enough experience with qemu-char to propose myself as > maintainer. This will allow me to send pull request without waiting for > Paolo. With pleasure. :) Paolo > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PULL 23/35] x86: ioapic: dump version for "info ioapic"

On 30/01/2017 09:07, Peter Maydell wrote: > On 20 January 2017 at 13:31, Paolo Bonzini wrote: >> From: Peter Xu >> >> Signed-off-by: Peter Xu >> Message-Id: <1483952153-7221-3-git-send-email-pet...@redhat.com> >> Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH 06/15] postcopy: Record largest page size

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Record the largest page size in use; we'll need it soon for

Re: [Qemu-devel] [PATCH v2 01/16] softfloat: define 680x0 specific values

On 30 January 2017 at 18:16, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > +#elif defined(TARGET_M68K) > +static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN, > + flag aIsLargerSignificand) > +{ > +/* If

Re: [Qemu-devel] [PATCH 05/15] postcopy: enhance ram_discard_range for hugepages

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Unfortunately madvise DONTNEED doesn't work on hugepagetlb >> > so

Re: [Qemu-devel] [PATCH v2 02/16] softloat: disable floatx80_invalid_encoding() for m68k

On 30 January 2017 at 18:16, Laurent Vivier wrote: > According to the comment, this definition of invalid encoding is given > by intel developer's manual, and doesn't work with the behavior > of 680x0 FPU. > > Signed-off-by: Laurent Vivier Part of the

Re: [Qemu-devel] [PATCH v1 6/6] qemu-img: copy *key-secret opts when opening newly created files

On 01/26/2017 05:04 AM, Daniel P. Berrange wrote: > The qemu-img dd/convert commands will create a image file and > then try to open it. Historically it has been possible to open > new files without passing any options. With encrypted files > though, the *key-secret options are mandatory, so we

Re: [Qemu-devel] [PATCH v2 00/16] target-m68k: implement 680x0 FPU

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 00/16] target-m68k: implement 680x0 FPU Message-id: 20170130181634.13934-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 05/15] postcopy: enhance ram_discard_range for hugepages

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Unfortunately madvise DONTNEED doesn't work on hugepagetlb > > so use fallocate(FALLOC_FL_PUNCH_HOLE) > > qemu_fd_getpagesize

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

Hi - Original Message - > On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > > > > - Original Message - > > > > > On Wed, Jan 18, 2017 at

Re: [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

On Mon, Jan 30, 2017 at 07:13:51PM +0100, Christoph Hellwig wrote: > Support deallocating of LBAs using the DSM command by wiring it up to > the qemu discard implementation. The other DSM operations which are > purely advisory are ignored for now. > > Based on an implementation by Keith Busch in

Re: [Qemu-devel] [PATCH v2 00/16] target-m68k: implement 680x0 FPU

On Jan 30 2017, Laurent Vivier wrote: > The floatx80 datatype used here is not exactly the same as the > one used by 680x0 for its extended precision data type, because > normally the signaling bit of 680x0 NAN is the MSB of the mantissa > minus one and in floatx80 it is the

[Qemu-devel] [PATCH v2 16/16] target-m68k: add fsincos

Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 21 + target/m68k/helper.h | 1 + target/m68k/translate.c | 15 +++ 3 files changed, 37 insertions(+) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index

[Qemu-devel] [PATCH v2 05/16] target-m68k: use floatx80 internally

Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 13 +- target/m68k/cpu.h| 10 +- target/m68k/fpu_helper.c | 202

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

On 01/26/2017 07:27 AM, Daniel P. Berrange wrote: > On Thu, Jan 26, 2017 at 08:35:30PM +0800, Fam Zheng wrote: >> On Thu, 01/26 11:04, Daniel P. Berrange wrote: >>> The -n arg to the convert command allows use of a pre-existing image, >>> rather than creating a new image. This adds a -n arg to the

[Qemu-devel] [PATCH v2 15/16] target-m68k: add more FPU instructions

Add fsinh, flognp1, ftanh, fatan, fasin, fatanh, fsin, ftan, fetox, ftwotox, ftentox, flogn, flog10, facos, fcos. As softfloat library does not provide these functions, we us the libm of the host. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 237

[Qemu-devel] [PATCH v2 13/16] target-m68k: add fsglmul and fsgldiv

fsglmul and fsgldiv truncate data to single precision before computing results. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 22 ++ target/m68k/helper.h | 2 ++ target/m68k/translate.c | 8 3 files changed, 32 insertions(+)

[Qemu-devel] [PATCH v2 10/16] target-m68k: add fscc.

use DisasCompare with FPU conditions in fscc and fbcc. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 228 1 file changed, 153 insertions(+), 75 deletions(-) diff --git a/target/m68k/translate.c

Re: [Qemu-devel] [PATCH] qcow2: Optimize the refcount-block overlap check

On 01/30/2017 10:34 AM, Alberto Garcia wrote: > > I don't think QEMU produces files where refcount_table[i] == 0 but > refcount_table[i + 1] != 0. Do they even make sense? I don't know if qemu can be directly coerced to create such an image, but a third party tool can (and that probably

[Qemu-devel] [PATCH v2 03/16] target-m68k: move FPU helpers to fpu_helper.c

Signed-off-by: Laurent Vivier --- target/m68k/Makefile.objs | 2 +- target/m68k/fpu_helper.c | 112 ++ target/m68k/helper.c | 88 3 files changed, 113 insertions(+), 89 deletions(-)

[Qemu-devel] [PATCH v2 04/16] target-m68k: define ext_opsize

Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9f60fbc..d9ba735 100644 ---

[Qemu-devel] [PATCH v2 11/16] target-m68k: add fmovecr

fmovecr moves a floating point constant from the FPU ROM to a floating point register. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 31 +++ target/m68k/helper.h | 1 + target/m68k/translate.c | 12 +++- 3 files

[Qemu-devel] [PATCH v2 09/16] target-m68k: add fmovem

Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 6 +++ target/m68k/helper.h | 1 + target/m68k/translate.c | 99 +++- 3 files changed, 80 insertions(+), 26 deletions(-) diff --git a/target/m68k/fpu_helper.c

[Qemu-devel] [PATCH v2 07/16] target-m68k: manage FPU exceptions

Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 28 + target/m68k/fpu_helper.c | 107 ++- target/m68k/helper.h | 1 + target/m68k/translate.c | 27 4 files changed, 162 insertions(+), 1

[Qemu-devel] [PATCH v2 14/16] target-m68k: add explicit single and double precision operations

Add fssqrt, fdsqrt, fsabs, fdabs, fsneg, fdneg, fsadd, fdadd, fssub, fdsub, fsmul, fdmul, fsdiv, fddiv, fsmove and fdmove. The precision is managed using set_floatx80_rounding_precision(), except for fsmove, fdmove, fsneg, fdneg, fsabs and fdabs: the value is converted manually to the given

[Qemu-devel] [PATCH v2 02/16] softloat: disable floatx80_invalid_encoding() for m68k

According to the comment, this definition of invalid encoding is given by intel developer's manual, and doesn't work with the behavior of 680x0 FPU. Signed-off-by: Laurent Vivier --- fpu/softfloat.c | 20 include/fpu/softfloat.h | 15

[Qemu-devel] [PATCH v2 06/16] target-m68k: add FPCR and FPSR

Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 2 +- target/m68k/cpu.h| 36 +- target/m68k/fpu_helper.c | 116 +++--- target/m68k/helper.c | 20 ++- target/m68k/helper.h | 3 +- target/m68k/qregs.def| 1 +

[Qemu-devel] [PATCH v2 01/16] softfloat: define 680x0 specific values

Signed-off-by: Laurent Vivier --- fpu/softfloat-specialize.h | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index f05c865..01b594f 100644 ---

[Qemu-devel] [PATCH v2 12/16] target-m68k: add fscale, fgetman, fgetexp and fmod

Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 1 + target/m68k/fpu_helper.c | 56 target/m68k/helper.h | 4 target/m68k/translate.c | 14 4 files changed, 75 insertions(+) diff --git

[Qemu-devel] [PATCH v2 00/16] target-m68k: implement 680x0 FPU

This series modifies the original ColdFire FPU implementation to use floatx80 instead of float64 internally as this is the native datatype for 680x0. I didn't keep the float64 type for ColdFire, but if someone thinks it's required I can update this series in this way. The series also adds the FPU

[Qemu-devel] [PATCH v2 08/16] target-m68k: define 96bit FP registers for gdb on 680x0

Signed-off-by: Laurent Vivier --- configure| 2 +- gdb-xml/m68k-fp.xml | 21 + target/m68k/helper.c | 45 + 3 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 gdb-xml/m68k-fp.xml

[Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

Support deallocating of LBAs using the DSM command by wiring it up to the qemu discard implementation. The other DSM operations which are purely advisory are ignored for now. Based on an implementation by Keith Busch in the qemu-nvme.git repository, but rewritten to use the qemu AIO

[Qemu-devel] [PATCH 0/2] two more NVMe commands

Hi all, this series implements two more NVMe commands: DSM and Write Zeroes. Both trace their lineage to Keith's qemu-nvme.git repository, and while the Write Zeroes one is taken from there almost literally the DSM one has seen a major rewrite to not block the main thread as well as various other

[Qemu-devel] [PATCH 2/2] nvme: Implement Write Zeroes

From: Keith Busch Signed-off-by: Keith Busch [hch: ported over from qemu-nvme.git to mainline] Signed-off-by: Christoph Hellwig --- hw/block/nvme.c | 27 ++- hw/block/nvme.h | 1 + 2 files changed, 27

Re: [Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

On 01/30/2017 08:16 PM, Eric Blake wrote: > On 01/30/2017 04:22 AM, Denis V. Lunev wrote: >> If explicit zeroing out before mirroring is required for the target image, >> it moves the block job offset counter to EOF, then offset and len counters >> count the image size twice. >> >> There is no

Re: [Qemu-devel] [PATCH] io: fix decoding when multiple websockets frames arrive at once

On 01/30/2017 04:51 AM, Daniel P. Berrange wrote: > The qio_channel_websock_read_wire() method will read upto 4096 s/upto/up to/ > bytes off the socket and then decode the websockets header and > payload. The code was only decoding a single websockets frame, > even if the buffered data contained

Re: [Qemu-devel] [PATCH 1/1] mirror: restore offset after zeroing out the image

On 01/30/2017 04:22 AM, Denis V. Lunev wrote: > If explicit zeroing out before mirroring is required for the target image, > it moves the block job offset counter to EOF, then offset and len counters > count the image size twice. > > There is no harm but confusing stats (e.g. for 1G image the

Re: [Qemu-devel] [PATCH v4 6/7] blkdebug: Add ability to override unmap geometries

On 01/28/2017 02:57 PM, Max Reitz wrote: > On 20.12.2016 20:15, Eric Blake wrote: >> Make it easier to simulate various unusual hardware setups (for >> example, recent commits 3482b9b and b8d0a98 affect the Dell >> Equallogic iSCSI with its 15M preferred and maximum unmap and >> write zero sizing,

Re: [Qemu-devel] [PATCH v8 08/25] tcg: drop global lock during TCG code execution

On 01/30/2017 01:57 AM, Alex Bennée wrote: >>> diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c >>> index a9ee7fddf9..2624d8d909 100644 >>> --- a/hw/intc/arm_gicv3_cpuif.c >>> +++ b/hw/intc/arm_gicv3_cpuif.c >>> @@ -14,6 +14,7 @@ >>> >>> #include "qemu/osdep.h" >>> #include

Re: [Qemu-devel] [PATCH v4 2/7] qcow2: Discard/zero clusters by byte count

On 01/28/2017 02:21 PM, Max Reitz wrote: > On 20.12.2016 20:15, Eric Blake wrote: >> Passing a byte offset, but sector count, when we ultimately >> want to operate on cluster granularity, is madness. Clean up >> the interfaces to take both offset and count as bytes, while >> still keeping the

Re: [Qemu-devel] [PATCH v1 1/6] qemu-img: add support for --object with 'dd' command

On 01/26/2017 05:04 AM, Daniel P. Berrange wrote: > The qemu-img dd command added --image-opts support, but missed > the corresponding --object support. This prevented passing > secrets (eg auth passwords) needed by certain disk images. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v3 3/3] qemu-io: Fix tests expecting the wrong output

On 01/27/2017 09:59 PM, Nir Soffer wrote: > From: Nir Soffer > > Many tests expected the wrong behavior when qemu-io call into the > command with after failing to open the file, writing this error: > > no file open, try 'help open' > > Now that we fail immediately when

Re: [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure

On 01/27/2017 09:59 PM, Nir Soffer wrote: > From: Nir Soffer > > The result of openfile was not checked, leading to failure deep in the > actual command with confusing error message, and exiting with exit code 0. > When posting a series, please ensure that your messages are

Re: [Qemu-devel] [RFC 3/4] hw/intc/arm_gicv3_its: Implement state save/restore

Auger Eric wrote: > Hi Juan, > > On 30/01/2017 10:15, Juan Quintela wrote: >> Eric Auger wrote: >>> We need to handle both registers and ITS tables. While >>> register handling is standard, ITS table handling is more >>> challenging since the kernel

Re: [Qemu-devel] [PATCH] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

Peter Maydell wrote: > On 30 January 2017 at 14:41, Ashijeet Acharya > wrote: >> Commit a3a3d8c7 introduced a segfault bug while checking for >> 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add >> devices which do no set

Re: [Qemu-devel] [PATCH 06/15] postcopy: Record largest page size

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Record the largest page size in use; we'll need it soon for allocating > > temporary buffers. > > > > Signed-off-by: Dr. David

Re: [Qemu-devel] [PATCH] qcow2: Optimize the refcount-block overlap check

On Mon 30 Jan 2017 05:14:41 PM CET, Alberto Garcia wrote: > This patch keeps the index of the last used (i.e. non-zero) entry in > the refcount table and updates it every time the table changes. The > refcount-block overlap check then uses that index instead of reading > the whole table. Note

Re: [Qemu-devel] QEMU websockets support is laggy?

On 1/30/2017 5:51 AM, Daniel P. Berrange wrote: On Fri, Jan 27, 2017 at 06:08:20PM +, Daniel P. Berrange wrote: On Fri, Jan 27, 2017 at 09:35:38AM +, Daniel P. Berrange wrote: On Tue, Jan 24, 2017 at 05:02:25PM -0500, Brian Rak wrote: We've been considering switching over to using

[Qemu-devel] [PATCH] qcow2: Optimize the refcount-block overlap check

The metadata overlap checks introduced in a40f1c2add help detect corruption in the qcow2 image by verifying that data writes don't overlap with existing metadata sections. The 'refcount-block' check in particular iterates over the refcount table in order to get the addresses of all refcount

Re: [Qemu-devel] [PATCH 11/17] block: explicitly acquire aiocontext in timers that need it

On Fri, Jan 20, 2017 at 05:43:16PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/curl.c| 2 ++ > block/io.c | 5 + > block/iscsi.c | 8 ++-- > block/null.c| 4 >

Re: [Qemu-devel] Towards an ivshmem 2.0?

On 2017-01-30 13:19, Markus Armbruster wrote: >>> Can you explain why not letting the guest map the shared memory into its >>> address space on its own just like any other piece of device memory is a >>> requirement? >> >> It requires reconfiguration of the sensitive 2nd level page tables >>

Re: [Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev()

On 30/01/17 16:46, Peter Maydell wrote: > On 30 January 2017 at 15:14, Juergen Gross wrote: >> The error exits of xen_pv_find_xendev() free the new xen-device via >> g_free() which is wrong. >> >> As the xen-device has been initialized as qdev it must be removed >> via

Re: [Qemu-devel] [RFC PATCH 1/5] checkpatch: add a check for utf-8 in commit logs

On 30.01.2017 15:12, Stefan Hajnoczi wrote: > On Thu, Jan 26, 2017 at 02:11:01PM +0100, Thomas Huth wrote: >> This patch is a port of the following commit from the Linux kernel: >> >> commit 15662b3e8644905032c2e26808401a487d4e90c1 >> Author: Joe Perches >> Date: Mon Oct 31

Re: [Qemu-devel] [PATCH 07/17] nbd: convert to use qio_channel_yield

On Fri, Jan 20, 2017 at 05:43:12PM +0100, Paolo Bonzini wrote: > +aio_co_wake(s->recv_coroutine[i]); > > -qemu_coroutine_enter(nbd_get_client_session(bs)->send_coroutine); > +/* We're woken up by the recv_coroutine itself. */ > +qemu_coroutine_yield(); This relies

Re: [Qemu-devel] [PATCH 06/17] io: make qio_channel_yield aware of AioContexts

On Fri, Jan 20, 2017 at 05:43:11PM +0100, Paolo Bonzini wrote: > Support separate coroutines for reading and writing, and place the > read/write handlers on the AioContext that the QIOChannel is registered > with. > > Cc: Daniel P. Berrange > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/1] io: ignore case in WebSocket HTTP header #PSBM-57554

What is #PSBM-57554 referring to ? Is that some custom bug tracker you have ? I'm going to drop that unless its something we need to keep On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis V. Lunev wrote: > From: Anton Nefedov > > According to RFC7230 Section 3.2,

Re: [Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev()

On 30 January 2017 at 15:14, Juergen Gross wrote: > The error exits of xen_pv_find_xendev() free the new xen-device via > g_free() which is wrong. > > As the xen-device has been initialized as qdev it must be removed > via qdev_unplug(). > > This bug has been introduced with

[Qemu-devel] [PATCH 3/4] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer

xhci_submit and xhci_fire_ctl_transfer are is called from xhci_kick_epctx processing loop only, so there is no need to call xhci_kick_epctx make sure processing continues. Also eecursive calls into xhci_kick_epctx can cause trouble. Drop the xhci_kick_epctx calls. Cc: 1653...@bugs.launchpad.net

[Qemu-devel] [PATCH 4/4] xhci: guard xhci_kick_epctx against recursive calls

Track xhci_kick_epctx processing being active in a variable. Check the variable before calling xhci_kick_epctx from xhci_kick_ep. Add an assert to make sure we don't call recursively into xhci_kick_epctx. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55

Re: [Qemu-devel] [PATCH 05/17] io: add methods to set I/O handlers on AioContext

On Fri, Jan 20, 2017 at 05:43:10PM +0100, Paolo Bonzini wrote: > This is in preparation for making qio_channel_yield work on > AioContexts other than the main one. > > Cc: Daniel P. Berrange > Signed-off-by: Paolo Bonzini > --- > v1->v2: removed

[Qemu-devel] [PATCH 0/4] xhci: fix misc regressions

Hi, Commit 94b037f2a451b3dc855f9f2c346e5049a361bd55 caused some regressions, partly plain bugs in that commit, partly it seems to have uncovered other issues lurking in the xhci code. This series fixes the isses which poped up so far. cheers, Gerd Gerd Hoffmann (4): xhci: only free

[Qemu-devel] [PATCH 2/4] xhci: rename xhci_complete_packet to xhci_try_complete_packet

Make clear that this isn't guaranteed to actually complete the transfer, the usb packet can still be in flight after calling that function. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 1/4] xhci: only free completed transfers

Most callsites check already, one was missed. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by: Fabian Lesniak Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

On 10/20/2016 03:25 PM, Halil Pasic wrote: > diff --git a/migration/vmstate.c b/migration/vmstate.c > index fc29acf..8767e40 100644 > --- a/migration/vmstate.c > +++ b/migration/vmstate.c > @@ -66,10 +66,10 @@ static void *vmstate_base_addr(void *opaque, VMStateField > *field, bool alloc) >

Re: [Qemu-devel] [PATCH 04/17] block: move AioContext and QEMUTimer to libqemuutil

On Fri, Jan 20, 2017 at 05:43:09PM +0100, Paolo Bonzini wrote: > AioContext is fairly self contained, the only dependency is QEMUTimer but > that in turn doesn't need anything else. So move them out of block-obj-y > to avoid introducing a dependency from io/ to block-obj-y. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode

Am 30.01.2017 um 16:11 schrieb Peter Maydell: > On 30 January 2017 at 15:09, Stefan Weil wrote: >> Am 30.01.2017 um 15:50 schrieb David Hildenbrand: >>> "any" does not exist, therefore resulting in a misleading error message. >>> >>> Reported-by: Stefan Weil

Re: [Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake

On Fri, Jan 20, 2017 at 05:43:06PM +0100, Paolo Bonzini wrote: > diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h > index 14d4f1d..1efa356 100644 > --- a/include/qemu/coroutine_int.h > +++ b/include/qemu/coroutine_int.h > @@ -40,12 +40,20 @@ struct Coroutine { >

[Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev()

The error exits of xen_pv_find_xendev() free the new xen-device via g_free() which is wrong. As the xen-device has been initialized as qdev it must be removed via qdev_unplug(). This bug has been introduced with commit 3a6c9172ac5951e6dac2b3f6 ("xen: create qdev for each backend device").

Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode

On 30 January 2017 at 15:09, Stefan Weil wrote: > Am 30.01.2017 um 15:50 schrieb David Hildenbrand: >> "any" does not exist, therefore resulting in a misleading error message. >> >> Reported-by: Stefan Weil >> Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode

Am 30.01.2017 um 15:50 schrieb David Hildenbrand: > "any" does not exist, therefore resulting in a misleading error message. > > Reported-by: Stefan Weil > Signed-off-by: David Hildenbrand > --- > linux-user/main.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [Qemu-devel] [PATCH] migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

On 30 January 2017 at 14:41, Ashijeet Acharya wrote: > Commit a3a3d8c7 introduced a segfault bug while checking for > 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add > devices which do no set their 'dc->vmsd' yet while initialization. > Place a

[Qemu-devel] [PATCH] q35: Provide improved sample configurations

Instead of having a single sample configuration file, now we have two: one gives access to the guest through the serial console and only includes a minimal set of devices, the other uses a graphical console and includes extra devices such as an audio card. Both configuration file are full

  1   2   3   >