[Qemu-devel] [PATCH] target-i386: reduce rtc 0x70 access vm-exit time

some versions of windows guest access rtc frequently because of rtc as system tick.guest access rtc like this: write register index to 0x70, then write or read data from 0x71. writing 0x70 port is just as index and do nothing else. So we can use coalesced mmio to handle this scene to reduce

Re: [Qemu-devel] [PATCH for-2.11 v2] file-posix: Clear out first sector in hdev_create

On Fri, 08/11 09:42, Eric Blake wrote: > On 08/11/2017 03:09 AM, Fam Zheng wrote: > > People get surprised when, after "qemu-img create -f raw /dev/sdX", they > > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > > header. While this is natural because raw doesn't need to

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

On Fri, Aug 11, 2017 at 4:21 PM, Alistair Francis wrote: > On Fri, Aug 11, 2017 at 3:17 PM, Alistair Francis > wrote: >> I found some issues with the way exclusive store was working. This patch >> series seems to fix the test cases that were

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

On Fri, Aug 11, 2017 at 3:17 PM, Alistair Francis wrote: > I found some issues with the way exclusive store was working. This patch > series seems to fix the test cases that were failing for me. > > The first patch is just a simple adjustment. > > The third patch

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

On 08/08/2017 10:26 AM, Vladimir Sementsov-Ogievskiy wrote: Initial review, I'm still playing with this one, and will reply again on Monday. > Do not communicate after the first error to avoid communicating throught s/throught/through a/ > broken channel. The only exclusion is try to send

[Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask

When we perform the atomic_cmpxchg operation we want to perform the operation on a pair of 32-bit registers. Previously we were just passing the register size in which was set to MO_32. This would result in the high register to be ignored. To fix this issue we hardcode the size to be 64-bits long

[Qemu-devel] [PATCH v1 1/3] target/arm: Update the memops for exclusive load

Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Signed-off-by: Alistair Francis Reviewed-by: Richard

[Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

I found some issues with the way exclusive store was working. This patch series seems to fix the test cases that were failing for me. The first patch is just a simple adjustment. The third patch fixes the main bug I was seeing. The second patch is left over from the RFC that seems like it is

[Qemu-devel] [PATCH v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions

Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson --- Although I no longer am using these functions I have left this patch in as Richard thought it was a good

Re: [Qemu-devel] [PATCH 1/2] nbd: Drop connection if broken server is detected

On 08/11/2017 03:01 PM, Eric Blake wrote: > On 08/11/2017 02:41 PM, Eric Blake wrote: >>> Hmm, was it correct even before your patch? Is it safe to enter a coroutine >>> (which we've scheduled by nbd_recv_coroutines_enter_all()), which is >>> actually >>> yielded inside nbd_rwv (not our yield in

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

Hello, Programmingkid, on jeu. 10 août 2017 16:44:19 -0400, wrote: > While compiling I saw these error messages: > > slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' of > class or > structure 'ip6' may result in an unaligned pointer value >

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On Fri, Aug 11, 2017 at 1:39 PM, Alistair Francis wrote: > On Fri, Aug 11, 2017 at 1:38 PM, Richard Henderson > wrote: >> On 08/11/2017 01:29 PM, Alistair Francis wrote: >>> On Fri, Aug 11, 2017 at 1:24 PM, Richard Henderson >>>

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On Fri, Aug 11, 2017 at 1:38 PM, Richard Henderson wrote: > On 08/11/2017 01:29 PM, Alistair Francis wrote: >> On Fri, Aug 11, 2017 at 1:24 PM, Richard Henderson >> wrote: >>> On 08/11/2017 01:13 PM, Alistair Francis wrote: >> +

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On 08/11/2017 01:29 PM, Alistair Francis wrote: > On Fri, Aug 11, 2017 at 1:24 PM, Richard Henderson > wrote: >> On 08/11/2017 01:13 PM, Alistair Francis wrote: > +tcg_gen_ext_i64(val, val, memop); What is this addition intended to

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On Fri, Aug 11, 2017 at 1:24 PM, Richard Henderson wrote: > On 08/11/2017 01:13 PM, Alistair Francis wrote: +tcg_gen_ext_i64(val, val, memop); >>> >>> What is this addition intended to accomplish? Because of the position >>> within >>> the code,

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On 08/11/2017 01:13 PM, Alistair Francis wrote: >>> +tcg_gen_ext_i64(val, val, memop); >> >> What is this addition intended to accomplish? Because of the position within >> the code, you know that memop contains MO_64, so that this is a no-op. > > This is when size == 2 so it's a

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On Fri, Aug 11, 2017 at 12:46 PM, Richard Henderson wrote: > On 08/11/2017 11:19 AM, Alistair Francis wrote: >> The exclusive store operation should return 0 if the operation updates >> memory and 1 if it doesn't. This means that storing tmp in the rd >> register is

Re: [Qemu-devel] [PATCH 1/2] nbd: Drop connection if broken server is detected

On 08/11/2017 02:41 PM, Eric Blake wrote: >> Hmm, was it correct even before your patch? Is it safe to enter a coroutine >> (which we've scheduled by nbd_recv_coroutines_enter_all()), which is >> actually >> yielded inside nbd_rwv (not our yield in nbd_co_receive_reply)? > > I'm honestly not sure

Re: [Qemu-devel] [RFC v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions

On 08/11/2017 11:19 AM, Alistair Francis wrote: > Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions as we are > going to use them later. > > Signed-off-by: Alistair Francis > --- > > tcg/tcg-op.c | 4 ++-- > tcg/tcg-op.h | 2 ++ > 2 files changed, 4

Re: [Qemu-devel] [RFC v1 1/3] target/arm: Update the memops for exclusive load

On 08/11/2017 11:19 AM, Alistair Francis wrote: > Acording to the ARM ARM exclusive loads require the same allignment as > exclusive stores. Let's update the memops used for the load to match > that of the store. This adds the alignment requirement to the memops. > > Signed-off-by: Alistair

Re: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

On 08/11/2017 11:19 AM, Alistair Francis wrote: > The exclusive store operation should return 0 if the operation updates > memory and 1 if it doesn't. This means that storing tmp in the rd > register is incorrect. I'm confused as to what you believe is wrong. >

Re: [Qemu-devel] [PATCH 1/2] nbd: Drop connection if broken server is detected

On 08/11/2017 09:53 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.08.2017 17:15, Eric Blake wrote: >> On 08/11/2017 02:48 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further

Re: [Qemu-devel] [PATCH v6 17/19] migration: Rename initial_bytes

* Juan Quintela (quint...@redhat.com) wrote: > Now it is called qemu_file_bytes that reflects better what it does, > and we create qemu_file_bytes_now to not have to call qemu_ftell() twice. Yes OK, although you could lose the 'qemu_' off the start; it's local anyway. Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

On 11.08.2017 19:18, Richard Henderson wrote: > It's not all kvm related, so I'd prefer the more general name. Thomas suggested to have both, internal.h and kvm_s390x.h All KVM stuff goes into kvm_s390x.h. I even moved the stubs to kvm-stubs.c (that's the way e.g. x86 handles it). End result

[Qemu-devel] [RFC v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions

Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions as we are going to use them later. Signed-off-by: Alistair Francis --- tcg/tcg-op.c | 4 ++-- tcg/tcg-op.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c

[Qemu-devel] [RFC v1 1/3] target/arm: Update the memops for exclusive load

Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Signed-off-by: Alistair Francis ---

[Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

The exclusive store operation should return 0 if the operation updates memory and 1 if it doesn't. This means that storing tmp in the rd register is incorrect. This patch updates the succesful opertion to store 0 into the rd register instead of tmp. It also adds a branch to fail if the memory

[Qemu-devel] [RFC v1 0/3] Fixup exclusive store logic

I found some issues with the way exclusive store was working. This patch series seems to fix the test cases that were failing for me and also seem to follow what the ARM ARM says. The first patch is just a simple adjustment. The second patch is just preparing for the third patch. The third

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

On Fri, Aug 11, 2017 at 05:44:55PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > > CCing Zack Cornelius. > > > > On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > > > This series adds a new "persistent" option to > > >

Re: [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI

On Wed, Aug 09, 2017 at 04:51:21PM -0400, Lan Tianyu wrote: > From: Chao Gao > > If a vIOMMU is exposed to guest, guest will configure the msi to remapping > format. The original code isn't suitable to the new format. A new pair > bind/unbind interfaces are added for this

Re: [Qemu-devel] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3

On 11 August 2017 at 18:10, Peter Maydell wrote: > I get an intermittent failure on aarch64 test-aio-multithread: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > gtester -k --verbose -m=quick tests/test-aio-multithread > TEST:

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

On 08/11/2017 11:05 AM, Markus Armbruster wrote: > We've wanted -object to support non-scalar properties for a while. > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > authorization API". Review led to the conclusion that we need to > replace rather than add to QemuOpts. Initial

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > set, but this was done only when ACPI tables are built which is not > needed for a Xen guest. The need for the property starts with commit > "pc: pcihp:

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

It's not all kvm related, so I'd prefer the more general name. r~ On August 11, 2017 9:19:52 AM CDT, Thomas Huth wrote: >On 11.08.2017 09:46, David Hildenbrand wrote: >> Let's move everything into internal.h > >Or kvm_s390x.h ? ;-) > > Thomas -- Sent from my Android device

Re: [Qemu-devel] [RFC PATCH] memory: fix access_with_adjusted_size() on big-endian

Hi Philippe, Thanks for that, I'll try this out when I'm back. The 15th is blank holiday here. Thanks, Fred On 08/11/2017 04:49 PM, Philippe Mathieu-Daudé wrote: On 08/11/2017 11:25 AM, Paolo Bonzini wrote: On 11/08/2017 16:06, Philippe Mathieu-Daudé wrote: remove unnecessary

Re: [Qemu-devel] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3

On 11 August 2017 at 15:05, Kevin Wolf wrote: > The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-08-10 18:53:39 +0100) > > are available in the git

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/2] Increased the size of requester_id field from MemTxAttrs

On 11 August 2017 at 15:32, Diana Madalina Craciun wrote: > On 07/26/2017 03:23 PM, Auger Eric wrote: >> With respect to the renaming, stream_id really is ARM specific and >> corresponds to the ID space before the SMMU while you mostly address >> device id problematics here

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

Am 11.08.2017 um 17:34 hat Christian Ehrhardt geschrieben: > On Fri, Aug 11, 2017 at 2:37 PM, Kevin Wolf wrote: > > > Am 11.08.2017 um 14:04 hat Fam Zheng geschrieben: > > > On Fri, 08/11 13:07, Christian Ehrhardt wrote: > > > > Simplifying that to a smaller test: > > > > > > >

[Qemu-devel] [Bug 1583420] Re: Please support "-soundhw none"

Pulseaudio is a sound *backend*. This is independent of the choice of guest hardware frontend. You can disable pulseaudio using an env variable QEMU_AUDIO_DRV=none -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > CCing Zack Cornelius. > > On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > > This series adds a new "persistent" option to > > memory-backend-file. The new option it will be useful if > > somebody is sharing RAM

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

CCing Zack Cornelius. On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > This series adds a new "persistent" option to > memory-backend-file. The new option it will be useful if > somebody is sharing RAM contents on a file using share=on, but > don't need it to be flushed to disk

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

On 11.08.2017 18:11, David Hildenbrand wrote: > On 11.08.2017 16:39, Thomas Huth wrote: >> On 11.08.2017 16:21, David Hildenbrand wrote: >>> On 11.08.2017 16:00, Thomas Huth wrote: On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed

[Qemu-devel] [Bug 1583420] Re: Please support "-soundhw none"

It looks like qemu without any specific -soundhw CLI option uses pulseaudio. So I still think a -soundhw none would be nice to have. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1583420 Title:

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

On 11.08.2017 16:19, Thomas Huth wrote: > On 11.08.2017 09:46, David Hildenbrand wrote: >> Let's move everything into internal.h > > Or kvm_s390x.h ? ;-) And even kvm-stubs.c! > > Thomas > > -- Thanks, David

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

On 11.08.2017 16:39, Thomas Huth wrote: > On 11.08.2017 16:21, David Hildenbrand wrote: >> On 11.08.2017 16:00, Thomas Huth wrote: >>> On 11.08.2017 09:46, David Hildenbrand wrote: cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can

Re: [Qemu-devel] [PATCH for-2.10 0/2] Fix NBD client after server error

On 08/10/2017 09:37 PM, Eric Blake wrote: > Patch 1 is a much smaller patch than Vladimir's attempt [1] at fixing > the client in the face of a malicious server. > > [1] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01501.html > > Patch 2 is not to be applied; it is a hack for easily

[Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

v2: * PATCH 1: Whitespace change dropped [Eric] * PATCH 2: Deallocation done differently [Paolo], R-by dropped Commit message typo [Eric] Markus Armbruster (2): vl: Factor object_create() out of main() vl: Partial support for non-scalar properties with -object qapi-schema.json |

[Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

We've wanted -object to support non-scalar properties for a while. Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based authorization API". Review led to the conclusion that we need to replace rather than add to QemuOpts. Initial work towards that goal has been merged to provide -blockdev

[Qemu-devel] [PATCH v2 1/2] vl: Factor object_create() out of main()

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- vl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/vl.c b/vl.c index 8e247cc..96c5da1 100644 ---

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

On Fri, Aug 11, 2017 at 02:35:28PM +, Diana Madalina Craciun wrote: > Hi Edgar, > > On 07/31/2017 06:16 PM, Edgar E. Iglesias wrote: > > On Wed, Jul 26, 2017 at 02:22:28PM +0200, Auger Eric wrote: > >> Hi Diana, > >> On 23/05/2017 13:12, Diana Craciun wrote: > >>> Device IDs are required by

Re: [Qemu-devel] [RFC v6 0/9] ARM SMMUv3 Emulation Support

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1502461354-11327-1-git-send-email-eric.au...@redhat.com Subject: [Qemu-devel] [RFC v6 0/9] ARM SMMUv3 Emulation Support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v6 16/19] migration: Test new fd infrastructure

On Tue, Aug 08, 2017 at 06:26:26PM +0200, Juan Quintela wrote: > We just send the address through the alternate channels and test that it > is ok. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 50 ++ > 1 file

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

On Fri, Aug 11, 2017 at 2:37 PM, Kevin Wolf wrote: > Am 11.08.2017 um 14:04 hat Fam Zheng geschrieben: > > On Fri, 08/11 13:07, Christian Ehrhardt wrote: > > > Simplifying that to a smaller test: > > > > [...] > > > Block node is read-only > [...] > > > > This is actually

Re: [Qemu-devel] [PATCH v6 18/19] migration: Transfer pages over new channels

On Tue, Aug 08, 2017 at 06:26:28PM +0200, Juan Quintela wrote: > We switch for sending the page number to send real pages. > > Signed-off-by: Juan Quintela > > -- > > Remove the HACK bit, now we have the function that calculates the size > of a page exported. > --- >

Re: [Qemu-devel] [PATCH v6 16/19] migration: Test new fd infrastructure

On Tue, Aug 08, 2017 at 06:26:26PM +0200, Juan Quintela wrote: > We just send the address through the alternate channels and test that it > is ok. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 50 ++ > 1 file

Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

On 11.08.2017 17:15, Cornelia Huck wrote: > On Fri, 11 Aug 2017 09:46:47 +0200 > David Hildenbrand wrote: > >> cpu.h is accessed outside of target/s390x. It should only contain >> what is expected to be accessed outside of this folder. Therefore, create >> internal.h and move a

Re: [Qemu-devel] [PATCH v6 15/19] migration: Create thread infrastructure for multifd recv side

On Tue, Aug 08, 2017 at 06:26:25PM +0200, Juan Quintela wrote: > We make the locking and the transfer of information specific, even if we > are still receiving things through the main thread. > > Signed-off-by: Juan Quintela > > -- > > We split when we create the main

Re: [Qemu-devel] [PATCH v6 12/19] migration: Create ram_multifd_page

On Tue, Aug 08, 2017 at 06:26:22PM +0200, Juan Quintela wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter and a new flag for this type of pages. > > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH v6 11/19] migration: Start of multiple fd work

On Tue, Aug 08, 2017 at 06:26:21PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are > sure that we connect the right channels in both sides. > > Signed-off-by: Juan Quintela > >

Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

On Fri, 11 Aug 2017 09:46:47 +0200 David Hildenbrand wrote: > cpu.h is accessed outside of target/s390x. It should only contain > what is expected to be accessed outside of this folder. Therefore, create > internal.h and move a lot to that file. Cool, I like that. > > While

[Qemu-devel] [PATCH for-2.10 0/2] Fix hotplug of PCI passthrought device on Xen

Adding PCI passthrough before the guest start works fine (broken in 2.9 but now fixed), but hotplug does not work anymore. Anthony PERARD (2): hw/acpi: Call acpi_set_pci_info when no ACPI tables needed Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen" hw/acpi/piix4.c | 11

[Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be set, but this was done only when ACPI tables are built which is not needed for a Xen guest. The need for the property starts with commit "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice"

[Qemu-devel] [PATCH for-2.10 2/2] Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen"

This reverts commit 153eba4726dfa1bdfc31d1fe973b2a61b9035492. This patch prevents PCI passthrough hotplug on Xen. Even if the Xen tool stack prepares its own ACPI tables, we still rely on QEMU for hotplug ACPI notifications. The original issue is fixed by the previous patch (hw/acpi: Call

Re: [Qemu-devel] [PATCH v6 10/19] migration: Split migration_fd_process_incoming

On Tue, Aug 08, 2017 at 06:26:20PM +0200, Juan Quintela wrote: > We need that on later patches. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 14 -- > 1 file changed, 12

Re: [Qemu-devel] [PATCH v6 08/19] migration: Create x-multifd-group parameter

On Tue, Aug 08, 2017 at 06:26:18PM +0200, Juan Quintela wrote: > Indicates how many pages we are going to send in each batch to a multifd > thread. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > > -- > > Be consistent with

Re: [Qemu-devel] [PATCH v6 06/19] migration: Add multifd capability

On Tue, Aug 08, 2017 at 06:26:16PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > > -- > > Use new DEFINE_PROP > --- > migration/migration.c | 10 ++ > migration/migration.h | 1 + >

Re: [Qemu-devel] [PATCH v6 07/19] migration: Create x-multifd-threads parameter

On Tue, Aug 08, 2017 at 06:26:17PM +0200, Juan Quintela wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > > -- > > Catch

Re: [Qemu-devel] [PATCH v6 01/19] migration: Create migration_ioc_process_incoming()

On Tue, Aug 08, 2017 at 06:26:11PM +0200, Juan Quintela wrote: > We pass the ioc instead of the fd. This will allow us to have more > than one channel open. We also make sure that we set the > from_src_file sooner, so we don't need to pass it as a parameter. > > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH for-2.11 v2] file-posix: Clear out first sector in hdev_create

On 08/11/2017 03:09 AM, Fam Zheng wrote: > People get surprised when, after "qemu-img create -f raw /dev/sdX", they > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > header. While this is natural because raw doesn't need to write any > magic bytes during creation,

Re: [Qemu-devel] [RFC PATCH] memory: fix access_with_adjusted_size() on big-endian

On 08/11/2017 11:25 AM, Paolo Bonzini wrote: On 11/08/2017 16:06, Philippe Mathieu-Daudé wrote: remove unnecessary memory_region_big_endian() Can you explain why it's unnecessary?... I might have missed a lot here, I'm focusing on something else and thought this might help Frederic so I

Re: [Qemu-devel] [PATCH 1/2] nbd: Drop connection if broken server is detected

11.08.2017 17:15, Eric Blake wrote: On 08/11/2017 02:48 AM, Vladimir Sementsov-Ogievskiy wrote: 11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further messages to the server, and allow all pending coroutines for any remaining

Re: [Qemu-devel] [PATCH v2] tests/qmp-test: Add generic, basic test of query commands

On 08/11/2017 09:19 AM, Markus Armbruster wrote: > A command is a query if it has no side effect and yields a result. > Such commands are typically named query-FOO, but there are exceptions. > > The basic idea is to find candidates with query-qmp-schema, filter out > the ones that aren't queries

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

On 11.08.2017 16:21, David Hildenbrand wrote: > On 11.08.2017 16:00, Thomas Huth wrote: >> On 11.08.2017 09:46, David Hildenbrand wrote: >>> cpu.h should only contain what really has to be accessed outside of >>> target/s390x/. Add internal.h which can only be used inside target/s390x/. >>> >>>

[Qemu-devel] marking SCM_RIGHTS qapi commands [was: [PATCH] tests/qmp-test: Add generic, basic test of query commands]

On 08/11/2017 04:08 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/10/2017 01:30 PM, Markus Armbruster wrote: >>> A command is a query if it has no side effect and yields a result. >>> Such commands are typically named query-FOO, but there are exceptions. >>> >>>

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

Hi Eric, Thanks for looking into this. On 07/26/2017 03:22 PM, Auger Eric wrote: Hi Diana, On 23/05/2017 13:12, Diana Craciun wrote: Device IDs are required by the ARM GICv3 ITS for IRQ remapping. Currently, for PCI devices, the requester ID was used as device ID in the virt machine. If the

Re: [Qemu-devel] [PATCH V2 for-2.10] xlnx-qspi: add a property for mmio-execution

On Fri, Aug 11, 2017 at 09:54:12AM +0200, KONRAD Frederic wrote: > This adds mmio-exec property to workaround the migration bug. > When enabled the migration is blocked and will return an error. > > Signed-off-by: KONRAD Frederic Thanks Fred! Reviewed-by: Edgar E.

Re: [Qemu-devel] [PATCH v2 1/2] Increased the size of requester_id field from MemTxAttrs

Hi Eric, On 07/26/2017 03:23 PM, Auger Eric wrote: > Hi Diana, > On 23/05/2017 13:12, Diana Craciun wrote: >> The PCI requester ID field is 16 bits. The requester_id field >> from MemTxAttrs is used for MSIs to specify the device ID for >> the platforms where this device ID is needed (e.g virt

Re: [Qemu-devel] [PATCH for-2.11] s390x: introduce 2.11 compat machine

On Thu, 10 Aug 2017 14:37:41 +0200 Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > > It's that time again. I plan to put this into my first 2.11 pullreq. > Yes, and I assume that the next version is indeed 2.11 :) > > --- >

Re: [Qemu-devel] big endian arm.

On 08/11/2017 07:18 AM, Peter Maydell wrote: On 11 August 2017 at 10:59, KONRAD Frederic wrote: [...]>> It seems that when I try to load a big endian image on a Cortex-R5 it gets confused: * the instructions are fine it executes some code. * GDB address /

[Qemu-devel] [RFC v6 9/9] hw/arm/virt-acpi-build: Use the ACPI_IORT_SMMU_V3_CACHING_MODE model

To allow VFIO use case, let's set the smmu model to ACPI_IORT_SMMU_V3_CACHING_MODE. An important notice is this model is not standardized in the ACPI IORT as this work is a proof of concept. We also set the COHACC override flag which seems to be mandated. Signed-off-by: Eric Auger

[Qemu-devel] [RFC v6 8/9] hw/arm/smmuv3: VFIO integration

This patch allows doing PCIe passthrough with a guest exposed with a vSMMUv3. It implements the replay and notify_flag_changed iommu ops. Also on TLB and data structure invalidation commands, we replay the mappings so that the physical IOMMU implements updated stage 1 settings (Guest IOVA -> Guest

Re: [Qemu-devel] [PATCH] target/i386: fix phminposuw in-place operation

On 11/08/2017 16:23, Joseph Myers wrote: > The SSE4.1 phminposuw instruction finds the minimum 16-bit element in > the source vector, putting the value of that element in the low 16 > bits of the destination vector, the index of that element in the next > three bits and zeroing the rest of the

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

Hi Edgar, On 07/31/2017 06:16 PM, Edgar E. Iglesias wrote: > On Wed, Jul 26, 2017 at 02:22:28PM +0200, Auger Eric wrote: >> Hi Diana, >> On 23/05/2017 13:12, Diana Craciun wrote: >>> Device IDs are required by the ARM GICv3 ITS for IRQ remapping. >>> Currently, for PCI devices, the requester ID

[Qemu-devel] [RFC v6 6/9] hw/arm/virt: Add tlbi-on-map property to the smmuv3 node

For VFIO integration we need to update physical IOMMU mappings each time the guest updates the vIOMMU translation structures. For that, we rely on a special smmuv3 option, "tlbi-on-map" which forces TLB invalidations on map (this mode is similar to the Intel VTD caching Mode). The smmuv3 driver

[Qemu-devel] [RFC v6 7/9] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

In case the MSI is translated by an IOMMU we need to fixup the MSI route with the translated address. Signed-off-by: Eric Auger --- v5 -> v6: - use IOMMUMemoryRegionClass API It is still unclear to me if we need to register an IOMMUNotifier to handle any change in the

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

On 11.08.2017 09:46, David Hildenbrand wrote: > Let's move everything into internal.h Or kvm_s390x.h ? ;-) Thomas

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

On 08/01/2017 05:05 AM, Michael S. Tsirkin wrote: > On Mon, Jul 31, 2017 at 03:13:09PM +, Diana Madalina Craciun wrote: >> On 07/31/2017 05:06 PM, Michael S. Tsirkin wrote: >>> On Mon, Jul 31, 2017 at 01:22:45PM +, Diana Madalina Craciun wrote: >> If we are to use a value of 0 for the

[Qemu-devel] [RFC v6 5/9] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

From: Prem Mallappa This patch builds the smmuv3 node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in smmuv3, which in turn maps to deviceid space 0x0-0x1 in the ITS group. The guest must

Re: [Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/

On 11.08.2017 09:46, David Hildenbrand wrote: > Let's just introduce an helper. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 4 +--- > target/s390x/cpu.c | 6 ++ > target/s390x/cpu.h | 1 + > 3 files changed, 8 insertions(+), 3

[Qemu-devel] [RFC v6 4/9] hw/arm/virt: Add 2.11 machine type

The new machine type allows smmuv3 instantiation. A new option is introduced to turn the feature on/off (off by default). Signed-off-by: Eric Auger --- v5 -> v6: machine 2_11 Another alternative would be to use the -device option as done on x86. As the smmu is a sysbus

[Qemu-devel] [PATCH v2] tests/qmp-test: Add generic, basic test of query commands

A command is a query if it has no side effect and yields a result. Such commands are typically named query-FOO, but there are exceptions. The basic idea is to find candidates with query-qmp-schema, filter out the ones that aren't queries with an explicit blacklist, and test the remaining ones

[Qemu-devel] [RFC v6 2/9] hw/arm/smmuv3: smmuv3 emulation model

From: Prem Mallappa Introduces the SMMUv3 derived model. This is based on System MMUv3 specification (v17). Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger --- v5 -> v6: - Use IOMMUMemoryregion - regs

[Qemu-devel] [PATCH] target/i386: fix phminposuw in-place operation

The SSE4.1 phminposuw instruction finds the minimum 16-bit element in the source vector, putting the value of that element in the low 16 bits of the destination vector, the index of that element in the next three bits and zeroing the rest of the destination. The helper for this operation fills

[Qemu-devel] [RFC v6 3/9] hw/arm/virt: Add SMMUv3 to the virt board

From: Prem Mallappa Add code to instantiate an smmu-v3 in mach-virt. A new boolean flag is introduced in VirtMachineState to allow this instantiation. It is currently false. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed outside of > target/s390x/. Add internal.h which can only be used inside target/s390x/. > > Move everything that isn't fast enough to run away and restructure it > right away. > > Minor style

Re: [Qemu-devel] [RFC PATCH] memory: fix access_with_adjusted_size() on big-endian

On 11/08/2017 16:06, Philippe Mathieu-Daudé wrote: > remove unnecessary memory_region_big_endian() Can you explain why it's unnecessary?... Paolo > Signed-off-by: Philippe Mathieu-Daudé > --- > This is part of a branch with many cross-endianness tests for 2.11 > > Frederic

[Qemu-devel] [RFC v6 0/9] ARM SMMUv3 Emulation Support

This series implements the emulation code for ARM SMMUv3. This is the continuation of Prem's work [1]. This v6 fixes some VFIO integration issues: - Block replay was corrected. - Range unmap is done before the replay (vhost issue). - Introduction of a new CMDQ_OP_TLBI_NH_VA_AM command to handle

[Qemu-devel] [RFC v6 1/9] hw/arm/smmu-common: smmu base class

Introduces the base device and class for the ARM smmu. Implements VMSAv8-64 table lookup and translation. VMSAv8-32 is not implemented. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v5 -> v6: - use IOMMUMemoryRegion - remove

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

On 11.08.2017 16:00, Thomas Huth wrote: > On 11.08.2017 09:46, David Hildenbrand wrote: >> cpu.h should only contain what really has to be accessed outside of >> target/s390x/. Add internal.h which can only be used inside target/s390x/. >> >> Move everything that isn't fast enough to run away and

[Qemu-devel] [PULL for-2.10 1/1] boot-serial-test: fallback to kvm accelerator

Currently, at least x86_64 and s390x support building with --disable-tcg. Instead of forcing tcg (which causes the test to fail on such builds), allow to use kvm as well. Reviewed-by: Daniel P. Berrange Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck

  1   2   3   >