On 12/03/10 11:57, Stefan Hajnoczi wrote:
On Thu, Dec 2, 2010 at 5:46 PM, jes.soren...@redhat.com wrote:
+create_options = append_option_parameters(create_options,
+ drv-create_options);
+create_options =
From: Jes Sorensen jes.soren...@redhat.com
Hi,
These patches moves the handling of block help printing to shared
code, which allows the ? detection to happen early in the parsing,
instead of half way down img_create() and img_convert(). I would like
to see this happen as I would like to pull
From: Jes Sorensen jes.soren...@redhat.com
This consolidates the printing of block driver options in
print_block_option_help() which is called from both img_create() and
img_convert().
This allows for the ? detection to be done just after the parsing of
options and the filename, instead of half
From: Jes Sorensen jes.soren...@redhat.com
This patch changes qemu-img to exit if an unknown option is detected,
instead of trying to continue with a set of arguments which may be
incorrect.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-img.c | 48
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-img.c | 77 +++
1 files changed, 51 insertions(+), 26 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 99f30b3..d0dc445 100644
Looks a duplicate of
https://sourceforge.net/tracker/index.php?func=detailaid=2042889group_id=180599atid=893831
Closed the SF bug, lets focus on this issue here.
Jes
** Bug watch added: SourceForge.net Tracker #2042889
http://sourceforge.net/support/tracker.php?aid=2042889
--
qemu-kvm
On 11/29/10 08:44, Jes Sorensen wrote:
On 11/26/10 15:21, Anthony Liguori wrote:
Attaching is easier logistically but I don't know how much that helps if
it's a full 3 days instead of just a single day. Might be worth poking
the LF folks for some advice.
But the key point is breadth
On 11/26/10 15:21, Anthony Liguori wrote:
On 11/26/2010 08:15 AM, Jes Sorensen wrote:
I would be all in favor of this! Do you want to attach it to another
conference or totally standalone?
Attaching is easier logistically but I don't know how much that helps if
it's a full 3 days
On 11/25/10 14:22, Paul Brook wrote:
On 25.11.2010, at 11:59, Paul Brook wrote:
RH needs to compile out as much as they can from the code base, because
they state that they support everything that's compiled in. So making as
much as possible optional is good. And I don't see why we should
On 11/26/10 12:53, Alexander Graf wrote:
On 26.11.2010, at 08:56, Jes Sorensen wrote:
Doing a get together somewhere in Europe really shouldn't be that hard
to organize, however it would probably be useful to have it attached to
a bigger conference to help with the logistics. There is going
On 11/26/10 15:13, Anthony Liguori wrote:
On 11/26/2010 07:39 AM, Alexander Graf wrote:
I can certainly get in touch with the organizers, but I can't answer
the latter question. There are usually at least ~10-20 kernel
developers around and it's easy to get most of the German qemu people
On 11/26/10 00:48, Alexander Graf wrote:
On 25.11.2010, at 23:53, Andreas Färber wrote:
From the fosdem homepage:
We would like to inform all interested parties that the call for devrooms
is running at its end.
Coming Saturday, 16 October at 23.59 the call for devrooms closes.
So
files changed, 62 insertions(+), 2 deletions(-)
Hi Hidetoshi,
This looks good to me!
Acked-by: Jes Sorensen jes.soren...@redhat.com
Cheers,
Jes
On 11/22/10 15:54, Anthony Liguori wrote:
On 11/22/2010 08:38 AM, Kevin Wolf wrote:
You're free to dislike NBD as much as you want. Just compiling it out
unconditionally and calling it a cleanup is a bit too much. ;-)
A configure option for disabling NBD sounds reasonable, though I'm not
|2 ++
default-configs/x86_64-softmmu.mak |2 ++
12 files changed, 20 insertions(+), 7 deletions(-)
Acked-by: Jes Sorensen jes.soren...@redhat.com
With a configure flag to flip modify the list from the default it would
reach perfect status :)
Cheers,
Jes
On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
On 11/22/10 15:54, Anthony Liguori wrote:
Using block format whitelisting should be enough to disable nbd. I
don't see a need for an explicit --disable-nbd option.
Right, the right solution
On 11/22/10 16:20, Anthony Liguori wrote:
On 11/22/2010 09:10 AM, Jes Sorensen wrote:
On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
Right, the right solution is probably to create a block driver list
argument for configure, similar to what we
On 11/20/10 19:31, Stefan Hajnoczi wrote:
On Sat, Nov 20, 2010 at 6:04 PM, Andreas Färber andreas.faer...@web.de
wrote:
http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/daemon.3.html
Deprecated in favor of using launchd.
Removing qemu-nbd from the
On 11/20/10 18:22, Andreas Färber wrote:
Am 19.11.2010 um 17:30 schrieb jes.soren...@redhat.com:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile |2 +-
Makefile.objs | 12 ++--
2 files changed, 11 insertions
On 11/21/10 16:22, Anthony Liguori wrote:
On 11/14/2010 08:15 PM, Hidetoshi Seto wrote:
This patch introduce a fallback mechanism for old systems that do not
support utimensat(). This fix build failure with following warnings:
hw/virtio-9p-local.c: In function 'local_utimensat':
On 11/18/10 15:47, Hannes Reinecke wrote:
This patch adds an emulation for the LSI Megaraid SAS HBA.
Signed-off-by: Hannes Reinecke h...@suse.de
---
Makefile.objs |2 +-
hw/megasas.c | 1826
+
hw/mfi.h | 1197
On 11/19/10 15:06, Markus Armbruster wrote:
Only comment, as you are adding another SCSI driver, maybe it's time to
make the driver selection configurable, rather than hard coding the build?
What do you mean by that?
We hardcode lsi53c895a in two places where we really mean default SCSI
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile |2 +-
Makefile.objs | 12 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 747e47c..a503c1c 100644
--- a/Makefile
+++ b
On 11/19/10 17:36, Alexander Graf wrote:
On 19.11.2010, at 15:31, Jes Sorensen wrote:
What I mean is for most other device types we allow to specify a list of
wanted devices at the configure line, which is what I am suggesting we
added support for for SCSI as well.
Oh, you mean something
On 11/18/10 01:41, Hidetoshi Seto wrote:
This patch introduce a fallback mechanism for old systems that do not
support utimensat(). This fix build failure with following warnings:
hw/virtio-9p-local.c: In function 'local_utimensat':
hw/virtio-9p-local.c:479: warning: implicit declaration of
On 11/18/10 09:48, Hidetoshi Seto wrote:
(2010/11/18 17:02), Jes Sorensen wrote:
Hi Hidetoshi,
I think the idea of the patch is good, but please move qemu_utimensat()
to oslib-posix.c and provide a wrapper for oslib-win32.c. It is
emulation for a system library function, so it doesn't belong
Hello,
Could you please provide more data, what kinda of system and version are
you running on?
Jes
--
Silently fail with wrong vde socket dir
https://bugs.launchpad.net/bugs/676029
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 11/16/10 02:15, Michael Roth wrote:
Daemon to be run in guest, or on host in standalone mode.
(re-)implements some qemu utility functions used by core virtproxy.c
code via wrapper functions. For built-in virtproxy code we will define
these wrapper functions in terms of qemu's built-in
On 11/16/10 02:15, Michael Roth wrote:
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
virtproxy.c | 136
+++
virtproxy.h | 34 +++
2 files changed, 170 insertions(+), 0 deletions(-)
create mode 100644
On 11/16/10 02:15, Michael Roth wrote:
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
virtproxy.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/virtproxy.c b/virtproxy.c
index 8f18d83..3686c77 100644
--- a/virtproxy.c
+++
On 11/16/10 02:16, Michael Roth wrote:
+if (pkt-type == VP_PKT_CLIENT) {
+TRACE(recieved client packet, client fd: %d, server fd: %d,
+ pkt-payload.proxied.client_fd,
pkt-payload.proxied.server_fd);
+fd = pkt-payload.proxied.server_fd;
+} else if
On 11/16/10 02:16, Michael Roth wrote:
Process control packets coming in over the channel. This entails setting
up/tearing down connections to local services initiated from the other
end of the channel.
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
virtproxy.c | 154
On 11/16/10 02:16, Michael Roth wrote:
+/* utility function to parse iforward/oforward options for qemu-vp
+ * or virtproxy chardev and put them into QemuOpts
+ */
+int vp_parse(QemuOpts *opts, const char *str, bool is_channel)
+{
+/* TODO: use VP_SERVICE_ID_LEN, bring it into
On 11/16/10 02:16, Michael Roth wrote:
+/* read handler for proxied connections */
+static void vp_conn_read(void *opaque)
+{
+VPConn *conn = opaque;
+VPDriver *drv = conn-drv;
+VPPacket pkt;
+char buf[VP_CONN_DATA_LEN];
+int fd, count, ret;
+bool client;
+
+
On 11/16/10 02:16, Michael Roth wrote:
Virtproxy relies on routines defined within qemu-vp which mirror various
i/o related operations in qemu to provide similar functionality for the
guest daemon. When building virtproxy as part of qemu rather than
qemu-vp we need these definitions to provide
On 11/16/10 02:16, Michael Roth wrote:
This allows us to create a virtproxy instance via a chardev. It can now
be created with something like:
qemu -chardev virtproxy,id=vp1 \
-device virtio-serial \
-device virtserialport,chardev=vp1
In the future the ability to add
On 11/16/10 17:01, Michael Roth wrote:
This set of patches is meant to be applied on top of the recently submitted
Virtproxy v3 patchset. It can also be obtained at:
git://repo.or.cz/qemu/mdroth.git virtproxy_v3
OVERVIEW:
There are a wide range of use cases motivating the need for a
On 11/16/10 17:01, Michael Roth wrote:
+#define DEBUG_VA
+
+#ifdef DEBUG_VA
+#define TRACE(msg, ...) do { \
+fprintf(stderr, %s:%s():L%d: msg \n, \
+__FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \
+} while(0)
+#else
+#define TRACE(msg, ...) \
+do { } while (0)
Given that you know what the problem is, it would probably have been
faster to post a patch than just updating the bug and marking it
confirmed
--
Silently fail with wrong vde socket dir
https://bugs.launchpad.net/bugs/676029
You received this bug notification because you are a member of
On 11/16/10 17:01, Michael Roth wrote:
+#include syslog.h
+#include qemu_socket.h
+#include virtagent-daemon.h
+#include virtagent-common.h
+#include virtagent.h
+
+static bool va_enable_syslog = false; /* enable syslog'ing of RPCs */
+
+#define SLOG(msg, ...) do { \
+char
On 11/16/10 17:01, Michael Roth wrote:
diff --git a/monitor.c b/monitor.c
index 8cee35d..cb81cd7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -42,6 +42,7 @@
#include audio/audio.h
#include disas.h
#include balloon.h
+#include virtagent.h
#include qemu-timer.h
#include migration.h
On 11/16/10 17:01, Michael Roth wrote:
Utilize the getfile RPC to provide a means to view text files in the
guest. Getfile can handle binary files as well but we don't advertise
that here due to the special handling requiring to store it and provide
it back to the user (base64 encoding it for
On 11/16/10 17:01, Michael Roth wrote:
RPC to initiate guest shutdown/reboot/powerdown
Do we really need this? After all those events can be passed down via ACPI?
Cheers,
Jes
On 11/16/10 17:01, Michael Roth wrote:
Provide monitor command to initiate guest shutdown/reboot/powerdown
+int do_agent_shutdown(Monitor *mon, const QDict *mon_params,
+ MonitorCompletion cb, void *opaque)
+{
+xmlrpc_env env;
+xmlrpc_value *params;
+
On 11/16/10 17:01, Michael Roth wrote:
Non-monitor version of agent_capabilities monitor function. This is
called by the local RPC server when it gets a hello from the guest
agent to re-negotiate guest agent capabilities.
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
On 11/18/10 16:35, Anthony Liguori wrote:
On 11/18/2010 08:17 AM, Jes Sorensen wrote:
On 11/16/10 17:01, Michael Roth wrote:
RPC to initiate guest shutdown/reboot/powerdown
Do we really need this? After all those events can be passed down via
ACPI?
Reboot can't be passed
On 11/18/10 16:41, Anthony Liguori wrote:
On 11/18/2010 09:35 AM, Michael Roth wrote:
+/* listening fd, one for each service we're forwarding to remote
end */
+typedef struct VPOForward {
+VPDriver *drv;
+int listen_fd;
+char service_id[VP_SERVICE_ID_LEN];
+
On 11/18/10 16:56, Anthony Liguori wrote:
On 11/18/2010 09:51 AM, Jes Sorensen wrote:
Yes, I think Jes was just looking for an excuse to say typedefmeharder
:-)
Actually typedefs are not listed as a must do thing in CODING_STYLE,
fortunately!
That's a bug in CODING_STYLE
On 11/18/10 17:18, Michael Roth wrote:
On 11/18/2010 05:35 AM, Jes Sorensen wrote:
You should never have two closing braces in the same column like this -
something is wrong with the formatting.
That's from using a block for the case
switch () {
case: {
...
}
}
Alternative
On 11/08/10 07:44, M. Mohan Kumar wrote:
This patch introduce a fallback mechanism for old systems that do not
support utimensat. This will fix build failure with following warnings:
hw/virtio-9p-local.c: In function 'local_utimensat':
hw/virtio-9p-local.c:479: warning: implicit declaration
On 11/08/10 17:21, Djamel Hakkar wrote:
Hello,
We have a software that runs on MS-DOS and must communicate with a specific
card installed on port isa.
We want to use this software in Qemu with a machine that runs XP.
Is it possible to access to the ISA port with Qemu in this case?
Do
From: Jes Sorensen jes.soren...@redhat.com
This patch adds missing braces around if/else statements that call
macros which are likely to result in errors if the macro is
changed. It also makes the code comply better with CODING_STYLE.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw
On 11/08/10 04:57, Alex Williamson wrote:
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
Compile tested only. Only current user is kvm, no cross-arch users.
hw/pc.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
Patch looks fine to me, but are
On 11/09/10 13:42, Alexander Graf wrote:
On 09.11.2010, at 11:57, Jes Sorensen wrote:
On 11/08/10 04:57, Alex Williamson wrote:
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
Compile tested only. Only current user is kvm, no cross-arch users.
hw/pc.c | 14
From: Jes Sorensen jes.soren...@redhat.com
The current send_all() wrapper for POSIX calls does nothing but call
unix_write(). Merge them to simplify the code.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-char.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Here is another set of patches which tries to split up osdep.c further
into posix and win32 versions. It introduces oslib-{posix,win32}.c
files which are used for functions that are OS specific core library
functionality, like gettimeofday
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 22 --
oslib-posix.c | 22 ++
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/osdep.c b/osdep.c
index 902fce9..926c8ad
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 32
osdep.c| 34 --
2 files changed, 32 insertions(+), 34 deletions(-)
diff --git a/os-posix.c b/os-posix.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 38 --
oslib-posix.c | 15 +++
oslib-win32.c | 21 +
3 files changed, 36 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
TRUE/FALSE are generally reserved keywords and shouldn't be defined in
a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE
respectively.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/bt-sdp.c | 20 ++--
1
From: Jes Sorensen jes.soren...@redhat.com
This consolidates the duplicated oom_check() functions, as well as
splitting them into OS dependant versions to avoid the #ifdef
grossness that was present in the old osdep.c version.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 21 +
os-win32.c | 24
osdep.c| 38 --
3 files changed, 45 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
This moves library functions used by both QEMU and the QEMU tools,
such as qemu-img, qemu-nbd etc. from osdep.c to oslib-{posix,win32}.c
In addition it introduces oslib-obj.y to the Makefile set to be
included by the various targets, instead of relying
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
m68k-semi.c|2 +-
osdep.c| 31 ---
osdep.h| 15 ---
oslib-win32.c | 27 +++
posix-aio
From: Jes Sorensen jes.soren...@redhat.com
No need to include stdlib.h for BSD as it is included by
qemu-common.h, windows.h is handled by sysemu.h and osdep.c no longer
needs malloc.h
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c |8
1 files changed, 0 insertions
On 10/23/10 16:42, Blue Swirl wrote:
On Mon, Oct 18, 2010 at 8:15 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
Almost there:
CCm68k-linux-user/m68k-semi.o
/src/qemu/m68k-semi.c: In function
On 10/22/10 09:59, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
This patch introduces cutils.c: strtosz() and gets rid of the
multiple custom hacks for parsing byte sizes. In addition it adds
supports for specifying human style sizes
From: Jes Sorensen jes.soren...@redhat.com
This patch introduces cutils.c: strtosz() and gets rid of the
multiple custom hacks for parsing byte sizes. In addition it adds
supports for specifying human style sizes such as 1.5G. Last it
eliminates the horrible abuse of a float to store the byte
From: Jes Sorensen jes.soren...@redhat.com
'f' double is no longer used, and we should be using floating point
variables to store byte sizes. Remove it.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
monitor.c | 18 +-
1 files changed, 1 insertions(+), 17 deletions
From: Jes Sorensen jes.soren...@redhat.com
strtosz() returns -1 on error. It now supports human unit formats in
eg. 1.0G, with better error handling.
The following suffixes are supported:
B/b = bytes
K/k = KB
M/m = MB
G/g = GB
T/t = TB
This patch changes -numa and -m input to use strtosz
From: Jes Sorensen jes.soren...@redhat.com
Octet format relies on strtosz which supports K/k, M/m, G/g, T/t
suffixes and unit support for humans, like 1.3G
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
monitor.c | 29 +
1 files changed, 29 insertions
From: Jes Sorensen jes.soren...@redhat.com
Clarify default value of MB in migration speed argument in monitor, if
no suffix is specified. This differ from previous default of bytes,
but is consistent with the rest of the places where we accept a size
argument.
Signed-off-by: Jes Sorensen
On 10/16/10 21:02, Blue Swirl wrote:
On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
This consolidates the duplicated oom_check() functions, as well as
splitting them into OS dependant versions to avoid the #ifdef
grossness
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Here is another set of patches which tries to split up osdep.c further
into posix and win32 versions. It introduces oslib-{posix,win32}.c
files which are used for functions that are OS specific core library
functionality, like gettimeofday
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 38 --
oslib-posix.c | 15 +++
oslib-win32.c | 21 +
3 files changed, 36 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
This moves library functions used by both QEMU and the QEMU tools,
such as qemu-img, qemu-nbd etc. from osdep.c to oslib-{posix,win32}.c
In addition it introduces oslib-obj.y to the Makefile set to be
included by the various targets, instead of relying
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 22 --
oslib-posix.c | 22 ++
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/osdep.c b/osdep.c
index 902fce9..926c8ad
On 10/16/10 21:32, Blue Swirl wrote:
On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
In addition add sysemu.h includes to file requiring a prototype for
ffs()
There are probably a lot more files which would need that:
/src/qemu
From: Jes Sorensen jes.soren...@redhat.com
No need to include stdlib.h for BSD as it is included by
qemu-common.h, windows.h is handled by sysemu.h and osdep.c no longer
needs malloc.h
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c |8
1 files changed, 0 insertions
From: Jes Sorensen jes.soren...@redhat.com
TRUE/FALSE are generally reserved keywords and shouldn't be defined in
a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE
respectively.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/bt-sdp.c | 20 ++--
1
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 32
osdep.c| 34 --
2 files changed, 32 insertions(+), 34 deletions(-)
diff --git a/os-posix.c b/os-posix.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 21 +
os-win32.c | 24
osdep.c| 38 --
3 files changed, 45 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c| 31 ---
osdep.h| 15 ---
oslib-win32.c | 27 +++
posix-aio-compat.c |1 +
qemu
From: Jes Sorensen jes.soren...@redhat.com
This consolidates the duplicated oom_check() functions, as well as
splitting them into OS dependant versions to avoid the #ifdef
grossness that was present in the old osdep.c version.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
On 10/16/10 02:37, Paolo Bonzini wrote:
On 10/15/2010 06:51 PM, Jes Sorensen wrote:
Hi,
Looking through some code in qemu-char.c I was wondering if we support
any other QEMU host target than Win32 which isn't covered by these
defines:
#if defined(__linux__) || defined(__sun__) || defined
On 10/15/10 18:39, Paolo Bonzini wrote:
On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote:
+typedef struct timeval qemu_timeval;
+#define qemu_gettimeofday(tp) gettimeofday(tp, NULL);
Argh, trailing semicolon. Please remove it or use an inline function.
Good point, it is present in the
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 38 --
oslib-posix.c | 15 +++
oslib-win32.c | 21 +
3 files changed, 36 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Here is another set of patches which tries to split up osdep.c further
into posix and win32 versions. It introduces oslib-{posix,win32}.c
files which are used for functions that are OS specific core library
functionality, like gettimeofday
From: Jes Sorensen jes.soren...@redhat.com
This moves library functions used by both QEMU and the QEMU tools,
such as qemu-img, qemu-nbd etc. from osdep.c to oslib-{posix,win32}.c
In addition it introduces oslib-obj.y to the Makefile set to be
included by the various targets, instead of relying
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 32
osdep.c| 34 --
2 files changed, 32 insertions(+), 34 deletions(-)
diff --git a/os-posix.c b/os-posix.c
From: Jes Sorensen jes.soren...@redhat.com
In addition add sysemu.h includes to file requiring a prototype for
ffs()
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/bt-sdp.c|1 +
osdep.c| 31 ---
osdep.h| 15
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 21 +
os-win32.c | 24
osdep.c| 38 --
3 files changed, 45 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c | 22 --
oslib-posix.c | 22 ++
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/osdep.c b/osdep.c
index 902fce9..926c8ad
From: Jes Sorensen jes.soren...@redhat.com
No need to include stdlib.h for BSD as it is included by
qemu-common.h, windows.h is handled by sysemu.h and osdep.c no longer
needs malloc.h
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
osdep.c |8
1 files changed, 0 insertions
From: Jes Sorensen jes.soren...@redhat.com
This consolidates the duplicated oom_check() functions, as well as
splitting them into OS dependant versions to avoid the #ifdef
grossness that was present in the old osdep.c version.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
oslib
From: Jes Sorensen jes.soren...@redhat.com
TRUE/FALSE are generally reserved keywords and shouldn't be defined in
a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE
respectively.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/bt-sdp.c | 20 ++--
1
On 10/16/10 11:44, Andreas Färber wrote:
Am 16.10.2010 um 02:37 schrieb Paolo Bonzini:
On 10/15/2010 06:51 PM, Jes Sorensen wrote:
Looking through some code in qemu-char.c I was wondering if we support
any other QEMU host target than Win32 which isn't covered by these
defines:
#if defined
From: Jes Sorensen jes.soren...@redhat.com
TRUE/FALSE are generally reserved keywords and shouldn't be defined in
a driver like this. Rename the macros to SDP_TRUE and SDP_FALSE
respectively.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hw/bt-sdp.c | 20 ++--
1
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 21 +
os-win32.c | 24
osdep.c| 38 --
3 files changed, 45 insertions(+), 38 deletions
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix-lib.c | 15 +++
os-win32-lib.c | 21 +
osdep.c| 38 --
3 files changed, 36 insertions(+), 38 deletions
401 - 500 of 894 matches
Mail list logo
