Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > > > I even wouldn't mind if you put

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Mon, Jul 4, 2022 at 7:02 PM Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 6:25 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote: > > > but I thought you were suggesting we built bits every time the test is > > > run? > > > > In my opinion 3

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 1, 2022 at 6:25 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote: > > but I thought you were suggesting we built bits every time the test is run? > > In my opinion 3 scenarios are worth supporting: > - people not touching ACPI, including users

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote: > but I thought you were suggesting we built bits every time the test is run? In my opinion 3 scenarios are worth supporting: - people not touching ACPI, including users - simply don't run the tests, comparing tables with expected

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 1, 2022 at 3:12 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 01:20:30PM +0530, Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > > > On Fri, Jul 1, 2022 at 12:23 PM

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 01, 2022 at 01:20:30PM +0530, Ani Sinha wrote: > On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Jul 01, 2022 at

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 1, 2022 at 1:08 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > > > I even wouldn't mind if you put

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 01, 2022 at 12:58:33PM +0530, Ani Sinha wrote: > On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > > I even wouldn't mind if you put your python stuff in a new directory like > > > tests/pytests/ for

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 1, 2022 at 12:23 PM Michael S. Tsirkin wrote: > > On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > > I even wouldn't mind if you put your python stuff in a new directory like > > tests/pytests/ for example, as long as it downloads your binaries separately > > - as I

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Fri, Jul 01, 2022 at 06:12:14AM +0200, Thomas Huth wrote: > I even wouldn't mind if you put your python stuff in a new directory like > tests/pytests/ for example, as long as it downloads your binaries separately > - as I wrote in another mail, the avocado framework rather looks like an >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 15.53, Ani Sinha wrote: On Tue, Jun 28, 2022 at 19:15 Peter Maydell > wrote: On Tue, 28 Jun 2022 at 14:23, Ani Sinha mailto:a...@anisinha.ca>> wrote: > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé mailto:berra...@redhat.com>>

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 06:52:55PM +0530, Ani Sinha wrote: > So why burden everyone by having bios-tables-test when it only affects > acpi/smbios developers? No it doesn't. Any change in qemu can break ACPI - it's enough to register an MR overlapping the ACPI registers. So we have a basic test

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 01:55:48PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 06:06:19PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell > > wrote: > > > > > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > > > > I think the main difference

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, 28 Jun 2022 at 14:53, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 19:15 Peter Maydell wrote: >> >> On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: >> > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé >> > wrote: >> > > This proposed biosbits test also involves a considerable

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 19:15 Peter Maydell wrote: > On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé > wrote: > > > This proposed biosbits test also involves a considerable download. > > > > I do not think 50 MB is "considerable" . Last

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, 28 Jun 2022 at 14:23, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé > wrote: > > This proposed biosbits test also involves a considerable download. > > I do not think 50 MB is "considerable" . Last time I tried to run > avocado tests, my laptop ran out of disk

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 6:25 PM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 06:06:19PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell > > wrote: > > > > > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > > > > I think the main difference is not

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 06:06:19PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell > wrote: > > > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > > > I think the main difference is not even in how it works, it's > > > in what it does. Which is check that ACPI

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 14.36, Ani Sinha wrote: On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell wrote: On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: I think the main difference is not even in how it works, it's in what it does. Which is check that ACPI tables are sane. Who cares about that?

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 5:40 PM Peter Maydell wrote: > > On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > > I think the main difference is not even in how it works, it's > > in what it does. Which is check that ACPI tables are sane. > > Who cares about that? Well developers do when they

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, 28 Jun 2022 at 12:50, Michael S. Tsirkin wrote: > I think the main difference is not even in how it works, it's > in what it does. Which is check that ACPI tables are sane. > Who cares about that? Well developers do when they change the > tables. Users really don't because for users we

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 11:42:37AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 03:58:21PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 3:37 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > > > If it is actually

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 11:42:37AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 03:58:21PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 3:37 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > > > If it is actually

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 4:00 PM Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 3:45 PM Daniel P. Berrangé > wrote: > > > > On Tue, Jun 28, 2022 at 10:28:04AM +0200, Thomas Huth wrote: > > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 03:58:21PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 3:37 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > > If it is actually booting a real guest image (from biosbits) and > > > interacting > > > with

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 3:48 PM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 06:07:13AM -0400, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > > If it is actually booting a real guest image (from biosbits) and > > > interacting > > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 11:18:14AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 06:07:13AM -0400, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > > If it is actually booting a real guest image (from biosbits) and > > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 12.21, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 11:14:53AM +0100, Daniel P. Berrangé wrote: Now that you mention it, avocado does feel like a more appropriate fit. IIUC the biosbits project appears to be effectively providing a custom guest OS ISO image. IOW this testing

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 3:45 PM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 10:28:04AM +0200, Thomas Huth wrote: > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 3:37 PM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > If it is actually booting a real guest image (from biosbits) and interacting > > with it, then it does feel like the scope of this testing is more > > appropriate

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 06:07:13AM -0400, Michael S. Tsirkin wrote: > On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > > If it is actually booting a real guest image (from biosbits) and interacting > > with it, then it does feel like the scope of this testing is more > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 11:14:53AM +0100, Daniel P. Berrangé wrote: > Now that you mention it, avocado does feel like a more appropriate fit. > IIUC the biosbits project appears to be effectively providing a custom > guest OS ISO image. IOW this testing is quite biased towards being > integration

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 10:28:04AM +0200, Thomas Huth wrote: > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé > > > wrote: > > > > > > > > On Tue, Jun 28, 2022 at 09:25:35AM

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 06:12:48AM -0400, Michael S. Tsirkin wrote: > On Tue, Jun 28, 2022 at 09:23:06AM +0100, Daniel P. Berrangé wrote: > > So bundling a pre-built biosbits in QEMU appears to mean that we're in > > turn going to unexpectedly bundle a bunch of other 3rd party projects > > too,

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 11:04:30AM +0100, Daniel P. Berrangé wrote: > If it is actually booting a real guest image (from biosbits) and interacting > with it, then it does feel like the scope of this testing is more appropriate > to QEMU's avocado framework than qtest, especially given the desire

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 09:23:06AM +0100, Daniel P. Berrangé wrote: > So bundling a pre-built biosbits in QEMU appears to mean that we're in > turn going to unexpectedly bundle a bunch of other 3rd party projects > too, all with dubious license compliance. Well looks like classical mere

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 02:05:19PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 1:58 PM Thomas Huth wrote: > > > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > > >> On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 02:19:41PM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 14:05 Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 1:58 PM Thomas Huth wrote: > > > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 08:48:42AM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > > No problem with that. So

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > No problem with that. So that's venv. But do we need pip and > > > > > > > > > pulling > > > > > > > > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 1:58 PM Thomas Huth wrote: > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > >> On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé > >> wrote: > >>> > >>> On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 14:05 Ani Sinha wrote: > On Tue, Jun 28, 2022 at 1:58 PM Thomas Huth wrote: > > > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > > >> On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé < >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 10.23, Daniel P. Berrangé wrote: On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé wrote: On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28,

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé > wrote: > > > > On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 09:03:33AM +0200,

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jun 27, 2022

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 09.49, Ani Sinha wrote: On Tue, Jun 28, 2022 at 12:55 PM Thomas Huth wrote: On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: No problem with that. So that's venv. But do we need pip and pulling packages from the net

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > > No problem with that. So that's

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 12:55 PM Thomas Huth wrote: > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > No problem with that. So that's venv. But do we need pip and pulling > packages from the net during testing?

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > No problem with that. So that's venv. But do we need pip and > > > > > > > > > pulling > > > > > > > > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > No problem with that. So that's venv. But do we need pip and > > > > > > > pulling > > > > > > > packages from the net during testing? > > > > > > > > > > > > We do that too. See requirements.txt in tests/ > > > > > >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: No problem with that. So that's venv. But do we need pip and pulling packages from the net during testing? We do that too. See requirements.txt in tests/ Following two are downloaded:

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

+danPb who pointed me to the TAP stuff. Maybe he has some good ideas on this. On Tue, Jun 28, 2022 at 12:27 PM Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 11:50

venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

On 28/06/2022 08.57, Ani Sinha wrote: On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: On Tue, Jun

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 11:36 AM

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 3:56 AM

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jun 28, 2022

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin wrote: > > > > On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > > > The README file is added describing the directory structure and the > > > purpose > > > of every file it

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > > > > The README file is added

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > > The README file is added describing the directory structure and the purpose > > of every file it contains. It also describes how to add new tests, make > > changes > > to

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > The README file is added describing the directory structure and the purpose > of every file it contains. It also describes how to add new tests, make > changes > to existing tests or bits config files or regenerate the bits software. >

[PATCH 11/12] acpi/tests/bits: add README file for bits qtests

The README file is added describing the directory structure and the purpose of every file it contains. It also describes how to add new tests, make changes to existing tests or bits config files or regenerate the bits software. Signed-off-by: Ani Sinha --- tests/qtest/acpi-bits/README | 168