Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf wrote: > Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: >> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: >> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> >> This series adds

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > >> This series adds blockdev-add support for SSH block driver. > >> > >> Patch 1 prepares the code for the

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> This series adds blockdev-add support for SSH block driver. >> >> Patch 1 prepares the code for the addition of a new option prefix, >> which is "server.". This is

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a > ssh_has_filename_options_conflict() function which

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
> I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. > > Going through the config output of the test script, I see that the > supporting library for SSH which is "libssh2" seems to be

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > > > Of course, we must be able to build qemu correctly both with ssh enabled > > and disabled, so if you

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > Of course, we must be able to build qemu correctly both with ssh enabled > and disabled, so if you can indeed see a (different) build error with > disabled libssh2,

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Kevin Wolf
Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > I received a mail saying my series failed the automatic build test but > it builds completely fine (after applying Dan's patch obviously) in my > local environment. The reason why patchew fails to build your series is because it doesn't

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-12 Thread Ashijeet Acharya
On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya wrote: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a >

Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-11 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1476171437-11830-1-git-send-email-ashijeetacha...@gmail.com Subject: [Qemu-devel] [PATCH 0/4] Allow blockdev-add

[Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH

2016-10-11 Thread Ashijeet Acharya
This series adds blockdev-add support for SSH block driver. Patch 1 prepares the code for the addition of a new option prefix, which is "server.". This is accomplished by adding a ssh_has_filename_options_conflict() function which helps to iterate over the various options and check for conflict.