The throttle driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. throttle:) will now fail gracefully:
$ qemu-img info throttle:foo
qemu-img: Could not open
The blkreplay driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. blkreplay:) will now fail gracefully:
$ qemu-img info blkreplay:foo
qemu-img: Could not open
Everything that refers to the protocol layer or QemuOpts is moved out of
block_crypto_create_generic(), so that the remaining function is
suitable to be called by a .bdrv_co_create implementation.
LUKS is the only driver that actually implements the old interface, and
we don't intend to use it in
Block drivers can be selected by either protocol syntax:
:[:options]
or explicitly:
driver=[,option=...]
For the protocol syntax to work, drivers should set the protocol_name
field of the BlockDriver structure and provide bdrv_file_open and
bdrv_parse_filename implementations.
Conversely,
On Fri, Mar 09, 2018 at 05:47:16PM +, Peter Maydell wrote:
> On 8 March 2018 at 18:28, Bill Paul wrote:
> > Anyway, this means that the only reason older Linux kernels worked in QEMU
> > with the broken interrupt configuration is that they also registered a
> > handler
>
This adds the .bdrv_co_create driver callback to luks, which enables
image creation over QMP.
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 17 -
block/crypto.c | 34 ++
2 files changed, 50 insertions(+), 1
The .bdrv_getlength implementation of the crypto block driver asserted
that the payload offset isn't after EOF. This is an invalid assertion to
make as the image file could be corrupted. Instead, check it and return
-EIO if the file is too small for the payload offset.
Zero length images are
On 9 March 2018 at 17:53, Auger Eric wrote:
> Hi Peter,
> On 08/03/18 20:06, Peter Maydell wrote:
>> On 17 February 2018 at 18:46, Eric Auger wrote:
>>> At the moment, the SMMUv3 does not support notification on
>>> TLB invalidation. So let's abort
From: Philippe Mathieu-Daudé
After spending months studying all the different SD Specifications
from the SD Association, voluntarily add myself as maintainer
for the SD code.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
From: Andrey Smirnov
Implement code needed to set up emulation of MCIMX7SABRE board from
NXP. For more info about the HW see:
From: Peter Lieven
this actually limits (as the original commit mesage suggests) the
number of I/O buffers that can be allocated and not the number
of parallel (inflight) I/O requests.
Signed-off-by: Peter Lieven
Message-Id:
From: Alistair Francis
Set the ARM CPU core count property for the A53's attached to the Xilnx
ZynqMP machine.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
Message-id:
This series implements the .bdrv_co_create callback for luks, adds an
image creation test for it and contains some bonus fixes for bugs that
the test triggered.
Kevin Wolf (6):
luks: Separate image file creation from formatting
luks: Create block_crypto_co_create_generic()
luks: Support
Add support for "-cpu max" for ARM guests. This CPU type behaves
like "-cpu host" when KVM is enabled, and like a system CPU with
the maximum possible feature set otherwise. (Note that this means
it won't be migratable across versions, as we will likely add
features to it in future.)
The crypto driver used to create the image file in a callback from the
crypto subsystem. If we want to implement .bdrv_co_create, this needs to
go away because that callback will get a reference to an already
existing block node.
Move the image file creation to block_crypto_create_generic().
From: Marc-André Lureau
Spotted thanks to ASAN:
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/migration-test -p
/x86_64/migration/bad_dest
==30302==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 48 byte(s) in 1 object(s) allocated from:
From: Richard Henderson
Split out helpers from target_setup_frame and target_restore_sigframe
for dealing with general registers, fpsimd registers, and the end record.
When we add support for sve registers, the relative positions of
these will change.
Reviewed-by:
From: Andrey Smirnov
The following interfaces are partially or fully emulated:
* up to 2 Cortex A9 cores (SMP works with PSCI)
* A7 MPCORE (identical to A15 MPCORE)
* 4 GPTs modules
* 7 GPIO controllers
* 2 IOMUXC controllers
* 1 CCM module
From: "Dr. David Alan Gilbert"
The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44:
memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09
15:55:20 +)
are available in the Git repository at:
Currently we query the host CPU features in the class init function
for the TYPE_ARM_HOST_CPU class, so that we can later copy them
from the class object into the instance object in the object
instance init function. This is awkward for implementing "-cpu max",
which should work like "-cpu host"
Add support for passing 'max' to -machine gic-version. By analogy
with the -cpu max option, this picks the "best available" GIC version
whether you're using KVM or TCG, so it behaves like 'host' when
using KVM, and gives you GICv3 when using TCG.
Also like '-cpu host', using -machine
Hi Peter,
On 08/03/18 20:06, Peter Maydell wrote:
> On 17 February 2018 at 18:46, Eric Auger wrote:
>> At the moment, the SMMUv3 does not support notification on
>> TLB invalidation. So let's abort as soon as such notifier gets
>> enabled.
>>
>> Signed-off-by: Eric Auger
From: Peter Lieven
Reset the dirty bitmap before reading to make sure we don't miss
any new data.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
Message-Id: <1520507908-16743-3-git-send-email...@kamp.de>
Reviewed-by: Juan Quintela
From: Richard Henderson
The EXTRA record allows for additional space to be allocated
beyon what is currently reserved. Add code to emit and read
this record type.
Nothing uses extra space yet.
Signed-off-by: Richard Henderson
From: Richard Henderson
This changes the qemu signal frame layout to be more like the kernel's,
in that the various records are dynamically allocated rather than fixed
in place by a structure.
For now, all of the allocation is out of uc.tuc_mcontext.__reserved,
so
On 09.03.2018 15:36, Eric Blake wrote:
> On 03/09/2018 12:13 AM, Thomas Huth wrote:
>> "-net" is clearly a legacy option. Yet we still use it in almost all
>> examples in the qemu documentation, and many other spots in the network
>> chapter. We should make it less prominent that users are not
From: Peter Lieven
this patch makes the bulk phase of a block migration to take
place before we start transferring ram. As the bulk block migration
can take a long time its pointless to transfer ram during that phase.
Signed-off-by: Peter Lieven
Reviewed-by: Stefan
From: Marc-André Lureau
Spotted by ASAN:
elmarco@boraha:~/src/qemu/build (master *%)$
QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 tests/boot-serial-test
/aarch64/boot-serial/virt: ** (process:19740): DEBUG: 18:39:30.275: foo
Move the definition of the 'host' cpu type into cpu.c, where all the
other CPU types are defined. We can do this now we've decoupled it
from the KVM-specific host feature probing. This means we now create
the type unconditionally (assuming we were built with KVM support at
all), but if you try
Hi Peter, Edgar.
On 03/09/2018 06:03 PM, Peter Maydell wrote:
> On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
>> [based on a patch from Alistair Francis
>> from qemu/xilinx tag xilinx-v2015.2]
>> Signed-off-by: Philippe Mathieu-Daudé
On Fri, Mar 09, 2018 at 05:03:11PM +, Peter Maydell wrote:
> On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
> > [based on a patch from Alistair Francis
> > from qemu/xilinx tag xilinx-v2015.2]
> > Signed-off-by: Philippe Mathieu-Daudé
/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20180309
for you to fetch changes up to 076a0fc32a73a9b960e0f73f04a531bc1bd94308:
MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard) (2018-03-09 17:09:45
+)
target-arm queue
From: Philippe Mathieu-Daudé
>From the "Physical Layer Simplified Specification Version 3.01":
A known data block ("Tuning block") can be used to tune sampling
point for tuning required hosts. [...]
This procedure gives the system optimal timing for each specific
host
On 8 March 2018 at 18:28, Bill Paul wrote:
> Anyway, this means that the only reason older Linux kernels worked in QEMU
> with the broken interrupt configuration is that they also registered a handler
> on vector 151 (119). Even though QEMU could not send events via GPIO6, it
On 09.03.2018 15:41, Paolo Bonzini wrote:
> On 09/03/2018 07:13, Thomas Huth wrote:
>> +
>> +@item --nic none
>> +Indicate that no network devices should be configured. It is used to
>> override
>> +the default configuration (default NIC with @option{--net user} backend)
>> which
>
> the
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Message-id: 20180309153654.13518-8-f4...@amsat.org
Signed-off-by: Peter Maydell
---
hw/sd/sdhci.c | 4 ++--
1
Hi,
This series failed build test on ppcbe host. Please find the details below.
Type: series
Message-id: 20180309091535.13315-1-pet...@redhat.com
Subject: [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked
Hi Peter,
On 08/03/18 19:39, Peter Maydell wrote:
> On 17 February 2018 at 18:46, Eric Auger wrote:
>> Let's introduce a helper function aiming at recording an
>> event in the event queue.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
>>
>> v8 -> v9:
>>
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
Message-id: 20180309153654.13518-2-f4...@amsat.org
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
On 03/09/2018 06:08 PM, Peter Maydell wrote:
> On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
>> This series contains the leftover patches from these 2 series:
>> - SDCard: housekeeping, add tracing (part 4)
>> - SDCard: bugfixes, support UHS-I (part 5)
>> with Peter
From: Alistair Francis
The cortex A53 TRM specifies that bits 24 and 25 of the L2CTLR register
specify the number of cores in the processor, not the total number of
cores in the system. To report this correctly on machines with multiple
CPU clusters (ARM's big.LITTLE
On 03/09/2018 10:54 AM, Eric Blake wrote:
On 03/09/2018 03:15 AM, Peter Xu wrote:
Based-on: <20180309090006.10018-1-pet...@redhat.com>
This series is based on the series:
[PATCH v8 00/23] QMP: out-of-band (OOB) execution support
Let's spell that in a way patchew understands:
Based-on:
For guest kernel that supports KASLR, the load address can change every
time when guest VM runs. To find the physical base address correctly,
current QEMU dump searches VMCOREINFO for the string "NUMBER(phys_base)=".
However this string pattern is only available on x86_64. AArch64 uses a
different
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/208 | 211 +++
tests/qemu-iotests/208.out | 136
tests/qemu-iotests/common.rc | 2 +-
tests/qemu-iotests/group | 1 +
4 files changed, 349
From: Richard Henderson
As an implementation choice, widening VL has zeroed the
previously inaccessible portion of the sve registers.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Acked-by:
Introduce latency histogram statics for block devices.
For each accounted operation type latency region [0, +inf) is
divided into subregions by several points. Then, calculate
hits for each subregion.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
From: Richard Henderson
Depending on the currently selected size of the SVE vector registers,
we can either store the data within the "standard" allocation, or we
may beedn to allocate additional space with an EXTRA record.
Signed-off-by: Richard Henderson
From: Andrey Smirnov
Add code needed to get a functional PCI subsytem when using in
conjunction with upstream Linux guest (4.13+). Tested to work against
"e1000e" (network adapter, using MSI interrupts) as well as
"usb-ehci" (USB controller, using legacy PCI
09.03.2018 19:41, Eric Blake wrote:
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote:
01 and 02 are splitted and updated "[PATCH] nbd/server: fix space read",
others are new.
Vladimir Sementsov-Ogievskiy (5):
nbd/server: move nbd_co_send_structured_error up
nbd/server: fix
On 03/08/2018 02:06 PM, Peter Maydell wrote:
> Allow the virt board to support '-cpu max' in the same way
> it already handles '-cpu host'.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/arm/virt.c | 1 +
> 1 file
From: Thomas Huth
A lot of ARM object files are linked into the executable unconditionally,
even though we have corresponding CONFIG switches like CONFIG_PXA2XX or
CONFIG_OMAP. We should make sure to use these switches in the Makefile so
that the users can disable certain
From: Philippe Mathieu-Daudé
The SDBus will reuse these functions, so we put them in a new source file.
Signed-off-by: Philippe Mathieu-Daudé
Message-id: 20180309153654.13518-3-f4...@amsat.org
Reviewed-by: Peter Maydell
[PMM: slight
Set (and clear) histogram through new command
block-latency-histogram-set and show new statistics in
query-blockstats results.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 111 ++-
block/qapi.c
From: Marc-André Lureau
Spotted by ASAN:
QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 tests/boot-serial-test
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x7ff8a9b0ca38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
#1
On 03/09/18 14:09, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This module measures and log the boot environment. It also produces
> the Tcg2 protocol, which allows for example to read the log from OS.
>
> The linux kernel doesn't yet read the
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Message-id: 20180309153654.13518-4-f4...@amsat.org
Signed-off-by: Peter Maydell
---
hw/sd/sd.c | 14
On Thu, Mar 08, 2018 at 12:52:31PM +, Igor Druzhinin wrote:
> This should help to avoid problems with accessing the device after
> migration/resume without PV drivers. Older systems will acquire
> the new record when migrated which should not change their state for
> worse.
>
> Signed-off-by:
Hi Peter,
On 08/03/18 19:28, Peter Maydell wrote:
> On 17 February 2018 at 18:46, Eric Auger wrote:
>> We introduce helpers to read/write into the command and event
>> circular queues.
>>
>> smmuv3_write_eventq and smmuv3_cmq_consume will become static
>> in subsequent
Now we have a working '-cpu max', the linux-user-only
'any' CPU is pretty much the same thing, so implement it
that way.
For the moment we don't add any of the extra feature bits
to the system-emulation "max", because we don't set the
ID register bits we would need to to advertise those
features
On 5 March 2018 at 08:41, Richard W.M. Jones wrote:
>
> The attached patch is also needed to avoid crashes during various
> math-heavy test suites.
Applied to master, thanks.
FYI, sending patches as attachments in the middle of a long
thread on something else is a good way to
Hi Peter,
On 08/03/18 19:37, Peter Maydell wrote:
> On 17 February 2018 at 18:46, Eric Auger wrote:
>> Now we have relevant helpers for queue and irq
>> management, let's implement MMIO write operations.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
>>
On 03/09/2018 02:59 AM, Peter Xu wrote:
Update both the developer and spec for the new QMP OOB (Out-Of-Band)
command.
Signed-off-by: Peter Xu
---
docs/devel/qapi-code-gen.txt | 65
docs/interop/qmp-spec.txt| 30
Allow the virt board to support '-cpu max' in the same way
it already handles '-cpu host'.
Signed-off-by: Peter Maydell
Message-id: 20180308130626.12393-6-peter.mayd...@linaro.org
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
On 7 March 2018 at 13:29, Thomas Huth wrote:
> On 07.03.2018 14:02, Paolo Bonzini wrote:
>> Fixes: 11e732a5ed46903f997985bed4c3767ca28a7eb6
>> Reported-by: Cornelia Huck
>> Reported-by: luigi burdo
>> Signed-off-by: Paolo Bonzini
From: Stefan Hajnoczi
There is a race between the test's 'query-migrate' QMP command after the
QMP 'STOP' event and completing the migration:
The test case invokes 'query-migrate' upon receiving 'STOP'. At this
point the migration thread may still be in the process of
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
> [based on a patch from Alistair Francis
> from qemu/xilinx tag xilinx-v2015.2]
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/sd/sd.c | 148
>
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
> This series contains the leftover patches from these 2 series:
> - SDCard: housekeeping, add tracing (part 4)
> - SDCard: bugfixes, support UHS-I (part 5)
> with Peter Maydell comments addressed.
>
> I misunderstood the
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote:
01 and 02 are splitted and updated "[PATCH] nbd/server: fix space read",
others are new.
Vladimir Sementsov-Ogievskiy (5):
nbd/server: move nbd_co_send_structured_error up
nbd/server: fix sparse read
nbd/server: fix: check
This adds the .bdrv_co_create driver callback to sheepdog, which enables
image creation over QMP.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
qapi/block-core.json | 24 -
block/sheepdog.c | 243
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote:
To be reused in nbd_co_send_sparse_read() in the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
nbd/server.c | 48
1 file changed, 24
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote:
> [based on a patch from Alistair Francis
> from qemu/xilinx tag xilinx-v2015.2]
> Signed-off-by: Philippe Mathieu-Daudé
This should ideally have a Signed-off-by: from
Create a BlockdevOptionsSsh object in connect_to_ssh() and take the
options from there. 'host_key_check' is still processed separately
because it's not in the schema yet.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block/ssh.c | 137
On 03/09/18 14:09, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The Tcg2ConfigPei module informs the firmware globally about the TPM
> device type, by setting the PcdTpmInstanceGuid PCD to the appropriate
> GUID value. The original module under
Peter Maydell writes:
> On 9 March 2018 at 13:52, Alex Bennée wrote:
>>
>> Peter Maydell writes:
>>
>>> This patchset adds support for '-cpu max' to Arm, along the lines
>>> of the existing support we have for x86
This adds the .bdrv_co_create driver callback to ssh, which enables
image creation over QMP.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
qapi/block-core.json | 16 +-
block/ssh.c | 83
On 03/09/18 14:09, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The library registers a security management handler, to measure images
> that are not measure in PEI phase. For example with the qemu PXE rom:
>
> Loading driver at 0x0003E6C2000
On 03/09/2018 03:15 AM, Peter Xu wrote:
Based-on: <20180309090006.10018-1-pet...@redhat.com>
This series is based on the series:
[PATCH v8 00/23] QMP: out-of-band (OOB) execution support
Let's spell that in a way patchew understands:
Based-on: <20180309090006.10018-1-pet...@redhat.com>
09.03.2018 18:40, Eric Blake wrote:
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:
v4:
Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks
build.
Was the cross file motion necessary, or could you just fix
This adds the .bdrv_co_create driver callback to nfs, which enables
image creation over QMP.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
qapi/block-core.json | 16 ++-
block/nfs.c | 76
v6:
Use correct header qapi/qapi-builtin-types.h, to fix build again.
Sorry for spam =(
v5:
Revert to v3 and just add qapi-types.h header.
v4:
Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks
build.
v3:
-
09.03.2018 19:37, Eric Blake wrote:
On 03/09/2018 10:31 AM, Vladimir Sementsov-Ogievskiy wrote:
09.03.2018 18:40, Eric Blake wrote:
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:
v4:
Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type
This adds the .bdrv_co_create driver callback to gluster, which enables
image creation over QMP.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
qapi/block-core.json | 18 ++-
block/gluster.c | 135
On 9 March 2018 at 14:28, Peter Maydell wrote:
> NB: there was a test failure on OpenBSD host:
>
> TEST: tests/qom-test... (pid=64016)
> /riscv32/qom/spike_v1.9.1: **
> ERROR:/home/qemu/tests/qom-test.c:64:test_properties:
This adds a synchronous x-blockdev-create QMP command that can create
qcow2 images on a given node name.
We don't want to block while creating an image, so this is not the final
interface in all aspects, but BlockdevCreateOptionsQcow2 and
.bdrv_co_create() are what they actually might look like
On 03/09/2018 10:31 AM, Vladimir Sementsov-Ogievskiy wrote:
09.03.2018 18:40, Eric Blake wrote:
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:
v4:
Move block_latency_histogram_set from block/accounting.c to
blockdev.c, as it uses qapi type uint64List and this fact breaks
build.
On 03/08/2018 02:06 PM, Peter Maydell wrote:
> Now we have a working '-cpu max', the linux-user-only
> 'any' CPU is pretty much the same thing, so implement it
> that way.
>
> For the moment we don't add any of the extra feature bits
> to the system-emulation "max", because we don't set the
> ID
This adds the .bdrv_co_create driver callback to file-win32, which
enables image creation over QMP.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block/file-win32.c | 47
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
tests/qemu-iotests/206 | 436 +
tests/qemu-iotests/206.out | 209 ++
tests/qemu-iotests/group | 1 +
3 files changed, 646
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180309160224.78821-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [PATCH v5 0/2] block latency histogram
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the
From: Alberto Garcia
This patch tweaks TestParallelOps in iotest 030 so it allocates data
in smaller regions (256KB/512KB instead of 512KB/1MB) and the
block-stream job in test_stream_commit() only needs to copy data that
is at the very end of the image.
This way when the
We'll use a separate source file for image creation, and we need to
check there whether the requested driver is whitelisted.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
include/block/block.h | 1 +
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-id: 20171225025107.23985-1-f...@redhat.com
Reviewed-by: Eric Blake
Signed-off-by: Max Reitz
---
tests/qemu-iotests/153 | 8 +---
tests/qemu-iotests/153.out | 7
On 03/09/18 14:09, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This module will initialize TPM device, measure reported FVs and BIOS
> version. We keep both SHA-1 and SHA-256 for the TCG 1.2 log format
> compatibility, but the SHA-256
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
tests/qemu-iotests/207 | 261 +
tests/qemu-iotests/207.out | 75 +
tests/qemu-iotests/group | 1 +
3 files changed, 337 insertions(+)
Instead of passing the encryption format name and the QemuOpts down, use
the QCryptoBlockCreateOptions contained in BlockdevCreateOptions.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
---
block/qcow2.c | 62
From: Fam Zheng
The AFL image is to exercise the code validating image size, which
doesn't work on 32 bit or when out of memory (there is a large
allocation before the interesting point). So check that and skip the
test, instead of faking the result.
Signed-off-by: Fam Zheng
Most callers have their own checks, but something like this should also
be checked centrally. As it happens, x-blockdev-create can pass negative
image sizes to format drivers (because there is no QAPI type that would
reject negative numbers) and triggers the check added by this patch.
Currently, qcow2_create() only parses the QemuOpts and then calls
qcow2_co_create() for the actual image creation, which includes both the
creation of the actual file on the file system and writing a valid empty
qcow2 image into that file.
The plan is that qcow2_co_create() becomes the function
If bdrv_truncate() is called, but the requested size is the same as
before, don't call posix_fallocate(), which returns -EINVAL for length
zero and would therefore make bdrv_truncate() fail.
The problem can be triggered by creating a zero-sized raw image with
'falloc' preallocation mode.
Move the parsing of the QDict options up to the callers, in preparation
for the .bdrv_co_create implementation that directly gets a QAPI type.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block/ssh.c | 34 +-
1 file
101 - 200 of 496 matches
Mail list logo