Re: [Qemu-devel] [PATCH v4 1/2] Implement .hex file loader

> -Original Messages- > From: "Su Hang" > Sent Time: 2018-04-16 22:49:48 (Monday) > To: "stefan hajnoczi" > Cc: "jim mussared" , qemu-devel > , "joel stanley" > Subject: Re:

Re: [Qemu-devel] [PATCH v11 08/17] hw/arm/smmuv3: Event queue recording helper

On 12 April 2018 at 08:37, Eric Auger wrote: > Let's introduce a helper function aiming at recording an > event in the event queue. > > Signed-off-by: Eric Auger > > --- > v9 -> v10: > - rework SMMU_EVENT_STRING > - trigger a GERROR EVENTQ_ABT_ERR in

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

Hi On Mon, Apr 16, 2018 at 10:12 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> By moving the base fields to a QObjectBase_, QObject can be a type >> which also has a 'base' field. This allows to write a generic >> QOBJECT() macro

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

On 16 April 2018 at 17:39, Eduardo Habkost wrote: > Last remaining fix for -rc4. > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' > into staging (2018-04-16

[Qemu-devel] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes

Signed-off-by: Max Reitz --- block/io.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index 134b2a498f..fada4efbf3 100644 --- a/block/io.c +++ b/block/io.c @@ -1115,13 +1115,15 @@ static int coroutine_fn

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 3/4] arm: always start from first_cpu when registering loader cpu reset callback

On 12 April 2018 at 19:29, Peter Maydell wrote: > On 12 April 2018 at 17:40, Igor Mammedov wrote: >> if arm_load_kernel() were passed non first_cpu, QEMU would end up >> with partially set do_cpu_reset() callback leaving some CPUs without it. >> >>

[Qemu-devel] [PATCH] tests: request access to locality 0 before sending command

Recent changes to the CRB code now require that access to locality 0 be requested before the locality can be used for sending a command. This patch adds the request to access the locality. Signed-off-by: Stefan Berger --- tests/tpm-util.c | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

Ian Jackson writes: > Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide > new -runas : facility"): >> Ian Jackson writes: >> > That would defer the getpwnam from argument parsing to os_setup_post. >> > I think that's

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

Ian Jackson writes: > Thanks for the review. Taking your comments out of order slightly: > > Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide > new -runas : facility"): >> [change_process_uid] is the only user of @user_pwd, @user_uid,

Re: [Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

Just a ping to say I'd like us to restart work this patch and try to get it mergable for the 2.13 cycle, so I can rely it on for the ACL support I've had out of tree since 2.6 :-) On Fri, Aug 11, 2017 at 06:05:20PM +0200, Markus Armbruster wrote: > v2: > * PATCH 1: Whitespace change dropped

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

On Mon, Aug 14, 2017 at 07:49:54AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/11/2017 11:05 AM, Markus Armbruster wrote: > >> We've wanted -object to support non-scalar properties for a while. > >> Dan Berrange tried in "[PATCH v4 00/10]Provide a

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

On Mon, Aug 14, 2017 at 01:24:17PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Aug 11, 2017 at 12:47:44PM -0500, Eric Blake wrote: > >> On 08/11/2017 11:05 AM, Markus Armbruster wrote: > >> > We've wanted -object to support non-scalar

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

On Mon, Apr 16, 2018 at 06:30:45PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > A user trying out SMBIOS "OEM strings" feature reported that the data > > they are exposing to the guest was truncated at 1023 bytes, which breaks > > the app consuming in

Re: [Qemu-devel] [PATCH v11 07/17] hw/arm/smmuv3: Implement MMIO write operations

On 12 April 2018 at 08:37, Eric Auger wrote: > Now we have relevant helpers for queue and irq > management, let's implement MMIO write operations. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa > -int

[Qemu-devel] [PATCH v3 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signed-off-by: Collin

[Qemu-devel] [PATCH v3 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumerated Boot Menu.

[Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

Change Log: v3 - added r-b's - added check around memset v2 - added r-b's - s/zipl_println/zipl_print_entry - prints entry and returns entry number - while loop now handles valid_entries These patches fix the following: - The

[Qemu-devel] [PATCH 9/9] iotests: Add test for COR across nodes

COR across nodes (that is, you have some filter node between the actually COR target and the node that performs the COR) cannot reliably work together with the permission system when there is no explicit COR node that can request the WRITE_UNCHANGED permission for its child. This is because COR

Re: [Qemu-devel] [PATCH for-2.13 4/4] arm/boot: split load_dtb() from arm_load_kernel()

On 12 April 2018 at 17:40, Igor Mammedov wrote: > load_dtb() depends on arm_load_kernel() to figure out place > in RAM where it should be loaded, but it's not required for > arm_load_kernel() to work. Sometimes it's neccesary for > devices added with -device/device_add to be

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: > On 16 April 2018 at 17:39, Eduardo Habkost wrote: > > Last remaining fix for -rc4. > > > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: > > > > Merge remote-tracking branch > >

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

On 16 April 2018 at 18:46, Eduardo Habkost wrote: > On Mon, Apr 16, 2018 at 02:42:52PM -0300, Eduardo Habkost wrote: >> On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: >> > On 16 April 2018 at 17:39, Eduardo Habkost wrote: >> > > Last

Re: [Qemu-devel] Purpose of memory-backend-file.discard-data

(CCing Zack Cornelius) On Fri, Apr 13, 2018 at 08:21:26AM +0200, Michal Privoznik wrote: > Eduardo et al, > > I'm looking at 11ae6ed8affdd131e and I wanted to implement libvirt > support for that. But more I look at it less I understand it. My > understanding it is an optimization (although not

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 16 April 2018 at 19:18, Marc-André Lureau wrote: > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the > regression, but was inadvertently broken again in merge commit > 2d6752d38d8acda. > > Fixes: > https://bugs.launchpad.net/qemu/+bug/1654137 > >

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

On 14.04.2018 00:08, Collin Walling wrote: > Rename the loadparm char array in main.c to loadparm_str and > increased the size by one byte to account for a null termination > when converting the loadparm string to an int via atoui. We > also allow the boot menu to be enabled when loadparm is set

[Qemu-devel] [PULL 2/2] iotests: fix 169

From: Vladimir Sementsov-Ogievskiy Improve and fix 169: - use MIGRATION events instead of RESUME - make a TODO: enable dirty-bitmaps capability for offline case - recreate vm_b without -incoming near test end This (likely) fixes racy faults at least of the

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On 16/04/2018 15:20, Igor Mammedov wrote: > Generally object doesn't need to know its own name, > we use it only for debugging and nice error reporting so far. > I'd rather have 'id' property at Object level so we won't have > to fish out ID from parent /which we aren't supposed to do and > which

[Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

Last remaining fix for -rc4. The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' into staging (2018-04-16 15:30:54 +0100) are available in the Git repository at:

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

Bharata B Rao wrote: > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: >> Now recent kernels (i.e. since linux-stable commit a346137e9142 >> ("powerpc/numa: Use ibm,max-associativity-domains to discover possible >> nodes") >> support this property to mark initially memory-less

[Qemu-devel] [PULL 1/1] vhost: do not verify ring mappings when IOMMU is enabled

From: Jason Wang When IOMMU is enabled, we store virtqueue metadata as iova (though it may has _phys suffix) and access them through dma helpers. Any translation failures could be reported by IOMMU. In this case, trying to validate iova against gpa won't work and will cause

[Qemu-devel] [PULL 0/1] vhost: bugfix

The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

On Mon, Apr 16, 2018 at 10:31 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Marc-André Lureau writes: >> >>> By moving the base fields to a QObjectBase_, QObject can be a type >>> which also has a 'base' field.

[Qemu-devel] [PATCH v3 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an empty string or a series of spaces.

[Qemu-devel] [PATCH 6/9] block: Support BDRV_REQ_WRITE_UNCHANGED in filters

Update the rest of the filter drivers to support BDRV_REQ_WRITE_UNCHANGED. They already forward write request flags to their children, so we just have to announce support for it. This patch does not cover the replication driver because that currently does not support flags at all, and because it

[Qemu-devel] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED

Currently we never actually check whether the WRITE_UNCHANGED permission has been taken for unchanging writes. But the one check that is commented out checks both WRITE and WRITE_UNCHANGED; and considering that WRITE_UNCHANGED is already documented as being weaker then WRITE, we should probably

[Qemu-devel] [PATCH 1/9] block: Add COR filter driver

This adds a simple copy-on-read filter driver. It relies on the already existing COR functionality in the central block layer code, which may be moved here once we no longer need it there. Signed-off-by: Max Reitz --- block/Makefile.objs | 2 +- qapi/block-core.json | 5

Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

On 16 April 2018 at 10:37, Michael Tokarev wrote: > Fixes 722cd7496474cebb2218f21e038592fad8603365 > > Signed-off-by: Michael Tokarev > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

Daniel P. Berrangé writes: > On Mon, Apr 16, 2018 at 06:30:45PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > A user trying out SMBIOS "OEM strings" feature reported that the data >> > they are exposing to the guest was

[Qemu-devel] [PATCH] mux: fix ctrl-a b again

Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the regression, but was inadvertently broken again in merge commit 2d6752d38d8acda. Fixes: https://bugs.launchpad.net/qemu/+bug/1654137 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH] WHPX fixes an issue with CPUID 1 not returning CPUID_EXT_HYPERVISOR

On Thu, Apr 05, 2018 at 05:50:20PM +0200, Paolo Bonzini wrote: > On 28/03/2018 22:48, Justin Terry (VM) wrote: [...] > > If we use [2] to inject the answers at creation time WHPX needs access > > to the CPUX86State at accel init which also doesn't seem to be possible > > in QEMU today. WHPX could

Re: [Qemu-devel] [PATCH v11 14/17] hw/arm/virt: Introduce the iommu option

On 12 April 2018 at 08:38, Eric Auger wrote: > ARM virt machine now exposes a new "iommu" option. > The SMMUv3 IOMMU is instantiated using -machine virt,iommu=smmuv3. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa

[Qemu-devel] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED

We just need to forward it to quorum's children (except in case of a rewrite because of corruption), but for that we first have to support flags in child requests at all. Signed-off-by: Max Reitz --- block/quorum.c | 19 +-- 1 file changed, 13 insertions(+), 6

[Qemu-devel] [PATCH v2 for 2.13] migration: Don't activate block devices if using -S

From: "Dr. David Alan Gilbert" Activating the block devices causes the locks to be taken on the backing file. If we're running with -S and the destination libvirt hasn't started the destination with 'cont', it's expecting the locks are still untaken. Don't activate the

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility"): > Ian Jackson writes: > > That would defer the getpwnam from argument parsing to os_setup_post. > > I think that's undesriable. > > No argument. But why can't

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

On 04/16/2018 05:53 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> Now all the build infrastructure is in place we can build tests for >>> each guest that we support. That support mainly depends on having >>> cross

[Qemu-devel] [PATCH 8/9] iotests: Copy 197 for COR filter driver

iotest 197 tests copy-on-read using the (now old) copy-on-read flag. Copy it to 215 and modify it to use the COR filter driver instead. Signed-off-by: Max Reitz --- tests/qemu-iotests/215 | 120 + tests/qemu-iotests/215.out |

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

On Mon, Apr 16, 2018 at 02:42:52PM -0300, Eduardo Habkost wrote: > On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote: > > On 16 April 2018 at 17:39, Eduardo Habkost wrote: > > > Last remaining fix for -rc4. > > > > > > The following changes since commit > > >

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

On Mon, Apr 16, 2018 at 07:41:29PM +0200, Thomas Huth wrote: > The CAN device crashes have been fixed with the commit > 089eac81e1d34d202471c0a023284f47f4c5f00e already. > > Signed-off-by: Thomas Huth Queued, thanks. -- Eduardo

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

Daniel P. Berrangé writes: > A user trying out SMBIOS "OEM strings" feature reported that the data > they are exposing to the guest was truncated at 1023 bytes, which breaks > the app consuming in the guest. After searching for the cause I > eventually found that the

[Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759264 Title: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns Status

Re: [Qemu-devel] [PATCH v11 06/17] hw/arm/smmuv3: Queue helpers

On 12 April 2018 at 08:37, Eric Auger wrote: > We introduce helpers to read/write into the command and event > circular queues. > > smmuv3_write_eventq and smmuv3_cmq_consume will become static > in subsequent patches. > > Invalidation commands are not yet dealt with. We do

[Qemu-devel] [PULL 1/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

The assumption in the cpu->max_features code is that anything enabled on GET_SUPPORTED_CPUID should be enabled on "-cpu host". This shouldn't be the case for FEAT_KVM_HINTS. This adds a new FeatureWordInfo::no_autoenable_flags field, that can be used to prevent FEAT_KVM_HINTS bits to be enabled

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

@elmarco could you take a look at this possible regression since bisect claims it was due to the mux refactor -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654137 Title: Ctrl-A b not working in

[Qemu-devel] [PATCH 0/9] block: Add COR filter driver

In our quest to... (Oh, man, I always struggle with writing cover letters. But rarely have I become stuck so early on.) Orthogonalize? the block layer (that is, turn hard-coded special options into independent data processing nodes you can put anywhere in your data flow graph), this series adds

[Qemu-devel] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag

This flag signifies that a write request will not change the visible disk content. With this flag set, it is sufficient to have the BLK_PERM_WRITE_UNCHANGED permission instead of BLK_PERM_WRITE. Signed-off-by: Max Reitz --- include/block/block.h | 6 +- block/io.c

[Qemu-devel] [PATCH v3 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h to make it available

[Qemu-devel] [PATCH 7/9] iotests: Clean up wrap image in 197

Signed-off-by: Max Reitz --- tests/qemu-iotests/197 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/197 b/tests/qemu-iotests/197 index 5e869fe2b7..3ae4975eec 100755 --- a/tests/qemu-iotests/197 +++ b/tests/qemu-iotests/197 @@ -44,6 +44,7 @@ esac

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

On 12 April 2018 at 17:40, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on

[Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

The CAN device crashes have been fixed with the commit 089eac81e1d34d202471c0a023284f47f4c5f00e already. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

** Changed in: qemu Assignee: (unassigned) => elmarco (marcandre-lureau) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654137 Title: Ctrl-A b not working in 2.8.0 Status in QEMU:

Re: [Qemu-devel] [Qemu-arm] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

On 16 April 2018 at 16:19, Peter Maydell wrote: > In commit 8c5931de0ac7738809 we added support for SVE extended > sigframe records. These mean that the signal frame might now be > larger than the size of the target_rt_sigframe record, so make sure > we call lock_user

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

On 16 April 2018 at 16:25, Jan Kiszka wrote: > On 2018-04-01 23:17, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when >> E1000_ICR_OTHER is set in EIAC. In fact, removing this code

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

This regression is still unfixed three months after being reported, and it's rendering qemu 2.11.1 unusable for my present use case, so I just reverted my system to the ever reliable qemu 0.15.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

Peter Maydell writes: > On 16 April 2018 at 15:11, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 12 March 2018 at 13:18, Stefan Hajnoczi wrote: Warn if files are

Re: [Qemu-devel] [PATCH v2 2/2] docs: Document the new default sizes of the qcow2 caches

On 2018-03-14 09:29, Alberto Garcia wrote: > We have just reduced the refcount cache size to the minimum unless > the user explicitly requests a larger one, so we have to update the > documentation to reflect this change. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric

[Qemu-devel] [PATCH 3/3] opts: don't silently truncate long option values

The existing QemuOpts parsing code uses a fixed size 1024 byte buffer for storing the option values. If a value exceeded this size it was silently truncated and no error reported to the user. Long option values is not a common scenario, but it is conceivable that they will happen. eg if the user

[Qemu-devel] [PATCH v2 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter

Drop parameter "HBitmap **out" which is unused now, all callers set it to NULL. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 2 +- block/dirty-bitmap.c | 14 +- blockdev.c| 4 ++-- 3 files changed, 8

[Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions

Separate them in the header and clarify needed locking in comments. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 14 +- block/dirty-bitmap.c | 5 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

Ok, confusion around backend is I think cleared up. The other confusion seems to be around dma-buf: dma-buf is the cross subsystem zerocopy abstraction. PRIME is the drm-specific support for it, 100% based on top of the generic struct dma_buf. You need a dma_buf exporter to convert a xen grant

Re: [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB

On 12 April 2018 at 14:55, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence

Re: [Qemu-devel] [PATCH v11 04/17] hw/arm/smmuv3: Skeleton

On 12 April 2018 at 08:37, Eric Auger wrote: > From: Prem Mallappa > > This patch implements a skeleton for the smmuv3 device. > Datatypes and register definitions are introduced. The MMIO > region, the interrupts and the queue are initialized.

Re: [Qemu-devel] [PATCH] vhost: do not verify ring mappings when IOMMU is enabled

On Fri, 13 Apr 2018 11:01:49 +0800 Jason Wang wrote: > When IOMMU is enabled, we store virtqueue metadata as iova (though it > may has _phys suffix) and access them through dma helpers. Any > translation failures could be reported by IOMMU. > > In this case, trying to

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

On 16 April 2018 at 15:42, Alex Bennée wrote: > > Bastian Koppelmann writes: > >> On 04/16/2018 03:54 PM, Alex Bennée wrote: >>> The re-factoring of div_floats changed the order of checking meaning >>> an operation like -inf/0 erroneously

Re: [Qemu-devel] [PATCH v4 1/2] Implement .hex file loader

Sorry I didn't reply in detai on last weekend. Here are some points I want to discuss. > parse_hex_blob() must handle input files that touch large ranges of > memory. At the moment it assumes bin_buf will be large enough for the > memory regions described by the input file. Since Intel HEX

Re: [Qemu-devel] [RFC] Intermediate block mirroring

On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: > On 2018-04-12 19:07, Alberto Garcia wrote: >> Hello, >> >> I mentioned this some time ago, but I'd like to retake it now: I'm >> checking how to copy arbitrary nodes on a backing chain, so if I have >> e.g. >> >>[A] <- [B] <- [C] <- [D]

[Qemu-devel] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

In commit 8c5931de0ac7738809 we added support for SVE extended sigframe records. These mean that the signal frame might now be larger than the size of the target_rt_sigframe record, so make sure we call lock_user on the entire frame size when we're creating it. (The code for restoring the signal

Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size

W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: >From the datasheet (3368J–SEEPR) description: The AT25128A/256A provides 131,072/262,144 bits of serial electrically-erasable programmable read only memory (EEPROM) organized as 16,384/32,768 words of 8 bits each. However

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

On 4/10/2018 11:32 AM, Yulei Zhang wrote: > VM status change handler is added to change the vfio pci device > status during the migration, write the demanded device status > to the DEVICE STATUS subregion to stop the device on the source side > before fetch its status and start the deivce on the

Re: [Qemu-devel] [RFC PATCH V4 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

On 4/10/2018 11:32 AM, Yulei Zhang wrote: > New VFIO sub region VFIO_REGION_SUBTYPE_DEVICE_STATE is added > to fetch and restore the status of mdev device vGPU during the > live migration. > > Signed-off-by: Yulei Zhang > --- > hw/vfio/pci.c | 25

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

On 4/10/2018 11:33 AM, Yulei Zhang wrote: > Instead of using vm state description, add SaveVMHandlers for VFIO > device to support live migration. > > Introduce new Ioctl VFIO_DEVICE_GET_DIRTY_BITMAP to fetch the memory > bitmap that dirtied by vfio device during the iterative precopy stage >

[Qemu-devel] [PATCH V5] migration: add capability to bypass the shared memory

1) What's this When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, extremely-fast-save-restore, vm-template,

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

On 2018-03-14 09:29, Alberto Garcia wrote: > The L2 and refcount caches have default sizes that can be overridden > using the l2-cache-size and refcount-cache-size (an additional > parameter named cache-size sets the combined size of both caches). > > Unless forced by one of the aforementioned

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

Bastian Koppelmann writes: > On 04/16/2018 03:54 PM, Alex Bennée wrote: >> The re-factoring of div_floats changed the order of checking meaning >> an operation like -inf/0 erroneously raises the divbyzero flag. >> IEEE-754 (2008) specifies this should only occur

Re: [Qemu-devel] [RFC] Intermediate block mirroring

On 2018-04-16 16:59, Alberto Garcia wrote: > On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: >> On 2018-04-12 19:07, Alberto Garcia wrote: >>> Hello, >>> >>> I mentioned this some time ago, but I'd like to retake it now: I'm >>> checking how to copy arbitrary nodes on a backing chain, so if

Re: [Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

Peter Maydell writes: > On 16 April 2018 at 15:03, Alex Bennée wrote: >> Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 >> trap..) user-space has been able to read this system register. This >> patch enables access to that

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On 16/04/2018 16:27, Igor Mammedov wrote: > On Mon, 16 Apr 2018 15:30:39 +0200 > Paolo Bonzini wrote: > >> On 16/04/2018 15:20, Igor Mammedov wrote: >>> Generally object doesn't need to know its own name, >>> we use it only for debugging and nice error reporting so far. >>>

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

On 2018-04-01 23:17, Jan Kiszka wrote: > From: Jan Kiszka > > The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when > E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the > issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e:

Re: [Qemu-devel] [PULL 0/2] Block patches for 2.12.0-rc4

On 16 April 2018 at 13:38, Max Reitz wrote: > The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 > 10:11:17 +0100) > > are available in the

Re: [Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

On 16 April 2018 at 16:29, Alex Bennée wrote: > > Peter Maydell writes: >> CNTVCT_EL0 isn't much use without CNTFRQ_EL0 which tells >> you how fast it ticks... > > I've added it but of course: > > /* Note that CNTFRQ is purely

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

> > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index 0cdbc15..0d5b0f7 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = { > S390_FEAT_ADAPTER_INT_SUPPRESSION, >

[Qemu-devel] [PATCH v2 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex

Clarify first two cases and fix Modify -> Any access in third case. Also, drop 'only' from third case, as it a bit confuses, when thinking about case where we modify BdrvDirtyBitmap and access HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH] Implement query-usbhost QMP command

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1523675125-14022-1-git-send-email-...@godking.net Subject: [Qemu-devel] [PATCH] Implement

Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

Thanks for the review. Taking your comments out of order slightly: Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas : facility"): > [change_process_uid] is the only user of @user_pwd, @user_uid, @user_gid. > > Have you considered replacing global @user_pwd

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

On 04/16/2018 08:27 AM, Thomas Huth wrote: > On 14.04.2018 00:08, Collin Walling wrote: >> Rename the loadparm char array in main.c to loadparm_str and >> increased the size by one byte to account for a null termination >> when converting the loadparm string to an int via atoui. We >> also allow

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

On 04/16/2018 03:45 AM, Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine with this

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: > Essentially this is abusing the export name as a crude authentication > token. There are NBD servers that expect NBD_OPT_LIST to always succeeed I guess you mean "NBD clients" ... > when they detect that the new style protocol

[Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

A user trying out SMBIOS "OEM strings" feature reported that the data they are exposing to the guest was truncated at 1023 bytes, which breaks the app consuming in the guest. After searching for the cause I eventually found that the QemuOpts parsing is using fixed length 1024 byte array for option

Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

On 2018-04-06 17:17, Max Reitz wrote: > My non-Fedora testing system does not have a kernel with userfaultfd > support which causes 181 and 201 to fail. That is annoying. This > series makes those tests recognize the issue and convert it into a > _notrun. > > > Max Reitz (2): > iotests: Add

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

On 16/04/2018 13:17, Daniel P. Berrangé wrote: > A user trying out SMBIOS "OEM strings" feature reported that the data > they are exposing to the guest was truncated at 1023 bytes, which breaks > the app consuming in the guest. After searching for the cause I > eventually found that the QemuOpts

[Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

The re-factoring of div_floats changed the order of checking meaning an operation like -inf/0 erroneously raises the divbyzero flag. IEEE-754 (2008) specifies this should only occur for operations on finite operands. We fix this by moving the check on the dividend being Inf/0 to before the

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

Thomas Huth writes: > On 12.03.2018 14:18, Stefan Hajnoczi wrote: >> Warn if files are added/renamed/deleted without MAINTAINERS file >> changes. This has helped me in Linux and we could benefit from this >> check in QEMU. >> >> This patch is a manual cherry-pick of Linux

  1   2   3   >