Re: Contributor wanting to get started with simple contributions

2020-10-13 Thread Rohit Shinde
get built along with the main code? 2. If not, how do I start using this part and contributing to it? Thanks, Rohit. On Tue, Sep 29, 2020 at 9:38 PM John Snow wrote: > On 9/2/20 12:38 PM, Rohit Shinde wrote: > > Hey John, > > > > I wanted to follow up on this, in case y

QEMU - Contributing to SCSI Adapter Emulation (BusLogic BT-958 SCSI adapter)

2020-09-03 Thread Rohit Shinde
Hello, I am interested in contributing to the implementation of the BusLogic adapter. I saw on the doc pages of QEMU that it is an incomplete adaptation and I would like to take it further and complete it. Before I take it up however, I wanted to check in and see if it wasn't already being

Re: Contributor wanting to get started with simple contributions

2020-09-02 Thread Rohit Shinde
Hey John, I wanted to follow up on this, in case you missed my previous email :) Thanks, Rohit. On Sat, Aug 29, 2020 at 1:14 AM Rohit Shinde wrote: > Hey John, > > Sorry to bother you! I just wanted to know if you had any thoughts on the > mail I sent. > > Is there anyt

Contributing to x86 device emulationi

2020-08-31 Thread Rohit Shinde
Hello everyone, I am a software engineer working as an SDE in the industry and I have been wanting to contribute to QEMU. I mailed earlier introducing myself to the mailing list and I was told to talk to specific people who work with the subsystem I want to contribute to. I am interested in

Re: Contributor wanting to get started with simple contributions

2020-08-28 Thread Rohit Shinde
with that? Thanks, Rohit. On Wed, Aug 26, 2020 at 1:55 PM Rohit Shinde wrote: > Hey John, > > I came across QEMU in 2015 when I was looking to participate in GSOC. I > did GSoC through another org. I kept following qemu because I was > interested in virtualization, systems level coding and d

Re: Contributor wanting to get started with simple contributions

2020-08-27 Thread Rohit Shinde
Hey Thomas, Thanks for the in-depth response! I appreciate it a lot! On Wed, Aug 26, 2020 at 9:38 PM Thomas Huth wrote: > On 26/08/2020 17.00, Rohit Shinde wrote: > > Hey Thomas, > > > > I didn't really have any specific questions. I wanted to know if there > >

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-27 Thread Rohit Shinde
. On Wed, Aug 26, 2020 at 11:10 PM Markus Armbruster wrote: > Rohit Shinde writes: > > > I am just compiling with cflag set to -Wimplicit-fallthrough. I am using > > gcc. > > -Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our > -code is not prepared

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-26 Thread Rohit Shinde
I am just compiling with cflag set to -Wimplicit-fallthrough. I am using gcc. On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster wrote: > Rohit Shinde writes: > > > Added fallthrough comment on line 270 to prevent the compiler from > > throwing an error while compiling w

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Rohit Shinde
. I have been reading about KVM quite a bit because I wanted to know how virtualization theory is actually implemented. And once again, thanks for the response! I really appreciate it! Thanks, Rohit. On Wed, Aug 26, 2020 at 11:51 AM John Snow wrote: > On 8/26/20 11:00 AM, Rohit Shinde wr

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Rohit Shinde
Hey Thomas, I didn't really have any specific questions. I wanted to know if there was any part of qemu that I could contribute to. Qemu is overwhelmingly vast and without some pointers, I felt very lost. On Tue, Aug 25, 2020 at 1:51 AM Thomas Huth wrote: > On 25/08/2020 04.26, Rohit Shi

Re: Contributor wanting to get started with simple contributions

2020-08-24 Thread Rohit Shinde
in the reply to my comment on the bug, was pretty interesting. I would like to get started with at least ensuring that all python code is flake8/pylint compliant. Do let me know what you think of this. Thanks, Rohit. On Thu, Aug 13, 2020 at 7:18 AM Rohit Shinde wrote: > Hello everyone, > > I a

[PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-18 Thread Rohit Shinde
Added fallthrough comment on line 270 to prevent the compiler from throwing an error while compiling with the -Wimplicit-fallthrough flag Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

2020-08-16 Thread Rohit Shinde
On Sun, Aug 16, 2020 at 11:26 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 5:57 PM, Rohit Shinde wrote: > > I misread the comment. The comment /* fallthrough */ was meant to stop > the > > compiler warning from occurring. I am trying to comple

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

2020-08-16 Thread Rohit Shinde
On Sun, Aug 16, 2020 at 6:52 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/16/20 9:55 AM, Rohit Shinde wrote: > > Hey Richard, > > > > 1. So I should fork off the master again? > > Yes. > > There need to be special circumstances

Re: [PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

2020-08-16 Thread Rohit Shinde
that line got there. I was trying to fix the compiler warnings. Could you please guide me on how I create the next version of a patch? Thanks, Rohit. On Sun, Aug 16, 2020 at 12:03 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/15/20 7:31 PM, Rohit Shi

[PATCH v4] qapi/opts-visitor: Fixed fallthrough compiler warning

2020-08-15 Thread Rohit Shinde
Added fallthrough comment on line 270 to fix compiler warning Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 43cf60d3a0..3422ff265e 100644 --- a/qapi/opts-visitor.c +++ b

Re: [PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c

2020-08-15 Thread Rohit Shinde
ified: > > "qapi/opts-visitor: Add missing fallthrough annotations" > > On 8/15/20 3:00 PM, Rohit Shinde wrote: > > Added the fallthrough comment so that the compiler doesn't emit an error > on compiling with the -Wimplicit-fallthrough flag. > > If possible align t

[PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c

2020-08-15 Thread Rohit Shinde
Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag. Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7781c23a42

[PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c

2020-08-15 Thread Rohit Shinde
Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag. Signed-off-by: Rohit Shinde --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7781c23a42

[PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c

2020-08-15 Thread Rohit Shinde
Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag. Signed off by: Rohit Shinde --- qapi/opts-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7781c23a42

Contributor wanting to get started with simple contributions

2020-08-13 Thread Rohit Shinde
Hello everyone, I am a hobby programmer (working as an SDE in the industry) and I have been observing qemu for quite a while. I have always wanted to contribute but I couldn't manage my time. I am good at Java and Python but quite a bit rusty with C++ and C (although working with it will not be a

[Bug 1874678] Re: [Feature request] python-qemu package

2020-08-13 Thread Rohit Shinde
Hello, I am new to the community and I would like to cut my teeth with this bug. Is this a good starting point? If so, where should I be looking? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1874678