Re: [Qemu-devel] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-17 Thread Thomas Huth
On 14.10.2016 19:38, Peter Maydell wrote: > On 14 October 2016 at 09:27, Greg Kurz wrote: >> On Fri, 14 Oct 2016 09:28:35 +1100 >> David Gibson wrote: >> >>> On Thu, Oct 13, 2016 at 12:57:19PM +0100, Peter Maydell wrote: On 13 October 2016 at

Re: [Qemu-devel] [PATCH 00/18] dataplane: remove RFifoLock (including almost all previously sent patches)

2016-10-17 Thread Christian Borntraeger
On 10/13/2016 07:34 PM, Paolo Bonzini wrote: > This patch reorganizes aio_poll callers to establish new rules for > dataplane locking. The idea is that I/O operations on a dataplane > BDS (i.e. one where the AioContext is not the main one) do not call > aio_poll anymore. Instead, they wait for

[Qemu-devel] CVE-2016-5403 results in a bug

2016-10-17 Thread yue
hi, all: i apply this patch, https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33 . but this patch always results in a bug(bug?). a vm always exits

Re: [Qemu-devel] [PATCH 00/18] dataplane: remove RFifoLock (including almost all previously sent patches)

2016-10-17 Thread Paolo Bonzini
> On 10/13/2016 07:34 PM, Paolo Bonzini wrote: > > This patch reorganizes aio_poll callers to establish new rules for > > dataplane locking. The idea is that I/O operations on a dataplane > > BDS (i.e. one where the AioContext is not the main one) do not call > > aio_poll anymore. Instead, they

Re: [Qemu-devel] [PATCH v2 3/4] fdc: Move qdev properties to FloppyDrive

2016-10-17 Thread Kevin Wolf
Am 15.10.2016 um 00:32 hat John Snow geschrieben: > On 09/30/2016 03:39 PM, Kevin Wolf wrote: > >This makes the FloppyDrive qdev object actually useful: Now that it has > >all properties that don't belong to the controller, you can actually > >use '-device floppy' and get a working result. > > >

[Qemu-devel] [PATCH V4] colo-proxy: fix memory leak

2016-10-17 Thread Zhang Chen
Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. v3: - rebase this patch for upstream codes v2: - use traces instead of fprintf in colo-compare.c v1: - initial patch Zhang Chen (1): colo-proxy: fix memory leak net/colo-compare.c

[Qemu-devel] [PATCH V4] colo-proxy: fix memory leak

2016-10-17 Thread Zhang Chen
Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen --- net/colo-compare.c| 34 +++--- net/filter-rewriter.c | 17 + net/trace-events | 1

[Qemu-devel] [PATCH v8 09/11] virtio-crypto: add data queue processing handler

2016-10-17 Thread Gonglei
Introduces VirtIOCryptoReq structure to store crypto request so that we can support synchronous and asynchronous crypto operation in the future. At present, we only support cipher and algorithm chaining. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c |

[Qemu-devel] [PATCH v8 10/11] cryptodev: introduce an unified wrapper for crypto operation

2016-10-17 Thread Gonglei
We use an opaque point to the VirtIOCryptoReq which can support different packets based on different algorithms. Signed-off-by: Gonglei --- backends/cryptodev.c | 28 ++-- hw/virtio/virtio-crypto.c | 10 +-

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Thomas Huth
On 14.10.2016 20:58, Michael Tokarev wrote: > Hi. > > This commit: c9bc3437a905b660561a26cd4ecc64579843267b > Author: Richard Henderson > Date: Tue Jun 21 17:32:12 2016 -0700 > > linux-user: Provide safe_syscall for s390x > > does not build on debian unstable porterbox

Re: [Qemu-devel] bug introduced by "block: Move throttling fields from BDS to BB"

2016-10-17 Thread Alberto Garcia
On Fri 14 Oct 2016 04:11:46 PM CEST, Paolo Bonzini wrote: > Here is next_throttle_token: > > -ThrottleGroup *tg = container_of(blk_bs(blk)->throttle_state, > - ThrottleGroup, ts); > +BlockBackendPublic *blkp = blk_get_public(blk); > +ThrottleGroup

Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create

2016-10-17 Thread Fam Zheng
On Tue, 10/11 11:35, Kevin Wolf wrote: > > >By the way, why did we allow to add a 'bitmap' option for DriveBackup > > >without adding it to BlockdevBackup at the same time? > > > > I don't remember. I'm not sure anyone ever audited it to convince > > themselves it was a useful or safe thing to

[Qemu-devel] [Bug 1634069] [NEW] Exclude keys from grab

2016-10-17 Thread Constantine
Public bug reported: Feature request: pressing every time a shortcut to release grab for switching windows/desktops is pretty annoying, especially for users of tiling WMs. QEMU have to have a way to specify keys or shortcuts (possibly something like "everything with the specified modifier key"),

[Qemu-devel] [PATCH v8 02/11] cryptodev: add symmetric algorithm operation stuff

2016-10-17 Thread Gonglei
This patch adds session operation and crypto operation stuff in the cryptodev backend, including function pointers and corresponding structures. Signed-off-by: Gonglei --- backends/cryptodev.c | 45 ++ include/sysemu/cryptodev.h | 149

Re: [Qemu-devel] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv_wakeup

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 12:25, Stefan Hajnoczi wrote: > On Thu, Oct 13, 2016 at 07:34:11PM +0200, Paolo Bonzini wrote: >> @@ -485,9 +474,14 @@ void bdrv_inc_in_flight(BlockDriverState *bs) >> atomic_inc(>in_flight); >> } >> >> +void bdrv_wakeup(BlockDriverState *bs) >> +{ >> +} > > Please write a

Re: [Qemu-devel] [PATCH 02/18] blockjob: introduce .drain callback for jobs

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 12:02, Stefan Hajnoczi wrote: > On Thu, Oct 13, 2016 at 07:34:06PM +0200, Paolo Bonzini wrote: >> +static void backup_drain(BlockJob *job) >> +{ >> +BackupBlockJob *s = container_of(job, BackupBlockJob, common); >> + >> +/* Need to keep a reference in case blk_drain

Re: [Qemu-devel] [PATCH 15/18] block: only call aio_poll on the current thread's AioContext

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 18:40, Stefan Hajnoczi wrote: > > void bdrv_wakeup(BlockDriverState *bs) > > { > > +if (bs->wakeup) { > > +aio_bh_schedule_oneshot(qemu_get_aio_context(), dummy_bh_cb, NULL); > > +} > > } > > Why use a dummy BH instead of aio_notify()? Originally I used

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-17 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > On 10/14/16 10:25, Dr. David Alan Gilbert wrote: > > * Stefan Weil (s...@weilnetz.de) wrote: > > > Instead of allocating a VMStateDescription for each NIC instance, > > > the code now uses a single constant VMStateDescription for all > > > instances. That

[Qemu-devel] [Bug 1634069] Re: Exclude keys from grab

2016-10-17 Thread Constantine
Alternatively/additionally it would be nice to be able to disable keys grabbing at all. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1634069 Title: Exclude keys from grab Status in QEMU: New

Re: [Qemu-devel] [PATCH v4 10/20] ppc/xics: Make the ICSState a list

2016-10-17 Thread Cédric Le Goater
On 10/17/2016 01:53 AM, David Gibson wrote: > On Fri, Oct 14, 2016 at 09:35:46AM +0200, Cédric Le Goater wrote: >> On 10/14/2016 07:32 AM, David Gibson wrote: >>> On Mon, Oct 03, 2016 at 09:24:46AM +0200, Cédric Le Goater wrote: From: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH v4 09/12] iotests.py: Add qemu_nbd function

2016-10-17 Thread Kevin Wolf
Am 15.10.2016 um 19:17 hat Max Reitz geschrieben: > On 13.10.2016 15:11, Kevin Wolf wrote: > > Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: > >> Signed-off-by: Max Reitz > >> --- > >> tests/qemu-iotests/iotests.py | 8 > >> 1 file changed, 8 insertions(+) > >> >

Re: [Qemu-devel] [PATCH] vfio: fix duplicate function call

2016-10-17 Thread Cao jin
Hi, On 10/14/2016 11:50 PM, Alex Williamson wrote: On Fri, 14 Oct 2016 19:16:59 +0800 Cao jin wrote: When vfio device is reset(encounter FLR, or bus reset), if need to do bus reset(vfio_pci_hot_reset_one is called), vfio_pci_pre_reset & vfio_pci_post_reset will be

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-17 Thread Pradeep Jagadeesh
Hi Alberto, On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { }, { .name

Re: [Qemu-devel] invtsc + migration + TSC scaling

2016-10-17 Thread Marcelo Tosatti
On Fri, Oct 14, 2016 at 06:20:31PM -0300, Eduardo Habkost wrote: > I have been wondering: should we allow live migration with the > invtsc flag enabled, if TSC scaling is available on the > destination? TSC scaling and invtsc flag, yes. > > For reference, this is what the Intel SDM says about

[Qemu-devel] [PATCH v8 01/11] cryptodev: introduce cryptodev backend interface

2016-10-17 Thread Gonglei
cryptodev backend interface is used to realize the active work for virtual crypto device. This patch only add the framework, doesn't include specific operations. Signed-off-by: Gonglei --- backends/Makefile.objs | 2 + backends/cryptodev.c | 176

Re: [Qemu-devel] [PATCH v4 17/20] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2016-10-17 Thread Cédric Le Goater
On 10/17/2016 01:52 AM, David Gibson wrote: > On Fri, Oct 14, 2016 at 10:07:53AM +0200, Cédric Le Goater wrote: --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -318,15 +318,24 @@ static void ppc_powernv_reset(void) * have a CPLD that will collect the SerIRQ and shoot them as a

Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics

2016-10-17 Thread Alex Bennée
Emilio G. Cota writes: > On Tue, Oct 11, 2016 at 14:40:26 -0500, Richard Henderson wrote: >> Sixth time is the charm, right? This time I'm certain that it >> compiles with centos6, and contains the previously missing update >> from Emilio to atomic_add-bench. > > For patches

Re: [Qemu-devel] [PATCH] include/qemu: Add documentation to functions in include/qemu/id.h

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 23:03, Veronia Bahaa wrote: > Add documentation to the functions id_generate and id_wellformed in > include/qemu/id.h > > Signed-off-by: Veronia Bahaa > --- > include/qemu/id.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff

[Qemu-devel] [PATCH v8 11/11] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer

2016-10-17 Thread Gonglei
This patch includes two parts: Cryptodev Backends and virtio-crypto stuff. I can maintain cryptodev backends which introduced by myself. For virtio-crypto stuff, I can share the work with Michael (The whole virtio supporter). Signed-off-by: Gonglei --- MAINTAINERS | 13

Re: [Qemu-devel] invtsc + migration + TSC scaling

2016-10-17 Thread Marcelo Tosatti
On Mon, Oct 17, 2016 at 07:11:01PM -0200, Eduardo Habkost wrote: > On Mon, Oct 17, 2016 at 06:24:38PM +0200, Paolo Bonzini wrote: > > On 17/10/2016 16:50, Radim Krčmář wrote: > > > 2016-10-17 07:47-0200, Marcelo Tosatti: > [...] > > >> since Linux guests use kvmclock and Windows guests use Hyper-V

Re: [Qemu-devel] [PATCH] ppc/xics: Add xics to the monitor "info pic" command

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 10:33:14PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Useful to debug interrupt problems. > > Signed-off-by: Benjamin Herrenschmidt > [clg: - updated for qemu-2.7 > - added a test on ->irqs

[Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

2016-10-17 Thread Kirti Wankhede
Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by different drivers of different devices. This module provides a generic interface to create the device, add it to mediated bus, add device to IOMMU

[Qemu-devel] [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags

2016-10-17 Thread Kirti Wankhede
Function vfio_device_api_string() returns string based on flag set in vfio_device_info's flag. This should be used by vendor driver to get string based on flag for device_api attribute. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id:

[Qemu-devel] [PATCH v9 05/12] vfio: Introduce common function to add capabilities

2016-10-17 Thread Kirti Wankhede
Vendor driver using mediated device framework should use vfio_info_add_capability() to add capabilities. Introduced this function to reduce code duplication in vendor drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id:

[Qemu-devel] [PATCH v9 08/12] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare()

2016-10-17 Thread Kirti Wankhede
Updated vfio_pci.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I9f3daba89d8dba5cb5b01a8cff420412f30686c7 --- drivers/vfio/pci/vfio_pci.c | 29 + 1 file

[Qemu-devel] [PATCH v9 11/12] docs: Add Documentation for Mediated devices

2016-10-17 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d ---

[Qemu-devel] [PATCH v9 07/12] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-10-17 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id:

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-17 Thread Michael Roth
Quoting Peter Maydell (2016-10-17 13:45:21) > On 17 October 2016 at 19:13, Michael Roth wrote: > > We could do both though: use some ad-hoc way to tag for a particular > > sub-maintainer tree/stable branch, as well as an explicit "not for > > master" in the cover letter

[Qemu-devel] [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-10-17 Thread Kirti Wankhede
The Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mdev/Makefile | 13 +

[Qemu-devel] [PATCH] trivial: Restore blank line in qapi-schema

2016-10-17 Thread Eric Blake
Commit de63ab6 accidentally undid part of commit a43edcf, because the two patches were written in parallel, and the blank line was not noticed as a casualty of merge conflicts. Signed-off-by: Eric Blake --- qapi-schema.json | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH v3 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-17 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote: [...] > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx, MachineState > *machine, > /* The current AML generator can cover the APIC ID range [0..255], > * inclusive, for VCPU hotplug. */ >

Re: [Qemu-devel] [PATCH v3 0/3] Split cpu_exec_init() into an init and a realize part

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 04:47:34PM -0200, Eduardo Habkost wrote: > On Mon, Oct 17, 2016 at 02:44:04PM +1100, David Gibson wrote: > > On Sat, Oct 15, 2016 at 12:52:46AM +0200, Laurent Vivier wrote: > > > Since commit 42ecaba ("target-i386: Call cpu_exec_init() on realize"), > > > , commit 6dd0f83

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 0/6] tests: enable virtio tests on SPAPR

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 12:30:18PM +0200, Laurent Vivier wrote: > This series enables virtio tests on SPAPR by starting > machines using qtest_pc_boot() or qtest_spapr_boot() to > use the good libqos PCI framework (pc or spapr). > > It adds also some byte-swapping in virtio-pci.c as > PCI is

Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-17 Thread Alexey Kardashevskiy
Ping, anyone? I rather expected floods of mails on such a controversial topic :) On 11/10/16 09:19, Alexey Kardashevskiy wrote: > Ping, anyone? > > > On 04/10/16 11:33, Alexey Kardashevskiy wrote: >> From: Greg Kurz >> >> Some systems can already provide more than

Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-17 Thread David Gibson
On Tue, Oct 18, 2016 at 12:07:20PM +1100, Alexey Kardashevskiy wrote: > Ping, anyone? > > I rather expected floods of mails on such a controversial topic :) I think it's the reverse of the bike-shed problem. Hardly anyone feels qualified to comment on it. It looks ok to me, but I just don't

Re: [Qemu-devel] [PATCH v8 09/11] virtio-crypto: add data queue processing handler

2016-10-17 Thread Gonglei (Arei)
> +static CryptoDevBackendSymOpInfo * > +virtio_crypto_sym_op_helper(VirtIODevice *vdev, > + struct virtio_crypto_cipher_para *cipher_para, > + struct virtio_crypto_alg_chain_data_para *alg_chain_para, > + struct iovec *iov, unsigned int out_num) > +{ > +

Re: [Qemu-devel] [PATCH 2/7] nios2: Add architecture emulation support

2016-10-17 Thread Marek Vasut
On 09/29/2016 03:05 AM, Richard Henderson wrote: >> hw/nios2/cpu_pic.c | 70 +++ > > Why is this in this patch? Ah, good catch, moved to 10m50 support patch. >> target-nios2/instruction.c | 1427 >> >> target-nios2/instruction.h | 279

Re: [Qemu-devel] [PATCH] vfio: fix duplicate function call

2016-10-17 Thread Cao jin
On 10/17/2016 11:01 PM, Alex Williamson wrote: On Mon, 17 Oct 2016 16:57:08 +0800 Cao jin wrote: Hi, On 10/14/2016 11:50 PM, Alex Williamson wrote: On Fri, 14 Oct 2016 19:16:59 +0800 Cao jin wrote: When vfio device is reset(encounter

Re: [Qemu-devel] [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework.

2016-10-17 Thread Dong Jia Shi
* Kirti Wankhede [2016-10-18 02:52:12 +0530]: ...snip... > +static ssize_t mdev_access(struct mdev_device *mdev, char *buf, > + size_t count, loff_t pos, bool is_write) > +{ > + struct mdev_state *mdev_state; > + unsigned int index; > + loff_t

Re: [Qemu-devel] [V2,1/7] nios2: Add disas entries

2016-10-17 Thread Marek Vasut
On 10/15/2016 03:15 PM, Romain Naour wrote: > Hi Marek, Hi! > Le 28/09/2016 à 01:30, Marek Vasut a écrit : >> Add nios2 disassembler support. This patch is composed from binutils files >> from commit "Opcodes and assembler support for Nios II R2". The files from >> binutils used in this patch

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 06:44:24PM +0300, Aviv B.D wrote: > From: "Aviv Ben-David" > > Adds a list of registered vtd_as's to intel iommu state to save > iteration over each PCI device in a search of the corrosponding domain. > > Signed-off-by: Aviv Ben-David

Re: [Qemu-devel] [PATCH v4 RESEND 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 10:07:36AM -0600, Alex Williamson wrote: > On Mon, 17 Oct 2016 18:44:21 +0300 > "Aviv B.D" wrote: > > > From: "Aviv Ben-David" > > > > * Advertize Cache Mode capability in iommu cap register. > > This capability is controlled by

Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: > From: "Aviv Ben-David" > > Supports translation trials without reporting error to guest on > translation failure. > > Signed-off-by: Aviv Ben-David > --- > exec.c| 3 ++- >

Re: [Qemu-devel] [PATCH v4 RESEND 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-10-17 Thread Alex Williamson
On Tue, 18 Oct 2016 15:06:55 +1100 David Gibson wrote: > On Mon, Oct 17, 2016 at 10:07:36AM -0600, Alex Williamson wrote: > > On Mon, 17 Oct 2016 18:44:21 +0300 > > "Aviv B.D" wrote: > > > > > From: "Aviv Ben-David" > > > >

[Qemu-devel] [PATCH] docs/rcu.txt: Fix minor typo

2016-10-17 Thread Pranith Kumar
s/presented/prevented/ Signed-off-by: Pranith Kumar --- docs/rcu.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index a70b72c..c84e7f4 100644 --- a/docs/rcu.txt +++ b/docs/rcu.txt @@ -145,7 +145,7 @@ The core RCU API is

Re: [Qemu-devel] [RFC v5 0/8] KVM PCI/MSI passthrough with mach-virt

2016-10-17 Thread Fam Zheng
On Mon, 10/17 22:56, Auger Eric wrote: > Hi, > On 17/10/2016 22:16, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com > wrote: > > Hi, > > > > Your series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably

[Qemu-devel] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public

2016-10-17 Thread Ashijeet Acharya
Make inet_connect_saddr() in util/qemu-sockets.c public in order to be able to use it with InetSocketAddress sockets outside of util/qemu-sockets.c independently. Signed-off-by: Ashijeet Acharya --- include/qemu/sockets.h | 2 ++ util/qemu-sockets.c| 4 ++-- 2

Re: [Qemu-devel] [PATCH v6] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-17 Thread Peter Maydell
On 14 October 2016 at 04:43, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero. When auto-increment control

[Qemu-devel] [PATCH v3 4/5] block/ssh: Use InetSocketAddress options

2016-10-17 Thread Ashijeet Acharya
Drop the use of legacy options in favour of the InetSocketAddress options. Signed-off-by: Ashijeet Acharya Reviewed-by: Max Reitz --- block/ssh.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c

[Qemu-devel] [PULL 1/5] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Eduardo Habkost
From: Markus Armbruster machine_set_property() replaces '_' by '-' in the property name. Except it fails to replace an initial '_'. Screwed up in commit b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property '._-foo-bar' not found". Error messages using a mangled

[Qemu-devel] [PATCH v3 5/5] qapi: allow blockdev-add for ssh

2016-10-17 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 26

Re: [Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener

2016-10-17 Thread Peter Maydell
On 30 September 2016 at 08:17, Paolo Bonzini wrote: > The only address space where the GIC devices are added is > address_space_memory. There is no need to use a global > MemoryListener. > > This removes the only user of global MemoryListeners. > > Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] ppc/kvm: Mark 64kB page size support as disabled if not available

2016-10-17 Thread Michael Roth
Quoting Thomas Huth (2016-09-21 04:42:15) > QEMU currently refuses to start with KVM-PR and only prints out > > qemu: fatal: Unknown MMU model 851972 > > when being started there. This is because commit 4322e8ced5aaac719 > ("ppc: Fix 64K pages support in full emulation") introduced a new

[Qemu-devel] [PULL 05/21] target-i386: Make plus_features/minus_features QOM-based

2016-10-17 Thread Eduardo Habkost
Instead of using custom feature name lookup code for plus_features/minus_features, save the property names used in "[+-]feature" and use object_property_set_bool() to set them. We don't need a feat2prop() call because we now have alias properties for the old names containing underscores.

[Qemu-devel] [PULL 08/21] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas

2016-10-17 Thread Eduardo Habkost
Instead of treating the FP and SSE bits as special cases, add them to the x86_ext_save_areas array. This will simplify the code that calculates the supported xsave components and the size of the xsave area. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22

[Qemu-devel] [PULL 5/5] hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties

2016-10-17 Thread Eduardo Habkost
To do the conversion, the file_backend_class_init() was moved after the getter/setter functions. The old file_backend_instance_init() function was removed because it is not needed anymore. The NULL errp arguments on the property registration calls were changed to _abort. Reviewed-by: Igor

Re: [Qemu-devel] [very-WIP 3/4] slirp: VMStatify sbuf

2016-10-17 Thread Halil Pasic
On 10/17/2016 05:36 AM, David Gibson wrote: > On Tue, Oct 11, 2016 at 06:18:32PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Convert the sbuf structure to a VMStateDescription. >> Note this uses the VMSTATE_WITH_TMP mechanism to

[Qemu-devel] [PULL 13/21] intel_iommu: pass whole remapped addresses to apic

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář The MMIO interface to APIC only allowed 8 bit addresses, which is not enough for 32 bit addresses from EIM remapping. Intel stored upper 24 bits in the high MSI address, so use the same technique. The technique is also used in KVM MSI interface. Other APICs

Re: [Qemu-devel] [PATCH V1 02/10] qemu-clk: allow to attach a clock to a device

2016-10-17 Thread Peter Maydell
On 5 October 2016 at 23:10, wrote: > From: KONRAD Frederic > > This allows to attach a clock to a DeviceState. > Contrary to gpios, the clock pins are not contained in the DeviceState but > with the child property so they can appears in the

[Qemu-devel] [PULL 21/21] target-i386: Don't use cpu->migratable when filtering features

2016-10-17 Thread Eduardo Habkost
When explicitly enabling unmigratable flags using "-cpu host" (e.g. "-cpu host,+invtsc"), the requested feature won't be enabled because cpu->migratable is true by default. This is inconsistent with all other CPU models, which don't have the "migratable" option, making "+invtsc" work without the

Re: [Qemu-devel] [PATCH v2 09/11] blockjob: add block_job_start

2016-10-17 Thread John Snow
On 10/06/2016 06:44 PM, John Snow wrote: On 10/05/2016 11:17 AM, Kevin Wolf wrote: Am 01.10.2016 um 00:00 hat John Snow geschrieben: Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-17 Thread Michael Roth
Quoting Peter Maydell (2016-10-17 12:33:18) > On 17 October 2016 at 17:51, Michael Roth wrote: > > Maybe just a tag like [PULL for-stable], or [PULL for-2.7]? > > > > The latter seems to mirror how we handle things for patches coming for > > master during freeze. Others

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-17 Thread Peter Maydell
On 17 October 2016 at 17:51, Michael Roth wrote: > Maybe just a tag like [PULL for-stable], or [PULL for-2.7]? > > The latter seems to mirror how we handle things for patches coming for > master during freeze. Others who've submitted patches they've > backported

[Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it

2016-10-17 Thread Ashijeet Acharya
Add InetSocketAddress compatibility to SSH driver. Add a new option "server" to the SSH block driver which then accepts a InetSocketAddress. "host" and "port" are supported as legacy options and are mapped to their InetSocketAddress representation. Signed-off-by: Ashijeet Acharya

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Eric Blake
On 10/17/2016 09:50 AM, Markus Armbruster wrote: >> But even if I realised that QemuOpts support this syntax, I think we >> would still have to use the dotted syntax because it's explicit about >> the index and we need that because the list can contains dicts. >> >> Compare this: >> >>

[Qemu-devel] [PULL 06/21] target-i386: Remove underscores from feat_names arrays

2016-10-17 Thread Eduardo Habkost
Instead of translating the feature name entries when adding property names, store the actual property names in the feature name array. For reference, here is the full list of functions that use FeatureWordInfo::feat_names: * x86_cpu_get_migratable_flags(): not affected, as it just check for

[Qemu-devel] [PULL 07/21] target-i386: Register properties for feature aliases manually

2016-10-17 Thread Eduardo Habkost
Instead of keeping the aliases inside the feature name arrays and require parsing the strings, just register alias properties manually. This simplifies the code for property registration and lookup. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 43

[Qemu-devel] [PULL 2/5] machine: Register TYPE_MACHINE properties as class properties

2016-10-17 Thread Eduardo Habkost
When doing the conversion, the NULL errp arguments on the property registration calls were changed to _abort. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 206 ++

[Qemu-devel] [PULL 15/21] intel_iommu: add OnOffAuto intr_eim as "eim" property

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář The default (auto) emulates the current behavior. A user can now control EIM like -device intel-iommu,intremap=on,eim=off Reviewed-by: Igor Mammedov Reviewed-by: Peter Xu Signed-off-by: Radim Krčmář

[Qemu-devel] [PULL 19/21] target-i386: x86_cpu_load_features() function

2016-10-17 Thread Eduardo Habkost
When probing for CPU model information, we need to reuse the code that initializes CPUID fields, but not the remaining side-effects of x86_cpu_realizefn(). Move that code to a separate function that can be reused later. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo

[Qemu-devel] [PULL 17/25] pxa2xx: Auto-assign name for i2c bus in i2c_init_bus.

2016-10-17 Thread Peter Maydell
From: Vijay Kumar B If a name is provided, the same name is assigned to both the I2C controllers. Leaving it NULL, causes names to be automatically assigned with an ID suffix, giving unique names to each controller. This helps us to uniquely identify each controller in

[Qemu-devel] [PULL 00/25] target-arm queue

2016-10-17 Thread Peter Maydell
(2016-10-17 16:17:51 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20161017 for you to fetch changes up to 041ac05672993ff33a15f8017c0f729ca6dfad73: hw/char/pl011: Add trace events (2016-10-17 19:32:44 +0100

[Qemu-devel] [PATCH v3 0/5] Allow blockdev-add for SSH

2016-10-17 Thread Ashijeet Acharya
Previously posted series patches: v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg03403.html v1: http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02137.html This series adds blockdev-add support for SSH block driver. Patch 1 prepares the code for the addition of a new

[Qemu-devel] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict()

2016-10-17 Thread Ashijeet Acharya
We have 5 options plus ("server") option which is added in the next patch that conflict with specifying a SSH filename. We need to iterate over all the options to check whether its key has an "server." prefix. This iteration will help us adding the new option "server" easily. Signed-off-by:

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Markus Armbruster
Paolo Bonzini writes: >> For me, a replacement should do structured values by providing suitable >> *value* syntax instead of hacking it into the keys: >> >> { "driver": "quorum", >> "child": [ { "driver": "file", "filename": "disk1.img" }, >> {

[Qemu-devel] [PULL 09/21] qmp: Add runnability information to query-cpu-definitions

2016-10-17 Thread Eduardo Habkost
Add a new optional field to query-cpu-definitions schema: "unavailable-features". It will contain a list of QOM properties that prevent the CPU model from running in the current host. Cc: David Hildenbrand Cc: Michael Mueller Cc: Christian

[Qemu-devel] [PULL 04/21] target-i386: Register aliases for feature names with underscores

2016-10-17 Thread Eduardo Habkost
Registering the actual names containing underscores as aliases will allow management software to be aware that the old compatibility names are suported, and will make feat2prop() calls unnecessary when using feature names. Also, this will help us avoid making the code support underscores on

[Qemu-devel] [PULL 17/21] target-i386/kvm: cache the return value of kvm_enable_x2apic()

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář Assume that KVM would have returned the same on subsequent runs. Abstract the memoizaiton pattern into macros and call it memorize as adding the r makes it less obscure. Reviewed-by: Igor Mammedov Signed-off-by: Radim Krčmář

[Qemu-devel] [PULL 03/21] target-i386: Disable VME by default with TCG

2016-10-17 Thread Eduardo Habkost
VME is already disabled automatically when using TCG. So, instead of pretending it is there when reporting CPU model data on query-cpu-* QMP commands (making every CPU model to be reported as not runnable), we can disable it by default on all CPU models when using TCG. Do that by adding a

[Qemu-devel] [PULL 10/21] target-i386: Move warning code outside x86_cpu_filter_features()

2016-10-17 Thread Eduardo Habkost
x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 12/21] apic: add send_msi() to APICCommonClass

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář The MMIO based interface to APIC doesn't work well with MSIs that have upper address bits set (remapped x2APIC MSIs). A specialized interface is a quick and dirty way to avoid the shortcoming. Reviewed-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PULL 14/21] intel_iommu: redo configuraton check in realize

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář * there no point in configuring the device if realization is going to fail, so move the check to the beginning, * create a separate function for the check, * use error_setg() instead error_report(). Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 16/21] intel_iommu: reject broken EIM

2016-10-17 Thread Eduardo Habkost
From: Radim Krčmář Cluster x2APIC cannot work without KVM's x2apic API when the maximal APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we forbid other APICs and also the old KVM case with less than 9, to simplify the code. There is no point in enabling

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-17 Thread Vladimir Sementsov-Ogievskiy
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 241

[Qemu-devel] DROP THIS Re: [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-17 Thread Vladimir Sementsov-Ogievskiy
Sorry, this was an accidental reply. On 17.10.2016 20:57, Vladimir Sementsov-Ogievskiy wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: drop thread spun work-around

2016-10-17 Thread Max Reitz
On 10.10.2016 04:57, Michael S. Tsirkin wrote: > We've disabled the warning, no need for test to work > around it. > > Signed-off-by: Michael S. Tsirkin > --- > tests/qemu-iotests/common.filter | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Qemu-devel] [Qemu-block] block/nfs: Fine grained runtime options in nfs

2016-10-17 Thread Ashijeet Acharya
On Fri, Oct 14, 2016 at 9:16 PM, Stefan Hajnoczi wrote: > On Mon, Oct 10, 2016 at 10:39:30AM +0530, Ashijeet Acharya wrote: >> Hi all, >> >> I was working on trying to add blockdev-add compatibility for the nfs >> block driver but before that runtime options need to be

[Qemu-devel] qemu master tests/vmstate prints "Failed to load simple/primitive:b_1" etc

2016-10-17 Thread Peter Maydell
I've just noticed that qemu master running 'make check' prints GTESTER tests/test-vmstate Failed to load simple/primitive:b_1 Failed to load simple/primitive:i64_2 Failed to load simple/primitive:i32_1 Failed to load simple/primitive:i32_1 but the test doesn't fail. Can we either (a) silence

[Qemu-devel] [PATCH v9 03/12] vfio: Rearrange functions to get vfio_group from dev

2016-10-17 Thread Kirti Wankhede
Rearrange functions to have common function to increment container_users. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 --- drivers/vfio/vfio.c | 57

[Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-17 Thread Kirti Wankhede
VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated device only uses IOMMU APIs, the underlying hardware can be managed by an IOMMU domain. Aim of this change is: - To use most of the code of TYPE1 IOMMU driver for mediated devices - To support direct assigned device

  1   2   3   4   >