[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-16 Thread ChristianEhrhardt
** Also affects: qemu (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: qemu-linaro (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-16 Thread ChristianEhrhardt
That means our assumption taken in comment #63 that it was fixed in http://git.qemu.org/?p=qemu.git;a=commitdiff;h=014628a705bdaf31c09915 either was wrong (unset fix released) - or this is a similar but not the same issue (which would imply a new bug since this already has plenty of potentially mis

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Oleksandr Andrushchenko
On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: On 04/10/2018 08:26 PM, Dongwon Kim wrote: On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: On 04/06/2018 09:57 PM, Dongwon Kim wrote: On Fri, Apr 06,

Re: [Qemu-devel] Hot add vcpu not working in Windows server 2012r2

2018-04-16 Thread Wuzongyong (Euler Dept)
> On Fri, 13 Apr 2018 03:14:44 + > "Wuzongyong (Euler Dept)" wrote: > > > Hi, > > > > I try to hot add vcpus to a windows server 2012r2 virtual machine on > RHEL 7.4 platform. > > But Task Manager didn't show extra processors I hot added though they > > appeared in Device Manager. Actually, I

Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-16 Thread Stefan Hajnoczi
On Sat, Apr 07, 2018 at 01:12:05AM +0530, Nikhil Balachandra wrote: > Eventhough macOS does not ship with the if_bridgevar.h header file[2], > I expect the API to remain stable as this header file is similar to what > is found in other BSDs. If this patch is decided to be included in the > qemu, ca

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-16 Thread Cornelia Huck
On Fri, 13 Apr 2018 14:09:55 -0400 Collin Walling wrote: > On 04/13/2018 02:06 PM, Philippe Mathieu-Daudé wrote: > > On 04/13/2018 01:59 PM, Halil Pasic wrote: > On 04/13/2018 04:30 PM, Thomas Huth wrote: > > "size_t" should be an unsigned type - the signed counterpart is called > >>

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: > On 04/13/2018 06:37 PM, Daniel Vetter wrote: > > On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: > > > On 04/10/2018 08:26 PM, Dongwon Kim wrote: > > > > On Tue, Apr 10, 2018 at 09:37:53AM +0300, Ole

[Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-16 Thread Thomas Huth
"size_t" should be an unsigned type according to the C standard. Thus we should also use this convention in the s390-ccw firmware to avoid confusion. I checked the sources, and apart from one spot in libc.c, the code should all be fine with this change. Buglink: https://bugs.launchpad.net/qemu/+bu

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-16 Thread Stefan Hajnoczi
On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB Naming suggestion: "PREFILL_IOTLB" instead of "NEED_ALL_IOTLB". I wasn't able to guess what "NEED_ALL_IOTLB" does. "PREFILL_IOTLB" communicates that memory translation will be

Re: [Qemu-devel] [ARM/FDPIC 4/4] linux-user: ARM-FDPIC: Add arm get tls syscall support

2018-04-16 Thread Christophe Lyon
On 13/04/2018 17:03, Peter Maydell wrote: On 6 April 2018 at 16:17, Christophe Lyon wrote: Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h index 94e2a42..afc0772 100644 --- a/linux-user/arm/target_sys

[Qemu-devel] [PATCH] qemu-progress: redirct qemu progress message to another file stream

2018-04-16 Thread zhenwei pi
currently qemu progress message only print into stdout, and other thread may print some log into stdout at the same time. add a new api qemu_progress_set_output to redirect progress message to another file stream. Signed-off-by: zhenwei pi --- include/qemu-common.h | 1 + util/qemu-progress.c

Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

2018-04-16 Thread Christophe Lyon
On 13/04/2018 17:04, Peter Maydell wrote: On 6 April 2018 at 16:17, Christophe Lyon wrote: Adds --enable-fdpic and --disable-fdpic configure options. This feature is disabled by default, that's why it is not described in the "Optional features" help section (which are enabled by default if pos

Re: [Qemu-devel] [ARM/FDPIC 2/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-16 Thread Christophe Lyon
On 13/04/2018 17:07, Peter Maydell wrote: On 6 April 2018 at 16:17, Christophe Lyon wrote: Add FDPIC info into image_info structure since interpreter info is on stack and needs to be saved to be accessed later on. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/li

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-16 Thread Igor Mammedov
On Fri, 13 Apr 2018 20:00:18 +0200 Auger Eric wrote: > Hi Igor, > > On 12/04/18 18:40, Igor Mammedov wrote: > > platform-bus were using machine_done notifier to get and map > > (assign irq/mmio resources) dynamically added sysbus devices > > after all '-device' options had been processed. > > Th

Re: [Qemu-devel] [ARM/FDPIC 0/4] FDPIC ABI for ARM

2018-04-16 Thread Christophe Lyon
On 13/04/2018 17:18, Peter Maydell wrote: On 6 April 2018 at 16:17, Christophe Lyon wrote: Hello, This patch series implements the QEMU contribution of the FDPIC ABI for ARM targets. I am currently working on updating the patches for the other toolchain components, and will upstream them so

Re: [Qemu-devel] [PATCH v3 34/41] hw/usb: Use the BYTE-based definitions

2018-04-16 Thread Gerd Hoffmann
On Sun, Apr 15, 2018 at 08:43:00PM -0300, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé Rev

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

2018-04-16 Thread Markus Armbruster
Marc-André Lureau writes: > By moving the base fields to a QObjectBase_, QObject can be a type > which also has a 'base' field. This allows to write a generic > QOBJECT() macro that will work with any QObject type, including > QObject itself. The container_of() macro ensures that the object to >

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-16 Thread Christian Borntraeger
On 04/16/2018 09:45 AM, Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine with this

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-16 Thread Igor Mammedov
On Mon, 16 Apr 2018 12:43:55 +1000 David Gibson wrote: > On Thu, Apr 12, 2018 at 06:40:19PM +0200, Igor Mammedov wrote: > > platform-bus were using machine_done notifier to get and map > > (assign irq/mmio resources) dynamically added sysbus devices > > after all '-device' options had been proces

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Oleksandr Andrushchenko
On 04/16/2018 10:43 AM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: On 04/10/2018 08:26 PM, Dongwon Kim wrote: On Tue, Apr 10

Re: [Qemu-devel] [PATCH v4 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

2018-04-16 Thread Markus Armbruster
Marc-André Lureau writes: > Following a discussion on the mailing list: If a reader of this commit message could profit from reading the discussion, refer to it by URL and/or Message-Id. If not, don't mention it. > while it may be convenient > to acc

Re: [Qemu-devel] qapi: [PATCH v2] Implement query-usbhost QMP command

2018-04-16 Thread Gerd Hoffmann
On Sat, Apr 14, 2018 at 02:29:34AM -0700, Alexander Kappner wrote: > Implement a QMP command similar to the HMP's "info usbhost" command. The hmp version of the command should be switched over to call the qmp_query_usbhost() and pretty-print the qapi struct then, to make sure hmp and qmp versions

Re: [Qemu-devel] [PATCH v4 2/4] qobject: use a QObjectBase_ struct

2018-04-16 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> By moving the base fields to a QObjectBase_, QObject can be a type >> which also has a 'base' field. This allows to write a generic >> QOBJECT() macro that will work with any QObject type, including >> QObject itself. The container_of()

Re: [Qemu-devel] Hot add vcpu not working in Windows server 2012r2

2018-04-16 Thread Igor Mammedov
On Mon, 16 Apr 2018 07:28:47 + "Wuzongyong (Euler Dept)" wrote: > > On Fri, 13 Apr 2018 03:14:44 + > > "Wuzongyong (Euler Dept)" wrote: > > > > > Hi, > > > > > > I try to hot add vcpus to a windows server 2012r2 virtual machine on > > RHEL 7.4 platform. > > > But Task Manager didn

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-16 Thread Stefan Hajnoczi
On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure th

Re: [Qemu-devel] [PATCH v1 02/24] configure: add support for --cross-cc-FOO

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/10/2018 04:38 PM, Alex Bennée wrote: >> This allows us to specify cross compilers for our guests. This is >> useful for building test images/programs. Currently we re-run the >> compile test for each target. I couldn't think of a way to cache the >> value f

Re: [Qemu-devel] [PATCH v1 10/24] tests/tcg/multiarch: Build fix for linux-test

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/15/2018 09:07 PM, Philippe Mathieu-Daudé wrote: >> Hi Fam, Alex, >> >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> From: Fam Zheng >>> >>> To keep the compiler happy, and to fit in our buildsys flags: >>> >>> - Make local functions "static" >>> - #ifde

[Qemu-devel] Let event loop use non-default GMainContext

2018-04-16 Thread Eva Chen
Hello, It seems that AIO use global default GMainContext by *g_main_context_default()*. I want to replace all default GMainContext into another GMainContext by *g_main_context_new()*, but I have no idea when and where to add *g_main_context_new()*. It should be only created new GMainContext once,

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> Now all the build infrastructure is in place we can build tests for >> each guest that we support. That support mainly depends on having >> cross compilers installed or docker setup. To keep all the logic for >> that

Re: [Qemu-devel] [PATCH v1 21/24] tests/tcg: enable building for ppc64

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> Currently this just enables building the multiarch tests. >> >> Signed-off-by: Alex Bennée > > "make tcg-tests-ppc64-linux-user" works indeed. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Phili

[Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

2018-04-16 Thread Bharata B Rao
The new property ibm,dynamic-memory-v2 allows memory to be represented in a more compact manner in device tree. Signed-off-by: Bharata B Rao --- v2 - https://lists.nongnu.org/archive/html/qemu-ppc/2018-04/msg00052.html Changes in v3: - Addressed David Gibson's review comments: use of CamelCase, s

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> These only need to be built for MIPS guests. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/README | 11 --- >> tests/tcg/mips/README | 7 +++ >> tests/tcg/{ => mips}

Re: [Qemu-devel] [PATCH v4 3/4] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF

2018-04-16 Thread Markus Armbruster
Marc-André Lureau writes: > Now that we can safely call QOBJECT() on QObject * and children types, > we can have a single macro to ref/unref the object. > > Change the incref/decref prefix name for the more common ref/unref. > > Note that before the patch, "QDECREF(obj)" was problematic because i

Re: [Qemu-devel] [PATCH v1 12/24] tests/tcg/i386: Build fix for hello-i386

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Fam, Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> From: Fam Zheng >> >> We have -Werror=missing-prototype, add a dummy prototype to avoid that >> warning. >> >> Signed-off-by: Fam Zheng >> --- >> tests/tcg/i386/hello-i386.c | 1 + >> 1 file cha

Re: [Qemu-devel] [PATCH v1 09/24] tests/tcg: move architecture independent tests into subdir

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> We will want to build these for all supported guest architectures so >> lets move them all into one place. We also drop test_path at this >> point because it needs qemu utils and glib bits which is hard t

Re: [Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

2018-04-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 04/10/2018 04:38 PM, Alex Bennée wrote: >> We should still be able to use the system cross compiler with the >> appropriate flags on x86_64 hosts. >> >> Signed-off-by: Alex Bennée >> --- >> configure | 23 +++ >> 1 file chan

Re: [Qemu-devel] [PATCH v2 0/2] Softfloat Fixes for 2.12

2018-04-16 Thread Peter Maydell
On 13 April 2018 at 15:03, Alex Bennée wrote: > Hi, > > The float_invalid patch now handles the Inf case as well and includes > the fix to round_to_uint_and_pack. > > Alex Bennée (1): > fpu/softfloat: raise float_invalid for NaN/Inf in > round_to_int_and_pack > > Emilio G. Cota (1): > soft

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-16 Thread Peter Xu
On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > > In the future the monitor iothread may be accessing the cur_mon as > > well (via monitor_qmp_dispatch_one()). Before we introduce a real > > Out-Of-Band command, let's c

[Qemu-devel] [PATCH] linux-user: Add ARM get_tls syscall support

2018-04-16 Thread Christophe Lyon
Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h index 94e2a42..afc0772 100644 --- a/linux-user/arm/target_syscall.h +++ b/linux-user/arm/target_syscall.h @@ -16,6 +16,7 @@ struct target_pt_regs { #define

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-16 Thread Andrew Jones
On Fri, Apr 13, 2018 at 04:11:24PM +0200, Auger Eric wrote: > Hi Peter, > > On 13/04/18 16:06, Peter Maydell wrote: > > On 13 April 2018 at 15:01, Auger Eric wrote: > >> On 13/04/18 15:41, Peter Maydell wrote: > >>> I think it would be better to explicitly check "do we have > >>> support for spli

Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 08:57, Christophe Lyon wrote: > On 13/04/2018 17:04, Peter Maydell wrote: >> I think we should just have support for these binaries enabled >> always. Otherwise it will bitrot because nobody compiles it. >> > We are relying on a pre-existing CONFIG_USE_FDPIC, which is currently

Re: [Qemu-devel] [PATCH] linux-user: Add ARM get_tls syscall support

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 10:18, Christophe Lyon wrote: > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon I think it's worth mentioning in the commit message that this is a new Arm-specific syscall added in kernel version 4.15. Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-16 Thread Peter Maydell
On 14 April 2018 at 15:27, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 727ef118f3..8644c2e918 100644 > --- a/Makefile > +++ b/Makefile > @@ -856,7 +856,7 @@ ifneq ($(

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko wrote: > On 04/16/2018 10:43 AM, Daniel Vetter wrote: >> >> On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: >>> >>> On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at 08:59:32AM +0300, Ol

[Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-16 Thread Michael Tokarev
Fixes 722cd7496474cebb2218f21e038592fad8603365 Signed-off-by: Michael Tokarev --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 727ef118f3..d71dd5bea4 100644 --- a/Makefile +++ b/Makefile @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)

Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-16 Thread Michael Tokarev
16.04.2018 12:26, Peter Maydell wrote: > On 14 April 2018 at 15:27, Michael Tokarev wrote: >> -ifeq ($(CONFIG_GTK),m) >> +ifneq ($(filter $(CONFIG_GTK),y m),) >> $(MAKE) -C po $@ >> endif > "trivial" and "for 2.12" don't make much sense together at this point in > the release cycle. Is

Re: [Qemu-devel] [PATCH v4 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

2018-04-16 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Following a discussion on the mailing list: > > If a reader of this commit message could profit from reading the > discussion, refer to it by URL and/or Message-Id. If not, don't mention > it. > >>

Re: [Qemu-devel] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly

2018-04-16 Thread Marcel Apfelbaum
On 16/04/2018 2:43, Philippe Mathieu-Daudé wrote: > All files using "qemu/units.h" definitions already include it directly, > we can now remove it from "qemu/cutils.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/cutils.h | 1 - > hw/core/machine.c | 2 +- > 2 files change

Re: [Qemu-devel] [PATCH v3 32/41] hw/i386: Use the BYTE-based definitions

2018-04-16 Thread Marcel Apfelbaum
On 16/04/2018 2:42, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/i

Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 06:37 AM, Michael Tokarev wrote: > Fixes 722cd7496474cebb2218f21e038592fad8603365 > > Signed-off-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes

2018-04-16 Thread Philippe Mathieu-Daudé
Hi Thomas, On 04/16/2018 01:53 AM, Thomas Huth wrote: > On 16.04.2018 01:42, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/devices.h | 7 ++- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/include/hw/devices.h b/include/hw/

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Oleksandr Andrushchenko
On 04/16/2018 12:32 PM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko wrote: On 04/16/2018 10:43 AM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 201

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 05:56 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> These only need to be built for MIPS guests. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> tests/tcg/README | 11 --- >>> tests/tcg/mips/R

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 05:53 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 04/10/2018 04:39 PM, Alex Bennée wrote: >>> Now all the build infrastructure is in place we can build tests for >>> each guest that we support. That support mainly depends on having >>> cross compilers installe

Re: [Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 06:02 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Hi Alex, >> >> On 04/10/2018 04:38 PM, Alex Bennée wrote: >>> We should still be able to use the system cross compiler with the >>> appropriate flags on x86_64 hosts. >>> >>> Signed-off-by: Alex Bennée >>> --- >>

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-16 Thread Daniel P . Berrangé
On Fri, Apr 13, 2018 at 10:26:03PM +0300, Nir Soffer wrote: > When a management application expose images using qemu-nbd, it needs a > secure way to allow temporary access to the disk. Using a random export > name can solve this problem: > > nbd://server:10809/22965f19-9ab5-4d18-94e1-cbeb321fa

Re: [Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:38 PM, Alex Bennée wrote: > Hi, > > We've talked about fixing this up for a long time and there have been > several RFC patches sent attempting to do that. This is yet another > RFC but hopefully shows a way forward which can build on our docker > support but also allow users to s

Re: [Qemu-devel] [PATCH 2/4] configure: Display if libfdt is from system or git

2018-04-16 Thread Philippe Mathieu-Daudé
Hi Thomas, On 04/16/2018 02:16 AM, Thomas Huth wrote: > On 16.04.2018 01:05, Philippe Mathieu-Daudé wrote: >> The configure script outputs "yes" regardless which libfdt is used: >> >> ./configure >> [...] >> fdt support yes >> >> Sometimes you can have both system and local git version

Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-16 Thread Halil Pasic
On 04/16/2018 09:45 AM, Thomas Huth wrote: > "size_t" should be an unsigned type according to the C standard. > Thus we should also use this convention in the s390-ccw firmware to avoid > confusion. I checked the sources, and apart from one spot in libc.c, the > code should all be fine with this

Re: [Qemu-devel] [PULL 0/1] m68k fixes for 2.12-rc4

2018-04-16 Thread Peter Maydell
On 15 April 2018 at 10:46, Laurent Vivier wrote: > The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: > > Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu-m68k.git tags/m68k

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-16 Thread Richard W.M. Jones
On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: > Essentially this is abusing the export name as a crude authentication > token. There are NBD servers that expect NBD_OPT_LIST to always succeeed I guess you mean "NBD clients" ... > when they detect that the new style protocol

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 10:19, Andrew Jones wrote: > This is the cleaner choice, but I wasn't opposed to the max-vcpus > query getting double-duty though. While the backporting argument is > a good point, I'm not sure we've ever really cared about what > issues backporters have had to endure when they

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-16 Thread Daniel P . Berrangé
On Mon, Apr 16, 2018 at 11:53:41AM +0100, Richard W.M. Jones wrote: > On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: > > Essentially this is abusing the export name as a crude authentication > > token. There are NBD servers that expect NBD_OPT_LIST to always succeeed > > I gue

[Qemu-devel] [PATCH 1/3] accel: use g_strsplit for parsing accelerator names

2018-04-16 Thread Daniel P . Berrangé
Instead of re-using the get_opt_name() method from QemuOpts to split a string on ':', just use g_strsplit(). Signed-off-by: Daniel P. Berrangé --- accel/accel.c | 16 +++- include/qemu/option.h | 1 - util/qemu-option.c| 3 ++- 3 files changed, 9 insertions(+), 11 delet

[Qemu-devel] [PATCH 2/3] opts: don't silently truncate long parameter keys

2018-04-16 Thread Daniel P . Berrangé
The existing QemuOpts parsing code uses a fixed size 128 byte buffer for storing the parameter keys. If a key exceeded this size it was silently truncate and no error reported to the user. This behaviour was reasonable & harmless because traditionally the key names are all statically declared, and

[Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Daniel P . Berrangé
A user trying out SMBIOS "OEM strings" feature reported that the data they are exposing to the guest was truncated at 1023 bytes, which breaks the app consuming in the guest. After searching for the cause I eventually found that the QemuOpts parsing is using fixed length 1024 byte array for option

[Qemu-devel] [PATCH 3/3] opts: don't silently truncate long option values

2018-04-16 Thread Daniel P . Berrangé
The existing QemuOpts parsing code uses a fixed size 1024 byte buffer for storing the option values. If a value exceeded this size it was silently truncated and no error reported to the user. Long option values is not a common scenario, but it is conceivable that they will happen. eg if the user ha

Re: [Qemu-devel] [PATCH 1/3] accel: use g_strsplit for parsing accelerator names

2018-04-16 Thread Philippe Mathieu-Daudé
On 04/16/2018 08:17 AM, Daniel P. Berrangé wrote: > Instead of re-using the get_opt_name() method from QemuOpts to split a > string on ':', just use g_strsplit(). > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé > --- > accel/accel.c | 16 +++- > i

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
14.04.2018 00:06, John Snow wrote: On 04/13/2018 01:44 PM, Vladimir Sementsov-Ogievskiy wrote: will add, as always, thank you for natural rewording) Hm, I have a question: why do you often use double white-space "  " between sentences? Is it something meaningful? There is some GREAT DEBATE in

[Qemu-devel] [PATCH v2 for-2.13 0/7] Dirty bitmaps fixing and refactoring

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
v2: 05: drop bdrv_undo_clear_dirty_bitmap(), which becomes unused. Vladimir Sementsov-Ogievskiy (7): block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap dirty-bitmaps: fix comment about dirty_bitmap_mutex dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header dirt

[Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
Functions write to BdrvDirtyBitmap field, so the should take the lock. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 4 1 file changed, 4 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 967159479d..6c00288fd7 100644 --- a/block/dirty-bi

[Qemu-devel] [PATCH v2 3/7] dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h index 1ff8949b1b..c7e910016d 100644 --- a/include/block/dirty-bitmap.h +++ b/include/block/dirty-bitmap.h @@

[Qemu-devel] [PATCH v2 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
Clarify first two cases and fix Modify -> Any access in third case. Also, drop 'only' from third case, as it a bit confuses, when thinking about case where we modify BdrvDirtyBitmap and access HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 12 1

[Qemu-devel] [PATCH v2 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
Drop parameter "HBitmap **out" which is unused now, all callers set it to NULL. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 2 +- block/dirty-bitmap.c | 14 +- blockdev.c| 4 ++-- 3 files changed, 8 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
Separate them in the header and clarify needed locking in comments. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 14 +- block/dirty-bitmap.c | 5 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/block/dirty-bitma

[Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction commit, avoiding any rollback. After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 1 - block/dirty-bitmap.c | 9 -

[Qemu-devel] [PATCH v2 7/7] blockdev: unify block-dirty-bitmap-clear command and transaction action

2018-04-16 Thread Vladimir Sementsov-Ogievskiy
- use error messages from qmp command, as they are more descriptive - we need not check bs, as block_dirty_bitmap_lookup never returns bs = NULL on success (and if user set bs to be not NULL pointer), so, let's just assert it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c |

Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

2018-04-16 Thread Max Reitz
On 2018-04-06 17:17, Max Reitz wrote: > My non-Fedora testing system does not have a kernel with userfaultfd > support which causes 181 and 201 to fail. That is annoying. This > series makes those tests recognize the issue and convert it into a > _notrun. > > > Max Reitz (2): > iotests: Add f

Re: [Qemu-devel] [PATCH 0/3] Remove artificial length limits when parsing options

2018-04-16 Thread Paolo Bonzini
On 16/04/2018 13:17, Daniel P. Berrangé wrote: > A user trying out SMBIOS "OEM strings" feature reported that the data > they are exposing to the guest was truncated at 1023 bytes, which breaks > the app consuming in the guest. After searching for the cause I > eventually found that the QemuOpts pa

Re: [Qemu-devel] [PATCH] Show values and description when using "qom-list"

2018-04-16 Thread Perez Blanco, Ricardo (Nokia - BE/Antwerp)
Hi, A new patch (to be rebase on top of my previous one). From 77f7217c07d5e3892f26082f220954678eb375b3 Mon Sep 17 00:00:00 2001 From: Ricardo Perez Blanco Date: Mon, 16 Apr 2018 13:51:42 +0200 Subject: [PATCH] [PATCHv2] Show values and description when using "qom-list" For debugging purpo

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
Ok, confusion around backend is I think cleared up. The other confusion seems to be around dma-buf: dma-buf is the cross subsystem zerocopy abstraction. PRIME is the drm-specific support for it, 100% based on top of the generic struct dma_buf. You need a dma_buf exporter to convert a xen grant re

Re: [Qemu-devel] [PATCH] Implement query-usbhost QMP command

2018-04-16 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1523675125-14022-1-git-send-email-...@godking.net Subject: [Qemu-devel] [PATCH] Implement

Re: [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 14:55, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence increase the limit to 1 Mi

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-04-16 Thread Thomas Huth
On 14.04.2018 00:08, Collin Walling wrote: > Rename the loadparm char array in main.c to loadparm_str and > increased the size by one byte to account for a null termination > when converting the loadparm string to an int via atoui. We > also allow the boot menu to be enabled when loadparm is set t

Re: [Qemu-devel] [PATCH v11 02/17] hw/arm/smmu-common: IOMMU memory region and address space setup

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > We set up the infrastructure to enumerate all the PCI devices > attached to the SMMU and create an associated IOMMU memory > region and address space. > > Those info are stored in SMMUDevice objects. The devices are > grouped according to the PCIBus t

[Qemu-devel] [PULL 1/2] qcow2: try load bitmaps only once

2018-04-16 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Checking reopen by existence of some bitmaps is wrong, as it may be some other bitmaps, or on the other hand, user may remove bitmaps. This criteria is bad. To simplify things and make behavior more predictable let's just add a flag to remember, that we've alrea

[Qemu-devel] [PULL 0/2] Block patches for 2.12.0-rc4

2018-04-16 Thread Max Reitz
The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 10:11:17 +0100) are available in the Git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2018-

[Qemu-devel] [PULL 2/2] iotests: fix 169

2018-04-16 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Improve and fix 169: - use MIGRATION events instead of RESUME - make a TODO: enable dirty-bitmaps capability for offline case - recreate vm_b without -incoming near test end This (likely) fixes racy faults at least of the following types: - tim

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-16 Thread Bastian Koppelmann
On 04/13/2018 05:29 PM, Peter Maydell wrote: > On 13 April 2018 at 16:24, Bastian Koppelmann > wrote: >> However, my risu-like tests found another flag raising problem with >> float32_div. I'll investigate it on Monday. I found the problem. With float32_div(a, b), if a is inf and b is not inf we

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-16 Thread David Lechner
I am seeing the same symptoms as the original poster. I'm building the opencv package in a debian stretch armfh chroot on a ubuntu bionic amd64 host. So, I'm guessing that the race condition wasn't entirely fixed or there has been some sort of regression. -- You received this bug notification bec

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-16 Thread David Lechner
Steps to reproduce: # on ubuntu bionic amd64 host sudo apt-add-repository ppa:ev3dev/tools # assuming apt-add-repository does apt update now sudo apt install pbuilder-ev3dev git git clone --depth=1 https://github.com/ev3dev/opencv cd opencv OS=debian ARCH=armhf DIST=stretch pbuilder-ev3dev base OS

Re: [Qemu-devel] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu

2018-04-16 Thread Janosch Frank
On 14.04.2018 00:08, Collin Walling wrote: > Change Log: > > v2 > > - added r-b's > - s/zipl_println/zipl_print_entry > - prints entry and returns entry number > - while loop now handles valid_entries Series reviewed-by: Janosch Frank > > These patches

Re: [Qemu-devel] [PATCH v11 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > This patch implements the page table walk for VMSAv8-64. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mallappa > diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c > index 9a966bb..6a58948 100644 > --- a/hw/arm/smmu-common.c > +++ b/hw

Re: [Qemu-devel] [PATCH v11 04/17] hw/arm/smmuv3: Skeleton

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > From: Prem Mallappa > > This patch implements a skeleton for the smmuv3 device. > Datatypes and register definitions are introduced. The MMIO > region, the interrupts and the queue are initialized. > > Only the MMIO read operation is implemented here

Re: [Qemu-devel] [PATCH v11 05/17] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-04-16 Thread Peter Maydell
On 12 April 2018 at 08:37, Eric Auger wrote: > We introduce some helpers to handle wired IRQs and especially > GERROR interrupt. SMMU writes GERROR register on GERROR event > and SW acks GERROR interrupts by setting GERRORn. > > The Wired interrupts are edge sensitive hence the pulse usage. > > Si

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-16 Thread Igor Mammedov
On Thu, 12 Apr 2018 11:15:04 +0200 Paolo Bonzini wrote: > On 29/03/2018 05:21, Alexey Kardashevskiy wrote: > > +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, > > TYPE_DEVICE); > > +const char *id = object_property_print(obj, "id", true, NULL); > > I learnt now about comm

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-16 Thread Paolo Bonzini
On 16/04/2018 15:20, Igor Mammedov wrote: > Generally object doesn't need to know its own name, > we use it only for debugging and nice error reporting so far. > I'd rather have 'id' property at Object level so we won't have > to fish out ID from parent /which we aren't supposed to do and > which d

[Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-16 Thread Alex Bennée
The re-factoring of div_floats changed the order of checking meaning an operation like -inf/0 erroneously raises the divbyzero flag. IEEE-754 (2008) specifies this should only occur for operations on finite operands. We fix this by moving the check on the dividend being Inf/0 to before the divisor

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-04-16 Thread Alberto Garcia
On Fri 13 Apr 2018 05:00:48 PM CEST, Max Reitz wrote: > On 2018-03-14 09:29, Alberto Garcia wrote: >> The L2 and refcount caches have default sizes that can be overridden >> using the l2-cache-size and refcount-cache-size (an additional >> parameter named cache-size sets the combined size of both c

[Qemu-devel] [RFC PATCH] target/arm: support reading of CNTVCT_EL0 from user-space

2018-04-16 Thread Alex Bennée
Since kernel commit a86bd139f2 (arm64: arch_timer: Enable CNTVCT_EL0 trap..) user-space has been able to read this system register. This patch enables access to that register although currently it always returns 0 as we don't yet have a mechanism for managing timers in linux-user mode. Signed-off-

  1   2   3   >