[Qemu-devel] [Bug 1182344] Re: ARM: invalid code execution after subs instruction

2013-05-21 Thread Peter Maydell
Can you attach or provide a link to your app.exe test case? Otherwise this is going to be harder to track down and test. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1182344 Title: ARM:

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Peter Maydell
On 21 May 2013 09:19, Li Zhang zhlci...@gmail.com wrote: We encounter this problem in openstack which always use default machine type. Currently, QEMU sets mac99 as default setting for ppc64 but it doesn't work on our platform at all. I tried to fix this in libvirt which it is not acceptable

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Peter Maydell
On 21 May 2013 09:39, Daniel P. Berrange berra...@redhat.com wrote: Libvirt has always had support for specifying what machine type to use. This discussion is simply about what machine type to default to, if the user hasn't explicitly asked for one. QEMU has the notion of a default machine

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Peter Maydell
On 21 May 2013 10:02, Li Zhang zhlci...@gmail.com wrote: On 2013年05月21日 16:45, Peter Maydell wrote: On 21 May 2013 09:39, Daniel P. Berrange berra...@redhat.com wrote: Libvirt has always had support for specifying what machine type to use. OK, that makes sense. So is the problem here just

Re: [Qemu-devel] [PATCH arm-devs v1 1/5] sd/sd.c: Fix inquiry ACMD41

2013-05-21 Thread Peter Maydell
the command to be responsive when in the ready state accordingly. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH arm-devs v1 4/5] sd/sdhci.c: Fix bdata_read DPRINT message

2013-05-21 Thread Peter Maydell
similar messages in this module. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:01, Daniel P. Berrange berra...@redhat.com wrote: On Tue, May 21, 2013 at 07:55:27PM +1000, Paul Mackerras wrote: I think libvirt needs some more sensible way to ask qemu what its capabilities are. Currently it has no way to ask qemu what machines can you emulate with kvm

Re: [Qemu-devel] [PATCH 01/30] exec: remove obsolete comment

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org (I'm

Re: [Qemu-devel] [PATCH 02/30] exec: eliminate qemu_put_ram_ptr

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 03/30] exec: make qemu_get_ram_ptr private

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: It is a private interface between exec.c and memory.c. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 07/30] memory: Replace open-coded memory_region_is_romd

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: From: Jan Kiszka jan.kis...@siemens.com Improves readability. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org for about the third time. -- PMM

Re: [Qemu-devel] [PATCH 09/30] memory: do not duplicate memory_region_destructor_none

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 10/30] memory: make memory_global_sync_dirty_bitmap take an AddressSpace

2013-05-21 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: Suggested-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 11/30] memory: fix address space initialization/destruction

2013-05-21 Thread Peter Maydell
Kivity avi.kiv...@gmail.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 13/30] memory: limit sections in the radix tree to the actual address space size

2013-05-21 Thread Peter Maydell
-by: Avi Kivity avi.kiv...@gmail.com [ Fail the build if TARGET_PHYS_ADDR_SPACE_BITS is too large - Paolo ] Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address spaces

2013-05-21 Thread Peter Maydell
not be empty at the time the IOMMU is created. Signed-off-by: Paolo Bonzini pbonz...@redhat.com The patch title should probably be populate FlatView for new address spaces, not create. Given that, Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Peter Maydell
On 21 May 2013 13:04, Anthony Liguori anth...@codemonkey.ws wrote: We've talked in the past about having an accelerator specific machine default. I think this is a perfectly reasonable thing to do and would solve the problem for ARM and for PPC. For ARM I would prefer not to have a default at

Re: [Qemu-devel] [RFC PATCH v3 01/11] configure: Support configuring c++ compiler

2013-05-21 Thread Peter Maydell
On 21 May 2013 16:33, Tomoki Sekiyama tomoki.sekiy...@hds.com wrote: Add configuration for c++ compiler (${corss_prefix}g++ as default) in configure and Makefiles. I think you should follow the same logic we use for picking the C compiler, so that we use 'c++' rather than 'g++' if cross_prefix

Re: [Qemu-devel] (Another) 1.4.1 - 1.5.0 migration failure

2013-05-21 Thread Peter Maydell
On 21 May 2013 18:26, mdroth mdr...@linux.vnet.ibm.com wrote: static const VMStateDescription vmstate_i6300esb = { .name = i6300esb_wdt, .version_id = sizeof(I6300State), .minimum_version_id = sizeof(I6300State), .minimum_version_id_old = sizeof(I6300State), apparently

Re: [Qemu-devel] (Another) 1.4.1 - 1.5.0 migration failure

2013-05-21 Thread Peter Maydell
On 21 May 2013 21:43, mdroth mdr...@linux.vnet.ibm.com wrote: Makes sense, but apparently version IDs for incoming device state are not allowed to exceed the destination's version, so we can't bump it beyond the value in 1.5 without breaking migration from 1.5+ - 1.5 We care about backwards

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-21 Thread Peter Maydell
On 21 May 2013 22:46, Michael S. Tsirkin m...@redhat.com wrote: Once in a while make gets killed and doesn't clean up partial object files after it. Result is nasty errors from link. This hack checks object is well formed before linking, and rebuilds it if not. Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH v1 1/1] configure: Probe for libfdt_env.h

2013-05-22 Thread Peter Maydell
On 22 May 2013 08:47, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Wed, May 22, 2013 at 11:50:22AM +1000, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Currently QEMU provides a local clone of the file libfdt_env.h in /include. This file is

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Peter Maydell
On 22 May 2013 09:37, Michael S. Tsirkin m...@redhat.com wrote: It's my fault for running -rc kernels all the time I guess, I get crashes kind of often, and losing more time on make clean on top of reboot annoys me. But we actually could make it robust, even against OS crash. Output to a

Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors

2013-05-22 Thread Peter Maydell
On 22 May 2013 11:38, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...) vfprintf(qemu_logfile, fmt, ap); } va_end(ap); + +/* + * Break the GDB session (if

[Qemu-devel] [Bug 1182344] Re: ARM: invalid code execution after subs instruction

2013-05-22 Thread Peter Maydell
I did a bit of digging, and the reason that QEMU is not taking the branch is that when control returns from the exception handler the CPSR ITSTATE fields are non-zero. This means that the branch instruction is UNPREDICTABLE (and therefore falling through is architecturally valid behaviour for QEMU

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Peter Maydell
On 22 May 2013 14:12, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I would much prefer it if we autogenerated this list so you didn't need to change this file at all to add a new target, but Anthony is against that; so this is at least

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Peter Maydell
On 22 May 2013 14:15, Anthony Liguori aligu...@us.ibm.com wrote: Paolo Bonzini pbonz...@redhat.com writes: You don't need to know what targets were supported in the version that you compiled from. Only one target is supported in this executable anyway. It seems useful to me. One day we

Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line)

2013-05-22 Thread Peter Maydell
On 22 May 2013 15:48, Anthony Liguori aligu...@us.ibm.com wrote: Andreas Färber afaer...@suse.de writes: Am 22.05.2013 16:28, schrieb Anthony Liguori: So are incompletely implemented targets (wrt instruction set) eligible for upstream these days? Aren't most of our target incomplete by some

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread Peter Maydell
On 23 May 2013 09:35, li guang lig.f...@cn.fujitsu.com wrote: ping ... again. misc_check_helper is still a terrible function name. -- PMM

[Qemu-devel] [PATCH 04/10] target-arm: Remove uses of gen_{ld, st}* from Neon code

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 7ce9a1c..057b180 100644 --- a/target-arm

[Qemu-devel] [PATCH 00/10] target-arm: fix TCGv usage (AArch64 prep)

2013-05-23 Thread Peter Maydell
-tested. I include it in this series because it completes the work that patch 1 starts, and as motivation/indication of direction. Peter Maydell (10): target-arm: Don't use TCGv when we mean TCGv_i32 target-arm: Remove gen_ld64() and gen_st64() target-arm: Remove uses of gen_{ld,st}* from iWMMXt

[Qemu-devel] [PATCH 05/10] target-arm: Remove use of gen_{ld, st}* from ldrex/strex

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 057b180..3899d0a 100644 --- a/target-arm/translate.c +++ b

[Qemu-devel] [PATCH 01/10] target-arm: Don't use TCGv when we mean TCGv_i32

2013-05-23 Thread Peter Maydell
building the 32 bit code for AArch64. Those changes will be in a separate patch for easier review. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 453 1 file changed, 229 insertions(+), 224 deletions(-) diff --git

[Qemu-devel] [PATCH 06/10] target-arm: Remove gen_{ld, st}* from basic ARM insns

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 101 +--- 1 file changed, 69 insertions(+), 32 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 3899d0a..e5a2e4c 100644 --- a/target-arm

[Qemu-devel] [PATCH 07/10] target-arm: Remove gen_{ld, st}* from Thumb insns

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 71 +++- 1 file changed, 46 insertions(+), 25 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index e5a2e4c..953c5fb 100644 --- a/target-arm

[Qemu-devel] [PATCH 08/10] target-arm: Remove gen_{ld, st}* from thumb2 decoder

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 953c5fb..0ca68fe 100644 --- a/target-arm/translate.c +++ b

[Qemu-devel] [PATCH 10/10] target-arm: Abstract out load/store from a vaddr in AArch32

2013-05-23 Thread Peter Maydell
and the extension/truncation of the data value. Apart from the function definitions most of this patch is a simple s/tcg_gen_qemu_/gen_aa32_/. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 309 ++-- 1 file changed

[Qemu-devel] [PATCH 02/10] target-arm: Remove gen_ld64() and gen_st64()

2013-05-23 Thread Peter Maydell
gen_ld64() and gen_st64() are used only in one place, so just expand them out. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/target-arm/translate.c b/target-arm

[Qemu-devel] [PATCH 09/10] target-arm: Remove gen_{ld, st}* definitions

2013-05-23 Thread Peter Maydell
All the uses of the gen_{ld,st}* functions are gone now, so remove the functions themselves. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 46 -- 1 file changed, 46 deletions(-) diff --git a/target-arm

[Qemu-devel] [PATCH 03/10] target-arm: Remove uses of gen_{ld, st}* from iWMMXt code

2013-05-23 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 8e46527..7ce9a1c 100644 --- a/target-arm/translate.c +++ b/target-arm

Re: [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG target VERSION 2

2013-05-23 Thread Peter Maydell
On 23 May 2013 13:37, Andreas Färber afaer...@suse.de wrote: If Big Endian targets are not yet supported, should this rather be an RFC? Or is that just about some unimplemented opcodes? I'm happy for us to wait until an actual big-endian system running Linux appears before we worry about it.

Re: [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG target VERSION 2

2013-05-23 Thread Peter Maydell
On 23 May 2013 13:53, Andreas Färber afaer...@suse.de wrote: Am 23.05.2013 14:50, schrieb Peter Maydell: I'm happy for us to wait until an actual big-endian system running Linux appears before we worry about it. I was worried about Big Endian QEMU targets (ppc, sparc, etc.), not about Big

Re: [Qemu-devel] [PATCH 1/4] include/elf.h: add aarch64 ELF machine and relocs

2013-05-23 Thread Peter Maydell
On 23 May 2013 09:14, Claudio Fontana claudio.font...@huawei.com wrote: we will use the 26bit relative relocs in the aarch64 tcg target. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 3/4] configure: permit compilation on arm aarch64

2013-05-23 Thread Peter Maydell
On 23 May 2013 09:19, Claudio Fontana claudio.font...@huawei.com wrote: support compiling on aarch64. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 00/10] virtio: import headers from linux

2013-05-23 Thread Peter Maydell
On 23 May 2013 15:34, Michael S. Tsirkin m...@redhat.com wrote: I'm working on adding new virtio layout to qemu. The job is complicated by the fact that qemu has its own copy of the virtio headers, sometimes with slightly different names and structure. Import headers from linux instead. Do

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-23 Thread Peter Maydell
On 23 May 2013 09:18, Claudio Fontana claudio.font...@huawei.com wrote: add preliminary support for TCG target aarch64. Richard's handling the technical bits of the review, so just some minor style nits here. I tested this on the foundation model and was able to boot a 32-bit-ARM kernel.

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-23 Thread Peter Maydell
On 23 May 2013 18:08, Paolo Bonzini pbonz...@redhat.com wrote: BTW, if you give me your Tested-by it would be good, since most comments have been cosmetic. I'd like to collect all of Peter's Reviewed-by from the RFC and send a pull request next week. There's been at least one requested fix in

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: It is not used anywhere. So does this get deleted just because it's not used, or because it gets in the way of patches later in the series. As far as I can tell the st*_phys_notdirty() are for TCG to update page table entries with

Re: [Qemu-devel] [PATCH 05/30] memory: assert that PhysPageEntry's ptr does not overflow

2013-05-23 Thread Peter Maydell
(phys_sections_nb_alloc * 2, 16); phys_sections = g_renew(MemoryRegionSection, phys_sections, Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 06/30] memory: allow memory_region_find() to run on non-root memory regions

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: memory_region_find() is similar to registering a MemoryListener and checking for the MemoryRegionSections that come from a particular region. There is no reason for this to be limited to a root memory region. Signed-off-by:

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: +bool address_space_valid(AddressSpace *as, hwaddr addr, int len, bool is_write) +{ +AddressSpaceDispatch *d = as-dispatch; +MemoryRegionSection *section; +int l; +hwaddr page; + +while (len 0) { +

Re: [Qemu-devel] [PATCH 16/30] memory: clean up phys_page_find

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: Remove the goto. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-23 Thread Peter Maydell
point where IOMMU forwarding is implemented. Signed-off-by: Paolo Bonzini pbonz...@redhat.com 4 overlength lines in this patch. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 18/30] memory: add return value to address_space_rw/read/write

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 19/30] memory: Introduce address_space_lookup_region

2013-05-23 Thread Peter Maydell
we introduce BQL-free dispatching. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 20/30] memory: iommu support

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: From: Avi Kivity avi.kiv...@gmail.com Add a new memory region type that translates addresses it is given, then forwards them to a target address space. This is similar to an alias, except that the mapping is more flexible than a

Re: [Qemu-devel] [PATCH 26/30] dma: eliminate old-style IOMMU support

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: The translate function in the DMAContext is now always NULL. Remove every reference to it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com More long lines. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: From: David Gibson da...@gibson.dropbear.id.au This patch adds a NotifierList to MemoryRegions which represent IOMMUs allowing other parts of the code to register interest in mappings or unmappings from the IOMMU. All IOMMU

Re: [Qemu-devel] [PATCH 27/30] pci: use memory core for iommu support

2013-05-23 Thread Peter Maydell
] Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Paolo Bonzini pbonz...@redhat.com More 80column excesses. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 29/30] dma: eliminate DMAContext

2013-05-23 Thread Peter Maydell
pbonz...@redhat.com Hey look, checkpatch is complaining again. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 30/30] memory: give name to every AddressSpace

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: From: Alexey Kardashevskiy a...@ozlabs.ru The info mtree command in QEMU console prints only memory and I/O address spaces while there are actually a lot more other AddressSpace structs created by PCI and VIO devices. Those

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-23 Thread Peter Maydell
On 23 May 2013 18:25, Peter Maydell peter.mayd...@linaro.org wrote: I'll have a look at the remaining patches now. ...and done. I haven't reviewed the spapr specific stuff, on the assumption that somebody familiar with that h/w will do so. thanks -- PMM

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Peter Maydell
On 23 May 2013 20:22, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 19:32, Peter Maydell ha scritto: On 21 May 2013 11:57, Paolo Bonzini pbonz...@redhat.com wrote: It is not used anywhere. So does this get deleted just because it's not used, or because it gets in the way of patches

Re: [Qemu-devel] [PATCH arm-devs v2 5/5] sd/sd.c: Fix inquiry ACMD41

2013-05-24 Thread Peter Maydell
On 24 May 2013 06:18, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com QEMU models two (of the three) ACMD41 has two modes, inquiry and first. The selection logic for which of the two is incorrect - it compares != 0 for the entire argument value rather

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Peter Maydell
return, break, continue, goto or throw statements are unnecessary. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 07:13, Jan Kiszka jan.kis...@web.de wrote: I'll also have a use for it: replace isa_is_ioport_assigned. That seems like it's something different: it's asking has some other bit of QEMU registered a handler for this ioport?, not at this moment in time if I make an I/O access will

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 09:02, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 20:04, Peter Maydell ha scritto: Shouldn't we be calling the MemoryRegionOps accepts() callback here? What about access alignment constraints and access size restrictions? Yes, we should. What if the validity

Re: [Qemu-devel] [PATCH arm-devs v4 00/15] Xilinx SPIPS fixes round 2

2013-05-24 Thread Peter Maydell
On 21 May 2013 07:28, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by a number of bugs/incompletnesses found by some (very) rigourous test vectors. Thanks; applied all to

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 13:58, Paolo Bonzini pbonz...@redhat.com wrote: If it's okay for you, I'll send a pull request up to memory: clean up phys_page_find and go on with the next series. That's fine with me, but please don't forget to fix up the doc comment for memory_region_find() (see comments on

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-24 Thread Peter Maydell
On 24 May 2013 14:33, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/05/2013 15:27, Peter Maydell ha scritto: On 24 May 2013 13:58, Paolo Bonzini pbonz...@redhat.com wrote: If it's okay for you, I'll send a pull request up to memory: clean up phys_page_find and go on with the next series

Re: [Qemu-devel] [PATCH arm-devs v2 0/5] SD and SDHCI Fixes

2013-05-24 Thread Peter Maydell
On 24 May 2013 06:14, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Fixes found in SD and SDHCI found doing some corner case testing. Changed from v1: Corrected ACMD41 patch. Moved ACMD41 patch to back of series. Patches 1-4 (but not the ACMD41

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-05-24 Thread Peter Maydell
On 22 April 2013 05:45, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini pbonz...@redhat.com wrote: libfdt is not that portable, it doesn't use libtool to build shared libraries. Perhaps we can just build the static library? Seems

Re: [Qemu-devel] [PATCH] i.MX: split GPT and EPIT timer implementation

2013-05-24 Thread Peter Maydell
On 19 May 2013 20:03, Jean-Christophe DUBOIS j...@tribudubois.net wrote: There is no common code between these 2 timer implementation. So it is better to split them. Signed-off-by: Jean-Christophe DUBOIS j...@tribudubois.net Thanks, applied to arm-devs.next. -- PMM

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-05-24 Thread Peter Maydell
On 24 May 2013 15:33, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Fri, May 24, 2013 at 03:16:00PM +0100, Peter Maydell wrote: Hi -- can you point me at the fix? Did it get committed? I did a search of my mail archives but couldn't find anything that looked like it. (I'm looking

[Qemu-devel] [PATCH 3/4] microblaze: Remove CONFIG_FDT conditionals

2013-05-24 Thread Peter Maydell
Now that we know we're compiling with libfdt we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/microblaze/boot.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c index e543d88

Re: [Qemu-devel] [PATCH 10/10] target-arm: Abstract out load/store from a vaddr in AArch32

2013-05-24 Thread Peter Maydell
On 23 May 2013 13:00, Peter Maydell peter.mayd...@linaro.org wrote: +#define DO_GEN_ST(OP)\ +static inline void gen_aa32_##OP(TCGv_i32 val, TCGv_i32 addr, int index

[Qemu-devel] [PATCH 0/4] Require libfdt for arm/microblaze/ppc softmmu targets

2013-05-24 Thread Peter Maydell
users to build less-than-useful binaries. NB: I have tested the ARM change, but only compile-tested PPC and MicroBlaze. Peter Maydell (4): configure: Require libfdt for arm, ppc, microblaze softmmu targets arm: Remove CONFIG_FDT conditionals microblaze: Remove CONFIG_FDT conditionals ppc

[Qemu-devel] [PATCH 4/4] ppc: Remove CONFIG_FDT conditionals

2013-05-24 Thread Peter Maydell
Now that we know we're compiling with libfdt we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- default-configs/ppc-softmmu.mak|2 +- default-configs/ppc64-softmmu.mak |4 ++-- default-configs/ppcemb-softmmu.mak |2 +- hw/ppc

[Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc, microblaze softmmu targets

2013-05-24 Thread Peter Maydell
A number of our softmmu targets (PPC, ARM, Microblaze) now more or less require flattened device tree support for various board models to work correctly. Make libfdt mandatory if the target list includes these, rather than building unhelpful half-functional binaries. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 2/4] arm: Remove CONFIG_FDT conditionals

2013-05-24 Thread Peter Maydell
Now that we know we're compiling with libfdt, we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm/boot.c |7 --- 1 file changed, 7 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index f451529..defcf15 100644 --- a/hw/arm

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-24 Thread Peter Maydell
On 24 May 2013 18:02, Richard Henderson r...@twiddle.net wrote: On 05/24/2013 01:53 AM, Claudio Fontana wrote: We use FP to point to the callee_saved registers, and to move to/from them in the tcg_out_store_pair and tcg_out_load_pair functions. I hadn't noticed you'd hard-coded FP into the

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-24 Thread Peter Maydell
On 24 May 2013 18:17, Richard Henderson r...@twiddle.net wrote: On 05/24/2013 10:08 AM, Peter Maydell wrote: Where's the waste? The procedure calling standard mandates that we set FP up, so it's not like we can use it as a general purpose register anywhere. Well, the calling standard

Re: [Qemu-devel] [libvirt] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-25 Thread Peter Maydell
On 24 May 2013 22:38, Eric Blake ebl...@redhat.com wrote: I think knowing the architecture (such as x86 vs. pseries ppc) is used by libvirt to know what default devices the board supports (for example, whether usb is present by default). ...but this is a per-board question, since (for

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-25 Thread Peter Maydell
On 25 May 2013 04:44, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, May 24, 2013 at 11:52:17AM +0100, Peter Maydell wrote: So when *is* it a good idea to use this API? In real hardware you don't usually get a tell me whether this access would succeed if I did it bus operation -- you

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-26 Thread Peter Maydell
On 26 May 2013 08:35, Michael S. Tsirkin m...@redhat.com wrote: On Sat, May 25, 2013 at 05:32:24PM +, Blue Swirl wrote: Another way to handle this would be to enhance GCC and linker to use atomic operations when producing or combining object files. The tools could also print a SHA of the

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-26 Thread Peter Maydell
On 26 May 2013 06:40, Lior Vernia liorv...@gmail.com wrote: Sorry, right after I wrote the message it occured to me I should have mentioned that I was talking about qemu-system, either x86 or i386. At the moment I just ran the limbo app on a Galaxy SIII with various images, just to see the

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-26 Thread Peter Maydell
On 26 May 2013 10:58, Gleb Natapov g...@redhat.com wrote: Actually here is an example of Starcraft running in android on ARM in full speed: http://forum.xda-developers.com/showthread.php?p=39009939 Search more about winulator. Yes; that seems to also be taking the path of going specifically

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-26 Thread Peter Maydell
On 26 May 2013 13:31, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 10:12:21AM +0100, Peter Maydell wrote: I definitely think individual project makefiles are the wrong place to fix this. If create-as-temp-and-rename is useful functionality it needs to go in the compiler so

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Peter Maydell
On 26 May 2013 16:22, Michael S. Tsirkin m...@redhat.com wrote: virtio linux headers are actually pretty portable: all we need is implement linux/types.h in a portable way, and we can import them and use on any platform. These patches do exactly that, as a pre-requisite to adding support for

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-26 Thread Peter Maydell
On 26 May 2013 18:51, Michael S. Tsirkin m...@redhat.com wrote: On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: This series breaks compilation on MacOSX: CCnet/eth.o In file included from net/eth.c:18: In file included from /Users/pm215/src/qemu/include/net/eth.h:29

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Peter Maydell
On 26 May 2013 19:10, Michael S. Tsirkin m...@redhat.com wrote: Ouch. Forgot to git-add them. Thanks. I'll send a fixed version - could you please try this patch on top? With this extra patch MacOSX compiles. thanks -- PMM

Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile

2013-05-27 Thread Peter Maydell
On 27 May 2013 07:13, Alexey Kardashevskiy a...@ozlabs.ru wrote: QEMU uses headers from source directory, however the asm symlink was created in the build directory what broke KVM stuff compilation. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- configure |2 +- 1 file changed,

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-27 Thread Peter Maydell
On 27 May 2013 09:19, Paolo Bonzini pbonz...@redhat.com wrote: Il 27/05/2013 09:23, Jan Kiszka ha scritto: Err, why? Will we emulate IOMMUs for TCG differently? Because IOMMUs should never be added to address_space_memory. TCG should only encounter an IOMMU during device emulation (DMA), not

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-27 Thread Peter Maydell
On 27 May 2013 10:10, Claudio Fontana claudio.font...@huawei.com wrote: Would it be acceptable to put a comment at the beginning of the function describing ext use, to avoiding a series of /* fall through */ comments? The 'fall through' comments are for the benefit of automatic checking and

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-27 Thread Peter Maydell
On 27 May 2013 11:45, Paolo Bonzini pbonz...@redhat.com wrote: It is possible to do it. As in other cases, I prefer no code to untested code. The design is sane (it isn't mine, so I can say it :)) and we know it can be done. Agreed; we're a long way from being able to make use of this.

Re: [Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc, microblaze softmmu targets

2013-05-28 Thread Peter Maydell
On 28 May 2013 10:03, Andreas Färber afaer...@suse.de wrote: Am 24.05.2013 17:26, schrieb Peter Maydell: +# fdt support is mandatory for at least some target architectures, +# so insist on it if we're building those system emulators. +fdt_required=no +for target in $target_list; do + case

Re: [Qemu-devel] should qemu-palcode git submodule be hosted on git.qemu.org?

2013-05-28 Thread Peter Maydell
On 23 April 2013 19:35, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I thought that our git submodules were all supposed to be hosted on git.qemu.org, or does that only apply to the ones which have sources we use to generate binary blobs we ship

Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8

2013-05-28 Thread Peter Maydell
Ping again! This patchset has now been on the list for eleven weeks without any review. thanks -- PMM On 2 May 2013 11:29, Peter Maydell peter.mayd...@linaro.org wrote: Ping! -- PMM On 22 April 2013 21:29, Peter Maydell peter.mayd...@linaro.org wrote: These patches fix various compiler

Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8

2013-05-28 Thread Peter Maydell
On 28 May 2013 18:22, Andreas Färber andreas.faer...@web.de wrote: I've looked at the patches today seeing the ping and they look fine - I wasn't properly CC'ed before (get_maintainer.pl would've spared the typo!) and so they were simply not in my mailbox. Augh, sorry -- no idea where that

Re: [Qemu-devel] [PATCH 3/4] main: use TARGET_ARCH only for the target-specific #define

2013-05-28 Thread Peter Maydell
On 27 May 2013 12:34, Paolo Bonzini pbonz...@redhat.com wrote: Everything else needs to match the executable name, which is TARGET_NAME. Before: $ sh4eb-linux-user/qemu-sh4eb --help usage: qemu-sh4 [options] program [arguments...] Linux CPU emulator (compiled for sh4 emulation)

  1   2   3   4   5   6   7   8   9   10   >