Question about setting up Default Reviewers

If we want person A to review all the changes made to any class of in directory D, but also want person B to review changes made to a particular class C1 in D, how should we define the default reviewers? Would the followings work? Or only the first matched reviewer will be picked? * Default

Question about customizing the diff view

I noticed that the lines in the diff view are automatically wrapped at the boundary of the browser windows. Is there a way to turn off the wrapping, and allow people to use horizontal scroll bar to control what is shown on the screen? --~--~-~--~~~---~--~~ You

Expand broken since 1.0.3?

Hello everyone, can somebody confirm my observation that clicking on any of the Expand hyperlinks (to expand collapsed source code sections) in the RB diff viewer no longer works with 1.0.3? Thanks, Thilo --~--~-~--~~~---~--~~ You received this message because

Re: Expand broken since 1.0.3?

On Fri, Sep 25, 2009 at 17:31, Thilo-Alexander Ginkel th...@ginkel.comwrote: can somebody confirm my observation that clicking on any of the Expand hyperlinks (to expand collapsed source code sections) in the RB diff viewer no longer works with 1.0.3? Just a brief update: The root cause

how to review code files that are not in repository yet

Is there any way to create review request for code files that are not added into CVS repository yet? I would like to be able to send review requests for classes that I am writing first time and not yet added into CVS. thanks, Deniz --~--~-~--~~~---~--~~ You

Re: Expand broken since 1.0.3?

Correct. The Expand links that expand individual files is not working correctly. Expand All seems to work however... -Tom On Fri, Sep 25, 2009 at 10:35 AM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Fri, Sep 25, 2009 at 17:31, Thilo-Alexander Ginkel th...@ginkel.comwrote: can

Re: Question about setting up Default Reviewers

Hi, You can have as many default reviewers as you need, covering redundant parts of the codebase or referencing the same people/groups multiple times. The setup you described should work fine. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org

Re: Expand broken since 1.0.3?

This is a standard diff, not an interdiff? Would you mind filing a bug for tracking purposes? We'll get it into 1.0.4. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 8:35 AM,

Re: Question about customizing the diff view

Hi, There is not, at least not within Review Board. You would have to write some custom CSS rules and either modify the bundled stylesheets (which would be overwritten on the next upgrade), or have people use a browser extension to reference custom CSS rules (but that' sa lot of

Re: how to review code files that are not in repository yet

You just need to cvs add these files and then generate a diff. This model (pre-commit reviews) are actually the model we had in mind when writing Review Board. We highly recommend using post-review for diff generation and uploading. It will make life much easier. You can get this by:

Re: Expand broken since 1.0.3?

On Friday 25 September 2009 21:38:35 Christian Hammond wrote: This is a standard diff, not an interdiff? Yes, it's a standard diff. One interesting thing is that for requests created prior to 1.0.3 the fragment expansion still seems to work (I just tried a couple of requests, though). Only

Re: Expand broken since 1.0.3?

Were you trying to expand a diff that was still attached to a draft of a review request? Or was it actually a published diff visible to everyone? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep

Re: Expand broken since 1.0.3?

On Friday 25 September 2009 22:11:01 Christian Hammond wrote: Were you trying to expand a diff that was still attached to a draft of a review request? Or was it actually a published diff visible to everyone? It was a published diff visible to everyone (actually a colleague pointed me to the

Re: Expand broken since 1.0.3?

That's odd.. I'll try to reproduce that tonight or this weekend. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 1:19 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Friday 25

Re: how to review code files that are not in repository yet

Thank you, Christian. I tried cvs add but then I got the following result: cvs diff: file_name is a new entry, no comparison available I am trying review board for facilitating our code review practice. We have a primitive mechanism around cvs and bugzilla for post-commit reviews but we do not

Re: Question about customizing the diff view

I think we have a solution. IE doesn't wrap the lines, but Firefox does. Not sure which one is doing the right thing. At least we have a choice. On Sep 25, 2:39 pm, Christian Hammond chip...@chipx86.com wrote: Hi, There is not, at least not within Review Board. You would have to write some

Re: Question about customizing the diff view

Technically I believe IE is wrong here, but that works. If you want to file a feature request for a preference to enable/disable wrapping, we can discuss how we might go about it. I can't say right now what we'll do with it, or how we'd implement it because, to be honest, this is the first time

Re: how to review code files that are not in repository yet

Yeah, sounds like a bug in the CVS support. If you can figure out what's causing it and contribute a fix, that would help. I won't be able to look at it for a little while. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. -

Re: how to review code files that are not in repository yet

You being Deniz, not Chris, unless Chris wants to take this on too. :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Sep 25, 2009 at 3:17 PM, Christian Hammond chip...@chipx86.comwrote: Yeah,

Issue 1072 in reviewboard: SVN --config-dir support

Updates: Labels: -Milestone-Release1.5 Milestone-Release1.1 Comment #9 on issue 1072 by chipx86: SVN --config-dir support http://code.google.com/p/reviewboard/issues/detail?id=1072 Just an update on this. We are working on a way to verify, store and manage certificates for 1.1. This