Posting files/paths for review, not changesets or diffs

2010-08-13 Thread Gordon Morehouse
I have some particular files and directories in a codebase which need review and can't figure out a way to simply post the entire files, as they exist now, to Review Board. The code is managed with Mercurial at the moment. I've been trying various incantations with post-review and hg export and

Re: remote Mercurial repo support?

2010-07-01 Thread Gordon Morehouse
Thanks both of you. I see the patch has been added as of RBTools 0.2.1 alpha 0, which I'm now using. Might want to take a peek at http://code.google.com/p/reviewboard/issues/detail?id=1708 though ;) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/

Re: remote Mercurial repo support?

2010-06-25 Thread Gordon Morehouse
On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars.  I think a recently accepted patch fixed the logic, but you can get it working with older

Re: Every patch failing on new RB install w/Mercurial

2010-06-24 Thread Gordon Morehouse
I've now replicated this on an entirely different RB 1.5 beta 2 installation running on Debian Lenny. I will file a bug report. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/

remote Mercurial repo support?

2010-06-24 Thread Gordon Morehouse
Hello, The manual page about repositories contains no information whatsoever about Mercurial. Is it possible to configure a remote Mercurial repo either via HTTP(S) or SSH, or does Review Board require disk access to the repository? If it's possible via HTTP, what is the path to use? The path

Re: Every patch failing on new RB install w/Mercurial

2010-06-24 Thread Gordon Morehouse
On Jun 24, 1:28 pm, Gordon Morehouse gordon.moreho...@gmail.com wrote: I've now replicated this on an entirely different RB 1.5 beta 2 installation running on Debian Lenny.  I will file a bug report. ...and it turns out the bug report was filed against the documentation, because upon looking

red borders around punctuation characters

2010-06-24 Thread Gordon Morehouse
When viewing diffs in Review Board, in some of the chunks I'm seeing punctuation characters be enclosed in red borders. This is happening on both the old and new side of the diff. What does this signify, or is it a bug? Example: return array('type' = $action_handle,

Re: red borders around punctuation characters

2010-06-24 Thread Gordon Morehouse
Ah, okay, it's a '.inc' file which contains PHP code. On Jun 24, 4:52 pm, David Trowbridge trowb...@gmail.com wrote: Probably pygments has the wrong idea about what type of file it is, and is highlighting what it thinks are errors. -David On Thu, Jun 24, 2010 at 4:41 PM, Gordon Morehouse

Re: Every patch failing on new RB install w/Mercurial

2010-06-09 Thread Gordon Morehouse
I've upgraded from 1.0.8 to 1.5b2 and this is still happening. This is on a server running Ubuntu 10.04; I'm wondering if it has to do with something on the server and if anybody else is seeing (or not seeing) similar issues on Ubuntu 10.04. Again, I've examined the .rej file and the .diff file

Re: Every patch failing on new RB install w/Mercurial

2010-06-03 Thread Gordon Morehouse
On Jun 2, 5:40 pm, Christian Hammond chip...@chipx86.com wrote: Can you look at that reject file and the other files in that directory and see if anything stands out as being wrong there? If it is the file endings, then that's something I'll be looking into shortly, but it would be nice to

Re: Every patch failing on new RB install w/Mercurial

2010-06-03 Thread Gordon Morehouse
This is also happening with the 'hg postreview' plugin, so I'm fairly sure that it's something fundamental to RB that's broken. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/

Every patch failing on new RB install w/Mercurial

2010-06-02 Thread Gordon Morehouse
Hello all, I'm working to set up a new RB install, and I've gotten to the point where I can post reviews with the 'post-review' command. However, when I view the diffs in RB, I get an error because the 'patch' command has failed. I've tried several post-commit reviews with commands like the

Re: Every patch failing on new RB install w/Mercurial

2010-06-02 Thread Gordon Morehouse
On Jun 2, 5:24 pm, Christian Hammond chip...@chipx86.com wrote: Hi Gordon, At what point are things failing? On upload, or on view? Can you show the debug output from post-review? Hi Christian, They're failing on view (Diff Viewer). Some output follows. The diff in this case is a one-line