Re: Unable to create CVS repository with ReviewBoard 1.1
That is really strange. We're doing nothing special there, just checking for the existence of the files using standard Python functions. Short of poking around the filesystem myself and running some tests, I don't really know what to suggest here. I'd say that maybe /usr/bin/cvs is a broken symlink, except for ldd's results. What distro is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 8:15 AM, Clemens Ballarin balla...@aicas.com wrote: Hi Christian, we've finally set up ReviewBoard 1.1 alpha 2 (dev). I'm afraid we are unable to add CVS repositories. The error is The executable cvs is not in the path. Something seems to be broken with cvs detection but we couldn't figure out what. RB seems to be able to locate patch, for example, but not cvs, although both exist. Some debug output is below. Clemens - path: /usr/lib/python2.4/site-packages/ Djblets-0.5.6alpha0.dev_20091026-py2.4.egg/djblets/util file: filesystem.py import syslog ... | for dir in os.environ['PATH'].split(os.pathsep): syslog.syslog(os.path.join(dir, name) + : + str(os.path.exists(os.path.join(dir, name |if os.path.exists(os.path.join(dir, name)): |return True output while adding a cvs repository: Nov 2 04:59:11 hraesvelgr httpd: /sbin/patch: False Nov 2 04:59:11 hraesvelgr httpd: /usr/sbin/patch: False Nov 2 04:59:11 hraesvelgr httpd: /bin/patch: False Nov 2 04:59:11 hraesvelgr httpd: /usr/bin/patch: True Nov 2 04:59:11 hraesvelgr httpd: /sbin/cvs: False Nov 2 04:59:11 hraesvelgr httpd: /usr/sbin/cvs: False Nov 2 04:59:11 hraesvelgr httpd: /bin/cvs: False Nov 2 04:59:11 hraesvelgr httpd: /usr/bin/cvs: False /usr/bin/patch is found, but /usr/bin/cvs is not. Both files are available: [r...@hraesvelgr ~]# file /usr/bin/cvs /usr/bin/cvs: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/ Linux 2.6.9, stripped [r...@hraesvelgr ~]# file /usr/bin/patch /usr/bin/patch: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/Linux 2.6.9, stripped -- Dr. Clemens Ballarin -- Senior Software Engineer aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * phone +49 721 663 968-35 * fax -99 USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim Geschäftsführer: Dr. James J. Hunt To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to create review request for hg
Check the log files. This would be due to the Mercurial dependencies not loading generally. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 9:50 AM, Clemens Ballarin balla...@aicas.com wrote: Hi Christian, here's another issue for RB 1.1a2: for a local mercurial repository, I cannot create a review request through the web interface. The repository menu is empty. Cheers, Clemens -- Dr. Clemens Ballarin -- Senior Software Engineer aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * phone +49 721 663 968-35 * fax -99 USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim Geschäftsführer: Dr. James J. Hunt To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to post-commit review a first time checkin?
It sounds like the generated diff is empty. If you add --output-diff to
those parameters, you should be able to see for sure.
if you don't specify a to:from, it will do, in your case, 24506:HEAD. If
that's what you're wanting, then we should find out why exactly this is
failing, but if that's not the expected range, you'll need to specify your
own from:to.
I don't entirely understand what your scenario is. Are you saying that there
are new files that were created in r24506 and those are the ones you want to
put up for review?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Oct 29, 2009 at 12:07 PM, Pv p...@swooby.com wrote:
I am using the following command to do a post-commit review on a first
time checkin:
post-review -d --revision-range=24506
Obviously, I am not specifying a from:to range, but since this is a
first time checking any earlier from svn rev # wouldn't exist in the
newly created path.
The [debug] output I get is this:
svn info
repository info: Path: svn://devsrvsea01/svnroot, Base path:
/trunk/StopProcess, Supports changesets: False
svn propget reviewboard:url C:\svns\tps\trunk\StopProcess
svn propget reviewboard:url C:\svns\tps\trunk\
svn diff --diff-cmd=diff -r 24506
Looking for '10.100.120.86 /' cookie in C:\Documents and
Settings\User\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
repository info: Path: svn://devsrvsea01/svnroot, Base path:
/trunk/TPS/QA/StopProcess, Supports changesets: False
HTTP POSTing to http://10.100.120.86/api/json/reviewrequests/new/:
{'repository_path': 'svn://devsrvsea01/svnroot'}
Review request created
Uploading diff, size: 0
HTTP POSTing to
http://10.100.120.86/api/json/reviewrequests/14/diff/new/: {'basedir':
'/trunk/TPS/QA/StopProcess'}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['The submitted file is empty.']}, 'stat': 'fail',
'err': {'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
Since
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: easy_install rbtools on py26?
Can you file a bug on this? We just need to turn off the sqlite dependency when building Python 2.6 packages. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Oct 29, 2009 at 10:37 AM, Pv p...@swooby.com wrote: I had ActivePython 2.6 installed and installed ezsetup for py26 (on a x64 Windows 2K8 Server). I then tried easy_install rbtools and it failed when installing the simplejson egg. easy_install simplejson also fails with the same error. The simplejson site says that py26 includes json and that simplejson is for legacy support on 2.5 2.4. So why does easy_install rbtools want to install simplejson? Thanks! Pv To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
lucene indexing
I noticed that while the full index is running, the incremental indexes fail with this exception: lucene.JavaError: org.apache.lucene.store.LockObtainFailedException: Lock obtain timed out: SimpleFSLock@/data/www/reviewboard/search-index/write.lock It looks like the default lock timeout is 1 second. Has this been noticed before? Any thoughts about preventing incremental indexing while the full index is running? Also, what's the motivation for doing the full index? Is it trying to pick up changes that aren't caught by checking the last_updated field? -Eric --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Can not post word document in review
Hello, we have RB 1.0.3-Perforce setup. I created pending CL with word document. When I post the review, it did post the review successfully. But when I click on View Diff, on my first try I get below message: The patch to 'c:/Perforce/Sources/Integration/Automation_Scripts/ ClearQuest_Documents/4weewrewrewr.doc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.0_p4v9' for debugging purposes. `patch` returned: patching file /tmp/reviewboard. 0_p4v9/tmpnshHiq patch: malformed patch at line 5: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 152, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Integration/ Automation_Scripts/ClearQuest_Documents/4weewrewrewr.doc' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard. 0_p4v9' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.0_p4v9/tmpnshHiq patch: malformed patch at line 5: ON MY SECOND TRY WITH NEW PENDING CL, I GOT BELOW MESSAGE WHEN I CLICK ON VIEW DIFF: 'ascii' codec can't decode byte 0xa0 in position 87: ordinal not in range(128) Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 152, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.3-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.3.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) UnicodeDecodeError: 'ascii' codec can't decode byte 0xa0 in position 87: ordinal not in range(128) HOW TO FIX THIS ISSUE? --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to make the description of the Review READ ONLY
Hello, For the RB 1.0.3, we want to make such custom changes that the description is read only once someone post the review even if it is in draft mode. We DO NOT want users to allow editing the description in review board as it contains some pre-defined template and we do not want it to change. How to do this? Is it possible? If yes, which file I have to change? --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to confiure EMAILS for Reviews
We have RB 1.0.3 with Perforce integration. We have set up Apache server and everything works fine like posting review, publshing review, updating diff etc. We do not get any emails though once the review is posted etc. how to configure email settings? Thanks Kunjal --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to make the description of the Review READ ONLY
This isn't possible today without modifying Review Board heavliy. It's a pretty specific policy choice and and we probably wouldn't want to add a setting for it (as it's more to test, maintain, and isn't something that 99% of our userbase will need). Generally, I'd say you should just make sure people know not to change it. After all, what's to prevent them from modifying the template on the first post, and what if their code has changed enough to warrant a change in the description? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 4:04 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, For the RB 1.0.3, we want to make such custom changes that the description is read only once someone post the review even if it is in draft mode. We DO NOT want users to allow editing the description in review board as it contains some pre-defined template and we do not want it to change. How to do this? Is it possible? If yes, which file I have to change? To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to confiure EMAILS for Reviews
You should be able to configure that in the E-mail Settings part of the Admin UI. If e-mail is not working correctly, then it's an issue talking to the mail server. Unfortunately, going through Django's e-mail infrastructure means that we don't get any detailed error logging. Assuming the mail server is under your control, you may want to check your mail server logs if your e-mail is enabled/configured properly and you're still not seeing anything. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 4:05 PM, Kunjal kunjal.par...@gmail.com wrote: We have RB 1.0.3 with Perforce integration. We have set up Apache server and everything works fine like posting review, publshing review, updating diff etc. We do not get any emails though once the review is posted etc. how to configure email settings? Thanks Kunjal To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewing non-revision controlled source codes
Hi Christian, Synchronicity is another SCM. You can get some information from here: http://www.3ds.com/products/enovia I'm not too familiar with Python. I found this in other threads. Are these the only things that have to be modified if new SCM was to be added? Basically, you'll create a subclass of SCMTool that does the following: 1) Grabs a file from a repository, given a file path andrevision. 2) Provide a DiffParser subclass that handles pulling out filenames and revisions and any other necessary data from a diff (most of the code for all this is common, so you just hook into things -- see the other files for 3) If Vault has a concept of server-side changesets (you register a changeset with a description, and other data, and the server always knows what you have checked out on the client) then you'll need to implement get_changeset(). So the general model is that this code will have three classes: 1) VaultTool 2) VaultDiffParser 3) VaultClient VaultTool will be a subclass of SCMTool and will be what Review Board talks to. VaultDiffParser will be a subclass of DiffParser and will override functions to parse revision info out of a diff. VaultClient will be a wrapper around the command line tool, which VaultClient will talk to. Now, let's talk diffs. Many revision control systems provide tools that generate diffs unsuitable for Review Board, and sometimes we have to work around them. If vault's tool generates a diff containing revision information for a file that can be used to pull data from the repository, then we're good. If not, you'll need to implement this in post-review. Thanks On Oct 29, 10:27 am, Christian Hammond chip...@chipx86.com wrote: Hi, There's no good way of doing this right now. Review Board really requires a repository of some sort. Is Synchronicity the name of the SCM? I haven't seen this one. I'd love the URL if you have it. Assuming there are tools available for fetching a file on a remote server given a filename and a revision, then someone should be able to write support for this (though it'll need to be someone who has access to a Synchronicity repository and has real-world uses for it). Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Oct 28, 2009 at 3:14 AM, marypap maryafa...@hotmail.com wrote: Hi, I have been using reviewboard for doing a code review based on CVS. However, there are new projects that are based on other repository that is not in the supported list (Example: Synchronicity). Is there a way to create review of those stored in non-supported repository or any files that are not revision controlled and do a view diff? Thanks a lot, mary To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewing non-revision controlled source codes
These are the main things you'd need to do, though having experience with Python would be helpful. The information you pasted would be relevant here. Also, you'd ideally want post-review support in order to automatically generate and upload the diff, but the first step would be to make the new SCMTool. I couldn't find any place on that site for evaluating Synchronicity, so I wouldn't be able to look into this too much myself. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 5:30 PM, marypap maryafa...@hotmail.com wrote: Hi Christian, Synchronicity is another SCM. You can get some information from here: http://www.3ds.com/products/enovia I'm not too familiar with Python. I found this in other threads. Are these the only things that have to be modified if new SCM was to be added? Basically, you'll create a subclass of SCMTool that does the following: 1) Grabs a file from a repository, given a file path andrevision. 2) Provide a DiffParser subclass that handles pulling out filenames and revisions and any other necessary data from a diff (most of the code for all this is common, so you just hook into things -- see the other files for 3) If Vault has a concept of server-side changesets (you register a changeset with a description, and other data, and the server always knows what you have checked out on the client) then you'll need to implement get_changeset(). So the general model is that this code will have three classes: 1) VaultTool 2) VaultDiffParser 3) VaultClient VaultTool will be a subclass of SCMTool and will be what Review Board talks to. VaultDiffParser will be a subclass of DiffParser and will override functions to parse revision info out of a diff. VaultClient will be a wrapper around the command line tool, which VaultClient will talk to. Now, let's talk diffs. Many revision control systems provide tools that generate diffs unsuitable for Review Board, and sometimes we have to work around them. If vault's tool generates a diff containing revision information for a file that can be used to pull data from the repository, then we're good. If not, you'll need to implement this in post-review. Thanks On Oct 29, 10:27 am, Christian Hammond chip...@chipx86.com wrote: Hi, There's no good way of doing this right now. Review Board really requires a repository of some sort. Is Synchronicity the name of the SCM? I haven't seen this one. I'd love the URL if you have it. Assuming there are tools available for fetching a file on a remote server given a filename and a revision, then someone should be able to write support for this (though it'll need to be someone who has access to a Synchronicity repository and has real-world uses for it). Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Oct 28, 2009 at 3:14 AM, marypap maryafa...@hotmail.com wrote: Hi, I have been using reviewboard for doing a code review based on CVS. However, there are new projects that are based on other repository that is not in the supported list (Example: Synchronicity). Is there a way to create review of those stored in non-supported repository or any files that are not revision controlled and do a view diff? Thanks a lot, mary To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1381 by ostocek: diff update doesn't work in web GUI and in
post-review utility
http://code.google.com/p/reviewboard/issues/detail?id=1381
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.0.5.1
What's the URL of the page containing the problem?
https://ourdevelserver/rb/r/187/diff/
What steps will reproduce the problem?
1. Create a request with diff (works fine)
2. Try to update diff by Upload diff form
What is the expected output? What do you see instead?
The error is displayed with this detail message
{fields: {path: [The diff file is empty]}, stat: fail, err:
{msg: One or more fields had errors, code: 105}}
when I try post-review in the terminal, problem is following:
$ post-review -p -r 187 --description some message
== HTTP Authentication Required
Enter username and password for at ourdevelserver
Username: user
Password:
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
What operating system are you using? What browser?
Firefox 3.5.1, Opera 10.0.1
Please provide any additional information below.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
