Re: Customize ReviewBoard instance
The beauty of Git is that you don't have to only base your changes on one branch. You can easily merge from multiple branches into your branch. What I'd recommend is to have a branch, for example vendor, which is what your internal builds will be from. Then, each feature would go its own feature branch, for the purpose of making it easy to port certain things down the road, and maybe to even provide patches. vendor would merge from each branch when you're ready to do a new build. This is done by: $ git checkout vendor $ git merge my-feature You may have to resolve some merge conflicts, but then you'd have that feature in your branch. Periodically, you'd also merge from master. If you want our extensions branch for instance, you'd merge from extensions. If you want it to incorporate the 1.6 changes before they land to master, you might merge from release-1.6. The key point is that your branch for your own builds can merge from any number of branches, any time those branches merge, and those branches can merge from what they need to (master for example). You probably shouldn't ever commit to any of the upstream branches, though, as those should be reserved for changes coming from our GitHub repository. If you've been doing this and want to try the vendor approach, it won't be hard to switch over. Just rename your branch: $ git branch -M master vendor $ git checkout -b master origin/master That'll rename master to vendor and then create a new master branch. Hope that helps? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Apr 5, 2010 at 9:21 PM, Jan Koprowski jan.koprow...@gmail.comwrote: Thank You very much for answer :) To the POST hooks :) or URL hooks. IMHO there are many ways to pass arguments to hook like this. I think this will be good to have something like method argument in hook calling which could be similar to jquery.ajax argument. Which means when we call hook we could determine how arguments hook will be send: POST, GET or JSON or something else. My little suggestion :) I belive this mechanism will be good enough to customize reviewboard external integrations :] About branches. Now I see one problem. I'am providing some features to ReviewBoard (more fixes for ClearCase then features but features will be there also) and I post reviews for it. But there are some features which have sens only for my company, and I just keep them in another branch without posting it public. Which branch I should use? Now I use default one from github. Now I see there is another branches where some of features which I need (maybe which I implement by my self) are present :) I don't want implement features which is available now. No I'am a little bit confused which branch I should use to have stable ReviewBoard, may post reviews and write patches and get unpublic features not provide in ReviewBoard yet? Is there any branch like this? :D Thank You for Your answers :) On Apr 6, 5:14 am, Christian Hammond chip...@chipx86.com wrote: Hi, We have a few things planned and in development for the level of customization you guys want. 1) We have some things that will be in the 1.6 release (it's actually written today, just isn't scheduled for 1.5) for WebHooks, which allow for calling external scripts (technically, doing an HTTP POST to a URL) on various events. I can't remember exactly if Submitted or Discarded hooks into this, but it could be made to if it doesn't. I'll probably create an early 1.6 branch for development before long which will have this. You could make use of this branch if you want to use this sooner, though you'd have to maintain your own packages internally. The way it works is that you have a script hosted on a web server somewhere. It could be PHP, Python, whatever. It responds to an HTTP POST and knows how to take a certain payload and return certain information. You would then reference this URL in the admin UI for different events. 2) It's quite possible we'll have some level of theme support (perhaps as a Summer of Code project) for letting admins configure their own templates by basically just overriding parts that they need. That's not happening for 1.5, but maybe 1.6. 3) We're working on extensions support. There are branches for it today, but it's nowhere near ready for production use. However, it will allow for more advanced customization without modifying Review Board. As for the suggestions for changing how settings works, I'd actually rather do nothing about this right now. I feel that while we'd get a lot of flexibility, it would increase our support burden, and there's rarely a case where this would need to be used anyway. The customizations you're referencing will be there in a much easier way in future releases, and if you really need to specify your own
Re: Customize ReviewBoard instance
This give some point of view :) Great thanks! For now I have separate branch for each of my issue. Each branch is lead from reviewboard master and contain only changes for each issue. All of issues is merged to intel branch. I made some smart command intelit which make greate use from git archive and propagate changes in intel branch to virtualenv system and of course working reviewboard copies as well. I think when I will try use hooks branch or 1.6 I just checkout this branch and merge all my issues to it. This will be probably easier :) Thank You for Your time and publishing extra branches :) Today is a big day - first implementing of ReviewBoard in our team :] So. I have a grate hope all will go fine, my managers will be charm of this tool and I get more tasks to help with development :] On Apr 6, 8:03 am, Christian Hammond chip...@chipx86.com wrote: The beauty of Git is that you don't have to only base your changes on one branch. You can easily merge from multiple branches into your branch. What I'd recommend is to have a branch, for example vendor, which is what your internal builds will be from. Then, each feature would go its own feature branch, for the purpose of making it easy to port certain things down the road, and maybe to even provide patches. vendor would merge from each branch when you're ready to do a new build. This is done by: $ git checkout vendor $ git merge my-feature You may have to resolve some merge conflicts, but then you'd have that feature in your branch. Periodically, you'd also merge from master. If you want our extensions branch for instance, you'd merge from extensions. If you want it to incorporate the 1.6 changes before they land to master, you might merge from release-1.6. The key point is that your branch for your own builds can merge from any number of branches, any time those branches merge, and those branches can merge from what they need to (master for example). You probably shouldn't ever commit to any of the upstream branches, though, as those should be reserved for changes coming from our GitHub repository. If you've been doing this and want to try the vendor approach, it won't be hard to switch over. Just rename your branch: $ git branch -M master vendor $ git checkout -b master origin/master That'll rename master to vendor and then create a new master branch. Hope that helps? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Apr 5, 2010 at 9:21 PM, Jan Koprowski jan.koprow...@gmail.comwrote: Thank You very much for answer :) To the POST hooks :) or URL hooks. IMHO there are many ways to pass arguments to hook like this. I think this will be good to have something like method argument in hook calling which could be similar to jquery.ajax argument. Which means when we call hook we could determine how arguments hook will be send: POST, GET or JSON or something else. My little suggestion :) I belive this mechanism will be good enough to customize reviewboard external integrations :] About branches. Now I see one problem. I'am providing some features to ReviewBoard (more fixes for ClearCase then features but features will be there also) and I post reviews for it. But there are some features which have sens only for my company, and I just keep them in another branch without posting it public. Which branch I should use? Now I use default one from github. Now I see there is another branches where some of features which I need (maybe which I implement by my self) are present :) I don't want implement features which is available now. No I'am a little bit confused which branch I should use to have stable ReviewBoard, may post reviews and write patches and get unpublic features not provide in ReviewBoard yet? Is there any branch like this? :D Thank You for Your answers :) On Apr 6, 5:14 am, Christian Hammond chip...@chipx86.com wrote: Hi, We have a few things planned and in development for the level of customization you guys want. 1) We have some things that will be in the 1.6 release (it's actually written today, just isn't scheduled for 1.5) for WebHooks, which allow for calling external scripts (technically, doing an HTTP POST to a URL) on various events. I can't remember exactly if Submitted or Discarded hooks into this, but it could be made to if it doesn't. I'll probably create an early 1.6 branch for development before long which will have this. You could make use of this branch if you want to use this sooner, though you'd have to maintain your own packages internally. The way it works is that you have a script hosted on a web server somewhere. It could be PHP, Python, whatever. It responds to an HTTP POST and knows how to take a certain payload and return certain information. You would then reference this
Re: How do I export an entire review request - request + replies + diffs?
My apologies, I don't think we ever responded to you on this topic. Did you ever find a solution here? Basically, there's no great way to migrate content today and merge it with another instance. There are some old scripts in the source tree's contrib/db/ directory for exporting/importing, but they'd have to be modified to handle the new models in the right order. However, that would overwrite your existing database. The webapi isn't really suitable for what you need. It doesn't provide a database-level representation, and doesn't allow creating all the information needed for fully transplanting a database. The problem is that there are a lot of database tables that rely on keeping IDs correct. A plain SQL dump will expect to be able to use the IDs as they were in the old database. Some very careful scripts would need to be written to grab the data out of a database with all the linked information and then import it properly. It'd be great if someone took the initiative to write this, but we have our hands full and it's unlikely we will in the near future. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Mar 26, 2010 at 12:54 AM, Srinidhi B S srinidhi...@gmail.comwrote: Hi, As I've mentioned in my earlier email, I'm moving one of our ReviewBoard instances to production. One of the teams has been using another (local) RB instance till now and would like to merge their requests to this new production instance. If my understanding is correct, I've 2 options to merge those changes - 1) Export individual review request using API calls and then importing them manually 2) Take the MySQL dump and import them here. I read through the webapi docs available at http://www.reviewboard.org/docs/manual/dev/webapi/ - I couldn't find an api call to extract all meta-data and data for a particular review request. Is there any way I can extract all data - request details + replies + reviews + diffs, etc - using a single API call? (Something like what Bugzilla provides) How can I import these entries to my new system? If I POST these entries using the API calls, then RB would mark them as created by me - instead of the real requester. Is this understanding correct? I would really prefer the MySQL dump, but I'm really not sure which tables to extract data from. Any help / pointers on this would be of great help!! Regards, Srinidhi. -- ASCII ribbon campaign ( )B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: Cant run post-reveiw
There's some code going in to 1.5 that will make ticket-based auth work better with Perforce. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Mar 30, 2010 at 9:04 AM, RShelley 12gaugeme...@gmail.com wrote: I think we experience this when we haven't authenticated Review Board to Perforce. We have a Perforce user, then generate a ticket with: p4 -u user login -a -p That generates a alphanumeric ticket we use as the password in Review Board repository config to Perforce... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: How to change the site name of a particular reviewboard installation?
Hi, Did you find a solution to this problem? You didn't mention this in the e-mail, but did you change the hostname in the Admin UI - General Settings page? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 25, 2010 at 3:30 PM, Srinidhi B S srinidhi...@gmail.com wrote: Hi, I've been running a reviewboard instance in our network for testing purpose. It was being accessed as: http://hostname.example.com/reviews Now I would like to move this installation to production and would like to change the URL to http://reviews.example.com/ - how can I achieve this? I tried changing the apache configuration and /path/to/reviewboard/installdir/conf/settings_local.py, but things didn't work correctly. For example, users were not able to Publish review comments, create new requests, etc. While debugging I figured out that the /api/json/... URLs were incorrect. It would be great if someone could suggest a working solution to this migration. Srinidhi. -- ASCII ribbon campaign ( )B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: post-commit with revision-range
Hi Ryan, Been out of town the past few days, so I'm catching up on e-mail now. Okay, so I think I understand. So with this process, you want to continually update an existing review request, and you want it to incorporate the new updates alongside the existing ones? So if it's already created with a diff modifying 5 files, the next update that adds 2 files will result in a diff containing a total of 7? So that won't happen today unless that revision range spans the revision originally modifying those 5. If you post a review request with a range that covers one set of files, and then update it with a diff covering another set of files, then the latest diff will only contain that second set. The first set will still exist as a revision, but won't be the latest shown. It might be possible to come up with something a bit more custom to augment the existing diff, but I don't know how clean it would be right now. You'd have to download the existing diff, figure out what should be removed/appended/replaced, and update that. I don't think augmenting the latest diff is a very common scenario. If it turned out to be easy (unlikely without the new APIs I'm doing for 1.5 and without parsing the downloadable diff file) then maybe we could add it to post-review, but it might be best as its own tool. Going to be working toward expanding RBTools to make it easier to write custom scripts such as this, so maybe it'd be better there? Please let me know if I misunderstood. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Mar 30, 2010 at 3:30 PM, rshelley ryan.shel...@disney.com wrote: Ok, let me clarify with a concrete scenario. We use JIRA for our bug tracking. JIRA generates bug IDs such as BUG-123. We also have Hudson for continuous integration, and it's tied to Perforce to poll for changes, build the changes, and log the changelists in the build (for release notes). Our standard process is to include within our Perforce descriptions the JIRA bug ID our check- in is for, so Perforce syncs with JIRA to update the issue with the Perforce files modified to complete the circle. So now we know what files were changed to fix what bugs in which build (and in reverse, what build certain changes were included in by reference through JIRA). There are many, many, MANY times where one check-in (and therefore, one changelist) does not encompass all of the changes required to resolve the bug, but all changes are tracked by a single JIRA. We have a culture of checking-in often and not holding onto files for days on end until we check-in one massive changelist since we're developing in a highly collaborative and volatile environment (we often have people developing within the same file at the same time, so merges are often done on a daily basis). This is why we use CI to build and test the project regularly. So it doesn't make sense for us to create dozens of new review requests for new changelists since they are often updates to a related JIRA. Now, we're both in agreement that the CLI provides all the functionality of creating and updating reviews and the developer can decide what files update what reviews and when to create a new review. However, I can't get my developers to use it. Both Kyle Hayes and I have been expounding it, documenting it internally, emailing our team, and we haven't had a single person use it yet. And until I have something people will use (or even better, in their view, is if it's done for them), I can't make it a standard. So my goal is to create a Hudson plugin to link Perforce and Reviewboard for post-commit reviews. Now, I know that Reviewboard has a field for Bugs, which we currently have linked to JIRA, but I'm not aware of a way to pass that in as part of post-review, or retrieve through a CLI query, so I'm looking into mapping a Perforce changelist, to a JIRA bug (via the bug ID entered in the changelist description) and the Reviewboard ID. This mapping should be relatively trivial. What isn't trivial is making updates to a review request when an updated changelist is submit (meaning a second changelist is submit with the same JIRA bug ID as another changelist that has an open review request). This is where my Improvement request 1562 would have been helpful. From what I gather in your post, however, is that revision-range isn't supported by post-review for Perforce which shouldn't be a problem. Hudson gives me the depot paths as part of the change set the build was executed for. I just want to make sure that if I have 5 files in the review, and I add 2 and update 3 that the review shows 7 files with three deltas and the other 3 files that were in the original review aren't dropped. I hope that makes sense and isn't too confusing. I know post-commit is a less-than-ideal solution. I'm pro-pre-commit, but my team is not. Well,
Re: post-commit with revision-range
So with this process, you want to continually update an existing review request, and you want it to incorporate the new updates alongside the existing ones? So if it's already created with a diff modifying 5 files, the next update that adds 2 files will result in a diff containing a total of 7? Yep! Exactly. So that won't happen today unless that revision range spans the revision originally modifying those 5. Right. I'm getting around this by automatically publishing the review when it gets created or updated. That seems to be working, and I'm actually happy about the way that works. Since I'm writing the plugin for Hudson, when a build runs, it creates or updates a review request and then publishes it. This way the review request emails get sent out and the author knows when it's been done. Otherwise they wouldn't know to go into RB and manually publish it. So, I'm ok with this process currently and think that in an automated process like what I'm doing, updating a diff with new files would defeat the purpose of automation because it would still require a manual step that I want to avoid. Going to be working toward expanding RBTools to make it easier to write custom scripts such as this, so maybe it'd be better there? Yeah, I'd agree. I know you're currently developing some APIs and hooks, but in the interim I've developed a Java API that calls your RESTful endpoints with the proper params and authentication to update fields and publish reviews. Works fine for me for the moment. Thanks for following back up! -Ryan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How do I export an entire review request - request + replies + diffs?
Hi Christian, On Tue, Apr 6, 2010 at 1:33 PM, Christian Hammond chip...@chipx86.com wrote: My apologies, I don't think we ever responded to you on this topic. Did you ever find a solution here? Basically, there's no great way to migrate content today and merge it with another instance. There are some old scripts in the source tree's contrib/db/ directory for exporting/importing, but they'd have to be modified to handle the new models in the right order. However, that would overwrite your existing database. After our small conversation on twitter, I figured out that I'll use the MySQL dump. That worked just fine for moving data, as is, to a new installation. But I'm afraid, I'll not get access to MySQL for the other server that was being used by one of our teams as a temporary solution. The webapi isn't really suitable for what you need. It doesn't provide a database-level representation, and doesn't allow creating all the information needed for fully transplanting a database. The problem is that there are a lot of database tables that rely on keeping IDs correct. A plain SQL dump will expect to be able to use the IDs as they were in the old database. Some very careful scripts would need to be written to grab the data out of a database with all the linked information and then import it properly. It'd be great if someone took the initiative to write this, but we have our hands full and it's unlikely we will in the near future. I'm still very new to DJango and RB. I'll see what I can do here. Unfortunately, can't confirm / commit anything as of now. :( Srinidhi. On Fri, Mar 26, 2010 at 12:54 AM, Srinidhi B S srinidhi...@gmail.com wrote: Hi, As I've mentioned in my earlier email, I'm moving one of our ReviewBoard instances to production. One of the teams has been using another (local) RB instance till now and would like to merge their requests to this new production instance. If my understanding is correct, I've 2 options to merge those changes - 1) Export individual review request using API calls and then importing them manually 2) Take the MySQL dump and import them here. I read through the webapi docs available at http://www.reviewboard.org/docs/manual/dev/webapi/ - I couldn't find an api call to extract all meta-data and data for a particular review request. Is there any way I can extract all data - request details + replies + reviews + diffs, etc - using a single API call? (Something like what Bugzilla provides) How can I import these entries to my new system? If I POST these entries using the API calls, then RB would mark them as created by me - instead of the real requester. Is this understanding correct? I would really prefer the MySQL dump, but I'm really not sure which tables to extract data from. Any help / pointers on this would be of great help!! Regards, Srinidhi. -- ASCII ribbon campaign ( ) B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \ Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ASCII ribbon campaign ( )B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to change the site name of a particular reviewboard installation?
Hi Christian, On Tue, Apr 6, 2010 at 1:36 PM, Christian Hammond chip...@chipx86.com wrote: Hi, Did you find a solution to this problem? I actually gave up and created a new site. I then imported the entire MySQL DB over to this new installation! You didn't mention this in the e-mail, but did you change the hostname in the Admin UI - General Settings page? Doh! Didn't look there!! I was digging around more at the site config :( Will remember this for the next time :) Thanks, Srinidhi. On Thu, Mar 25, 2010 at 3:30 PM, Srinidhi B S srinidhi...@gmail.com wrote: Hi, I've been running a reviewboard instance in our network for testing purpose. It was being accessed as: http://hostname.example.com/reviews Now I would like to move this installation to production and would like to change the URL to http://reviews.example.com/ - how can I achieve this? I tried changing the apache configuration and /path/to/reviewboard/installdir/conf/settings_local.py, but things didn't work correctly. For example, users were not able to Publish review comments, create new requests, etc. While debugging I figured out that the /api/json/... URLs were incorrect. It would be great if someone could suggest a working solution to this migration. Srinidhi. -- ASCII ribbon campaign ( ) B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \ Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ASCII ribbon campaign ( )B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ldap auth not working on RHEL5.3, python-ldap-2.2.0
Hi list, got the following problem with a fresh reviewboard install on RHEL5.3. it's using python 2.4, and python-ldap-2.2.0-2.1. 1) server, base etc is configured with the web interface 2) when I do the query from the commandline I get the right results 3) ldap server is openldap and allows anonymous 4) tcpdump shows traffic to port 389 when using ldapsearch, but no traffic when trying to login on reviewboard 5) reviewboard log shows: 2010-04-06 15:31:24,347 - WARNING - LDAP error: (13, 'Permission denied') I can understand permission denied if the password would be incorrect, but there is no traffic at all going to the ldap server, so which permissions are denied? Any idea? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: How to change the site name of a particular reviewboard installation?
Hi, I had tried to change site domain. I had changed this site setting in MySQL Database directly and local_settings.py both, And this works. Table Name is django_site, You may have a try. Best Regards! On 4月6日, 下午8时51分, Srinidhi B S srinidhi...@gmail.com wrote: Hi Christian, On Tue, Apr 6, 2010 at 1:36 PM, Christian Hammond chip...@chipx86.com wrote: Hi, Did you find a solution to this problem? I actually gave up and created a new site. I then imported the entire MySQL DB over to this new installation! You didn't mention this in the e-mail, but did you change the hostname in the Admin UI - General Settings page? Doh! Didn't look there!! I was digging around more at the site config :( Will remember this for the next time :) Thanks, Srinidhi. On Thu, Mar 25, 2010 at 3:30 PM, Srinidhi B S srinidhi...@gmail.com wrote: Hi, I've been running a reviewboard instance in our network for testing purpose. It was being accessed as:http://hostname.example.com/reviews Now I would like to move this installation to production and would like to change the URL tohttp://reviews.example.com/- how can I achieve this? I tried changing the apache configuration and /path/to/reviewboard/installdir/conf/settings_local.py, but things didn't work correctly. For example, users were not able to Publish review comments, create new requests, etc. While debugging I figured out that the /api/json/... URLs were incorrect. It would be great if someone could suggest a working solution to this migration. Srinidhi. -- ASCII ribbon campaign ( ) B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \ Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ASCII ribbon campaign ( ) B S Srinidhi - against HTML email X http://www.srinidhi-is.in vCards / \ Bangalore -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Windows Installation -- FastCGI working, RB saying update required
Hi folks, Still powering through this. I used nginx to get it up and going, and now I'm getting my first RB page. However, it gives these errors: Manual server updates required A recent change requires manual updates to be made on this server. After these changes are made, you should restart your server. Install GNU patch.exe GNU patch.exe must be in your executable search path for the diff viewer to work. Both should be up to date, as I just installed RB via easy_install, and I can definitely get to patch from the path. Any ideas? TIA Mike -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: Windows Installation -- FastCGI working, RB saying update required
OK, found it. Needed to do the ./manage.py fixscreenshots On Apr 6, 10:22 pm, drmikecrowe drmikecr...@gmail.com wrote: Hi folks, Still powering through this. I used nginx to get it up and going, and now I'm getting my first RB page. However, it gives these errors: Manual server updates required A recent change requires manual updates to be made on this server. After these changes are made, you should restart your server. Install GNU patch.exe GNU patch.exe must be in your executable search path for the diff viewer to work. Both should be up to date, as I just installed RB via easy_install, and I can definitely get to patch from the path. Any ideas? TIA Mike -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using remove me as the subject.
Re: Issue 1580 in reviewboard: mysqld hogging cpu on our reviewboard instance.
Comment #5 on issue 1580 by chipx86: mysqld hogging cpu on our reviewboard instance. http://code.google.com/p/reviewboard/issues/detail?id=1580 For historical purposes, we've discussed this already outside of the bug report and are looking into various solutions. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1583 in reviewboard: Review Board doesn't work with private Mercurial repositories
Updates: Status: Confirmed Labels: Milestone-Release1.5 Component-SCMTools Comment #1 on issue 1583 by chipx86: Review Board doesn't work with private Mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=1583 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1585 in reviewboard: Order fields on login form so that TAB works as expected
Updates: Status: Confirmed Labels: Usability Keyboard Milestone-Release1.5 Comment #1 on issue 1585 by chipx86: Order fields on login form so that TAB works as expected http://code.google.com/p/reviewboard/issues/detail?id=1585 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1591 in reviewboard: Improve the navigation by providing a vertical bar showing where you are, and where diffs are
Updates: Status: Confirmed Labels: Component-DiffViewer Comment #3 on issue 1591 by chipx86: Improve the navigation by providing a vertical bar showing where you are, and where diffs are http://code.google.com/p/reviewboard/issues/detail?id=1591 Got it. Dunno when we'd do this but we can put it on the radar. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1419 in reviewboard: Error uploading diff: The file was not found in the repository (207)
Comment #12 on issue 1419 by jeff.gabhart: Error uploading diff: The file was not found in the repository (207) http://code.google.com/p/reviewboard/issues/detail?id=1419 Why is pointing to the tip of the repo a requirement? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on Summer_of_Code_Ideas in reviewboard
Comment by ollir.h: Hi, I'm ollir zhang from China, I would like to develop the following enhancements: 1. Add *report feature* to trace someone's/team's activities. 2. Create *Linux Installer Framework* to make RB installation much easier (RB installation on our debian linux almost cost me one working day, I hate dependencies). 3. Add *doc/pdf attachments* submit and review support. 4. (Candidate) I would like to do some improvements on _Diff Analysis and Filtering_ listed in Ideas page, after more discussion of requirements. I have been coding on RB enhancements for several weeks. For more information: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on IdeasFor2_0 in reviewboard
Comment by mailswami: It will be nice to have post-commit support. Instead of every post-commit review being a separate URL, if we could setup default rules for post-commit reviews to update an existing review providing the diff-between-diff features, it would be very useful. For more information: http://code.google.com/p/reviewboard/wiki/IdeasFor2_0 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1592 in reviewboard: Shouldn't factor out the username when checking a Subversion repository in usern...@server form
Comment #8 on issue 1592 by chipx86: Shouldn't factor out the username when checking a Subversion repository in usern...@server form http://code.google.com/p/reviewboard/issues/detail?id=1592 Seems reasonable. Feel free to file a separate feature request for that. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Comment #3 on issue 1575 by chipx86: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 We can only get the original, not the modifications. There's no way to see what changed, which makes it totally useless. There's also no way of making it work with other types of repositories. What we'd have to do is provide support in post-review for grabbing these modified binary files, figuring out the correct mimetypes, and uploading them. That might happen in a future release, but is not as easy as it may sound. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
