Re: ReviewBoard server tips over about twice a week

2013-09-12 Thread Paul Fee
MaxRequestsPerChild of 4000 should be fine.  I happen to have mine 
configured to 3000.  I didn't find the root cause of my server's lock ups, 
at the time I noted increased memory use by Apache.  A few months of 
evidence shows the change to be effective.  BTW I'm running RB 1.5 on an 
old Ubuntu release, so my problems may well have been fixed in more recent 
versions.  I expect you've got server issues different from mine, but 
MaxRequestsPerChild shouldn't do any harm.

On Wednesday, September 11, 2013 4:19:17 PM UTC+1, Steve wrote:

 Thanks Paul, that's helpful. We're using the prefork MPM.  Do you think 
 4000 is too large a number for MaxRequetsPerChild?

 --Steve

 On Wednesday, September 11, 2013 2:15:35 AM UTC-7, Paul Fee wrote:

 Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
 the /server-status URL on your web server.  This should cause Apache httpd 
 to provide a page that summarises the status of all its workers.  That may 
 help you understand why you've got more httpd processes than expected.

 Also, I've found the MaxRequestsPerChild directive to be useful on an 
 installation of mine that would lock up occasionally.  Your config shows 
 the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
 worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
 that MaxRequestsPerChild is taking effect.  The config file contains a set 
 of MPM tuning directives, duplicated for prefork and worker, make sure the 
 required configuration is actually active.

 -- 
 Paul

 On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-12 Thread sankar . curiosity
On Tuesday, September 10, 2013 11:16:21 AM UTC+5:30, David Trowbridge wrote:

 Can you define what you mean by patch snippets? The sections of code 
 that users comment on should be included in the HTML emails.


Sorry for the late reply. Somehow did not get this email notification.

The mail that I receive is not html (thankfully) and is only a plain text 
email with contents like:

===

filename
https://reviewboard-server/r/8995/#comment19850

comment

=

whereas what I want is something like:

=
filename
 actual code
comment
=

Sankar

 

 -David


 On Mon, Sep 9, 2013 at 10:37 PM, sankar.c...@gmail.com javascript:wrote:

 Hi,

 We are using ReviewBoard in our organization. Thanks for this nice 
 project.

 The reviewboard in our org is configured to send email notifications for 
 any new patches and patch review comments. However, the review comments and 
 the patches display a reviewboard url instead of the actual patch sources 
 in the notification email. Is there a way to display the actual sources in 
 the email instead of links to the review board ? (on the lines of how LKML 
 patch reviews happen)

 Thanks.

 Sankar

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Multiple reviewboard versions on one server

2013-09-12 Thread robcikss
Hello!

My current project involves migrating some of our implemented feature (that 
our office uses) from older reviewborad release to newer. But it is 
required that for now both reviewboard versions should be running, while 
migration is going on. As I'm new to reviewboard development and it's usage 
I have no idea how I could achieve this. I tried to google it but without 
success. 

Actually I tried to install two different reviewboard version, but it seems 
that only one of them is accessible (the later one installed). I taught 
that changing the .conf file in /etc/apache2/sites-enabled should be enough 
but after changing it and restarting apache server and memcached, the same 
reviewboard version is still running not the other.
I am using apache server (on localhost), memcahed, mod_wsg on Ubuntu 12.04.

I would appreciate any help

Thank You,
Robcikss

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-12 Thread David Trowbridge
I'm not sure what that would look like. Comments are over a set of rows in
the side-by-side diff rather than a set of lines from either the old or new
file. While it's possible that we could just pull out the relevant lines
from the changed revision of the file, it's likely that doing so would lose
a lot of the context for the comment. If we tried to mimic the HTML that we
show by showing columns in plain text, my instinct is that it would be very
hard to get formatted correctly, especially when mail clients wrap lines.

-David


On Thu, Sep 12, 2013 at 6:29 AM, sankar.curios...@gmail.com wrote:

 On Tuesday, September 10, 2013 11:16:21 AM UTC+5:30, David Trowbridge
 wrote:

 Can you define what you mean by patch snippets? The sections of code
 that users comment on should be included in the HTML emails.


 Sorry for the late reply. Somehow did not get this email notification.

 The mail that I receive is not html (thankfully) and is only a plain text
 email with contents like:

 ===

 filename
 https://reviewboard-server/r/8995/#comment19850

 comment

 =

 whereas what I want is something like:

 =
 filename
  actual code
 comment
 =

 Sankar



 -David


 On Mon, Sep 9, 2013 at 10:37 PM, sankar.c...@gmail.com wrote:

 Hi,

 We are using ReviewBoard in our organization. Thanks for this nice
 project.

 The reviewboard in our org is configured to send email notifications for
 any new patches and patch review comments. However, the review comments and
 the patches display a reviewboard url instead of the actual patch sources
 in the notification email. Is there a way to display the actual sources in
 the email instead of links to the review board ? (on the lines of how LKML
 patch reviews happen)

 Thanks.

 Sankar

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/**
 powerpack/ http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@**googlegroups.com.

 For more options, visit 
 https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out
 .


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Multiple reviewboard versions on one server

2013-09-12 Thread Christian Hammond
Hi,

One option is to use virtualenvs, which will let you fully separate out
your set of Python packages. This isn't something we document or really
support right now, though, and it's a bit advanced.

Another is to install on a separate server/VM, which will fully let you
separate entire configs.

What two versions are you trying to use?

Christian


On Thursday, September 12, 2013, robcikss wrote:

 Hello!

 My current project involves migrating some of our implemented feature
 (that our office uses) from older reviewborad release to newer. But it is
 required that for now both reviewboard versions should be running, while
 migration is going on. As I'm new to reviewboard development and it's usage
 I have no idea how I could achieve this. I tried to google it but without
 success.

 Actually I tried to install two different reviewboard version, but it
 seems that only one of them is accessible (the later one installed). I
 taught that changing the .conf file in /etc/apache2/sites-enabled should be
 enough but after changing it and restarting apache server and memcached,
 the same reviewboard version is still running not the other.
 I am using apache server (on localhost), memcahed, mod_wsg on Ubuntu 12.04.

 I would appreciate any help

 Thank You,
 Robcikss

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com javascript:_e({},
 'cvml', 'reviewboard%2bunsubscr...@googlegroups.com');.
 For more options, visit https://groups.google.com/groups/opt_out.



-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3090 in reviewboard: Review Board Error when uploading SVN Diff

2013-09-12 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3090 by a20...@motorola.com: Review Board Error when uploading  
SVN Diff

http://code.google.com/p/reviewboard/issues/detail?id=3090

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running? - Review Board 1.5

What's the URL of the page containing the problem? -  
http://ca25rbs.am.mot.com/reviews/iptv/r/2815/#



What steps will reproduce the problem?
1. Take an SVN diff of the two revisions from the SVN  
repository http://ca25csvn01.w1.bcs.mot.com/svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST/;  
running the command as below on a linux machine:
svn diff -r7125:7268  
http://ca25csvn01.w1.bcs.mot.com/svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST/  

svndiff_BLS2_7125_7268_new.txt
2. Create a new review and specify the base directory as :  
http://ca25csvn01.w1.bcs.mot.com/svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST

2.Choose file as svndiff_BLS2_7125_7268_new.txt as the diff.
3.Do not Choose Parent Diff
4. Click Upload button.

What is the expected output? What do you see instead?
Expected proceed to the next screen and show the file difference; so that I  
can publish the review.


Instead I am getting an error message The  
file http://ca25csvn01.w1.bcs.mot.com/svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST/PLATFORM/Bcm97405/SRC/BOOTLOADER/PlaycastBLS2/PlaycastBLS2_B0.bib;  
(revision 7125) was not found in the repository as given in the attached  
picture.


What operating system are you using? What browser?
Using Windows 7 and Chrome(Version 29.0). (I tried with IE Version 8)

Please provide any additional information below:
Attached zip file contains the SVN diff and the screen capture of the error.

Attachments:
svndiff_BLS2_7125_7268_newAndErrorCapture.zip  111 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3090 in reviewboard: Review Board Error when uploading SVN Diff

2013-09-12 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3090 by chip...@gmail.com: Review Board Error when  
uploading SVN Diff

http://code.google.com/p/reviewboard/issues/detail?id=3090

The base directory is not valid. It should be a path relative to the root  
of the SVN repository (not containing the path to the repository) where you  
generated the diff.


In your case, I would assume it's  
/svn/erpos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST.


By the way, do you want us to delete the uploaded file? This is a publicly  
visible bug tracker.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3090 in reviewboard: Review Board Error when uploading SVN Diff

2013-09-12 Thread reviewboard


Comment #2 on issue 3090 by a20...@motorola.com: Review Board Error when  
uploading SVN Diff

http://code.google.com/p/reviewboard/issues/detail?id=3090

I am getting a similar error as below; When I  
use /svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST.



The  
file /svn/repos/iptv/vip/branches/WINCE500_BCM7405_PLAYCAST/PLATFORM/Bcm97405/SRC/BOOTLOADER/PlaycastBLS2/PlaycastBLS2_B0.bib  
(revision 7125) was not found in the repository


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3090 in reviewboard: Review Board Error when uploading SVN Diff

2013-09-12 Thread reviewboard


Comment #3 on issue 3090 by a20...@motorola.com: Review Board Error when  
uploading SVN Diff

http://code.google.com/p/reviewboard/issues/detail?id=3090

Issue got resolved by setting the base directory  
to /iptv/vip/branches/WINCE500_BCM7405_PLAYCAST


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3090 in reviewboard: Review Board Error when uploading SVN Diff

2013-09-12 Thread reviewboard

Updates:
Status: UserError

Comment #4 on issue 3090 by trowb...@gmail.com: Review Board Error when  
uploading SVN Diff

http://code.google.com/p/reviewboard/issues/detail?id=3090

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 67 in reviewboard: Need to be able to send to an abitrary email address

2013-09-12 Thread reviewboard


Comment #8 on issue 67 by maryelai...@gmail.com: Need to be able to send to  
an abitrary email address

http://code.google.com/p/reviewboard/issues/detail?id=67

Ah, I realized this wasn't under EasyFix. I'll just come back to it later  
then, after I do an EasyFix.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2466 in reviewboard: In New Review Request the ul class=errorlist element floats over the input area in a narrow browser window

2013-09-12 Thread reviewboard


Comment #2 on issue 2466 by maryelai...@gmail.com: In New Review Request  
the ul class=errorlist element floats over the input area in a narrow  
browser window

http://code.google.com/p/reviewboard/issues/detail?id=2466

I'll try my hands on this EasyFix. ^^

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2752 in reviewboard: User is able to submit a review request without filling in required fields

2013-09-12 Thread reviewboard


Comment #5 on issue 2752 by maryelai...@gmail.com: User is able to submit a  
review request without filling in required fields

http://code.google.com/p/reviewboard/issues/detail?id=2752

I agree with #3. This doesn't look like an existing bug anymore. It doesn't  
allow me to publish a new request without the required fields filled in.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.