Re: Limitations with diff files - any suggestions?

2008-11-05 Thread Christian Hammond
Hi Nancy, I'm unclear as to the problem here. You're trying to feed in a diff with multiple files, or you want a review request to contain multiple separate diffs? I haven't heard of anyone needing to do that before and can't really figure out where you'd need that, so if you could help me to unde

Re: Windows Installation: Trouble posting diff by hand

2008-11-05 Thread Christian Hammond
It's expecting .svn directories and the ability to run "svn" in that directory. Might be helpful to see what "svn info" shows. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Nov 5, 2008 at 3:34 PM, SamClark <[EMAIL PROTECTED]> wrote: > > Do I have to configure post-re

Re: Using ignore file extensions on post-review

2008-11-05 Thread Russell Bryant
On Wed, Nov 5, 2008 at 6:54 AM, Dave Hocker <[EMAIL PROTECTED]> wrote: > > You can use the Perforce "p4 files" command to determine if Perforce > thinks the file is text or binary. The last token of the output will > be something like (text) or (binary+l). Note that for a binary file > the charact

Re: Windows Installation: Trouble posting diff by hand

2008-11-05 Thread SamClark
Do I have to configure post-review.py and where exactly do I run it? I'm using subversion and my working copy is c:\svn\Hello\*a bunch of .h and .c files that make up my pretend project* When I run it in c:\svn and c:\svn\Hello I get: C:\SVN>python post-review.py The current directory does not

Re: Windows Installation: Trouble posting diff by hand

2008-11-05 Thread Christian Hammond
The base diff path should be whatever directory (relative to the root of the SVN tree) that you were in when you generated the diff. So if you're in C:\MyProject and that directory is really http://svn.example.com/svn/trunk/MyProject, then your base diff path is /trunk/MyProject. It's confusing at

Windows Installation: Trouble posting diff by hand

2008-11-05 Thread SamClark
OS: XP pro SP 2 I am having trouble with viewing a diff when I post a review by hand. I can't seem to get the base diff path right. the repository is at: svn://server:9000/ I have a checkout at: C:\SVN\HelloCmd\Hello_Modified where Hello_Modified is the checkout folder. I used: svn di

Re: Using ignore file extensions on post-review

2008-11-05 Thread Dave Hocker
You can use the Perforce "p4 files" command to determine if Perforce thinks the file is text or binary. The last token of the output will be something like (text) or (binary+l). Note that for a binary file the character after the + is the letter L in lower case. We've had this issue and I plan to

Re: Getting error after adding Repository as Subversion and clicking New Review Request button.

2008-11-05 Thread Christian Hammond
Comments are tied to a revision of a diff. They cant carry over to another revision, since the code may change and lines won't sync up or make any sense anymore. You should be using the Review Request page to see what comments were made to certain lines. You can also use interdiffs to see what cha

Re: Using ignore file extensions on post-review

2008-11-05 Thread Marcos
It seems some already answered you, thanks Russel. On Nov 4, 9:14 pm, 13Strider <[EMAIL PROTECTED]> wrote: > I got it thanks, i put it right before Diff > > On Nov 4, 2:14 pm, 13Strider <[EMAIL PROTECTED]> wrote: > > > Thanks Russell, > > Now if i know where to put it i'll be set, im going to try

Re: Getting error after adding Repository as Subversion and clicking New Review Request button.

2008-11-05 Thread Dev
Hi, Can anyone pl tell me why i am not able to see comments for second revision of diff file?It's very difficult for me to verify what exactly is fixed in 2nd revision of diff file. Awaiting for reply. Regards, dev On Oct 30, 11:20 am, Dev <[EMAIL PROTECTED]> wrote: > Atlast got it work ..!Tha