Setting up problem on windows XP sp3
Hi I have a problem with reviewboard setting up on windows XP sp3. When i try to create site with the command rb-site install, it says rb- site' is not recognized as an internal or external command, operable program or batch file. (I didnt find any rb-site.exe in any of the folders in the machine ) .But i could mange to install reviewboard on windows 2003 and i follow the same approache for XP also.Please some help help me to find the problem with the setting up. Thanks. Pubudu. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Setting up problem on windows XP sp3
How did you install Review Board on that system? Can you list the steps you performed? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Aug 4, 2009 at 1:00 AM, dmpub...@gmail.com dmpub...@gmail.comwrote: Hi I have a problem with reviewboard setting up on windows XP sp3. When i try to create site with the command rb-site install, it says rb- site' is not recognized as an internal or external command, operable program or batch file. (I didnt find any rb-site.exe in any of the folders in the machine ) .But i could mange to install reviewboard on windows 2003 and i follow the same approache for XP also.Please some help help me to find the problem with the setting up. Thanks. Pubudu. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Email notification and webserver port?
Hi, I am running my reviewboard server/webserver of a non standard port, 8080. In all email notifications send out, the port number is not included in the URL. I have tried to change the Domain Name in Admin - Database - Sites, to http://my.server.com:8080 but that did not make any difference. In email.py I can find: ... context['domain'] = current_site.domain ... which makes me belive that is should be enough to change the site config. I can't see if there are other settings to change. Any idea? Cheers, lars --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Email notification and webserver port?
Responding to my self. Restarting of the webserver did the trick. I think it could be worth looking into which settings that needs a webserver restart to become active, and see if we can remove the restart dependency. cheers, lars 2009/8/4 Lars Olsson lars.olsso...@gmail.com Hi, I am running my reviewboard server/webserver of a non standard port, 8080. In all email notifications send out, the port number is not included in the URL. I have tried to change the Domain Name in Admin - Database - Sites, to http://my.server.com:8080 but that did not make any difference. In email.py I can find: ... context['domain'] = current_site.domain ... which makes me belive that is should be enough to change the site config. I can't see if there are other settings to change. Any idea? Cheers, lars --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Migrating to 1.0.1
Hi. Thanks for great tool and I happy to hear about new release which support Mercurial 1.3. I wonder is there any guide how to migrate from 1.0 to 1.0.1 without losing already submitted reviews? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
substring not found
Hi, I've installed Review Board 1.0.1 and added ClearCase repository. To test Review Board, I've prepared fake diff file: Index: configurations/demo/toolbox.jsp === --- configurations/demo/toolbox.jsp (label ) +++ configurations/demo/toolbox.jsp (label copy) @@ -4,6 +4,7 @@ org.buba.ejb.session.custom.CustomXMLizerHome, org.buba.ejb.session.custom.CustomXMLizer, org.buba.ejb.framework.*, +java.math.BigInteger, org.buba.ejb.session.common.CommonService, org.buba.ejb.session.common.CommonServiceHome, java.util.Collection, As result the following error occurred: substring not found. What can I do to resolve this problem? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
substring not found
Hi, I've installed Review Board 1.0.1 and added ClearCase repository. To test Review Board, I've prepared fake diff file: Index: configurations/demo/toolbox.jsp === --- configurations/demo/toolbox.jsp (label ) +++ configurations/demo/toolbox.jsp (label copy) @@ -4,6 +4,7 @@ org.buba.ejb.session.custom.CustomXMLizerHome, org.buba.ejb.session.custom.CustomXMLizer, org.buba.ejb.framework.*, +java.math.BigInteger, org.buba.ejb.session.common.CommonService, org.buba.ejb.session.common.CommonServiceHome, java.util.Collection, As result the following error occurred: substring not found. What can I do to resolve this problem? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Migrating to 1.0.1
Hi Sergius, Just follow the upgrade steps in our docs, and you'll be fine. You won't lose anything in the database. It can be summed up to doing: 1) easy_install -U ReviewBoard 2) rb-site upgrade /path/to/your/site 3) Restart the web server If you feel more comfortable, go ahead and do a backup of the database first. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Aug 4, 2009 at 7:55 AM, Sergius yer...@gmail.com wrote: Hi. Thanks for great tool and I happy to hear about new release which support Mercurial 1.3. I wonder is there any guide how to migrate from 1.0 to 1.0.1 without losing already submitted reviews? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: substring not found
Can you provide more information? I need to see the full error log. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Aug 4, 2009 at 9:34 AM, MiZhKa miz...@gmail.com wrote: Hi, I've installed Review Board 1.0.1 and added ClearCase repository. To test Review Board, I've prepared fake diff file: Index: configurations/demo/toolbox.jsp === --- configurations/demo/toolbox.jsp (label ) +++ configurations/demo/toolbox.jsp (label copy) @@ -4,6 +4,7 @@ org.buba.ejb.session.custom.CustomXMLizerHome, org.buba.ejb.session.custom.CustomXMLizer, org.buba.ejb.framework.*, +java.math.BigInteger, org.buba.ejb.session.common.CommonService, org.buba.ejb.session.common.CommonServiceHome, java.util.Collection, As result the following error occurred: substring not found. What can I do to resolve this problem? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: how to support mod_wsgi?
Hi Rupert, While we don't have support for generating a mod_wsgi config file out of the box, it's something we could add (patches are always welcome). However, you should be able to generate a FastCGI config file and then change it to resemble the config files you referenced below. I believe you can continue to use the existing reviewboard.fcgi file, but I have not tried this. Maybe someone else on this list has this set up with mod_wsgi and can offer a sample config file? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Aug 3, 2009 at 3:27 AM, rupert.thurner rupert.thur...@gmail.comwrote: hi, how could one use mod_wsgi to run reviewboard? example configs for other software: * http://mercurial.selenic.com/wiki/modwsgi * http://trac.edgewall.org/wiki/TracModWSGI rupert. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: improvements
Hi, On Wed, Jul 29, 2009 at 3:58 AM, gbjbaanb andy.bolstri...@gmail.com wrote: Hi everyone. I'm a very new user of ReviewBoard, I've just set it up, and as you asked for information on how I intend to use it, and suggestion for improvement... I'd thought I'd post now while my initial thoughts are still fresh. Feedback is always welcome! So far... I've got it set up and it looks good, there were a few pains getting going though: 1. in my setup, I only have a single DNS entry for the webserver. I'm using it in a corporate environment, and I don't want to set up a new box just for RB, so I thought I'd install it on the existing web server (which runs a few other development-related sites such as mantis). Unfortunately the installer assumes that it will be running as a vhost, and takes over the entire web on port 80. If this could be changed to a directory instead of a vhost, I think that would be a good improvement to make. Currently I have it running on a different port, as I cannot affect the other sites (and I'm not too hot on mod_python requirements) Most of the time, a vhost suffices and is the easiest to work with. It's a sample configuration file, so we expect people who are using more custom setups to customize the config file. We can probably look into generating other forms of config files in the future, but it's the kind of thing we'd prefer to take a patch for. 2. When installing, the dependancy on PyLucene made me decide not to bother with search :) Would it be a good idea to try using Clucene instead as it might be easier to get installed, and possibly faster/ efficient to run? PyLucene is definitely a pain to install. I wish there was something we could do about that.. Clucene isn't an option, because it's, well, not Python. We need to be able to hook into it, and need Python bindings for this, which is what PyLucene is. We may look into alternative, pure-Python search engines that we can use in the future, though they will almost surely be slower than PyLucene. Maybe that's okay though 3. When I installed it, I immediately had a 'taking a nap' error. Looking at the logs showed a problem with the python egg cache. Setting the environment variable inside the vhost directive fixed this, but it was an annoyance that it didn't work out of the box. Also, the error message could be worded better, 'taking a nap' suggests a delay, not a fatal error! Which config file did you use? The python egg cache should have been set correctly in generated config files. The errors are something we're working to improve. That particular error is from back in the day when Review Board was used in only 2 places: review-board.org and VMware. 4. LDAP support. I access active directory from a linux box, no problem with that except that the corporate AD doesn't allow anonymous reads. Most other sites I use from my linux server (eg wikipedia, mantis) allow you to set a ldap proxy user to connect with. That user then attempts to search for the user specified and logs you in. I couldn't see any option for this in the web UI, is it supported? I don't know a lot about LDAP. Our support comes from third parties who need LDAP support. So, I can't really answer this, except to say that I don't believe we have support for a proxy user, and we'd need a patch to support it. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: improvements
On 5 авг, 00:27, Christian Hammond chip...@chipx86.com wrote: ... 4. LDAP support. I access active directory from a linux box, no problem with that except that the corporate AD doesn't allow anonymous reads. Most other sites I use from my linux server (eg wikipedia, mantis) allow you to set a ldap proxy user to connect with. That user then attempts to search for the user specified and logs you in. I couldn't see any option for this in the web UI, is it supported? I don't know a lot about LDAP. Our support comes from third parties who need LDAP support. So, I can't really answer this, except to say that I don't believe we have support for a proxy user, and we'd need a patch to support it. If someone is counting then I'd vote for this support too! :) -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Stripping comments from patches -- not so good
Hi Joyjit, Are you talking about comments that precede the actual diff in the patch? This is a problem for git patches, and a bug 1229 is open for it. I looked into the issue a bit and I think it can be resolved by maintaining the extra info as part of the diff set. Right now, RB splits the diff into separate file diffs which are then concatenated together for downloading the full diff. I'm interested in this change, so I'll look into modifying the code when I have a chance. Dan On Jul 29, 6:11 pm, joyjit joy...@gmail.com wrote: When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard to preserve the patch in its entirety when one chooses Download Diff from the web gui.. Thanks Joyjit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Setting up problem on windows XP sp3
Check that your pythonXX/Scripts directory is in your path. This is not added by default. Dan On Aug 4, 4:24 am, Christian Hammond chip...@chipx86.com wrote: How did you install Review Board on that system? Can you list the steps you performed? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Aug 4, 2009 at 1:00 AM, dmpub...@gmail.com dmpub...@gmail.comwrote: Hi I have a problem with reviewboard setting up on windows XP sp3. When i try to create site with the command rb-site install, it says rb- site' is not recognized as an internal or external command, operable program or batch file. (I didnt find any rb-site.exe in any of the folders in the machine ) .But i could mange to install reviewboard on windows 2003 and i follow the same approache for XP also.Please some help help me to find the problem with the setting up. Thanks. Pubudu. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: substring not found
Clearcase support only officially works through post-review since it needs to do some tricks to generate the diff. How did you create this fake diff? Can you try following the steps I provided in this thread and see if you are able to get it to work? http://groups.google.com/group/reviewboard/browse_thread/thread/1a6124f46fd926a Dan On Aug 4, 4:07 pm, Christian Hammond chip...@chipx86.com wrote: Can you provide more information? I need to see the full error log. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Aug 4, 2009 at 9:34 AM, MiZhKa miz...@gmail.com wrote: Hi, I've installed Review Board 1.0.1 and added ClearCase repository. To test Review Board, I've prepared fake diff file: Index: configurations/demo/toolbox.jsp === --- configurations/demo/toolbox.jsp (label ) +++ configurations/demo/toolbox.jsp (label copy) @@ -4,6 +4,7 @@ org.buba.ejb.session.custom.CustomXMLizerHome, org.buba.ejb.session.custom.CustomXMLizer, org.buba.ejb.framework.*, + java.math.BigInteger, org.buba.ejb.session.common.CommonService, org.buba.ejb.session.common.CommonServiceHome, java.util.Collection, As result the following error occurred: substring not found. What can I do to resolve this problem? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Stripping comments from patches -- not so good
Yes, I am referring to the comments that preced the actual diff in the patch. Reviewboard throws them away, which makes it a kind of severe limitation for us to use in our workflow (which uses git). Thanks On Tue, Aug 4, 2009 at 4:19 PM, Dan Savilonisd...@n-cube.org wrote: Hi Joyjit, Are you talking about comments that precede the actual diff in the patch? This is a problem for git patches, and a bug 1229 is open for it. I looked into the issue a bit and I think it can be resolved by maintaining the extra info as part of the diff set. Right now, RB splits the diff into separate file diffs which are then concatenated together for downloading the full diff. I'm interested in this change, so I'll look into modifying the code when I have a chance. Dan On Jul 29, 6:11 pm, joyjit joy...@gmail.com wrote: When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard to preserve the patch in its entirety when one chooses Download Diff from the web gui.. Thanks Joyjit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1254 in reviewboard: Delta times in the review are incorrect
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1254 by gmcelhoe: Delta times in the review are incorrect http://code.google.com/p/reviewboard/issues/detail?id=1254 What version are you running? Where can I tell? What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/92545/ What steps will reproduce the problem? 1. Go to a review 2. Refresh 3. Look at the delta times in the review What is the expected output? What do you see instead? The review was last updated almost a day ago, but reviewboard is telling me it was updated 20 minutes ago. What operating system are you using? What browser? Firefox 3.5, Windows XP Please provide any additional information below. I included a screen shot, you can see the local time in the bottom corner, and the delta times are not accurate. Attachments: reviewboardtimes.png 48.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1255 in reviewboard: Traceback viewing diff for Mercurial 1.3 repository
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1255 by yerges: Traceback viewing diff for Mercurial 1.3 repository http://code.google.com/p/reviewboard/issues/detail?id=1255 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.1 What's the URL of the page containing the problem? http://reviewboard-server/r/115/diff/#index_header What steps will reproduce the problem? 1. Clone repository (mercurial 1.3 repo) 2. Make a minor change, run hg diff hg.diff 3. In reviewboard Create New Request providing hg.diff 4. Click on View Diff What is the expected output? What do you see instead? I expect diff and see traceback instead. What operating system are you using? What browser? Windows Vista Ultimate SP2 Firefox 3.0.12 Please provide any additional information below. Error text: The patch to 'setup/SPB' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.3tarQx' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.3tarQx/tmp7t1HGD Hunk #1 FAILED at 3. Hunk #2 FAILED at 12. 2 out of 2 hunks FAILED -- saving rejects to file /tmp/reviewboard.3tarQx/tmp7t1HGD-new.rej Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 623, in get_diff_files large_data=True) File /usr/local/lib/python2.6/dist-packages/Djblets-0.5.1-py2.6.egg/djblets/util/misc.py, line 144, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 622, in lambda enable_syntax_highlighting), File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/diffviewer/diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'setup/SPB' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.3tarQx' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.3tarQx/tmp7t1HGD Hunk #1 FAILED at 3. Hunk #2 FAILED at 12. 2 out of 2 hunks FAILED -- saving rejects to file /tmp/reviewboard.3tarQx/tmp7t1HGD-new.rej --- I've attached screenshot of ` cat /tmp/reviewboard.3tarQx/tmp7t1HGD-new content.html` with blurred info I can't show due to confidentiality agreement. I believe the problem is in the fact this is catalog page instead of exact file text page. We have other repositories which works fine. There is one visual difference that I see -- other repos has manifest link and this one has files... Attachments: reviewboard-issue.jpg 32.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1254 in reviewboard: Delta times in the review are incorrect
Updates: Status: NeedInfo Comment #1 on issue 1254 by chipx86: Delta times in the review are incorrect http://code.google.com/p/reviewboard/issues/detail?id=1254 Can you shift-reload the page and tell me if it fixes itself? It could be a browser caching issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1257 in reviewboard: Screenshot caption is erased in certain cases
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1257 by grossag: Screenshot caption is erased in certain cases http://code.google.com/p/reviewboard/issues/detail?id=1257 *NOTE: Do not post confidential information in this bug report.* What version are you running? Whatever VMware is running now. Probably the RC. What's the URL of the page containing the problem? Saw it on https://reviewboard.eng.vmware.com/r/93173/ but I don't think it matters. What steps will reproduce the problem? 1. Create a review. Don't publish it yet. 2. Upload a screenshot but don't give it a caption. 3. Now edit the existing screenshot to give it a caption. 4. Upload another screenshot. What is the expected output? What do you see instead? You will see that the first screenshot's name is cleared even though in step #3 we gave it a caption. The caption should persist. What operating system are you using? What browser? Windows XP Pro SP3 running Google Chrome 3.0. Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1257 in reviewboard: Screenshot caption is erased in certain cases
Comment #2 on issue 1257 by grossag: Screenshot caption is erased in certain cases http://code.google.com/p/reviewboard/issues/detail?id=1257 Hmm nevermind, maybe this is a dupe of 1142. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1257 in reviewboard: Screenshot caption is erased in certain cases
Comment #3 on issue 1257 by chipx86: Screenshot caption is erased in certain cases http://code.google.com/p/reviewboard/issues/detail?id=1257 It's slightly different. Enough so that I'm willing to have two bugs open. That one's more about not auto-saving those files, since we trigger a reload. Which, I just realized, is fixed in SVN... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---