Permissions and Offline Mode

2010-12-21 Thread Leonel Togniolli
Hi, I recently started looking into Review Board and I'm about to give it a try with my team. A couple questions before I start: It appears to be possible as an unauthenticated user to see all review quests and the diffs. I need to prevent that and only let logged in users to do so. A setting

Reversed (or previously applied) patch detected! when view diff after git push

2010-12-21 Thread birdsong
I'm getting this error http://pastebin.com/uEwh1vjR Setup is: reviewboard on same servers as bare git repo and cgit server. path: /home/git/repositories/f.web.git mirror path: g...@repo.f.com:f.web.git raw file url mask: http://localhost:7000/cgit/f.web/plain/filename?id2=revision (i know i'm

Re: Permissions and Offline Mode

2010-12-21 Thread Christian Hammond
Hi Leonel, On Tue, Dec 21, 2010 at 4:20 AM, Leonel Togniolli tognio...@gmail.com wrote: Hi, I recently started looking into Review Board and I'm about to give it a try with my team. A couple questions before I start: It appears to be possible as an unauthenticated user to see all review

Re: Using reviewboard post-review with 'hg export' ?

2010-12-21 Thread Christian Hammond
Hi, Sorry for the late reply here. Holidays and all.. On Fri, Dec 17, 2010 at 7:06 AM, Oz Linden (Scott Lawrence) o...@lindenlab.com wrote: Our project uses Mercurial, and so there are a couple of things I'd like to be able to have contributors post patches generated with 'hg export' (either

Re: Reversed (or previously applied) patch detected! when view diff after git push

2010-12-21 Thread Christian Hammond
Can you plug in a filename and SHA1 into that raw URL mask and see if it's actually fetching using the SHA1? If modifying the tip of origin breaks things, I wonder if it's not actually making use of the SHA1 on your copy of cgit. If things break with gtk+, maybe there is some compatibility change.

Re: Using reviewboard post-review with 'hg export' ?

2010-12-21 Thread Oz Linden (Scott Lawrence)
On 2010-12-21 18:18, Christian Hammond wrote: There's a --repository-url parameter for post-review that can specify which repository you want to match on the server. It doesn't look like the Mercurial support in post-review handles this parameter, but it wouldn't take much to patch that if you

Re: Using reviewboard post-review with 'hg export' ?

2010-12-21 Thread Christian Hammond
On Tue, Dec 21, 2010 at 4:50 PM, Oz Linden (Scott Lawrence) o...@lindenlab.com wrote: On 2010-12-21 18:18, Christian Hammond wrote: There's a --repository-url parameter for post-review that can specify which repository you want to match on the server. It doesn't look like the Mercurial

Re: Using reviewboard post-review with 'hg export' ?

2010-12-21 Thread Oz Linden (Scott Lawrence)
On 2010-12-21 20:07, Christian Hammond wrote: First, there are two APIs today: the old Review Board 1.0 API, and the new REST one in RB 1.5. Today, post-review uses the RB 1.0 API only. I have a chance pending, which needs some additional work done first, that will update post-review to use

Re: Using reviewboard post-review with 'hg export' ?

2010-12-21 Thread Christian Hammond
On Tue, Dec 21, 2010 at 6:18 PM, Oz Linden (Scott Lawrence) o...@lindenlab.com wrote: Yes, a direct REST api that returned the url for a name would certainly be helpful. Do you plan to make it possible to require authentication for the REST apis in 1.6?  I'm currently running my server with