Re: Problem : A repository was not found at the specified path.

2011-09-30 Thread Mathias Schnydrig
I looked at the packets using wireshark.When a DNS lookup for the svn server
is done there is also a lookup for GitHub, which I did not configure.

The SVN server is placed in the same network as ReviewBoard but not on the
same system, so a communication through the proxy is not needed.

I have logging turned on but the only message I get is the one I've
previously posted:
ERROR - SVN: Failed to get repository information for
svn://svnServer.local/.../: Can't connect to host 'svnServer.local':
Permission denied.

Mathias

On the SVN server there is no ssh used, only a user authentication (username
and password).

On Fri, Sep 30, 2011 at 12:06 AM, Christian Hammond chip...@chipx86.comwrote:

 Where are you seeing that it wants to connect to GitHub? It shouldn't try
 that unless you've set the repository to talk to GitHub.

 I don't believe you'll end up going through the proxy for this, at least
 not on Review Board server when talking to Subversion.

 Is Review Board and the Subversion server on the same system?

 Do you have logging turned on for Review Board? Do you see any errors when
 attempting to save the repository?

 Christian


 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Sep 29, 2011 at 6:41 AM, Mathias Schnydrig 
 mathias.al...@gmail.com wrote:

 Hello Christian

 In my inquiries I found out that when I want to add my repo, reviewboard
 wants to connect to github. Why?
 Do I have to change some settings in reviewboad when I am behind a proxy?
 But I can still not find the solution to my problem...

 best
 Mathias


 On Mon, Sep 26, 2011 at 9:54 AM, Mathias Schnydrig 
 mathias.al...@gmail.com wrote:

 Hello,
 when I do an svn info I get:
 Path: .
 URL: svn://svnServer.local/.../trunk
 Repository Root: svn://svnServer.local/.../
 Repository UUID: b802f934-c87b-436e-8b01-e42a254ff852
 Revision: 1037
 Node Kind: directory
 Schedule: normal
 Last Changed Author: user0
 Last Changed Rev: 1037
 Last Changed Date: 2011-09-22 16:19:46 +0200 (Thu, 22 Sep 2011)

 Mathias




 On Sun, Sep 25, 2011 at 7:40 PM, Christian Hammond 
 chip...@chipx86.comwrote:

 Hi,

 What happens if you do an svn info on that address from that machine?

 Christian



 On Friday, September 23, 2011, schnmat mathias.al...@gmail.com wrote:
  Hello
 
  I just installed the most recent version of RevieBoard (1.6.1) on a
  CentOS6 machine. I had to install the pysvn from scratch, but the rest
  went quite well. So far so good.
 
  But when I want to add a repository (Hosting Service: Custom,
  Repository Type: Subversion) which is placed in the same subnet of my
  company I get the error:
  A repository was not found at the specified path.
  I enabled the log and get the message:
  2011-09-23 14:45:55,554 - ERROR - SVN: Failed to get repository
  information for svn://svnServer.local/.../: Can't connect to host
  'svnServer.local': Permission denied
 
  The Username and Password are correct, and when I enter some other
  Username and Pasword I get the same messages, it seams that they are
  not used at all in this case...
 
  I also looked at the packets in Wireshark, but I can only see some DNS
  packages to the svn server...
 
  All help is most appreciated
 
  Mathias
 
  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know at http://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en



  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 

Re: Is Review Board mostly useful in offline code review?

2011-09-30 Thread Nelson Jones
I agree. Thanks David.

On Sep 29, 1:55 pm, David Trowbridge trowb...@gmail.com wrote:
 You could use it for either. It's maybe not perfect during a meeting
 but it does mean that
 you have a full record of all the comments.

 -David



 On Thu, Sep 29, 2011 at 10:49 AM, Nelson Jones huawen@gmail.com wrote:
  Is it overkill if used for  meeting type code review (face to face
  code review)? Any comments?
  Thanks

  --
  Want to help the Review Board project? Donate today 
  athttp://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to 
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group 
  athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text -

 - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Is there a print function in review board?

2011-09-30 Thread Nelson Jones
Hi, Just wonder is there a print function in review board? In case, a
face to face review is needed? Thanks,

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


LDAP Authentication

2011-09-30 Thread purushoth
hello,

 i am a newbie to reviewboard. below are the details of my server:

os : ubuntu 11.04 server

version  : ReviewBoard 1.6.1 using wsgi method in Apache2

i am trying to configure the ldap authentication and getting the below
error:

  19:59:30  WARNING LDAP error: {'desc': 'Bad search filter'}.

my settings are:

LDAP Server: ldap://mydomain.com:389
LDAP Base DN : dc=example,dc=com
E-Mail LDAP Attribute: mail
Use TLS for authentication: unchecked
User Mask:uid=sAMAccountName=%s,dc=mydomain,dc=com
Anonymous User
Mask:cn=administrator,cn=Users,dc=server,dc=mydomain,dc=com
Anonymous User Password: 

please guide me on setting this up

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Is there a print function in review board?

2011-09-30 Thread Christian Hammond
Hi Nelson,

There's just the standard browser print capabilities. We don't do any
special formatting.

Christian


On Friday, September 30, 2011, Nelson Jones huawen@gmail.com wrote:
 Hi, Just wonder is there a print function in review board? In case, a
 face to face review is needed? Thanks,

 --
 Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Is there a print function in review board?

2011-09-30 Thread Nelson Jones
I see. Thanks Christian!

On Sep 30, 12:00 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Nelson,

 There's just the standard browser print capabilities. We don't do any
 special formatting.

 Christian

 On Friday, September 30, 2011, Nelson Jones huawen@gmail.com wrote:
  Hi, Just wonder is there a print function in review board? In case, a
  face to face review is needed? Thanks,

  --
  Want to help the Review Board project? Donate today at

 http://www.reviewboard.org/donate/ Happy user? Let us know 
 athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to

 reviewboard+unsubscr...@googlegroups.com For more options, visit this group 
 at

 http://groups.google.com/group/reviewboard?hl=en

 --
 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Does Creating Review Requests /Publish Comments send email notifications?

2011-09-30 Thread Nelson Jones
Hi,
Does Creating Review Requests/Publish Comments send email
notifications?
Mine doesn't. Wonder if it's the same for every body?

Thanks,

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Does Creating Review Requests /Publish Comments send email notifications?

2011-09-30 Thread Christian Hammond
It does if your email is configured correctly. If you have that configured,
check your mail server's logs for errors.

Christian


On Friday, September 30, 2011, Nelson Jones huawen@gmail.com wrote:
 Hi,
 Does Creating Review Requests/Publish Comments send email
 notifications?
 Mine doesn't. Wonder if it's the same for every body?

 Thanks,

 --
 Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Is there a print function in review board?

2011-09-30 Thread Chris Clark
One option is to print the email sent from reviewboard. If you want to 
print the diffs you are likely to find sizing issues with the web page 
approach with the wide side-by-side diff view.


We've modified our RB server to include the diff in the email that is 
sent out for review (we've not yet worked out how to NOT include the 
diffs in replies/comments). That can help a little bit but the main 
advantage we've found is using the browser to see the diffs and then 
immediately expand code and add comments. You could do this with 
face-to-face reviews if the computer is used instead of print.



Chris


On 9/30/2011 9:06 AM, Nelson Jones wrote:

I see. Thanks Christian!

On Sep 30, 12:00 pm, Christian Hammondchip...@chipx86.com  wrote:

Hi Nelson,

There's just the standard browser print capabilities. We don't do any
special formatting.

Christian

On Friday, September 30, 2011, Nelson Joneshuawen@gmail.com  wrote:

Hi, Just wonder is there a print function in review board? In case, a
face to face review is needed? Thanks,




--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Is there a print function in review board?

2011-09-30 Thread Stephen Gallagher
On Fri, 2011-09-30 at 11:32 -0700, Chris Clark wrote:
 One option is to print the email sent from reviewboard. If you want to 
 print the diffs you are likely to find sizing issues with the web page 
 approach with the wide side-by-side diff view.
 
 We've modified our RB server to include the diff in the email that is 
 sent out for review (we've not yet worked out how to NOT include the 
 diffs in replies/comments). That can help a little bit but the main 
 advantage we've found is using the browser to see the diffs and then 
 immediately expand code and add comments. You could do this with 
 face-to-face reviews if the computer is used instead of print.

Does it send the diff in the email contents or as an attachment? If the
latter, could you share your patch with the rest of the class? :)

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


LDAP configuration

2011-09-30 Thread jack jack
Hi,

If i configure LDAP in reviewboard, Do i need to change
apache-modpython.conf i.e httpd.conf file?

-Jack

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: LDAP configuration

2011-09-30 Thread Christian Hammond
No, you should only need to provide the settings in the admin UI.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Sep 30, 2011 at 11:56 AM, jack jack jais...@gmail.com wrote:

 Hi,

 If i configure LDAP in reviewboard, Do i need to change
 apache-modpython.conf i.e httpd.conf file?

 -Jack

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: LDAP configuration

2011-09-30 Thread jack jack
After configuration of LDAP we need create specfic user in the review board
right?

*I added following entries

*

LDAP host = ldap://nascmroot01:3268

BaseDN = dc=xxware,dc=com

Do i need to fill all the information in LDAP setting.

In the reviewboard log i can see following error message, what is going
wrong here. How can i increase the debug level of review baord error to get
more information

2011-09-30 09:27:36,742 - WARNING - LDAP error: {'info': ': LdapErr:
DSID-0C090627, comment: In order to perform this operation a successful bind
must be completed on the connection., data 0, vece', 'desc': 'Operations
error'}
2011-09-30 09:27:56,909 - WARNING - LDAP error: {'info': ': LdapErr:
DSID-0C090627, comment: In order to perform this operation a successful bind
must be completed on the connection., data 0, vece', 'desc': 'Operations
error'}


On Sat, Oct 1, 2011 at 12:31 AM, Christian Hammond chip...@chipx86.comwrote:

 No, you should only need to provide the settings in the admin UI.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Sep 30, 2011 at 11:56 AM, jack jack jais...@gmail.com wrote:

 Hi,

 If i configure LDAP in reviewboard, Do i need to change
 apache-modpython.conf i.e httpd.conf file?

 -Jack

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Is there a print function in review board?

2011-09-30 Thread Chris Clark

On 9/30/2011 11:34 AM, Stephen Gallagher wrote:

On Fri, 2011-09-30 at 11:32 -0700, Chris Clark wrote:

One option is to print the email sent from reviewboard. If you want to
print the diffs you are likely to find sizing issues with the web page
approach with the wide side-by-side diff view.

We've modified our RB server to include the diff in the email that is
sent out for review (we've not yet worked out how to NOT include the
diffs in replies/comments). That can help a little bit but the main
advantage we've found is using the browser to see the diffs and then
immediately expand code and add comments. You could do this with
face-to-face reviews if the computer is used instead of print.

Does it send the diff in the email contents or as an attachment?


It depends :-)

It is semi-configurable, i.e. there is code that has a parameter but it 
is hard coded at the moment.


We default to inline (this matches our old review standards that 
predated re) but switch to an attachment if we have no idea what the 
encoding of the diff is.


We need to add a size filter, e.g. we had a monster review the other day 
and what should have happened is the diff should have been compressed 
and attached.




  If the
latter, could you share your patch with the rest of the class? :)


Right now the code is in a private git repo :-( This is an excellent 
reminder that we should try and make this public even if no one will 
want all of it. Right now what we have is NOT ready for prime time


As a taster, here is the code, it is not pep8 compliant and it isn't a 
diff (we're on an older version), but it should allow you to make a 
similar (more robust!) change:


in reviewboard/templates/notifications/review_request_email.html:

{% if raw_diff %}
table width=100% bgcolor=#ff cellspacing=0 cellpadding=10 
style=border: 1px solid #b8b5a0

tr
td
pre style=margin: 0; padding: 0; {{precss}}{{ raw_diff }}/pre
/td
/tr
/table
{% endif %}

--- this is the inline diff option


In /reviewboard/notifications/email.py:


context['MEDIA_SERIAL'] = settings.MEDIA_SERIAL

# should really (add to) repository and add include raw diffs option
# for now check scm type or always do it!
include_raw_diff=True
#include_raw_diff=False ## DEBUG FIXME REMOVE!
## NOTE some of our mailing list do not retain (diff) attachments.
attachment_message='Diffs attached'
emaildiffs_inline=True ## if False make an attachment
context['raw_diff']=''
#context['raw_diff']='debug raw diff FIXME REMOVE'
if include_raw_diff:
## Other option, instead of a flag include_raw_diff could 
lazy evaluate
## http://pyds.muensterland.org/ has a nice short one (only 
needs minor cleanup, and I already have a cleaned up copy)

diffset = review_request.diffset_history.diffsets.latest()
raw_diff = 
review_request.repository.get_scmtool().get_parser('').raw_diff(diffset)

if emaildiffs_inline and isinstance(raw_diff, str):
try:
_ = raw_diff.decode('us-ascii') # should check 
repository encoding type..

except UnicodeDecodeError:
# non-ASCII data in diff, email is (probably) utf8 and
# so will not display inline. Switch to an attachment
emaildiffs_inline=False ## if False make an attachment
attachment_message='Diffs contain non-ASCII 
characters/bytes, unable to determine encoding. See attachment.'

if emaildiffs_inline:
context['raw_diff']=raw_diff
else:
# attach
context['raw_diff']=attachment_message



message = SpiffyEmailMessage(subject.strip(), text_body, html_body,
 from_email, list(to_field), 
list(cc_field),

 in_reply_to, headers)

if include_raw_diff and not emaildiffs_inline:
message.attach('diff.diff', raw_diff, 'text/x-diff')



--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: LDAP Authentication

2011-09-30 Thread Tucker
Are you really using example in your base DN?

On Fri, Sep 30, 2011 at 7:48 AM, purushoth purushot...@gmail.com wrote:
 hello,

  i am a newbie to reviewboard. below are the details of my server:

 os : ubuntu 11.04 server

 version  : ReviewBoard 1.6.1 using wsgi method in Apache2

 i am trying to configure the ldap authentication and getting the below
 error:

  19:59:30      WARNING         LDAP error: {'desc': 'Bad search filter'}.

 my settings are:

 LDAP Server: ldap://mydomain.com:389
 LDAP Base DN : dc=example,dc=com
 E-Mail LDAP Attribute: mail
 Use TLS for authentication: unchecked
 User Mask:uid=sAMAccountName=%s,dc=mydomain,dc=com
 Anonymous User
 Mask:cn=administrator,cn=Users,dc=server,dc=mydomain,dc=com
 Anonymous User Password: 

 please guide me on setting this up

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en



-- 

--tucker

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en