Configured repository doesn't show on New Review Request page
Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Configured repository doesn't show on New Review Request page
Hey, Do you have the clearcase command line tool installed on the server? If it's not found, then it won't display. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 1:08 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: API question: list of files in requests, filtered by path and request date
Hi Dado, The web API isn't really built to provide this sort of query, unfortunately. What would be needed is a new resource for all modified diffs that let you query such information. I'd be happy to include such a resource, but someone would have to write it. I'm curious what you're working on. Maybe there are other solutions for now. Also, what version of RB? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 5, 2012 at 6:11 PM, dado d...@dado.org wrote: What would be the best way of getting a list of all reviewed files matching a determined perforce path? I also know I'm after the reviews created after 04/01/12. Should I simply get all the reviews after that date and do any additional filtering client-side? If so, what would be the best way to get all reviews after April *and* the list of files in the reviews? I've used the WEB API before, but I'm clearly not very comfortable with it yet. Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issues publishing review with ReviewBoard
Hi Brian,
One more thing to sanity check. If you go to your General Settings page, do
you have the server set as http://blah, or https://blah ?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 4:59 PM, Brian Lewis *@brianlewis.us wrote:
Hi Christian,
Yes - I just stopped apache and manually restarted it as well just to make
sure. Here's a copy of the reviewboard.wsgi file ::
import os
import sys
os.environ['DJANGO_SETTINGS_MODULE'] = reviewboard.settings
os.environ['PYTHON_EGG_CACHE'] = /var/www/reviewboard/tmp/egg_cache
os.environ['HOME'] = /var/www/reviewboard/data
os.environ['HTTPS'] = 'on'
sys.path = ['/var/www/reviewboard/conf'] + sys.path
import django.core.handlers.wsgi
application = django.core.handlers.wsgi.WSGIHandler()
On Wednesday, December 5, 2012 4:52:12 PM UTC-8, Christian Hammond wrote:
Just to sanity check, did you reload Apache?
We put in absolute URLs, and we tell Django to build those for us. Django
will insert https if it sees the HTTPS environment variable set to
on, and http otherwise. Provided the process is ending up with this
environment variable set, and the server is reloaded, it should be working.
Would you mind pasting the reviewboard.wsgi file?
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 4:46 PM, Brian Lewis *...@brianlewis.us wrote:
Hi Christian,
Just tried that and there's no change. Additionally, I notice the
response from the first request looks like this (notice the http URL's vs
https.. almost like it sees the redirect but doesn't want to follow it!)
{stat: ok, review_request: {status: pending, last_updated:
2012-12-05 14:02:11, description: , links: {diffs: {href:
http://reviewboard.**COMPANYNAME.com/reviews/api/**
review-requests/189/diffs/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/diffs/,
method: GET}, repository: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**repositories/3/http://reviewboard.COMPANYNAME.com/reviews/api/repositories/3/,
method: GET, title: Puppet}, screenshots: {href:
http://reviewboard.**COMPANYNAME.com/reviews/api/**review-requests/189/*
*screenshots/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/screenshots/,
method: GET}, self: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/,
method: GET}, update: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/,
method: PUT}, last_update: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/last-**update/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/last-update/,
method: GET}, reviews: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/reviews/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/reviews/,
method: GET}, draft: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/draft/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/draft/,
method: GET}, file_attachments: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/file-**attachments/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/file-attachments/,
method: GET}, submitter: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**users/admin/http://reviewboard.COMPANYNAME.com/reviews/api/users/admin/,
method: GET, title: admin}, changes: {href:
http://reviewboard.**COMPANYNAME.com/reviews/api/**
review-requests/189/changes/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/changes/,
method: GET}, delete: {href: http://reviewboard.**
COMPANYNAME.com/reviews/api/**review-requests/189/http://reviewboard.COMPANYNAME.com/reviews/api/review-requests/189/,
method: DELETE}}, public: false, target_groups: [], bugs_closed:
[], changenum: null, target_people: [], testing_done: , branch:
, time_added: 2012-12-05 14:02:11, summary: , id: 189}}
On Wednesday, December 5, 2012 4:38:51 PM UTC-8, Christian Hammond wrote:
Hi Brian,
Something to try would be to add:
os.environ['HTTPS'] = 'on'
to htdocs/reviewboard.wsgi.
See if that makes a difference. I noticed this at one point as well. We
need to change things to generate this by default if using https, or find a
beter way to turn it on by default.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 4:31 PM, Brian Lewis *...@brianlewis.us wrote:
Hello All,
I've been racking my brain on this for a couple of days and figured
I'd post here before I
Re: Configured repository doesn't show on New Review Request page
Do you mean cleartool? I assume then, that answer is yes. Unfortunately, I can only assume as I don't have direct access to server, I can only instruct the responsible technician. At first, when I tried to add vobs, there was an error message stating The executable cleartool is not in the path. I asked him to fix it, and it seemed that it works as I became able to add repos. The problem now is that they don't show up in the list. If cleartool is installed, could the cause still be that I'm not providing proper path information? Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Hey, Do you have the clearcase command line tool installed on the server? If it's not found, then it won't display. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 1:08 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Configured repository doesn't show on New Review Request page
Sorry, yes, cleartool. (It's a bit late here.) If cleartool is there, then yeah, it's probably a repository path problem. I'd see if there's any error information in the reviewboard.log file that indicates what may be going wrong. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 2:43 AM, Géza Kulcsár gesap...@gmail.com wrote: Do you mean cleartool? I assume then, that answer is yes. Unfortunately, I can only assume as I don't have direct access to server, I can only instruct the responsible technician. At first, when I tried to add vobs, there was an error message stating The executable cleartool is not in the path. I asked him to fix it, and it seemed that it works as I became able to add repos. The problem now is that they don't show up in the list. If cleartool is installed, could the cause still be that I'm not providing proper path information? Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Hey, Do you have the clearcase command line tool installed on the server? If it's not found, then it won't display. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 1:08 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Info per source file
Hi, I'm writing a command line python script (to check if the given sourcefile was reviewed). My idea is to fetch enough information from Mysql tables. E.g.: 1. select diffset_id from reviewboard.diffviewer_filediff (where source_file==*needed_filename*) 2. select history_id from reviewboard.diffviewer_diffset (where id=* =selected_diffset_id*) 3. select ship_it from reviewboard.reviews_review (where id=* =selected_diffset_id*) ship_it==1 would tell that at least one file was reviewed in a diffset. The information would be incomplete but better than nothing. I even can't check this way if a whole diffset was reviewed. I didn't try web API, but It may be useful if You post an example. Thanks, Laimonas -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review fails if no tracking branch, when not needed?
On 2012-12-05 19:43, Christian Hammond wrote: When scanning for the right type of SCMTool for a repository, we ask each SCMTool to try to provide information on the repository. If we can get something useful out of it, we assume the tool is valid. Makes sense. The Git tool is asking for that data and is computing the tracking branch up-front, in all cases. That seems odd though. Maybe I miss something; if you're asking for a specific revision range, would not the first revision in the range always be the tracking branch? (It seems offhand it would be, but as I say, I'm not convinced if I miss something. If that /is/ the case, though, this would be the logical way to work around this issue.) Also would be good to know, as this is how I am working around the issue at present. It might be nice to only fetch when we need it, and we know there's a lot of work that needs to be done to refactor this code and clean it up. Would you mind filing a bug to help us track this? Sure. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Configured repository doesn't show on New Review Request page
Hi! I checked and it really seems that path will be problem? Could you help me in providing correct path format? Do I only need /vobs/..., or I need a view name on top of it, or any other variation? I'm a bit confused, as your documentation mentions views somewhere, but your on-page hint states absolute path, which, from server point of view, would be /vobs/... Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Sorry, yes, cleartool. (It's a bit late here.) If cleartool is there, then yeah, it's probably a repository path problem. I'd see if there's any error information in the reviewboard.log file that indicates what may be going wrong. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 2:43 AM, Géza Kulcsár gesap...@gmail.com wrote: Do you mean cleartool? I assume then, that answer is yes. Unfortunately, I can only assume as I don't have direct access to server, I can only instruct the responsible technician. At first, when I tried to add vobs, there was an error message stating The executable cleartool is not in the path. I asked him to fix it, and it seemed that it works as I became able to add repos. The problem now is that they don't show up in the list. If cleartool is installed, could the cause still be that I'm not providing proper path information? Thanks, Géza Kulcsár 2012/12/6 Christian Hammond chip...@chipx86.com: Hey, Do you have the clearcase command line tool installed on the server? If it's not found, then it won't display. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Dec 6, 2012 at 1:08 AM, Géza Kulcsár gesap...@gmail.com wrote: Hi! I'm trying to configure Review Board with ClearCase. I have successfully added a repository, but I'm not sure whether I'm giving path information in correct form. Could it affect if the repository showing or not in the list on New Review Request page? As I go there, there is nothing in the list but the default None option. Thanks, Best regards, Géza Kulcsár -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.7 RC 1 is released!
Thanks for the response Chris!
I upgrade CentOS to 5.8, manually installed Python 2.7, upgraded setuptools
for 2.7, then upgraded RB to 1.7rc1. All this made it fine (after getting
bunch of issues those I could look up in Google). Now I am stuck at
upgrading the site and my RB instance is down ... Please help!
[root@jira ~]# /usr/local/bin/rb-site upgrade /var/www/reviews.xxx..com
Rebuilding directory structure
Updating database. This may take a while.
/usr/local/lib/python2.7/site-packages/Djblets-0.7.5-py2.7.egg/djblets/gravatars/__init__.py:26:
DeprecationWarning: the md5 module is deprecated; use hashlib instead
from md5 import md5
/usr/local/lib/python2.7/site-packages/pycrypto-2.6-py2.7-linux-x86_64.egg/Crypto/Util/number.py:57:
PowmInsecureWarning: Not using mpz_powm_sec. You should rebuild using
libgmp = 5 to avoid timing attack vulnerability.
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.
Run `./manage.py evolve --hint` to see a suggestion for the changes
required.
The following are the changes that could not be resolved:
In model reviews.FileAttachmentComment:
Field 'extra_data' has been added
In model reviews.ReviewRequest:
Field 'last_review_activity_timestamp' has been added
Field 'last_review_timestamp' has been deleted
In model accounts.Profile:
Field 'timezone' has been added
Field 'open_an_issue' has been added
In model diffviewer.DiffSetHistory:
Field 'last_diff_updated' has been added
In model diffviewer.FileDiff:
Field 'diff_hash' has been added
Field 'parent_diff_hash' has been added
Field 'diff64' has been added
Field 'parent_diff64' has been added
Field 'parent_diff' has been deleted
Field 'diff' has been deleted
The model auth.Message has been deleted
Error: Your models contain changes that Django Evolution cannot resolve
automatically.
On Wednesday, December 5, 2012 8:36:42 PM UTC+5:30, Christian Hammond wrote:
Review Board 1.7 requires Python 2.5 or higher. You'll have to upgrade in
order for it to work.
What I'd recommend is a newer CentOS install, since some of our
dependencies will also need to be updated, and you won't hit as many issues
with the upgrade. Your best bet is to upgrade to something with Python 2.7.
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 2:22 AM, Vishal Gautam
gautam...@gmail.comjavascript:
wrote:
We are trying out RB, we have 1.6.14 installed and running on CentOS 5.5.
Tried to upgrade it to 1.7 using following cmd but its failing ...
easy_install -f
http://downloads.reviewboard.org/releases/ReviewBoard/1.7 -U ReviewBoard
Here is the stracktrace, any help will be much appreciated
Best match: ReviewBoard 1.7rc1
Downloading
http://downloads.reviewboard.org/releases/ReviewBoard/1.7/ReviewBoard-1.7rc1.tar.gz
Processing ReviewBoard-1.7rc1.tar.gz
Running ReviewBoard-1.7rc1/setup.py -q bdist_egg --dist-dir
/tmp/easy_install-vW-lSE/ReviewBoard-1.7rc1/egg-dist-tmp-DrI1Td
Traceback (most recent call last):
File ./contrib/internal/build-media.py, line 19, in ?
ret = call_command('collectstatic', interactive=False, verbosity=2)
File
/usr/lib/python2.4/site-packages/Django-1.3.4-py2.4.egg/django/core/management/__init__.py,
line 153, in call_command
klass = load_command_class(app_name, name)
File
/usr/lib/python2.4/site-packages/Django-1.3.4-py2.4.egg/django/core/management/__init__.py,
line 68, in load_command_class
return module.Command()
File
/usr/lib/python2.4/site-packages/Django-1.3.4-py2.4.egg/django/contrib/staticfiles/management/commands/collectstatic.py,
line 41, in __init__
self.storage = get_storage_class(settings.STATICFILES_STORAGE)()
File
/usr/lib/python2.4/site-packages/Django-1.3.4-py2.4.egg/django/core/files/storage.py,
line 265, in get_storage_class
raise ImproperlyConfigured('Error importing storage module %s: %s'
% (module, e))
django.core.exceptions.ImproperlyConfigured: Error importing storage
module pipeline.storage: cannot import name CachedFilesMixin
Traceback (most recent call last):
File /usr/bin/easy_install, line 7, in ?
sys.exit(
File
/usr/lib/python2.4/site-packages/setuptools-0.6c12dev_r88846-py2.4.egg/setuptools/command/easy_install.py,
line 1712, in main
..
snipped
...
self.distribution.run_command(command)
File /usr/lib64/python2.4/distutils/dist.py, line 966, in run_command
cmd_obj.run()
File setup.py, line 63, in run
File /usr/lib64/python2.4/distutils/cmd.py, line 333, in run_command
self.distribution.run_command(command)
File /usr/lib64/python2.4/distutils/dist.py, line 966,
Re: API question: list of files in requests, filtered by path and request date
Hi Christian, We're using ReviewBoard version 1.6.3 We also using Perforce version P4D/LINUX26X86_64/2012.2/551823 (2012/11/09) We have a few different groups of developers. One of these groups writes mostly one-offs or do local customizations at break neck speeds. These is all in-house code, for their own use. So for that group we never required the highest level of programming best-practices, but we want to start steering them in that direction. Use of reviewboard has been optional but we might make that a requirement. Right now we'd like to get some general stats in terms of how much of their code is being submitted for review, how much feedback people are getting, and that sort of stuff. We want to gauge current level of adoption and what effect it might have if/when we make that a requirement. If we make code review a requirement for them, then I'll have to query reviewboard for each source file being released. I'll have to make sure there's an approved review for that revision of the source file. Or maybe if the file being released is in an approved review just by looking at diffs. I haven't put much thought yet into what kind of checks make sense here. Any advice on that would be greatly appreciated. I thing I saw an email thread about that. I'll look that up. How do you feel about users querying the database directly? Is there any documentation on the schema? Thanks, Dado On Thu, 6 Dec 2012 01:37:52 -0800, Christian Hammond chip...@chipx86.com wrote: Hi Dado, The web API isn't really built to provide this sort of query, unfortunately. What would be needed is a new resource for all modified diffs that let you query such information. I'd be happy to include such a resource, but someone would have to write it. I'm curious what you're working on. Maybe there are other solutions for now. Also, what version of RB? Christian -- Christian Hammond - chip...@chipx86.com [1] Review Board - http://www.reviewboard.org [2] VMware, Inc. - http://www.vmware.com [3] On Wed, Dec 5, 2012 at 6:11 PM, dado wrote: What would be the best way of getting a list of all reviewed files matching a determined perforce path? I also know I'm after the reviews created after 04/01/12. Should I simply get all the reviews after that date and do any additional filtering client-side? If so, what would be the best way to get all reviews after April *and* the list of files in the reviews? I've used the WEB API before, but I'm clearly not very comfortable with it yet. Thanks, Dado -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ [5] Happy user? Let us know at http://www.reviewboard.org/users/ [6] -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com [7] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en [8] -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ [9] Happy user? Let us know at http://www.reviewboard.org/users/ [10] -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en [11] Links: -- [1] mailto:chip...@chipx86.com [2] http://www.reviewboard.org [3] http://www.vmware.com [4] mailto:d...@dado.org [5] http://www.reviewboard.org/donate/ [6] http://www.reviewboard.org/users/ [7] mailto:reviewboard%2bunsubscr...@googlegroups.com [8] http://groups.google.com/group/reviewboard?hl=en [9] http://www.reviewboard.org/donate/ [10] http://www.reviewboard.org/users/ [11] http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Info per source file
I have the exact same problem. I've never used Django. Would it be possible to leverage the Django ORM client side? Thanks, Dado On Thu, 6 Dec 2012 05:40:07 -0800 (PST), Laimonas Mockus laimonas.moc...@gmail.com wrote: Hi, I'm writing a command line python script (to check if the given sourcefile was reviewed). My idea is to fetch enough information from Mysql tables. E.g.: 1. select diffset_id from reviewboard.diffviewer_filediff (where source_file==_needed_filename_) 2. select history_id from reviewboard.diffviewer_diffset (where id=_=selected_diffset_id_) 3. select ship_it from reviewboard.reviews_review (where id=_=selected_diffset_id_) ship_it==1 would tell that at least one file was reviewed in a diffset. The information would be incomplete but better than nothing. I even can't check this way if a whole diffset was reviewed. I didn't try web API, but It may be useful if You post an example. Thanks, Laimonas -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Configuring Review Board for GIT
I tried using the following value for the raw file URL mask - http://gitgrid.unx.coep.com/cgit/Mobile/Commons/tree/Commons/formatters/Constants.cpp?id2=7d8cb5fa13a5985e70300baac4ae09d1be8c37bf where gitgrid.unx.coep.com is the host name of the machine hosting the GIT repository. I got the blob id by browsing the GIT repository via cgit. I left the path and mirror path fields blank since the GIT repository is hosted on a remote machine and I don't have access to its repository folder. When I try creating a repository with this, I get an error from ReviewBoard saying something is broken and I should contact admin. Any suggestion on what I should use for path and mirror path fields ? I tried a value like ssh://g...@gitgrid.unx.coep.com/Mobile/Commons and I still get an error. What about the id2 in the raw file URL mask - should I leave it as id2 or should I use just id ? On Tuesday, December 4, 2012 9:17:40 PM UTC+5:30, Matthew Woehlke wrote: On 2012-11-30 04:11, Krishnan Raghupathi wrote: I am using ReviewBoard version 1.6.1 and am facing a difficulty in configuring this for our GIT repository. Our GIT repository is hosted on a remote machine i.e different from the one hosting ReviewBoard. In the Add repository of ReviewBoard, I selected the following options - Hosting service - Custom Repository type - Git I left the Path and Mirror Path fields blank since the GIT repository is on a remote machine and not accessible via a path. Don't do that. The path and mirror path are used to determine what repository to use when posting a review. They can and should (mirror path especially, which exists ONLY for repository determination AFAIK) look like what users clone, e.g. 'git://server/path'. Since I am able to access our GIT repository on a browser via cgit, I am assuming that I need to specify the Raw file URL mask with a value similar to http://git.gnome.org/browse/gtk+/plain/filename?id2=revision as specified in the ReviewBoard documentation. Correct. Keep in mind however that revision is the blob ID of the file to which a patch hunk applies, i.e. 'git show revision' should give you the contents of a file, not a commit or tree. You'll need to form your URL accordingly. (Your server also needs to support retrieving content by blob ID; some might not.) I don't know cgit, so I can't give you any more information than that, but hopefully it helps. Note: if you need to find blob ID's for experimenting, read up on git's 'ls-tree' command. (Short form: 'git ls-tree branch/commit directory' will give you the list of blobs (files) with their respective ID's in directory as of branch/commit.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.7 RC 1 is released!
Hi,
First, do you have a backup of the database?
What actions did you take on the database prior to this attempt? For
example, did you ever run evolve yourself? Or attempt a downgrade after an
upgrade?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Dec 6, 2012 at 10:38 AM, Vishal Gautam gautamvis...@gmail.comwrote:
Thanks for the response Chris!
I upgrade CentOS to 5.8, manually installed Python 2.7, upgraded
setuptools for 2.7, then upgraded RB to 1.7rc1. All this made it fine
(after getting bunch of issues those I could look up in Google). Now I am
stuck at upgrading the site and my RB instance is down ... Please help!
[root@jira ~]# /usr/local/bin/rb-site upgrade /var/www/
reviews.xxx..com
Rebuilding directory structure
Updating database. This may take a while.
/usr/local/lib/python2.7/site-packages/Djblets-0.7.5-py2.7.egg/djblets/gravatars/__init__.py:26:
DeprecationWarning: the md5 module is deprecated; use hashlib instead
from md5 import md5
/usr/local/lib/python2.7/site-packages/pycrypto-2.6-py2.7-linux-x86_64.egg/Crypto/Util/number.py:57:
PowmInsecureWarning: Not using mpz_powm_sec. You should rebuild using
libgmp = 5 to avoid timing attack vulnerability.
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.
Run `./manage.py evolve --hint` to see a suggestion for the changes
required.
The following are the changes that could not be resolved:
In model reviews.FileAttachmentComment:
Field 'extra_data' has been added
In model reviews.ReviewRequest:
Field 'last_review_activity_timestamp' has been added
Field 'last_review_timestamp' has been deleted
In model accounts.Profile:
Field 'timezone' has been added
Field 'open_an_issue' has been added
In model diffviewer.DiffSetHistory:
Field 'last_diff_updated' has been added
In model diffviewer.FileDiff:
Field 'diff_hash' has been added
Field 'parent_diff_hash' has been added
Field 'diff64' has been added
Field 'parent_diff64' has been added
Field 'parent_diff' has been deleted
Field 'diff' has been deleted
The model auth.Message has been deleted
Error: Your models contain changes that Django Evolution cannot resolve
automatically.
On Wednesday, December 5, 2012 8:36:42 PM UTC+5:30, Christian Hammond
wrote:
Review Board 1.7 requires Python 2.5 or higher. You'll have to upgrade in
order for it to work.
What I'd recommend is a newer CentOS install, since some of our
dependencies will also need to be updated, and you won't hit as many issues
with the upgrade. Your best bet is to upgrade to something with Python 2.7.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Dec 5, 2012 at 2:22 AM, Vishal Gautam gautam...@gmail.comwrote:
We are trying out RB, we have 1.6.14 installed and running on CentOS
5.5. Tried to upgrade it to 1.7 using following cmd but its failing ...
easy_install -f http://downloads.reviewboard.**
org/releases/ReviewBoard/1.7http://downloads.reviewboard.org/releases/ReviewBoard/1.7-U
ReviewBoard
Here is the stracktrace, any help will be much appreciated
Best match: ReviewBoard 1.7rc1
Downloading http://downloads.reviewboard.**org/releases/ReviewBoard/1.7/
**ReviewBoard-1.7rc1.tar.gzhttp://downloads.reviewboard.org/releases/ReviewBoard/1.7/ReviewBoard-1.7rc1.tar.gz
Processing ReviewBoard-1.7rc1.tar.gz
Running ReviewBoard-1.7rc1/setup.py -q bdist_egg --dist-dir
/tmp/easy_install-vW-lSE/**ReviewBoard-1.7rc1/egg-dist-**tmp-DrI1Td
Traceback (most recent call last):
File ./contrib/internal/build-**media.py, line 19, in ?
ret = call_command('collectstatic', interactive=False, verbosity=2)
File /usr/lib/python2.4/site-**packages/Django-1.3.4-py2.4.**
egg/django/core/management/__**init__.py, line 153, in call_command
klass = load_command_class(app_name, name)
File /usr/lib/python2.4/site-**packages/Django-1.3.4-py2.4.**
egg/django/core/management/__**init__.py, line 68, in
load_command_class
return module.Command()
File /usr/lib/python2.4/site-**packages/Django-1.3.4-py2.4.**
egg/django/contrib/**staticfiles/management/**commands/collectstatic.py,
line 41, in __init__
self.storage = get_storage_class(settings.**STATICFILES_STORAGE)()
File /usr/lib/python2.4/site-**packages/Django-1.3.4-py2.4.**
egg/django/core/files/storage.**py, line 265, in get_storage_class
raise ImproperlyConfigured('Error importing storage module %s: %s'
% (module, e))
django.core.exceptions.**ImproperlyConfigured: Error importing storage
module pipeline.storage: cannot import name CachedFilesMixin
Traceback (most recent
Issue 2815 in reviewboard: Can't install new ReviewBoard 1.7rc1 - Djblets Pipeline error
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2815 by kozlenko...@gmail.com: Can't install new ReviewBoard
1.7rc1 - Djblets Pipeline error
http://code.google.com/p/reviewboard/issues/detail?id=2815
Currently have installed Django 1.4.2, django-evolution 0.6.7, Djblets
0.7.5, django-pipeline 1.2.16 but it looks like that problem is not in
reviewboard.
Was trying to install new Reviewboard 1.7rc1 and get error on the
collectstatic command:
Traceback (most recent call last):
File ./contrib/internal/build-media.py, line 20, in module
ret = call_command('collectstatic', interactive=False, verbosity=2)
File /usr/lib/python2.5/site-packages/Django-1.4.2-py2.5.egg/django/core/management/__init__.py,
line 150, in call_command
return klass.execute(*args, **defaults)
File /usr/lib/python2.5/site-packages/Django-1.4.2-py2.5.egg/django/core/management/base.py,
line 232, in execute
output = self.handle(*args, **options)
File /usr/lib/python2.5/site-packages/Django-1.4.2-py2.5.egg/django/core/management/base.py,
line 371, in handle
return self.handle_noargs(**options)
File /usr/lib/python2.5/site-packages/Django-1.4.2-py2.5.egg/django/contrib/staticfiles/management/commands/collectstatic.py,
line 163, in handle_noargs
collected = self.collect()
File /usr/lib/python2.5/site-packages/Django-1.4.2-py2.5.egg/django/contrib/staticfiles/management/commands/collectstatic.py,
line 119, in collect
dry_run=self.dry_run)
File /usr/lib/python2.5/site-packages/django_pipeline-1.2.21-py2.5.egg/pipeline/storage.py,
line 30, in post_process
packager.pack_stylesheets(package)
File /usr/lib/python2.5/site-packages/django_pipeline-1.2.21-py2.5.egg/pipeline/packager.py,
line 90, in pack_stylesheets
variant=package.variant, **kwargs)
File /usr/lib/python2.5/site-packages/django_pipeline-1.2.21-py2.5.egg/pipeline/packager.py,
line 99, in pack
paths = self.compile(package.paths, force=True)
File /usr/lib/python2.5/site-packages/django_pipeline-1.2.21-py2.5.egg/pipeline/packager.py,
line 93, in compile
return self.compiler.compile(paths, force=force)
File /usr/lib/python2.5/site-packages/django_pipeline-1.2.21-py2.5.egg/pipeline/compilers/__init__.py,
line 41, in compile
compiler.compile_file(infile, outfile, outdated=outdated, force=force)
File /usr/lib/python2.5/site-packages/Djblets-0.7.5-py2.5.egg/djblets/pipeline/compilers/bless.py,
line 67, in compile_file
content = urllib2.urlopen(r).read()
File /usr/lib/python2.5/urllib2.py, line 124, in urlopen
return _opener.open(url, data)
File /usr/lib/python2.5/urllib2.py, line 387, in open
response = meth(req, response)
File /usr/lib/python2.5/urllib2.py, line 498, in http_response
'http', request, response, code, msg, hdrs)
File /usr/lib/python2.5/urllib2.py, line 425, in error
return self._call_chain(*args)
File /usr/lib/python2.5/urllib2.py, line 360, in _call_chain
result = func(*args)
File /usr/lib/python2.5/urllib2.py, line 506, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: Not Found
As I understood, djblets-pipeline-bless trying to get the url that didn't
exists.
What steps will reproduce the problem?
1. Install corresponding libs
a. Install Django (https://www.djangoproject.com/download/1.4.2/tarball)
b. Install django_evolution
(http://django-evolution.googlecode.com/svn/trunk/)
c. Install Djblets
(http://downloads.reviewboard.org/releases/Djblets/0.7/Djblets-0.7.5.tar.gz)
d. Install django-pipeline (pip install django-pipeline)
2. Download RB
(http://downloads.reviewboard.org/releases/ReviewBoard/1.7/ReviewBoard-1.7rc1.tar.gz)
3. untar
4. Run Install - I've tried to run general setup.py install, but then to
localize problem was forced to run:
python ./contrib/internal/build-media.py
Expected result - RB was installed and do a lot of joy for me and team :)
Actual result - backtrace above.
OS: Linux debian 2.6.26-2-686 #1 SMP Sun Mar 4 22:19:19 UTC 2012 i686
GNU/LinuxOS
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2815 in reviewboard: Can't install new ReviewBoard 1.7rc1 - Djblets Pipeline error
Comment #2 on issue 2815 by kozlenko...@gmail.com: Can't install new ReviewBoard 1.7rc1 - Djblets Pipeline error http://code.google.com/p/reviewboard/issues/detail?id=2815 Thanks! Will try to use distribs, but not sure that they will correspont requirements bor RB. I'll report as soon as try. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2717 in reviewboard: cannot use space in svn path setting
Comment #2 on issue 2717 by zhouding...@gmail.com: cannot use space in svn path setting http://code.google.com/p/reviewboard/issues/detail?id=2717 2012-08-23 10:03:28,582 - ERROR - SVN: Failed to get repository information for http:///* Client 6.1: URL 'http:/// Client 6.1' is malformed or the scheme or host or path is missing 2012-08-23 10:08:48,677 - ERROR - SVN: Failed to get repository information for http://**/\ Client\ 6.1: URL 'http:///*\ Client\ 6.1' is malformed or the scheme or host or path is missing -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
