Add SVN repository But Error ...
I am a administrator about our reviewboard system. I am doing Add repository and selected Repository type = subversion, when I click SAVE . Following I get : https://lh3.googleusercontent.com/-euA-WtZaYqU/Uleq2BM7BMI/AAw/COR6oxcKSLM/s1600/QQ%E6%88%AA%E5%9B%BE20131011153338.jpg My environment is: centos,python2.7,svn 1.7.8 Is there anyone can help me ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Add SVN repository But Error ...
It looks like pysvn is not installed correctly. How did you install it? -David On Fri, Oct 11, 2013 at 12:39 AM, loufigo1...@gmail.com wrote: I am a administrator about our reviewboard system. I am doing Add repository and selected Repository type = subversion, when I click SAVE . Following I get : https://lh3.googleusercontent.com/-euA-WtZaYqU/Uleq2BM7BMI/AAw/COR6oxcKSLM/s1600/QQ%E6%88%AA%E5%9B%BE20131011153338.jpg My environment is: centos,python2.7,svn 1.7.8 Is there anyone can help me ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Add SVN repository But Error ...
cd pysvn-1.7.6/Source python setup.py configure --apr-lib-dir=/usr/local/apr/ lib Info: Configure for python 2.7.4 in exec_prefix /usr/local Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Using tool chain LinuxCompilerGCC Info: Creating Makefile for Sources Info: Creating Makefile for Tests mkdir /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/__init__.py /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/_pysvn_2_7.so /usr/local/lib/python2.7/site-packages/pysvn 在 2013年10月11日星期五UTC+8下午3时52分11秒，David Trowbridge写道： It looks like pysvn is not installed correctly. How did you install it? -David On Fri, Oct 11, 2013 at 12:39 AM, loufi...@gmail.com javascript:wrote: I am a administrator about our reviewboard system. I am doing Add repository and selected Repository type = subversion, when I click SAVE . Following I get : https://lh3.googleusercontent.com/-euA-WtZaYqU/Uleq2BM7BMI/AAw/COR6oxcKSLM/s1600/QQ%E6%88%AA%E5%9B%BE20131011153338.jpg My environment is: centos,python2.7,svn 1.7.8 Is there anyone can help me ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Add SVN repository But Error ...
I am a administrator about our reviewboard system. I am doing Add repository and selected Repository type = subversion, when I click SAVE . Following I get : https://lh4.googleusercontent.com/-f0xRVLXh3YA/UleyM6QRVwI/ABI/4pog-YrmIl4/s1600/QQ%E6%88%AA%E5%9B%BE20131011153338.jpgMy environment is: centos,python2.7,svn 1.7.8 My pysvn install command is: == cd pysvn-1.7.6/Source python setup.py configure --apr-lib-dir=/usr/local/apr/lib Info: Configure for python 2.7.4 in exec_prefix /usr/local Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Using tool chain LinuxCompilerGCC Info: Creating Makefile for Sources Info: Creating Makefile for Tests mkdir /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/__init__.py /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/_pysvn_2_7.so /usr/local/lib/python2.7/site-packages/pysvn == Is there anyone can help me ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Add SVN repository But Error ...
IIRC, CentOS should have pysvn packages available through yum. -David On Fri, Oct 11, 2013 at 1:14 AM, null loufigo1...@gmail.com wrote: I am a administrator about our reviewboard system. I am doing Add repository and selected Repository type = subversion, when I click SAVE . Following I get : https://lh4.googleusercontent.com/-f0xRVLXh3YA/UleyM6QRVwI/ABI/4pog-YrmIl4/s1600/QQ%E6%88%AA%E5%9B%BE20131011153338.jpgMy environment is: centos,python2.7,svn 1.7.8 My pysvn install command is: == cd pysvn-1.7.6/Source python setup.py configure --apr-lib-dir=/usr/local/apr/lib Info: Configure for python 2.7.4 in exec_prefix /usr/local Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX include in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4 Info: Found PyCXX Source in /usr/mengxing/src/pysvn-1.7.6/Import/pycxx-6.2.4/Src Info: FoundSVN include in /usr/include/subversion-1 Info: FoundSVN library in /usr/lib64 Info: FoundSVN bin in /usr/bin Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR include in /usr/include/apr-1 Info: FoundAPR library in /usr/local/apr/lib Info: Building against SVN 1.6.11 Info: Using tool chain LinuxCompilerGCC Info: Creating Makefile for Sources Info: Creating Makefile for Tests mkdir /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/__init__.py /usr/local/lib/python2.7/site-packages/pysvn cp pysvn/_pysvn_2_7.so /usr/local/lib/python2.7/site-packages/pysvn == Is there anyone can help me ? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Apply changes to reviews.min.js
Hello!
I'm developing ReviewBorad 1.7.14 to include new features, like drop down
list and buttons.
Adding for example drop down list to form works fine (in
review_request_box.html), but implementing change(function() {}); in
static/rb/js/reviews.js has no effect.
I found here:
https://groups.google.com/forum/#!msg/reviewboard/vCx2mFrkYZc/cD1Zc16_7XkJ
that I should run './setup.py bdist_egg release' to upgrade
htdocs/static/rb/js/reviews.min.js which is used by server, but I have no
clue where to find setup.py?
Furthermore, Christian Hammond said that this process will change a bit
in future versions. Has it changed by now?
I would be thankful for help!
Regards,
Robcikss
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Apply changes to reviews.min.js
We don't support making any modifications to our JavaScript or CSS files,
and in the upcoming major version of Review Board, the files you're
modifying don't even exist anymore.
You should be making use of the extension support wherever possible, and if
there isn't an ability to add what you need, please bring up the details of
what you're trying to do, why, and how on the reviewboard-dev list.
Assuming you're trying to add new fields to the review request page, this
functionality will come in a nice form in 2.0, but we can't do much to help
before that.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Fri, Oct 11, 2013 at 1:54 AM, robcikss gundar...@gmail.com wrote:
Hello!
I'm developing ReviewBorad 1.7.14 to include new features, like drop down
list and buttons.
Adding for example drop down list to form works fine (in
review_request_box.html), but implementing change(function() {}); in
static/rb/js/reviews.js has no effect.
I found here:
https://groups.google.com/forum/#!msg/reviewboard/vCx2mFrkYZc/cD1Zc16_7XkJ
that I should run './setup.py bdist_egg release' to upgrade
htdocs/static/rb/js/reviews.min.js which is used by server, but I have no
clue where to find setup.py?
Furthermore, Christian Hammond said that this process will change a bit
in future versions. Has it changed by now?
I would be thankful for help!
Regards,
Robcikss
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Javascript errors with Reviewboard 1.7.15
I installed Reviewboard 1.7.15 this morning, and I am getting the following errors on the edit review page. Uncaught SyntaxError: Use of future reserved word in strict mode 3rdparty.min.f0d3e37f248a.js:36 Uncaught ReferenceError: Backbone is not defined base.min.9651809ef5d5.js:1 Uncaught SyntaxError: Invalid regular expression: missing / /static/rb/js/reviews.min.d91b5b5b17e3.js:69 Uncaught ReferenceError: RB is not defined (index):529 As a result, when posting a new review, the review cannot be edited, published or discarded. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Javascript errors with Reviewboard 1.7.15
Darryl, Did you install from the python egg (easy_install) or using the .tar.gz file? -David On Fri, Oct 11, 2013 at 8:34 AM, Darryl McCutcheon dar...@themccutcheons.ca wrote: I installed Reviewboard 1.7.15 this morning, and I am getting the following errors on the edit review page. Uncaught SyntaxError: Use of future reserved word in strict mode 3rdparty.min.f0d3e37f248a.js:36 Uncaught ReferenceError: Backbone is not defined base.min.9651809ef5d5.js:1 Uncaught SyntaxError: Invalid regular expression: missing / /static/rb/js/reviews.min.d91b5b5b17e3.js:69 Uncaught ReferenceError: RB is not defined (index):529 As a result, when posting a new review, the review cannot be edited, published or discarded. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Review Board 1.6.20 and 1.7.16 released
Hey everyone, Last night's releases were a bit bumpier than we like, due to a regression in Djblets, in Review Board, and in a third-party tool we used for packaging. All in all, comedy of errors, and hopefully it didn't bite too many people. These are now resolved in the latest releases. See the news post for the full details. http://www.reviewboard.org/news/2013/10/11/review-board-1-6-20-and-1-7-16-released/ Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3105 in reviewboard: Can't post diffs containing non-ascii characters in file name
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3105 by leonid...@gmail.com: Can't post diffs containing non-ascii characters in file name http://code.google.com/p/reviewboard/issues/detail?id=3105 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? Review Board 1.7.14 What's the URL of the page containing the problem? http://192.168.238.129/r/new/ What steps will reproduce the problem? 1. Add file with russian name to repository 2. Create patch with TortoiseSVN 3. Try to add patch to review What is the expected output? What do you see instead? I expect new review but I get this message instead: 'ascii' codec can't decode byte 0xca in position 0: ordinal not in range(128) What operating system are you using? What browser? Review Board: Debian 6 Workstation: Windows 7 + Google Chrome (Version 30.0.1599.69 m) Please provide any additional information below. If I use english titles I get correct workflow (even if there is any russian word). So if I use russian titles I get error. It does not matter if I rename diff file. It's OK if russian words in the body of file. Attachments: Картинка 22.png.patch 551 bytes pic22.png.patch 551 bytes new.txt.patch 546 bytes screenshot.png 44.8 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3067 in reviewboard: Parent diffs with mercurial are still broken
Comment #9 on issue 3067 by scherere...@gmail.com: Parent diffs with mercurial are still broken http://code.google.com/p/reviewboard/issues/detail?id=3067 Possible related issue, but it may be a different bug. I attempted to use the -o -g workaround and have encountered another edge case that fails: r4 [draft] : add file A (unrelated in content, but sharing the same name) r3 [draft] : miscelaneous r2 [draft] : remove file A r1 [public] : file A present hg postreview r4 -o -g -i 'foo' File A will show 'diff unavailable' My original workaround (diff -r 0:r3) still worked in this scenario. I have not tested to see if r3 is necessary to the test. Since the -o -g workaround seemed to work because it was using git diffs (and thus likely a different code path), this case should probably be tested with a git repository as well to ensure that it doesn't exist there. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3106 in reviewboard: Sending out a huge diff for review failed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3106 by nithin...@gmail.com: Sending out a huge diff for review failed http://code.google.com/p/reviewboard/issues/detail?id=3106 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3106 in reviewboard: Sending out a huge diff for review failed
Updates: Status: Invalid Comment #1 on issue 3106 by trowb...@gmail.com: Sending out a huge diff for review failed http://code.google.com/p/reviewboard/issues/detail?id=3106 First of all, we can't accept bug reports that don't include answers to all of our questions. Second, there is a limit on the size of a diff file, but that limit is well above what is possible for humans to review. If your diff includes a bunch of auto-generated stuff, I suggest stripping that out before asking your colleagues to look at it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #17 on issue 2916 by javawiz...@opengroove.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.9 also has this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3067 in reviewboard: Parent diffs with mercurial are still broken
Comment #10 on issue 3067 by patrick.horn: Parent diffs with mercurial are still broken http://code.google.com/p/reviewboard/issues/detail?id=3067 I'm using RB 1.7.12 and I had a slightly different problem with a simpler solution (when using hg-style diffs). The old code allowed the 'origChangesetId' from any file in the parent diff to become the source_rev for every file in the child diff; however it only worked if the parent diff had any files in common with the child. My attached patch fixes this. While the code in 1.7.12 was not 100% correct, this effectively solved the issue. If you try with 1.7.12 and the attached patch, the problem should be solved. I also had no issues when removing files and re-adding them back--this should be handled by the f.origInfo != PRE_CREATION check. Perhaps it is a bug with git-style diffs. I have yet to test in RB 1.7.13, but looking at the commit log, it looks like the code changed significantly between 1.7.12 and 1.7.13 with https://reviews.reviewboard.org/r/4121/ (45faed44) -- From what I can tell, the code now will only work in the case that you specify a parent diff with a global # Parent comment because it now only checks the global origChangesetId, so I think this change just made the issue more complicated. The good news is that with commits 253ff68 and 5acf49a it is now possible to specify the parent commit ID via the API, so the API parameter might be a nice solution to this problem in versions after 1.7.13. I will try to do some tests on 1.7.13 or a later version. I also have only tested with hg-style diffs, not git-style diffs so those might be different. Attachments: fix-parent-diff-1.7.12.patch 1011 bytes -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
