Re: Review groups and private repositories
Hey, both groups are invite-only groups and review board is on version 1.7.18 - Support ▾ https://sdreview.protacon.com/dashboard/# - [image: Mikko Pulkkinen] Mikko ▾https://sdreview.protacon.com/account/preferences/ On Monday, 11 November 2013 23:15:36 UTC+2, Christian Hammond wrote: Hi, Are either group1 or group2 invite-only groups? Also, what version of Review Board? Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Mon, Nov 11, 2013 at 5:26 AM, SenjorGes gess...@gmail.comjavascript: wrote: Hey, I have noticed some problems with review groups and private repositories. It seems access control doesn't work properly or is it me? Scenario is this: - I have one SVN repository called repository1 and it's not publicly accessible - Review group named group1 has access to repository1 via admin panel (admin panel - repositories - repository1 - Review groups with access:) - Also group2 has same access to that repository as group1 - User1 belongs to group1 and User2 belongs to group2 So thats the setup, and the problem occuress when: - User1 creates a review request (repository1) and sets group1 as the group for the request - Now if User2 tries to read the review request he/she gets access denied So if you set repository to be private, only the selected group can view the review request, and not all the groups which have access to the repository via admin panel or am I missing something here? And if User2 is a superuser, then he/she can view the request. And this only works if group2 have access to the repository. If I remove group2 from the repository access list and user2 still have superuser rights, review request will not open (Access Denied). --Ges -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 2013-11-12 15:36, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB Any ideas? Are you using the official Fedora packages that I create or did you install with easy_install? # yum upgrade --enablerepo updates-testing ReviewBoard (IOW, your packages.) If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. Alas, yes. Bodhi feedback time? -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 11/13/2013 11:51 AM, Matthew Woehlke wrote: On 2013-11-12 15:36, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB Any ideas? Are you using the official Fedora packages that I create or did you install with easy_install? # yum upgrade --enablerepo updates-testing ReviewBoard (IOW, your packages.) If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. Alas, yes. Bodhi feedback time? A Bugzilla ticket would be best so I can track it. Thanks in advance. I wonder if SlimIt didn't help as much as I thought... I'll try making the UglifyJS conversion and send you a 1.7.18 scratch build, if you don't mind testing it. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 2013-11-13 11:54, Stephen Gallagher wrote: On 11/13/2013 11:51 AM, Matthew Woehlke wrote: On 2013-11-12 15:36, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB Any ideas? Are you using the official Fedora packages that I create or did you install with easy_install? # yum upgrade --enablerepo updates-testing ReviewBoard (IOW, your packages.) If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. Alas, yes. Bodhi feedback time? A Bugzilla ticket would be best so I can track it. Thanks in advance. Okay. I have to run right this moment, so it'll probably be in a few hours. I wonder if SlimIt didn't help as much as I thought... I'll try making the UglifyJS conversion and send you a 1.7.18 scratch build, if you don't mind testing it. Given that my server is (effectively) borked right now, I don't mind at all testing something maybe less borked :-). Thanks. -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 11/13/2013 12:49 PM, Matthew Woehlke wrote: On 2013-11-13 11:54, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. A Bugzilla ticket would be best so I can track it. Thanks in advance. https://bugzilla.redhat.com/show_bug.cgi?id=1030019 Thanks again for looking at this. Let me know if you have a package you want me to test. Hitting a snag right now; npmjs.org is down so I can't get the latest version of UglifyJS from there. I'll keep you apprised. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 2013-11-13 11:54, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. A Bugzilla ticket would be best so I can track it. Thanks in advance. https://bugzilla.redhat.com/show_bug.cgi?id=1030019 Thanks again for looking at this. Let me know if you have a package you want me to test. -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Browser opens incorrect URL from rbt post -o
Please ignore. Found already logged issue for this: https://code.google.com/p/reviewboard/issues/detail?id=3079 On Monday, November 11, 2013 3:40:31 PM UTC-5, Igor Berger wrote: Hello, I noticed a minor problem with rbt post -o. When I run post-review -o, my browser opens correctly at http://reviewboardhostname/reviews/r/reviewid/. When I run rbt post -o (from the the same changes), the review gets created correctly. However, the browser tries to open http://reviewboardhostname/r/reviewid/ and fails with HTTP 404. The reviews part of the path is missing (Review Board URL is http://reviewboardhostname/reviews). Review Board 1.7.18 on Ubuntu. RBTools 0.5.2 on Windows. Am I missing some configs? Regards, Igor. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Review groups and private repositories
If a user is on group1 but not group2, and a change is posted to group2, then the user will not be allowed to see the change. The reason is that there may be discussions from members on group2 that the user is not privy to. This is an intended design. When dealing with private review requests (due to private repositories or invite-only groups), Review Board becomes very restrictive on who has access. The owner of the review request must be explicit in who they want to bring in for discussion. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Nov 13, 2013 at 4:32 AM, SenjorGes gessi...@gmail.com wrote: Hey, both groups are invite-only groups and review board is on version 1.7.18 - Support ▾ https://sdreview.protacon.com/dashboard/# - [image: Mikko Pulkkinen] Mikko ▾https://sdreview.protacon.com/account/preferences/ On Monday, 11 November 2013 23:15:36 UTC+2, Christian Hammond wrote: Hi, Are either group1 or group2 invite-only groups? Also, what version of Review Board? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Mon, Nov 11, 2013 at 5:26 AM, SenjorGes gess...@gmail.com wrote: Hey, I have noticed some problems with review groups and private repositories. It seems access control doesn't work properly or is it me? Scenario is this: - I have one SVN repository called repository1 and it's not publicly accessible - Review group named group1 has access to repository1 via admin panel (admin panel - repositories - repository1 - Review groups with access:) - Also group2 has same access to that repository as group1 - User1 belongs to group1 and User2 belongs to group2 So thats the setup, and the problem occuress when: - User1 creates a review request (repository1) and sets group1 as the group for the request - Now if User2 tries to read the review request he/she gets access denied So if you set repository to be private, only the selected group can view the review request, and not all the groups which have access to the repository via admin panel or am I missing something here? And if User2 is a superuser, then he/she can view the request. And this only works if group2 have access to the repository. If I remove group2 from the repository access list and user2 still have superuser rights, review request will not open (Access Denied). --Ges -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 11/13/2013 01:15 PM, Stephen Gallagher wrote: On 11/13/2013 12:49 PM, Matthew Woehlke wrote: On 2013-11-13 11:54, Stephen Gallagher wrote: On 11/12/2013 03:13 PM, Matthew Woehlke wrote: After upgrading my RB server machine to Fedora 19 (was 18) and Review Board to 1.7.17 (from 1.7.12 IIRC), I am no longer able to see diffs; I am getting the spinning 'please wait' indicators indefinitely. I'm also seeing these javascript errors: https://nowhere/static/lib/js/3rdparty.min.f5aca98bcda3.js @36: SyntaxError: Use of reserved word 'private' in strict mode https://nowhere/static/rb/js/base.min.9651809ef5d5.js @1: ReferenceError: Can't find variable: Backbone https://nowhere/static/rb/js/reviews.min.03b57ae46446.js @1: ReferenceError: Can't find variable: RB https://nowhere/r/209/diff/ @441: ReferenceError: Can't find variable: RB If you're seeing this on the Fedora 1.7.17 package, that's serious and I need to know immediately. A Bugzilla ticket would be best so I can track it. Thanks in advance. https://bugzilla.redhat.com/show_bug.cgi?id=1030019 Thanks again for looking at this. Let me know if you have a package you want me to test. Hitting a snag right now; npmjs.org is down so I can't get the latest version of UglifyJS from there. I'll keep you apprised. Matthew, can you please try http://kojipkgs.fedoraproject.org//packages/ReviewBoard/1.7.18/1.fc19/noarch/ReviewBoard-1.7.18-1.fc19.noarch.rpm and let me know if it helps? It's building using UglifyJS 2.2.5 now. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 2013-11-13 15:53, Stephen Gallagher wrote: Matthew, can you please try http://kojipkgs.fedoraproject.org//packages/ReviewBoard/1.7.18/1.fc19/noarch/ReviewBoard-1.7.18-1.fc19.noarch.rpm Diffs appear, no JS errors. Thanks. -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: diffs not working since upgrade to F19 / RB 1.7.17
On 11/13/2013 04:10 PM, Matthew Woehlke wrote: On 2013-11-13 15:53, Stephen Gallagher wrote: Matthew, can you please try http://kojipkgs.fedoraproject.org//packages/ReviewBoard/1.7.18/1.fc19/noarch/ReviewBoard-1.7.18-1.fc19.noarch.rpm Diffs appear, no JS errors. Thanks. Ok, that's good to hear. I'll get this into the updates pipeline ASAP. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Mac OS X Mavericks, rb-site install, mysql
I believe I have installed all the necessary components to make this work. When I run rb-site install and when I get to the database question the only option is sqlite3. My python version is 2.7.5. If I run python and type import MySQLdb it returns with no errors. I've searched the group and the only post that I found interesting shows the poster as having the same problem but no solution is given. Any ideas what's wrong? Thank you, Chris -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
Hi Christian, Another further ideas on this? I did not nor can I figure out how to generate a new secret key. It is a new install. I'm also not too concerned about it. By wanting repository configuration, so there's no confusion can you be more specific for me? The repository I'm trying to access can only be access via pserver at this point . We are considering trying ssh... Thanks, Barry On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
Hi Barry, The secret key can be anything, so feel free to just mash on keys. A screenshot of the repository configuration page in Review Board, with all your settings, would give me the info I need. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Nov 13, 2013 at 2:34 PM, Barry Novinger ba...@novinger.net wrote: Hi Christian, Another further ideas on this? I did not nor can I figure out how to generate a new secret key. It is a new install. I'm also not too concerned about it. By wanting repository configuration, so there's no confusion can you be more specific for me? The repository I'm trying to access can only be access via pserver at this point . We are considering trying ssh... Thanks, Barry On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: A repository was not found at the specified path.
Ok, after the last post a search turned up a Django generator so I have a new key. However, I'm not sure what is dependent on that and if I change it in settings_local.py what I might break. On Friday, November 8, 2013 11:23:48 AM UTC-6, Barry Novinger wrote: After exploring the existing topics and trying a number of things I decided to post for specific help. Just recently downloaded reviewboard 1.7.16 using mysql, apache mod_wsgi following the best instructions I can find. I can add a local CVS repository to reviewboard but not the teams remote CVSNT repository. I can also access the teams CVSNT repository from the ubuntu shell. using cvs -d :pserver:user@host:/repo login Let me know if you need anything for diagnostics or have anything you recommend me checking or trying Thanks, -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
RFC: diffs with spaces in the path
So, I've been working on a git-specific helper script for posting reviews which, among other things, includes the git log in the diff. For a while, I was seeing a bug where the log shows up incorrectly when posted from a Windows machine. I finally determined that this is caused by the diff quoting the file paths, i.e.: diff --git a/.gitlog b/.gitlog new file mode 100644 index 000..sha --- /dev/null +++ b/.gitlog ...diffs... It seems that 'git diff' quotes the file names if they contain characters that might otherwise confuse the diff parser (what's not seen here is that the original file names were e.g. 'C:\Users\My User\Temporary Files\... and have had string substitution performed to get to .gitlog). What I'm wondering is, if a file name actually needs to be quoted, does RB correctly parse the quoted name? And in particular, should it also be handling the above case better than it seems to be doing? -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3135 in reviewboard: Support Assembla git repositories
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3135 by ch...@orr.me.uk: Support Assembla git repositories http://code.google.com/p/reviewboard/issues/detail?id=3135 Assembla.com is a code-hosting/project-management site similar to BeanstalkApp (which RB supports). I don't know exactly how SCM plugins need to be implemented, but I'm not sure whether Assembla can be easily supported as I haven't found an API for git so far (though the API does let you manage SSH keys for a project). http://api-doc.assembla.com/ Individual git commits are available through a web interface, though only with an HTML diff viewer. URLs are like this: https://www.assembla.com/code/project-name/git-repo-ID/changesets/sha1 (Projects can have multiple git repos, so git-repo-ID should be git, git-2, git-3 etc.) Individual file diffs within a commit are also available, but again only as HTML, with the URL format: https://www.assembla.com/code/project-name/git-repo-ID/node/diff/old-sha1/new-sha1/path/to/changed-file.foo -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3136 in reviewboard: depends_on field is removed after a change
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3136 by kannan...@gmail.com: depends_on field is removed after a change http://code.google.com/p/reviewboard/issues/detail?id=3136 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? ReviewBoard 1.7.12 What's the URL of the page containing the problem? NA What steps will reproduce the problem? 1. Create a review request 2. edit depends_on field 3. Make some changes to the review request like pass comment or upload a new diff 4. The depends on field will be removed and show null What is the expected output? What do you see instead? The depends on field should hold the value What operating system are you using? What browser? Linux Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3135 in reviewboard: Support Assembla git repositories
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Component-HostingServices Comment #1 on issue 3135 by chip...@gmail.com: Support Assembla git repositories http://code.google.com/p/reviewboard/issues/detail?id=3135 Hi Chris, Unfortunately, it's not looking like Assembla has the API we would need to support it properly. The only way we can use the code browser URLs is if they returned the raw content of the object and if we could access them with Basic HTTP Auth. I imagine it requires logging into the site manually first, which is a problem. The way they have authentication for the API may also prevent us from being able to access it, since we would need to register as an OAuth2 application on their site, and pass out the secret keys to everyone. It's unclear whether the same application can be registered many times. I'll keep this ticket open for the future, but right now, I don't see anything we can do. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3137 in reviewboard: 'rbt status' can't find repository
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3137 by ben.al...@gmail.com: 'rbt status' can't find repository http://code.google.com/p/reviewboard/issues/detail?id=3137 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? RBTools 0.5.1 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Configure a svn repository on a reviewboard server with both a repository path and mirror path specified 2. Check out a working copy using the mirror path 3. Run rbt status What is the expected output? What do you see instead? Actual output: WARNING:root:The repository detected in the current directory was not found on the Review Board server. Displaying review requests from all repositories. r/125 - Description 1 r/193 - Description 2 r/226 - Description 3 What operating system are you using? What browser? Ubuntu 12.04.3 (precise) 32-bit Please provide any additional information below. In this setup, the server has a local mirror of the Subversion repository. Reviewboard is set up with this local mirror as the main repository URL (for speed, our local network can be quite slow). The network URL of the Subversion repository is listed as the mirror path. This is the URL that developers use when accessing the repository. The URL displayed by running 'svn info' in my working copy is identical to the mirror URL. The rbt status command seems to be looking at the repository URL but not the mirror URL. However, the command rbt post will locate the correct repository when creating a new review request. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
