Re: embed the configuration file in your global Apache configuration file
Review Board will require a level of knowledge of Apache configuration and general system administration, and like David said, it's not something we can give specific instructions on. If you don't want to maintain it, and your code repositories are hosted on a service like GitHub or BitBucket, we offer Review Board hosting at https://rbcommons.com/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Dec 11, 2013 at 10:31 PM, David Trowbridge trowb...@gmail.comwrote: It sounds like you need to do a lot of reading up on how to install and configure the apache web server. We can't give you specific instructions because there are a huge number of variations in environment/software/configuration/etc. -David On Wed, Dec 11, 2013 at 10:28 PM, Alokkumar Thakur alok299...@gmail.comwrote: i know how to do in html/directory link but here it is like reviews.example.com and i cant find any where what change i have to do so if u know then give instruction what changes i have to do . On Thursday, 12 December 2013 11:46:06 UTC+5:30, David Trowbridge wrote: It's just editing the text files. See http://httpd.apache.org/ docs/2.2/configuring.html for more information on manipulating apache configurations. -David On Wed, Dec 11, 2013 at 10:13 PM, Alokkumar Thakur alok2...@gmail.comwrote: we have to add/copy the apache-wsgi.conf into /etc/httpd/conf/httpd.conf , i need how to copy/add into httpd.conf where and what changes i have to do ? On Thursday, 12 December 2013 11:31:42 UTC+5:30, David Trowbridge wrote: All that means is to copy the content of the apache-wsgi.conf file into the apache config file. -David On Wed, Dec 11, 2013 at 9:55 PM, Alokkumar Thakur alok2...@gmail.comwrote: Dear all I need a help from all kindly reply for bellow problem. If you have a sites-available directory in your Apache configuration directory (for example, /etc/apache2/sites-available, then you should rename your configuration file to match your site (e.g., reviews.example.com.conf) and put it in that directory. Then create a symbolic link from that file to the sites-enabled directory. This is the most common setup on Debian or Ubuntu-based distributions. So for example: $ cd /etc/apache2/sites-available $ cp /var/www/reviews.example.com/conf/apache-wsgi.conf reviews.example.com.conf $ cd ../sites-enabled $ ln -s ../sites-available/reviews.example.com.conf . If you do not have a sites-available or sites-enabled directory, you’ll need to embed the configuration file in your global Apache configuration file (usually /etc/httpd/httpd.conf or/etc/httpd/apache2.conf). Can any one tell how to do this you’ll need to embed the configuration file in your global Apache configuration file -- Get the Review Board Power Pack at http://www.reviewboard.org/pow erpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at
Re: DJblets _check_expired() issues
I opened another topic: https://groups.google.com/forum/#!topic/reviewboard/kS23n4m5aNw These above issues seem to be caused by the Apache configuration i used (MPM worker instead of MPM fork). Le mardi 10 décembre 2013 17:18:46 UTC+1, Vincent G. a écrit : Hi, Before to explain the problem, below the configuration: ReviewBoard version: 1.7.6 Django version: 1.4.5 Djblets version: 0.7.11 Apache used Memcache used (version 1.48, python lib) I developed some extensions for Reviewboard which are using TemplateHook and UrlHook, to add some HTML code on existing Reviewboard web pages. When i installed and enabled these extensions through administration web page, and users use the Reviewboard, some errors as below have been notified: (even after restarting apache, memcache, and users have refresh their web browser). *Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py, line 89, in get_responseresponse = middleware_method(request) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py, line 32, in process_requestself._check_expired() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py, line 50, in _check_expiredextension_manager.load(full_reload=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 453, in loadself._clear_extensions() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 542, in _clear_extensionsself._uninit_extension(extension) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 595, in _uninit_extensionextension.shutdown() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 170, in shutdownhook.shutdown() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/hooks.py, line 46, in shutdownsuper(URLHook, self).shutdown() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 246, in shutdownself.__class__.remove_hook(self) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 274, in remove_hookcls.hooks.remove(hook)ValueError: list.remove(x): x not in list* or *Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.4.5-py2.7.egg/django/core/handlers/base.py, line 89, in get_responseresponse = middleware_method(request) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py, line 32, in process_requestself._check_expired() File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/middleware.py, line 50, in _check_expiredextension_manager.load(full_reload=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 511, in loadself._init_extension(ext_class) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.11-py2.7.egg/djblets/extensions/base.py, line 580, in _init_extensionextension.info.installed = extension.registration.installedAttributeError: 'MetricsExtension' object has no attribute 'registration'* I tried to find the problem and it seems to come from a cache issue. As i understood (please tell me if i well understood or not), for each HTTP request, the Djblet middleware (located in middleware.py file) checks if the extension manager is expired (_check_expired() method). In *djblets/extensions/middleware.py* file: *class ExtensionsMiddleware(object):...def process_request(self, request):self._check_expired()def _check_expired(self):...for extension_manager in get_extension_managers():if extension_manager.is_expired(): extension_manager.load(full_reload=True)* In *djblets/extensions/base.py* file: *class ExtensionManager(object):...def is_expired(self): sync_gen = cache.get(self._sync_key) return (sync_gen is None or(type(sync_gen) is int and sync_gen != self._last_sync_gen))* If is *_expired()* returns True, all extensions are reloaded (extension_manager.load(full_reload=True) in _check_expired() method. And the problem seems to come during this reloading (see above error messages). So, is it possible to not execute the* extension_manager.load(full_reload=True)* method after each HTTP Request ? As to keep all the time the *_last_sync_gen* key of the extension manager in the cache. I don't understand why you need to put the key in
Re: Which recommended Apache MPM to use with Reviewboard + extensions
Hi Christian,
Thank you to answer so fast.
I would like to notify that the behavior of the Reviewboard, specially when
extensions are used is very 'strange' when Apache server is in MPM worker
mode instead of MPM Prefork.
When in MPM Worker, i noticed that the HTTP request are setup as:
wsgi.multithread : True and wsgi.multiprocess : True.
Ok. It's normal according to the mod_wsgi document ( read
http://code.google.com/p/modwsgi/wiki/ProcessesAndThreading )
The issues i found (described in the topic
https://groups.google.com/forum/#!topic/reviewboard/XL0E9Sb22w0 ) is we
have sometimes a lot of errors ('[Review Board] ERROR (EXTERNAL IP)'
emails) because some object does not exist for example. I tried to analyze
the problem and perhaps i found the cause of these issues.
When the wsgi.multithread is set as True (so for example when Apache MPM
Worker is used), the HTTP requests received by the Reviewboard middleware
(as for example, the djblet middleware which checks the expiration of the
extension manager) can be processed in parallel in each thread BUT also in
the same process. So, when an expiration is detected (by comparing key with
cache) the extension manager is reloaded (so means that ALL extensions have
been reloaded). The problem is that if an other HTTP request is processed
at the same time in other thread BUT in the same process (so normally
memory is shared between threads), this HTTP request can have some issues
because the loading of the extension is not finished. That's why, i think,
i received a lot of '[Review Board] ERROR (EXTERNAL IP)' errors. The
process_request() method of the ExtensionsMiddleware class (in djblet
package) seems to not include synchronization mechanism.
I din't check yet, if you updated the Djblet library (we used the 0.7.11
version, and Reviewboard 1.7.6), but i think it's very important to check
the Apache configuration and use the Apache Prefork MPM to avoid the issues
we encountered. Because in this case, the multithread mechanism is not used
(wsgi.multithread= False) or synchronization mechanism shall be included in
the process_request() of each middleware.
That's why i asked you the recommended Apache MPM to use with Reviewboard.
Don't worry about the other topic i created.
I can understand you have no time. A new released of Reviewboard has been
out recently.
We planned to upgrade our Reviewboard application, but i saw you have
changed some things, especially the extension functionality.
So i need to check if our extensions are always compatible.
Regards,
Vincent
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: how to install plugins on review board
Thanks Raja it worked for me.
when we select review tab we get a another template having ship it entry on
it i want to add another entry along with ship it can it be possible with
extensions.
also if i want to edit some strings in existing files how can i do it with
extensions.
Thanks.
On Thursday, 12 December 2013 12:23:50 UTC+5:30, Raja wrote:
You dont need the self.settings.load() and the self.url. Also, no need to
instantiate the extension using j = Notification(), This is done for you
automatically by the extension loader.
I would create a basic extension with the code in
http://www.reviewboard.org/docs/manual/dev/extending/extensions/hooks/#navigationbarhook
(Just
that, nothing more or less) and then trying to see if it works.
On Thu, Dec 12, 2013 at 11:50 AM, abc123 dange.s...@gmail.comjavascript:
wrote:
Hi ,
i have removed the is_configurable and admin urls part:
below is the my code:
from django.conf import settings
from django.conf.urls.defaults import patterns, include
from reviewboard.extensions.base import Extension
from reviewboard.extensions.hooks import NavigationBarHook
class Notification(Extension):
def __init__(self, *args, **kwargs):
super(Notification, self).__init__(*args, **kwargs)
self.navigationbar_hook = NavigationBarHook(
self,
entries=[
{
'label': 'abc',
'url':'http://abc.com',
},
])
self.settings.load()
self.url = 'http://' + Site.objects.get_current().domain
j=Notification()
and i have installed it but when i click on enable it says that object
does not exist. attached snap.
Thanks.
On Thursday, 12 December 2013 10:43:08 UTC+5:30, Raja wrote:
First off, I think for the task that you are trying to achieve(adding a
menu to navigation bar), there are elements in the Extension class that are
not required. Please look at http://www.reviewboard.org/
docs/manual/dev/extending/extensions/hooks/#navigationbarhook for
adding an entry to the navigation bar. You do not need is_configurable or
admin_urls for this task, these are required only if you are planning to
Configure your extension.
Can you try by just having those in your extension, making sure that
your extension got installed properly and then Enable it. Also a screenshot
of your error might be helpful to know where the error is.
Regards
Raja
On Thu, Dec 12, 2013 at 9:58 AM, abc123 dange.s...@gmail.com wrote:
Hi,
Thanks for the reply.
when i click on enable it gives me an error like object does not exist.
Can you please help.
On Wednesday, 11 December 2013 16:46:21 UTC+5:30, Raja wrote:
If Its installed successfully, you can go to the Administration menu
and click on the Extensions menu in the top-navigation. If the
extension
install was successful, you should be able to see your extension in that
list. Enable it to activate the extension.
Regards
Raja
On Wed, Dec 11, 2013 at 4:39 PM, abc123 dange.s...@gmail.com wrote:
Hi
I am trying to write a simple extension which will add an entry abc
to the navigation bar on review board.
extension.py file:
from django.conf import settings
from django.conf.urls.defaults import patterns, include
from reviewboard.extensions.base import Extension
from reviewboard.extensions.hooks import NavigationBarHook
class Notification(Extension):
def __init__(self, *args, **kwargs):
super(Notification, self).__init__(*args, **kwargs)
self.navigationbar_hook = NavigationBarHook(
self,
entries=[
{
'label': 'abc',
'url':'http://abc.com/',
},
])
self.settings.load()
self.url = 'http://' + Site.objects.get_current().domain
is_configurable = True
and admin urls.py file is:
from django.conf.urls.defaults import patterns, url
from package_name.extension import Notification
urlpatterns = patterns(
'',
(
{'ext_class': Notification,
})
)
and i have installed it using setup.py install command but it is not
working for me.
Can you please help?
On Monday, 25 November 2013 10:07:48 UTC+5:30, Christian Hammond
wrote:
We're going back and forth on this...
Can you tell me specifically what plugins you have found that you're
talking about? I'm not sure there's a lot out there that you can
install.
If you do find any, you'll need to follow their instructions.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Sun, Nov 24, 2013 at 8:36 PM, somdon dange.s...@gmail.comwrote:
so if i want to install any plugins which is freely available on
net how can i install it.
ii have somewhat knowledge of python programming.
On Monday, 25 November 2013 10:00:38 UTC+5:30, Christian Hammond
wrote:
Re: Post-review: How to specify the reviewboard repository in post-review comm
Is there a place for the format of the ~/.reviewboardrc file. It appears that the REPOSITORY field might want to be the name of my git branch? (I'm unsure what it is asking.) While looking playing with some of the REST apis I found that performing a GET of reviewboard.url/api/repositories gave me a list of our repositories. The one with id of 24 is the correct repository. It is using the old, still active, server. (But it is the replicated one.) I think I'm going to have to switch back to the old server. I don't think I can alias the server name too easily. I really just need to associated https://serverx.domain.com with https://servery.domain.com some how in the code. On Wed, Dec 11, 2013 at 4:55 PM, Mike Forsberg bigmik...@gmail.com wrote: Thank you Christian... will let you know if that works. On Wed, Dec 11, 2013 at 3:18 PM, Christian Hammond chip...@chipx86.comwrote: Hi Mike, The recommended setup is to have a .reviewboardrc file in the repository with: REPOSITORY = repository name Where repository name is the name assigned to that repository on Review Board. That way, it doesn't have to match the repository path, which it sounds like may have changed, and can instead do a direct lookup. I don't know if you already have this, but it sounded like it may have been a lookup problem, so starting there. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Dec 11, 2013 at 8:04 AM, Mike Forsberg bigmik...@gmail.comwrote: I'm having trouble specifying the review board repository to which my changes are based. Using post-review, I can make diff by the command post-review -n ~/blah.diff and post it using the GUI. However, I think post-review is having trouble identifying the reviewboard repository. Like I said, post-review -n works, I get a complete diff. Using the ---debug option I can also see that the server is contacted and a review is made. Post-review is just having issues attaching the diff file. A little about my environment. I'm on Ubuntu using a git-svn client for a replicated subversion repository. (By replicated subversion, I mean that IT is replicating the subversion across multiple servers in different locations. Each should mirror the master, it is a black box to me.) Just recently I switched the server my git client is using by using the script at: http://minimalreadership.blogspot.com/2011/06/svn-switch-for-git-svn-repo.html While I don't think these things are related, they are part of the picture. I think the fact that I switched subversion servers is confusing post-review about which review board repository to use. Thus, if I could specify to post-review to use a specific repository for the submission, then it might work I think. Thanks for the great product, Mike -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
New Djblets release for Review Board 1.7.20.
Hi everyone, We had a regression in Djblets, one of Review Board's dependencies, in the RB 1.7.20 release. Essentially, sending auth headers in an API request would cause an HTTP 500 if the user was already logged in. If you're on 1.7.20, you should upgrade Djblets from 0.7.26 to 0.7.27. You can do that with: $ sudo easy_install -U Djblets Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Post-review: How to specify the reviewboard repository in post-review comm
It's basically structured like a Python file. We have docs for this at http://www.reviewboard.org/docs/rbtools/dev/rbt/configuration/#repository (Note that we seem to have a docs bug where that's nested in the wrong section -- it's not Subversion-specific.) If you go into the admin UI for Review Board and see the repository's Name field, or access that API and look at the 'name' field instead of 'id', those are the values you want to put into REPOSITORY. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Dec 12, 2013 at 9:03 AM, Mike Forsberg bigmik...@gmail.com wrote: Is there a place for the format of the ~/.reviewboardrc file. It appears that the REPOSITORY field might want to be the name of my git branch? (I'm unsure what it is asking.) While looking playing with some of the REST apis I found that performing a GET of reviewboard.url/api/repositories gave me a list of our repositories. The one with id of 24 is the correct repository. It is using the old, still active, server. (But it is the replicated one.) I think I'm going to have to switch back to the old server. I don't think I can alias the server name too easily. I really just need to associated https://serverx.domain.com with https://servery.domain.com some how in the code. On Wed, Dec 11, 2013 at 4:55 PM, Mike Forsberg bigmik...@gmail.comwrote: Thank you Christian... will let you know if that works. On Wed, Dec 11, 2013 at 3:18 PM, Christian Hammond chip...@chipx86.comwrote: Hi Mike, The recommended setup is to have a .reviewboardrc file in the repository with: REPOSITORY = repository name Where repository name is the name assigned to that repository on Review Board. That way, it doesn't have to match the repository path, which it sounds like may have changed, and can instead do a direct lookup. I don't know if you already have this, but it sounded like it may have been a lookup problem, so starting there. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, Dec 11, 2013 at 8:04 AM, Mike Forsberg bigmik...@gmail.comwrote: I'm having trouble specifying the review board repository to which my changes are based. Using post-review, I can make diff by the command post-review -n ~/blah.diff and post it using the GUI. However, I think post-review is having trouble identifying the reviewboard repository. Like I said, post-review -n works, I get a complete diff. Using the ---debug option I can also see that the server is contacted and a review is made. Post-review is just having issues attaching the diff file. A little about my environment. I'm on Ubuntu using a git-svn client for a replicated subversion repository. (By replicated subversion, I mean that IT is replicating the subversion across multiple servers in different locations. Each should mirror the master, it is a black box to me.) Just recently I switched the server my git client is using by using the script at: http://minimalreadership.blogspot.com/2011/06/svn-switch-for-git-svn-repo.html While I don't think these things are related, they are part of the picture. I think the fact that I switched subversion servers is confusing post-review about which review board repository to use. Thus, if I could specify to post-review to use a specific repository for the submission, then it might work I think. Thanks for the great product, Mike -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and
Re: how to install plugins on review board
If you want to add a button alongside Ship It, you want
ReviewRequestActionHook.
You can't edit strings with extensions. The upcoming 2.0 release has
support for localization, so theoretically you could write and maintain
your own localization file that replaces some strings, but I can't say we
support that.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Thu, Dec 12, 2013 at 2:52 AM, abc123 dange.soman...@gmail.com wrote:
Thanks Raja it worked for me.
when we select review tab we get a another template having ship it entry
on it i want to add another entry along with ship it can it be possible
with extensions.
also if i want to edit some strings in existing files how can i do it with
extensions.
Thanks.
On Thursday, 12 December 2013 12:23:50 UTC+5:30, Raja wrote:
You dont need the self.settings.load() and the self.url. Also, no need to
instantiate the extension using j = Notification(), This is done for you
automatically by the extension loader.
I would create a basic extension with the code in
http://www.reviewboard.org/docs/manual/dev/extending/extensions/hooks/#
navigationbarhook (Just that, nothing more or less) and then trying to
see if it works.
On Thu, Dec 12, 2013 at 11:50 AM, abc123 dange.s...@gmail.com wrote:
Hi ,
i have removed the is_configurable and admin urls part:
below is the my code:
from django.conf import settings
from django.conf.urls.defaults import patterns, include
from reviewboard.extensions.base import Extension
from reviewboard.extensions.hooks import NavigationBarHook
class Notification(Extension):
def __init__(self, *args, **kwargs):
super(Notification, self).__init__(*args, **kwargs)
self.navigationbar_hook = NavigationBarHook(
self,
entries=[
{
'label': 'abc',
'url':'http://abc.com',
},
])
self.settings.load()
self.url = 'http://' + Site.objects.get_current().domain
j=Notification()
and i have installed it but when i click on enable it says that object
does not exist. attached snap.
Thanks.
On Thursday, 12 December 2013 10:43:08 UTC+5:30, Raja wrote:
First off, I think for the task that you are trying to achieve(adding a
menu to navigation bar), there are elements in the Extension class that are
not required. Please look at http://www.reviewboard.org/
docs/manual/dev/extending/extensions/hooks/#navigationbarhook for
adding an entry to the navigation bar. You do not need is_configurable or
admin_urls for this task, these are required only if you are planning to
Configure your extension.
Can you try by just having those in your extension, making sure that
your extension got installed properly and then Enable it. Also a screenshot
of your error might be helpful to know where the error is.
Regards
Raja
On Thu, Dec 12, 2013 at 9:58 AM, abc123 dange.s...@gmail.com wrote:
Hi,
Thanks for the reply.
when i click on enable it gives me an error like object does not exist.
Can you please help.
On Wednesday, 11 December 2013 16:46:21 UTC+5:30, Raja wrote:
If Its installed successfully, you can go to the Administration menu
and click on the Extensions menu in the top-navigation. If the
extension
install was successful, you should be able to see your extension in that
list. Enable it to activate the extension.
Regards
Raja
On Wed, Dec 11, 2013 at 4:39 PM, abc123 dange.s...@gmail.com wrote:
Hi
I am trying to write a simple extension which will add an entry abc
to the navigation bar on review board.
extension.py file:
from django.conf import settings
from django.conf.urls.defaults import patterns, include
from reviewboard.extensions.base import Extension
from reviewboard.extensions.hooks import NavigationBarHook
class Notification(Extension):
def __init__(self, *args, **kwargs):
super(Notification, self).__init__(*args, **kwargs)
self.navigationbar_hook = NavigationBarHook(
self,
entries=[
{
'label': 'abc',
'url':'http://abc.com/',
},
])
self.settings.load()
self.url = 'http://' + Site.objects.get_current().domain
is_configurable = True
and admin urls.py file is:
from django.conf.urls.defaults import patterns, url
from package_name.extension import Notification
urlpatterns = patterns(
'',
(
{'ext_class': Notification,
})
)
and i have installed it using setup.py install command but it is not
working for me.
Can you please help?
On Monday, 25 November 2013 10:07:48 UTC+5:30, Christian Hammond
wrote:
We're going back and forth on this...
Can you tell me specifically what plugins you have found that
you're talking about? I'm not sure there's a lot out there that you can
install.
If you
Re: Review Board 1.7.20 is out
On 12/10/2013 04:19 AM, Christian Hammond wrote: Hey everyone, We have a small bug fix release out. 1.7.20 fixes issues with JSON fields in the admin UI, compatibility issues with the Mercurial backend, API issues with file attachments, and more. http://www.reviewboard.org/news/2013/12/10/review-board-1-7-20-released/ We're gearing up for a new RBTools release with some real goodies, and another beta of Review Board 2.0. Stay tuned! A little delayed, but ReviewBoard for Fedora 18, 19 and 20 is ready, with EPEL 6 following in about an hour. You can wait for it to arrive in the updates-testing and epel-testing repos within 48 hours, or you can grab it right now from https://admin.fedoraproject.org/updates/search/ReviewBoard This includes the Djblets 0.9.27 release from today. Please let me know if any issues arise! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Review Board 1.7.20 is out
Thanks Stephen! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Dec 12, 2013 at 12:10 PM, Stephen Gallagher step...@gallagherhome.com wrote: On 12/10/2013 04:19 AM, Christian Hammond wrote: Hey everyone, We have a small bug fix release out. 1.7.20 fixes issues with JSON fields in the admin UI, compatibility issues with the Mercurial backend, API issues with file attachments, and more. http://www.reviewboard.org/news/2013/12/10/review-board-1-7-20-released/ We're gearing up for a new RBTools release with some real goodies, and another beta of Review Board 2.0. Stay tuned! A little delayed, but ReviewBoard for Fedora 18, 19 and 20 is ready, with EPEL 6 following in about an hour. You can wait for it to arrive in the updates-testing and epel-testing repos within 48 hours, or you can grab it right now from https://admin.fedoraproject.org/updates/search/ReviewBoard This includes the Djblets 0.9.27 release from today. Please let me know if any issues arise! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
How to make a field required?
I'm using RB 1.7.18. I'd like to make one of the fields that is currently not required to be a required field (with the asterisk). Specifically, I'd like to make the Bugs field required. How do I do this? Thanks, Blair -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to make a field required?
Hi Blair, There's no way to do this without modifying the code. In most cases, it doesn't make sense for every change to have a bug number, so we don't optimize for that. It's possible that an extension could do this in 2.0 beta by flipping the 'required' attribute for a field but there's no official support. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Dec 12, 2013 at 2:16 PM, Blair Barnett bbarn...@graphitesystems.com wrote: I'm using RB 1.7.18. I'd like to make one of the fields that is currently not required to be a required field (with the asterisk). Specifically, I'd like to make the Bugs field required. How do I do this? Thanks, Blair -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3018 in reviewboard: post-review can't find source code repository when using TortoiseSVN
Comment #8 on issue 3018 by kova...@gmail.com: post-review can't find source code repository when using TortoiseSVN http://code.google.com/p/reviewboard/issues/detail?id=3018 The cause of issue - TortoiseSVN was installed without command-line tools -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3166 in reviewboard: Duplicate user accounts created when authenticating against AD and using allcaps for username
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3166 by fishp...@gmail.com: Duplicate user accounts created when authenticating against AD and using allcaps for username http://code.google.com/p/reviewboard/issues/detail?id=3166 What version are you running? 1.7.11 What's the URL of the page containing the problem? http://reviewboard/account/login/ What steps will reproduce the problem? 1. Connect reviewboard to AD/LADAP 2. Login with an AD user, spelling the username in lowercase 3. Log out 4. Log in with the same user, spelling the username with capitalized letters 5. A duplicate user account is created What is the expected output? What do you see instead? The expectation would be that since AD is not case sensitive for usernames, you end up logged into the same account no matter how you caplitalize your username. What operating system are you using? What browser? Firefox 26, Fedora 18. Please provide any additional information below. You should probably tolower your usernames before checking if they already exist. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3107 in reviewboard: Negative count of requests
Updates: Status: NeedInfo Comment #4 on issue 3107 by chip...@gmail.com: Negative count of requests http://code.google.com/p/reviewboard/issues/detail?id=3107 I've been trying to reproduce this bug, and just can't. I know there are negative count issues, and I've seen them in the wild, but none of the repro steps seem to work for me. Is there anything in your repro steps you may have left out? Doing exactly those steps doesn't result in a counter issue here. The screenshot you posted is only showing a negative count for stars. Did you star/unstar at any point during this process? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3018 in reviewboard: post-review can't find source code repository when using TortoiseSVN
Comment #9 on issue 3018 by eyuw...@gmail.com: post-review can't find source code repository when using TortoiseSVN http://code.google.com/p/reviewboard/issues/detail?id=3018 I just found out why, will follow up with you guys. In my case, it was because we didn't use setuptools for installing RBTools, nor did we intend it to be installed by individual users locally. This version (0.5.2) used setuptools to manage scm clients as entry points and later loaded using tools in pkg_resources. A little tweak of entry points works for our infrastructure now. $ ./post-review --version ;./post-review 148092 RBTools 0.5.2 Review request #551754 posted. https://reviewboard.eng.vmware.com/r/551754/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3018 in reviewboard: post-review can't find source code repository when using TortoiseSVN
Comment #10 on issue 3018 by eyuw...@gmail.com: post-review can't find source code repository when using TortoiseSVN http://code.google.com/p/reviewboard/issues/detail?id=3018 I just found out why, will follow up with you guys. In my case, it was because we didn't use setuptools for installing RBTools, nor did we intend it to be installed by individual users locally. This version (0.5.2) used setuptools to manage scm clients as entry points and later loaded using tools in pkg_resources. A little tweak of entry points works for our infrastructure now. $ ./post-review --version ;./post-review 148092 RBTools 0.5.2 Review request #551754 posted. https://.../r/551754/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3168 in reviewboard: Next/previous hunk keyboard shortcuts not respecting selected file
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3168 by ade...@gmail.com: Next/previous hunk keyboard shortcuts not respecting selected file http://code.google.com/p/reviewboard/issues/detail?id=3168 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.7.16 What's the URL of the page containing the problem? http://our.review-board.url/r/12345/diff/ What steps will reproduce the problem? 1. Click on the link to any of the files except the first. 2. Hit 'n' to go to the first changed hunk. What is the expected output? What do you see instead? I expect to be taken to the first changed hunk in the selected file. Instead, I'm taken to the first changed hunk in the first file in the diff. Put another way, it doesn't look like the next/previous hunk keyboard shortcuts are respecting the file I selected. They definitely used to; we were using version 1.6.3 previously and this worked as I described there. What operating system are you using? What browser? Ubuntu Linux 13.04 with Chromium 31.0.1650.63. Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
