Re: Error when diff files on ReviewBoard site
Can you look in the /tmp/ directory it shows and see what the diff looks like? It sounds like the patch isn’t valid. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 7:55:36 PM, hoàng tuấn (hoangnt00...@gmail.com) wrote: Dear All, I installed Reviewboard (2.0.2) and Perforce on same machine (Ubuntu 12.04) and Rbt(0.6.1) When have a review request and i want to diff file and there is a error occurred. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py, line , in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_ uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 155, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 201, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 139, in patch 'output': stderr, Exception: The patch to '//depot/main/Guide for SW developer/Snippet.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JZeo6R' for debugging purposes. `patch` returned: patch: Only garbage was found in the patch input. I am a newbie with Reviewboard so i've just config as the document on reviewboard.org. Anyone help me please? Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firewor...@gmail.com) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Unable to use New Review Request to create requests with parent diffs
I looked into the Windows installer. I love the idea of getting one in, but at the moment, neither of us have Visual Studio, so we need to figure out if we want that as a dependency or if we want to evaluate something else (like NSIS). There’s also the matter of integrating this with our build system, which is another challenge to figure out. I’m going on vacation starting tomorrow, so I won’t be able to look into it any further until I’m back next week. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 4:15:14 PM, Bruce Cran (bruce.c...@gmail.com) wrote: Thanks! I've started committing .reviewboardrc files to each repo. I was slightly worried about the server changing, but it's simple enough to add a CNAME so things don't break. Is there anything I can do to help get the Windows installer patch committed and not forgotten about (presuming it's not already on someone's todo list)? I'm guessing most people working on Review Board are Linux developers and so the combination of Visual Studio projects and WiX code could be rather off-putting! -- Bruce On Fri, Jun 20, 2014 at 1:27 PM, Christian Hammond christ...@beanbaginc.com wrote: Right. We have a .reviewboardrc with REPOSITORY, REVIEWBOARD_URL, BRANCH, and (in some cases), TRACKING_BRANCH set for each repository we use with Review Board. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Error when diff files on ReviewBoard site
Dear Mr Christian Hammond, - When i go to folder /tmp in RB server, there is a folder *reviewboard.JZeo6R. *But I can not enter this folder or cat or do anything else. - I am afraid that may be i had a mistake when configured Repository for Perforce. There is any special required for intergrate Perforce and Reviewboard, isnt it? This is the process when i configured Perforce integration with RB. - Install P4PythonInstaller. - Add Repository in RB Admin site which Repository address = P4 Server Address(P4 info). - p4 counter reviewboard.url http://myreviewboard.example - At client side, i installed Rbtool (I think this step is successful because i can make a review request to RB Server). Best Regards, Nguyen Tuan Hoang Vào 14:46:59 UTC+7 Thứ năm, ngày 26 tháng sáu năm 2014, Christian Hammond đã viết: Can you look in the /tmp/ directory it shows and see what the diff looks like? It sounds like the patch isn’t valid. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 7:55:36 PM, hoàng tuấn (hoangn...@gmail.com javascript:) wrote: *Dear All,* *I installed Reviewboard (2.0.2) and Perforce on same machine (Ubuntu 12.04) and Rbt(0.6.1)* *When have a review request and i want to diff file and there is a error occurred.* Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py, line , in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_ uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 155, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 201, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 139, in patch 'output': stderr,*Exception: The patch to '//depot/main/Guide for SW developer/Snippet.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JZeo6R' for debugging purposes. `patch` returned: patch: Only garbage was found in the patch input.* *I am a newbie with Reviewboard so i've just config as the document on reviewboard.org http://reviewboard.org/.* *Anyone help me please?* *Best Regards,* *Nguyen Tuan Hoang* -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Error when diff files on ReviewBoard site
You’ll need to access that directory as root. Your process looks fine, but something’s certainly wrong. We’ll know more once you can look at the files in that directory. We also generally recommend using .reviewboardrc instead of ‘p4 counter’, but this isn’t the cause of any problem. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 1:15:38 AM, hoàng tuấn (hoangnt00...@gmail.com) wrote: Dear Mr Christian Hammond, - When i go to folder /tmp in RB server, there is a folder reviewboard.JZeo6R. But I can not enter this folder or cat or do anything else. - I am afraid that may be i had a mistake when configured Repository for Perforce. There is any special required for intergrate Perforce and Reviewboard, isnt it? This is the process when i configured Perforce integration with RB. - Install P4PythonInstaller. - Add Repository in RB Admin site which Repository address = P4 Server Address(P4 info). - p4 counter reviewboard.url http://myreviewboard.example - At client side, i installed Rbtool (I think this step is successful because i can make a review request to RB Server). Best Regards, Nguyen Tuan Hoang Vào 14:46:59 UTC+7 Thứ năm, ngày 26 tháng sáu năm 2014, Christian Hammond đã viết: Can you look in the /tmp/ directory it shows and see what the diff looks like? It sounds like the patch isn’t valid. Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 7:55:36 PM, hoàng tuấn (hoangn...@gmail.com) wrote: Dear All, I installed Reviewboard (2.0.2) and Perforce on same machine (Ubuntu 12.04) and Rbt(0.6.1) When have a review request and i want to diff file and there is a error occurred. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/reviews/views.py, line , in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_ uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 155, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 201, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 139, in patch 'output': stderr, Exception: The patch to '//depot/main/Guide for SW developer/Snippet.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.JZeo6R' for debugging purposes. `patch` returned: patch: Only garbage was found in the patch input. I am a newbie with Reviewboard so i've just config as the document on reviewboard.org. Anyone help me please? Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because
Search doesn't seem to work, when I try to index it says Indexing 0 review requests
I'm trying to use Search with ReviewBoard 2.0.2. I simply checked Enable search and left the Search index directory empty (which the docs say lets it use the default). Then I did rb-site manage /path/to/my/site rebuild_index which warned me and then said this. Removing all documents from your index because you said so. All documents removed. Indexing 0 review requests update_index similarly said that it was indexing nothing. The data directory in my site directory does now have a search-index directory, in which is a _MAIN_0.toc file, but as far as I can tell search isn't working at all. Any idea how I can fix this? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Error when diff files on ReviewBoard site
Dear Mr Christian, Actually when i used root, i still can not go into it. I think i do something wrong so i am re-installing RB rightnow. Anyway, nice to hear about .reviewboardrc. May you say more detail about this. Because as i know, this file can be generate after using rbt setup-repo. But when i typed this command and after input the variable for ReviewBoard Server. *There was a error: The current directory does not contain a checkout from a supported source code repository.* Where is the folder where i should stand at when setup-repo? Can i make this file manually? Thank you so much for you support Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Error when diff files on ReviewBoard site
Dear Mr Christian, Actually when i used root, i still can not go into it. I think i do something wrong so i am re-installing RB rightnow. Anyway, nice to hear about .reviewboardrc. May you say more detail about this. Because as i know, this file can be generate after using rbt setup-repo. But when i typed this command and after input the variable for ReviewBoard Server. *There was a error: The current directory does not contain a checkout from a supported source code repository.* Where is the folder i should stand at when setup-repo? Can i make this file manually? Thank you so much for you support Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Error when diff files on ReviewBoard site
After reinstall, I make a new request i face the same problem *Exception: The patch to '//depot/P4Test/new 2.txt' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.GPEAUp' for debugging purposes. `patch` returned: patch: Only garbage was found in the patch input.* https://lh4.googleusercontent.com/-z8Pdw27H_xU/U6vuG4PlmoI/ABo/orDlIsC4yRM/s1600/Capture.PNGAnd this is the result when i enter the /tmp.reviewboard.GPEAUp https://lh4.googleusercontent.com/-z8Pdw27H_xU/U6vuG4PlmoI/ABo/orDlIsC4yRM/s1600/Capture.PNG -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Does reviewboard support file types pdf and ppt files?
Hi All, I am a newbie with Reviewboard. And i have a question, i hope you guys can help me to find out. i am wondering that does Reviewboard support to view .PPT and .PDF file? Because i need to make a Reviewboard site for my team to upload and view also source code and some office files. If reviewboard does not support, can i upload a file and my team can download these files from RB page? Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Attempting to override insert count on FileDiffData warinings in reviewboard.log
I'm running Review Board 2.0.1. Is it normal to get quite a lot of the following messages in reviewboard.log? 2014-06-26 00:26:59,410 - WARNING - - Attempting to override insert count on FileDiffData 569c03ed942572b0d790d8db2ea1c4b49dbdcd4e from 196 to None (F ileDiff None) 2014-06-26 00:26:59,411 - WARNING - - Attempting to override delete count on FileDiffData 569c03ed942572b0d790d8db2ea1c4b49dbdcd4e from 0 to None (Fil eDiff None) -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com javascript:) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RB website showing only directory listing
I installed RB 2.0 version on a RHEL 6.5 . I installed all the pre requisites and created RB site and added the line in /etc/httpd/conf/httpd.conf Include /var/www/mytest.example.com/conf/apache-wsgi.conf Everything else in httpd.conf is default settings. But am only seeing the directory listing when i browse the website. Is there some other change in httpd.conf that i need to do? i have installed review board on another machine before (older version of course) and it did not need any further changes. Why am i seeing only directory listing when i browse the website? Should i change the document root or something? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
...I get the feeling my changes to the python are somehow not being actually run. Is there a place I can put a logging.debug() call that absolutely gets hit 100% of the time to make sure i can see it? On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote: Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
Ok, adding garbage text to the python is not causing the server to go down, I'm thinking my updates aren't taking effect. More sanity checking: I don't have any of the developer code installed and am modifying the install itself, right? I don't need to update an executable somewhere forcibly? The folder which I'm updating the python is in: /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard I see the pyc get updated, but again, it just runs happily, which seems very suspicious to me. I even put logging in webapi/resources/review_request.py, in _find_user(), which didn't update. Does any of this make sense? On Thursday, June 26, 2014 9:46:30 AM UTC-7, fireworm wrote: ...I get the feeling my changes to the python are somehow not being actually run. Is there a place I can put a logging.debug() call that absolutely gets hit 100% of the time to make sure i can see it? On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote: Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
Yeah, it does sound like it’s not executing. Try removing the .pyc file, just to check. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 10:12:41 AM, fireworm (firewor...@gmail.com) wrote: Ok, adding garbage text to the python is not causing the server to go down, I'm thinking my updates aren't taking effect. More sanity checking: I don't have any of the developer code installed and am modifying the install itself, right? I don't need to update an executable somewhere forcibly? The folder which I'm updating the python is in: /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard I see the pyc get updated, but again, it just runs happily, which seems very suspicious to me. I even put logging in webapi/resources/review_request.py, in _find_user(), which didn't update. Does any of this make sense? On Thursday, June 26, 2014 9:46:30 AM UTC-7, fireworm wrote: ...I get the feeling my changes to the python are somehow not being actually run. Is there a place I can put a logging.debug() call that absolutely gets hit 100% of the time to make sure i can see it? On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote: Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
posting reviews that span multiple repos
Hi there, Is there a way to post a single review request that spans multiple repos (using git)? I.e. one review request that contains relevant changes for 2+ repos instead of one separate review board request for each respective repo. Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: posting reviews that span multiple repos
Hi Dan, Sorry, there’s no way to do this. A lot would need to change to allow it to happen. What I’d recommend is just having two (or more) review requests, and using Depends On to relate them. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 11:49:11 AM, Dan Tehranian (tehran...@gmail.com) wrote: Hi there, Is there a way to post a single review request that spans multiple repos (using git)? I.e. one review request that contains relevant changes for 2+ repos instead of one separate review board request for each respective repo. Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Any way to tell how many reviews I have posted
I'm trying to tabulate how many reviews I have posted on my company's review board. Is there any way to do this? I'm using verison 1.7.14. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Active Directory - Can't Assign New User to Review
Removed the pyc file (review_request.pyc). Set myself as the owner (not www-data or admin or whatever). Restarted apache. Refreshed the review webpage. Page loaded just fine, no pyc next to review_request.py. Seems super suspicious. On Thursday, June 26, 2014 11:47:41 AM UTC-7, Christian Hammond wrote: Yeah, it does sound like it’s not executing. Try removing the .pyc file, just to check. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 10:12:41 AM, fireworm (firew...@gmail.com javascript:) wrote: Ok, adding garbage text to the python is not causing the server to go down, I'm thinking my updates aren't taking effect. More sanity checking: I don't have any of the developer code installed and am modifying the install itself, right? I don't need to update an executable somewhere forcibly? The folder which I'm updating the python is in: /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard I see the pyc get updated, but again, it just runs happily, which seems very suspicious to me. I even put logging in webapi/resources/review_request.py, in _find_user(), which didn't update. Does any of this make sense? On Thursday, June 26, 2014 9:46:30 AM UTC-7, fireworm wrote: ...I get the feeling my changes to the python are somehow not being actually run. Is there a place I can put a logging.debug() call that absolutely gets hit 100% of the time to make sure i can see it? On Thursday, June 26, 2014 9:19:22 AM UTC-7, fireworm wrote: Local Site: Not that I'm aware. (I don't know what it is...) Yep, Authentication Settings are Active Directory. (New Users can login via AD just fine.) On Thursday, June 26, 2014 12:49:57 AM UTC-7, Christian Hammond wrote: Hmm, it should be called under those conditions. Just to check, are you using the Local Sites feature? (If you don’t know what that is, then no.) Can you also just verify in Authentication Settings that it’s Active Directory and not LDAP? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 25, 2014 at 9:21:24 AM, fireworm (firew...@gmail.com) wrote: Christian: Open an existing review open in the RB website. Click the pencil under 'People' (which brings up a text box that is empty (no one is currently on the review)). Type in a name in our domain that doesn't have an account yet. (Other accounts show up in the 'intellisense'.) Hit Enter. Message in red says User 'the name I typed in' does not exist. Bruce: Yes, looking at the server log I even see other logs at DEBUG and INFO level. 18:08:32 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) 18:52:28 DEBUG - DiffParser.parse: Beginning parse of diff, size = 16150 On Wednesday, June 25, 2014 7:41:39 AM UTC-7, Bruce Cran wrote: Have you bumped the logging level to DEBUG in the admin settings? -- Bruce On Tue, Jun 24, 2014 at 7:02 PM, fireworm firew...@gmail.com wrote: I modified the one in /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/accounts/backend.py Then I restarted Apache, and reloaded the page, and tried to add a user who doesn't have an RB account. (I see an updated pyc in that folder as well) But I don't see anything in reviewboard.log or the apache error.log. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at
Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests
Hi Ian, Just to check, is that directory and everything in it writeable by the web server? Try running update_index with -v 3. You should hopefully get more useful info out of it. Also, which versions of Haystack and Whoosh? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 2:11:36 AM, Ian (iander...@mac.com) wrote: I'm trying to use Search with ReviewBoard 2.0.2. I simply checked Enable search and left the Search index directory empty (which the docs say lets it use the default). Then I did rb-site manage /path/to/my/site rebuild_index which warned me and then said this. Removing all documents from your index because you said so. All documents removed. Indexing 0 review requests update_index similarly said that it was indexing nothing. The data directory in my site directory does now have a search-index directory, in which is a _MAIN_0.toc file, but as far as I can tell search isn't working at all. Any idea how I can fix this? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: posting reviews that span multiple repos
Ah ok. We'll use the Depends On link. Thanks Christian! Dan On Thursday, June 26, 2014 11:50:43 AM UTC-7, Christian Hammond wrote: Hi Dan, Sorry, there’s no way to do this. A lot would need to change to allow it to happen. What I’d recommend is just having two (or more) review requests, and using Depends On to relate them. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 11:49:11 AM, Dan Tehranian (tehr...@gmail.com javascript:) wrote: Hi there, Is there a way to post a single review request that spans multiple repos (using git)? I.e. one review request that contains relevant changes for 2+ repos instead of one separate review board request for each respective repo. Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests
Looks like I have django_haystack-2.1.0-py2.7.egg and Whoosh-2.6.0-py2.7.egg installed. Everything appears to be writable by the web server (_www). $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard total 0 drwxr-xr-x 2 root admin 204 Dec 5 2013 conf drwxr-xr-x 4 _www admin 136 Jun 26 02:06 data drwxr-xr-x 4 root admin 204 Jun 19 13:00 htdocs drwxr-xr-x 2 root admin 68 Dec 5 2013 logs drwxrwxrwx 3 root admin 102 Dec 5 2013 tmp $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data total 0 drwxr-xr-x 2 _www admin 102 Jun 26 02:06 search-index $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data/search-index/ total 8 -rw-r--r-- 1 _www admin 3558 Jun 26 02:06 _MAIN_0.toc This is what -v 3 said. $ sudo -u _www rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard update_index -- -v 3 Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'django.contrib.auth.models.Permission'' - no index. Skipping 'class 'django.contrib.auth.models.Group'' - no index. Skipping 'class 'django.contrib.auth.models.User'' - no index. Skipping 'class 'django.contrib.contenttypes.models.ContentType'' - no index. Skipping 'class 'django.contrib.sites.models.Site'' - no index. Skipping 'class 'django.contrib.sessions.models.Session'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'djblets.siteconfig.models.SiteConfiguration'' - no index. Skipping 'class 'reviewboard.accounts.models.ReviewRequestVisit'' - no index. Skipping 'class 'reviewboard.accounts.models.Profile'' - no index. Skipping 'class 'reviewboard.accounts.models.LocalSiteProfile'' - no index. Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'reviewboard.attachments.models.FileAttachment'' - no index. Skipping 'class 'reviewboard.changedescs.models.ChangeDescription'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiffData'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiff'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSet'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSetHistory'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'reviewboard.hostingsvcs.models.HostingServiceAccount'' - no index. Skipping 'class 'reviewboard.reviews.models.group.Group'' - no index. Skipping 'class 'reviewboard.reviews.models.default_reviewer.DefaultReviewer'' - no index. Skipping 'class 'reviewboard.reviews.models.diff_comment.Comment'' - no index. Skipping 'class 'reviewboard.reviews.models.file_attachment_comment.FileAttachmentComment'' - no index. Skipping 'class 'reviewboard.reviews.models.screenshot.Screenshot'' - no index. Indexing 0 review requests Skipping 'class 'reviewboard.reviews.models.screenshot_comment.ScreenshotComment'' - no index. Skipping 'class 'reviewboard.reviews.models.review.Review'' - no index. Skipping 'class 'reviewboard.reviews.models.review_request_draft.ReviewRequestDraft'' - no index. Skipping 'class 'reviewboard.scmtools.models.Tool'' - no index. Skipping 'class 'reviewboard.scmtools.models.Repository'' - no index. Skipping 'class 'reviewboard.site.models.LocalSite'' - no index. Skipping 'class 'django_evolution.models.Version'' - no index. Skipping 'class 'django_evolution.models.Evolution'' - no index. Ian On Thursday, June 26, 2014 11:57:57 AM UTC-7, Christian Hammond wrote: Hi Ian, Just to check, is that directory and everything in it writeable by the web server? Try running update_index with -v 3. You should hopefully get more useful info out of it. Also, which versions of Haystack and Whoosh? Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 2:11:36 AM, Ian (iand...@mac.com javascript:) wrote: I'm trying to use Search with ReviewBoard 2.0.2. I simply checked Enable search and left the Search index directory empty (which the docs say lets it use the default). Then I did rb-site manage /path/to/my/site rebuild_index which warned me and then said this. Removing all documents from your index because you said so. All documents removed. Indexing 0 review requests update_index similarly said that it was indexing nothing. The data directory in my site directory does now have a search-index directory, in which is a _MAIN_0.toc file, but as far as I can tell search isn't working at all. Any idea how I can fix this? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop
Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests
What does rebuild_index with -v 3 show? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 2:32:22 PM, Ian (iander...@mac.com) wrote: Looks like I have django_haystack-2.1.0-py2.7.egg and Whoosh-2.6.0-py2.7.egg installed. Everything appears to be writable by the web server (_www). $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard total 0 drwxr-xr-x 2 root admin 204 Dec 5 2013 conf drwxr-xr-x 4 _www admin 136 Jun 26 02:06 data drwxr-xr-x 4 root admin 204 Jun 19 13:00 htdocs drwxr-xr-x 2 root admin 68 Dec 5 2013 logs drwxrwxrwx 3 root admin 102 Dec 5 2013 tmp $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data total 0 drwxr-xr-x 2 _www admin 102 Jun 26 02:06 search-index $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data/search-index/ total 8 -rw-r--r-- 1 _www admin 3558 Jun 26 02:06 _MAIN_0.toc This is what -v 3 said. $ sudo -u _www rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard update_index -- -v 3 Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'django.contrib.auth.models.Permission'' - no index. Skipping 'class 'django.contrib.auth.models.Group'' - no index. Skipping 'class 'django.contrib.auth.models.User'' - no index. Skipping 'class 'django.contrib.contenttypes.models.ContentType'' - no index. Skipping 'class 'django.contrib.sites.models.Site'' - no index. Skipping 'class 'django.contrib.sessions.models.Session'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'djblets.siteconfig.models.SiteConfiguration'' - no index. Skipping 'class 'reviewboard.accounts.models.ReviewRequestVisit'' - no index. Skipping 'class 'reviewboard.accounts.models.Profile'' - no index. Skipping 'class 'reviewboard.accounts.models.LocalSiteProfile'' - no index. Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'reviewboard.attachments.models.FileAttachment'' - no index. Skipping 'class 'reviewboard.changedescs.models.ChangeDescription'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiffData'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiff'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSet'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSetHistory'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'reviewboard.hostingsvcs.models.HostingServiceAccount'' - no index. Skipping 'class 'reviewboard.reviews.models.group.Group'' - no index. Skipping 'class 'reviewboard.reviews.models.default_reviewer.DefaultReviewer'' - no index. Skipping 'class 'reviewboard.reviews.models.diff_comment.Comment'' - no index. Skipping 'class 'reviewboard.reviews.models.file_attachment_comment.FileAttachmentComment'' - no index. Skipping 'class 'reviewboard.reviews.models.screenshot.Screenshot'' - no index. Indexing 0 review requests Skipping 'class 'reviewboard.reviews.models.screenshot_comment.ScreenshotComment'' - no index. Skipping 'class 'reviewboard.reviews.models.review.Review'' - no index. Skipping 'class 'reviewboard.reviews.models.review_request_draft.ReviewRequestDraft'' - no index. Skipping 'class 'reviewboard.scmtools.models.Tool'' - no index. Skipping 'class 'reviewboard.scmtools.models.Repository'' - no index. Skipping 'class 'reviewboard.site.models.LocalSite'' - no index. Skipping 'class 'django_evolution.models.Version'' - no index. Skipping 'class 'django_evolution.models.Evolution'' - no index. Ian On Thursday, June 26, 2014 11:57:57 AM UTC-7, Christian Hammond wrote: Hi Ian, Just to check, is that directory and everything in it writeable by the web server? Try running update_index with -v 3. You should hopefully get more useful info out of it. Also, which versions of Haystack and Whoosh? Christian -- Christian Hammond - chri...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 2:11:36 AM, Ian (iand...@mac.com) wrote: I'm trying to use Search with ReviewBoard 2.0.2. I simply checked Enable search and left the Search index directory empty (which the docs say lets it use the default). Then I did rb-site manage /path/to/my/site rebuild_index which warned me and then said this. Removing all documents from your index because you said so. All documents removed. Indexing 0 review requests update_index similarly said that it was indexing nothing. The data directory in my site directory does now have a search-index directory, in which is a _MAIN_0.toc file, but as far as I can tell search isn't working at all. Any idea how I can fix this? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at
Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests
$ sudo -u _www rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard rebuild_index -- -v 3 WARNING: This will irreparably remove EVERYTHING from your search index in connection 'default'. Your choices after this are to restore from backups or rebuild via the `rebuild_index` command. Are you sure you wish to continue? [y/N] y Removing all documents from your index because you said so. All documents removed. Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'django.contrib.auth.models.Permission'' - no index. Skipping 'class 'django.contrib.auth.models.Group'' - no index. Skipping 'class 'django.contrib.auth.models.User'' - no index. Skipping 'class 'django.contrib.contenttypes.models.ContentType'' - no index. Skipping 'class 'django.contrib.sites.models.Site'' - no index. Skipping 'class 'django.contrib.sessions.models.Session'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'djblets.siteconfig.models.SiteConfiguration'' - no index. Skipping 'class 'reviewboard.accounts.models.ReviewRequestVisit'' - no index. Skipping 'class 'reviewboard.accounts.models.Profile'' - no index. Skipping 'class 'reviewboard.accounts.models.LocalSiteProfile'' - no index. Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'reviewboard.attachments.models.FileAttachment'' - no index. Skipping 'class 'reviewboard.changedescs.models.ChangeDescription'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiffData'' - no index. Skipping 'class 'reviewboard.diffviewer.models.FileDiff'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSet'' - no index. Skipping 'class 'reviewboard.diffviewer.models.DiffSetHistory'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'reviewboard.hostingsvcs.models.HostingServiceAccount'' - no index. Skipping 'class 'reviewboard.reviews.models.group.Group'' - no index. Skipping 'class 'reviewboard.reviews.models.default_reviewer.DefaultReviewer'' - no index. Skipping 'class 'reviewboard.reviews.models.diff_comment.Comment'' - no index. Skipping 'class 'reviewboard.reviews.models.file_attachment_comment.FileAttachmentComment'' - no index. Skipping 'class 'reviewboard.reviews.models.screenshot.Screenshot'' - no index. Indexing 0 review requests Skipping 'class 'reviewboard.reviews.models.screenshot_comment.ScreenshotComment'' - no index. Skipping 'class 'reviewboard.reviews.models.review.Review'' - no index. Skipping 'class 'reviewboard.reviews.models.review_request_draft.ReviewRequestDraft'' - no index. Skipping 'class 'reviewboard.scmtools.models.Tool'' - no index. Skipping 'class 'reviewboard.scmtools.models.Repository'' - no index. Skipping 'class 'reviewboard.site.models.LocalSite'' - no index. Skipping 'class 'django_evolution.models.Version'' - no index. Skipping 'class 'django_evolution.models.Evolution'' - no index. On Thursday, June 26, 2014 4:09:50 PM UTC-7, Christian Hammond wrote: What does rebuild_index with -v 3 show? Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 2:32:22 PM, Ian (iand...@mac.com javascript:) wrote: Looks like I have django_haystack-2.1.0-py2.7.egg and Whoosh-2.6.0-py2.7.egg installed. Everything appears to be writable by the web server (_www). $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard total 0 drwxr-xr-x 2 root admin 204 Dec 5 2013 conf drwxr-xr-x 4 _www admin 136 Jun 26 02:06 data drwxr-xr-x 4 root admin 204 Jun 19 13:00 htdocs drwxr-xr-x 2 root admin 68 Dec 5 2013 logs drwxrwxrwx 3 root admin 102 Dec 5 2013 tmp $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data total 0 drwxr-xr-x 2 _www admin 102 Jun 26 02:06 search-index $ ls -l /Library/Server/Web/Data/WebApps/ReviewBoard/data/search-index/ total 8 -rw-r--r-- 1 _www admin 3558 Jun 26 02:06 _MAIN_0.toc This is what -v 3 said. $ sudo -u _www rb-site manage /Library/Server/Web/Data/WebApps/ReviewBoard update_index -- -v 3 Skipping 'class 'django.contrib.admin.models.LogEntry'' - no index. Skipping 'class 'django.contrib.auth.models.Permission'' - no index. Skipping 'class 'django.contrib.auth.models.Group'' - no index. Skipping 'class 'django.contrib.auth.models.User'' - no index. Skipping 'class 'django.contrib.contenttypes.models.ContentType'' - no index. Skipping 'class 'django.contrib.sites.models.Site'' - no index. Skipping 'class 'django.contrib.sessions.models.Session'' - no index. Skipping 'class 'djblets.extensions.models.RegisteredExtension'' - no index. Skipping 'class 'djblets.siteconfig.models.SiteConfiguration'' - no index. Skipping 'class 'reviewboard.accounts.models.ReviewRequestVisit'' - no index. Skipping 'class
Re: Does reviewboard support file types pdf and ppt files?
If you install the Review Board Power Pack ( https://www.reviewboard.org/powerpack/), PDF files will be reviewable directly in the browser. On any 1.7.x version, you can attach these files to review requests and other users can download them. -David On Thu, Jun 26, 2014 at 4:16 AM, hoàng tuấn hoangnt00...@gmail.com wrote: Hi All, I am a newbie with Reviewboard. And i have a question, i hope you guys can help me to find out. i am wondering that does Reviewboard support to view .PPT and .PDF file? Because i need to make a Reviewboard site for my team to upload and view also source code and some office files. If reviewboard does not support, can i upload a file and my team can download these files from RB page? Best Regards, Nguyen Tuan Hoang -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Attempting to override insert count on FileDiffData warinings in reviewboard.log
Bruce, It looks like the conditionals around this logging are catching too much. I'll get a fix in for the next 2.0.x. -David On Thu, Jun 26, 2014 at 9:02 AM, Bruce Cran bruce.c...@gmail.com wrote: I'm running Review Board 2.0.1. Is it normal to get quite a lot of the following messages in reviewboard.log? 2014-06-26 00:26:59,410 - WARNING - - Attempting to override insert count on FileDiffData 569c03ed942572b0d790d8db2ea1c4b49dbdcd4e from 196 to None (F ileDiff None) 2014-06-26 00:26:59,411 - WARNING - - Attempting to override delete count on FileDiffData 569c03ed942572b0d790d8db2ea1c4b49dbdcd4e from 0 to None (Fil eDiff None) -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3440 in reviewboard: AssertionError displaying changes from diff rev 1 to 2
Updates: Status: PendingReview Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-Release2.0.x Component-DiffViewer Comment #2 on issue 3440 by chip...@gmail.com: AssertionError displaying changes from diff rev 1 to 2 http://code.google.com/p/reviewboard/issues/detail?id=3440 Up for review at https://reviews.reviewboard.org/r/6030/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3444 in reviewboard: Autocomplete is too aggressive
Updates: Status: Confirmed Labels: EasyFix Component-WebUI Project-ReviewBoard Comment #1 on issue 3444 by chip...@gmail.com: Autocomplete is too aggressive http://code.google.com/p/reviewboard/issues/detail?id=3444 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 413 in reviewboard: Make Dashboard columns resizable.
Updates: Labels: -Djblets Project-Djblets Comment #5 on issue 413 by chip...@gmail.com: Make Dashboard columns resizable. http://code.google.com/p/reviewboard/issues/detail?id=413 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
22 issues changed in reviewboard
Updates: Labels: Project-RBTools Comment by chip...@gmail.com: (No comment was entered for this change.) Affected issues: issue 421: Enhancement request: nag owners about stale review requests http://code.google.com/p/reviewboard/issues/detail?id=421 issue 607: post-review option to insert the review url into the changelist description http://code.google.com/p/reviewboard/issues/detail?id=607 issue 1026: RFE: Add ability to ignore files in a patch http://code.google.com/p/reviewboard/issues/detail?id=1026 issue 1551: post-review: need an option to not save the cookie http://code.google.com/p/reviewboard/issues/detail?id=1551 issue 1556: Add the ability to pass SVN username and password on post-review command line http://code.google.com/p/reviewboard/issues/detail?id=1556 issue 1771: Prevent users from creating reviews for P4 changelists they don't own http://code.google.com/p/reviewboard/issues/detail?id=1771 issue 2071: A review should inform about any binary files that may have been changed (CVS) http://code.google.com/p/reviewboard/issues/detail?id=2071 issue 2392: rbtools should provide a warning when svn files are out of date http://code.google.com/p/reviewboard/issues/detail?id=2392 issue 2398: post-review should determine the SCM Client based on repository type http://code.google.com/p/reviewboard/issues/detail?id=2398 issue 2533: post-review prefers /home/login/.git over /home/login/svn/.svn http://code.google.com/p/reviewboard/issues/detail?id=2533 issue 2733: Avoid review creation if diff upload fails http://code.google.com/p/reviewboard/issues/detail?id=2733 issue 2835: post-review fails if extraneous git-svn remote http://code.google.com/p/reviewboard/issues/detail?id=2835 issue 3164: rbt patch --commit should support wrapping commit message lines http://code.google.com/p/reviewboard/issues/detail?id=3164 issue 3172: Review Board diff is not the same as perforce diff after files are moved and resolved http://code.google.com/p/reviewboard/issues/detail?id=3172 issue 3174: compare clearcase label is not supported http://code.google.com/p/reviewboard/issues/detail?id=3174 issue 3176: post-review requests to a server with thousand of repo is very slow http://code.google.com/p/reviewboard/issues/detail?id=3176 issue 3179: add support for UCM clearcase activity http://code.google.com/p/reviewboard/issues/detail?id=3179 issue 3194: Automatically determine subversion branch http://code.google.com/p/reviewboard/issues/detail?id=3194 issue 3195: Enable rbt post --guess-summary for subversion http://code.google.com/p/reviewboard/issues/detail?id=3195 issue 3289: Support for pre-post hooks http://code.google.com/p/reviewboard/issues/detail?id=3289 issue 3389: 'rbt patch' should error out more gracefully if the patch doesn't apply cleanly. http://code.google.com/p/reviewboard/issues/detail?id=3389 issue 3421: RB Tools cannot create a review request for a changeset that belongs to a discarded review request http://code.google.com/p/reviewboard/issues/detail?id=3421 -- You received this message because you are listed in the owner or CC fields of these issues, or because you starred them. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3445 in reviewboard: ReviewRequest.get_last_activity() always returns the ReviewRequest itself
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3445 by marc2...@gmail.com: ReviewRequest.get_last_activity()
always returns the ReviewRequest itself
http://code.google.com/p/reviewboard/issues/detail?id=3445
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
Review Board 2.1 alpha 0 (dev)
What's the URL of the page containing the problem?
My local page.
What steps will reproduce the problem?
1. Add a review to a review request
2. Compare timestamps between the latest review and the last_updated field
on the review request
What is the expected output? What do you see instead?
ReviewRequest.get_last_activity() always returns the ReviewRequest itself
instead of any of the reviews. This is because the last_updated field on a
ReviewRequest gets set to a time after the latest review, so there is never
a review that is newer than the ReviewRequest itself.
What operating system are you using? What browser?
Ubuntu and Chrome
Please provide any additional information below.
I'm trying to write an extension that will display the last user to update
a review request. However, ReviewRequest.get_last_activity() keeps
returning the ReviewRequest itself, so it always displays the submitter's
name.
I made an update as a different user than the one I submitted with and got
this:
$ python reviewboard/manage.py shell
...
from reviewboard.reviews.models.review_request import ReviewRequest as
RR
RR.objects.all()
[ReviewRequest: Test1]
rr = RR.objects.all()[0]
r = rr.reviews.filter(public=True).latest()
r
Review: Review of 'Test1'
r.timestamp
datetime.datetime(2014, 6, 26, 19, 46, 45, 65830, tzinfo=UTC)
rr.last_updated
datetime.datetime(2014, 6, 26, 19, 46, 45, 153334, tzinfo=UTC)
Here is the code I was playing with:
extension.py:
class LastUpdatedByColumn(Column):
def render_data(self, stateful_column, review_request):
timestamp, updated_object = review_request.get_last_activity()
if hasattr(updated_object, 'user'):
return updated_object.user.username
elif hasattr(updated_object, 'submitter'):
return updated_object.submitter.username
return '??? %s' % updated_object.__class__.__name__
class LastUpdatedBy(Extension):
metadata = {
'Name': 'LastUpdatedBy',
'Summary': 'A column that displays who the last user was to update
a review request.',
}
def initialize(self):
DashboardColumnsHook(self, [
LastUpdatedByColumn(id='lastUpdatedBy',
label='Last Updated',
detailed_label='Last Updated By'),
shrink=True),
])
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3446 by ke...@keithmoyer.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 What version are you running? 2.0.2 What's the URL of the page this enhancement relates to, if any? email notifications Describe the enhancement and the motivation for it. ReviewBoard 2.0 added extensibility for adding custom fields to a review request. We've embraced that and included a couple of important-to-us fields. It would fantastic if our field hook could also indicate to be included in the various review request notification emails, alongside the description, testing, diffs, bugs, etc. What operating system are you using? What browser? Windows 7, Firefox 29 Please provide any additional information below. The rendered value would be preferred over the text value of the field. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
