Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Thanks for the reply. I will check the same. Regards, Kalai On Wednesday, July 23, 2014 1:21:05 AM UTC+5:30, Christian Hammond wrote: Your best bet is to look at the source code for RBSeverity and see how it does it.

Re: Need help for adding drop down button in comment window ---- customization of rbsevrity 0.5.1 plugin

2014-07-24 Thread Christian Hammond
I wouldn't recommend modifying the file itself. If you want to have a custom extension, it's best to write your own extension, copying what you need from rbseverity. Christian On Wednesday, July 23, 2014, Rama krishna imr...@gmail.com wrote: ok after modifying severity.js file we need to

Re: Search doesn't seem to work, when I try to index it says Indexing 0 review requests

2014-07-24 Thread Ian
Hmm. My instance doesn't need multiple levels of security, is there a way other than using review groups? If we could somehow limit overall authentication to a particular LDAP group then we could make all our repositories public. Ian On Tuesday, July 22, 2014 1:04:26 PM UTC-7, Christian

Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi, On Monday, July 21, 2014 11:04:26 AM UTC+5:30, Kalaiyarasi Singaram wrote: Hi, I want to add a button/field to CommentDialog using CommentDialogHook.Can u give me a sample? Regards, Kalai -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign

Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi, I checked the java script.RbSeverity is working fine.But if change the button name from minor to medium it is not reflecting.Steps i followed are, 1) Disabled extension in reviewboard. 2) Modified severity.js lines as following (in Red color minor to medium),

Re: CommentDialogHook

2014-07-24 Thread Kalaiyarasi Singaram
Hi, It is reflecting now. Instead of using EGG, i installed the package from scratch using python setup.py install.Now it is working fine. Thanks Regards, Kalai On Thursday, July 24, 2014 3:03:06 PM UTC+5:30, Kalaiyarasi Singaram wrote: Hi, I checked the java

RBTools 0.6.2 revision range and file path

2014-07-24 Thread Yu-Kai Tseng
Hi Developers, I updated my rbtools to 0.6.2 and encountered the following problem. (my repo is SVN) When I use rbtools 0.5.x, I can use commands such as rbt post --revision-range=: /path/to/file1 path/to/file2 to indicate that I want to upload diffs of version and version of

Migrating Reviewboard from 1.5 to 2.0.4

2014-07-24 Thread Bogdan Berezovyi
Hi, I'm having trouble upgrading existing reviewboard 1.5.3 to the new release 2.0.4. After importing mysql dump and running rb-site upgrade I get the following error: CommandError: Error applying evolution: (1061, Duplicate key name 'scmtools_repository_97c59b73') I tried removing index

Re: Migrating Reviewboard from 1.5 to 2.0.4

2014-07-24 Thread Christian Hammond
Hi, Do you have a backup of your 1.5.3 database? You’ll need one at this point, since the new database is in an inconsistent state. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 24, 2014

Re: RBTools 0.6.2 revision range and file path

2014-07-24 Thread David Trowbridge
Under the new command-line syntax, each file path that you want to include should be prefixed with -I. So your command would be: rbt post -I src 29486:29527 or rbt post -I /path/to/file1 -I /path/to/file2 : -David On Thu, Jul 24, 2014 at 4:03 AM, Yu-Kai Tseng tanists...@gmail.com

how to reopen a discarded review?

2014-07-24 Thread Ngsquare
Hi Guys, I have a discarded review that i want it to be reopened. Is there a way to do that? I have login as admin but still i couldn't do it please advise thnx -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons:

Re: how to reopen a discarded review?

2014-07-24 Thread Christian Hammond
Hi, All you need to do is click Reopen on the review request page. So long as you own it or have sufficient permissions, it will work. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 24,

Re: how to reopen a discarded review?

2014-07-24 Thread Ngsquare
that's what i thought, but i don't see the reopen button as i was also expecting. I am login as admin with superuser status checked what else i need On Thursday, July 24, 2014 2:32:10 PM UTC-7, Christian Hammond wrote: Hi, All you need to do is click Reopen on the review request page.

Re: how to reopen a discarded review?

2014-07-24 Thread Christian Hammond
What version of Review Board are you using? Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 24, 2014 at 2:35:22 PM, Ngsquare (warren.man...@gmail.com) wrote: that's what i thought, but i

Re: how to reopen a discarded review?

2014-07-24 Thread Ngsquare
1.7.26 On Thursday, July 24, 2014 2:35:49 PM UTC-7, Christian Hammond wrote: What version of Review Board are you using? Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 24,

Issue 3497 in reviewboard: rbt tools not posting deleted files for perforce

2014-07-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3497 by jco...@gmail.com: rbt tools not posting deleted files for perforce http://code.google.com/p/reviewboard/issues/detail?id=3497 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or

Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3498 by blueazsk...@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a

Re: Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard
Comment #1 on issue 3498 by trowb...@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 While there's no explicit dump/restore, you can use the list-siteconfig, get-siteconfig and set-siteconfig management commands to do this from

Re: Issue 3498 in reviewboard: Command line configuration dump/restore

2014-07-24 Thread reviewboard
Comment #2 on issue 3498 by andrewm@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 I'm not 100% sure, but this might be related: https://groups.google.com/forum/#!topic/reviewboard-dev/ZWJsfyJz_nw -- You received this

Re: Issue 3402 in reviewboard: Include revision of the commits shown in the repository listing of a branch

2014-07-24 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #2 on issue 3402 by trowb...@gmail.com: Include revision of the commits shown in the repository listing of a branch http://code.google.com/p/reviewboard/issues/detail?id=3402 (No comment was entered for this

Re: Issue 3383 in reviewboard: Upload file form doesn't detect errors

2014-07-24 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 3383 by trowb...@gmail.com: Upload file form doesn't detect errors http://code.google.com/p/reviewboard/issues/detail?id=3383 Fixed in release-2.0.x (76caaa7). -- You received this message because this project is configured to send all

Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories

2014-07-24 Thread reviewboard
Updates: Status: ThirdParty Comment #28 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Until RhodeCode supports the necessary APIs, there's nothing we can do

Re: Issue 3311 in reviewboard: Not able to integrate LDAP with Review Board

2014-07-24 Thread reviewboard
Updates: Status: SetupIssue Comment #1 on issue 3311 by trowb...@gmail.com: Not able to integrate LDAP with Review Board http://code.google.com/p/reviewboard/issues/detail?id=3311 I believe that this is just a misconfiguration. The LDAP config UI in 2.0.x is much less confusing.

Re: Issue 3436 in reviewboard: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment

2014-07-24 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 3436 by trowb...@gmail.com: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment http://code.google.com/p/reviewboard/issues/detail?id=3436 Backed out change in 8bfbcf0. -- You received this message because this

Re: Issue 3470 in reviewboard: Unable to set groups/people on a review request

2014-07-24 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 3470 by trowb...@gmail.com: Unable to set groups/people on a review request http://code.google.com/p/reviewboard/issues/detail?id=3470 This is fixed in djblets (85eb686), which you should get if you upgrade to the latest Review Board 2.0.x

Re: Issue 1556 in reviewboard: Add the ability to pass SVN username and password on post-review command line

2014-07-24 Thread reviewboard
Updates: Labels: EasyFix Comment #6 on issue 1556 by trowb...@gmail.com: Add the ability to pass SVN username and password on post-review command line http://code.google.com/p/reviewboard/issues/detail?id=1556 (No comment was entered for this change.) -- You received this message

Re: Issue 2733 in reviewboard: Avoid review creation if diff upload fails

2014-07-24 Thread reviewboard
Comment #3 on issue 2733 by trowb...@gmail.com: Avoid review creation if diff upload fails http://code.google.com/p/reviewboard/issues/detail?id=2733 This is quite doable now that we have the diff validation resource. -- You received this message because this project is configured to send

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard
Comment #19 on issue 46 by trowb...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Mike has some CSS that works for this: table.sidebyside tr[line] td:before { content: ''; position: absolute; transform: translateX(80ch);

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2014-07-24 Thread reviewboard
Comment #20 on issue 46 by chip...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 A few notes on the CSS, after playing with it, that we'll need to address: 1. The red lines end up overflowing from the left-hand side to the right-hand

Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard
Comment #2 on issue 3462 by trowb...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 I'm curious if this is fixed by the new ship-it column in 2.0.x. If you add a new review that has issues, the ship-it won't be shown, and instead the

Re: Issue 3318 in reviewboard: Allow rbt to post from previously submitted changes without a perforce client

2014-07-24 Thread reviewboard
Updates: Summary: Allow rbt to post from previously submitted changes without a perforce client Labels: Project-RBTools Component-RBTools Comment #1 on issue 3318 by trowb...@gmail.com: Allow rbt to post from previously submitted changes without a perforce client

Re: Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement

2014-07-24 Thread reviewboard
Comment #4 on issue 1570 by fbeach...@gmail.com: Diff-Upload UI: Usability Enhancement http://code.google.com/p/reviewboard/issues/detail?id=1570 Thanks to the RB team for thorough and patient attention to this report. -- You received this message because this project is configured to send

Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard
Comment #3 on issue 3462 by vlov...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 Not really. A review may have larger issues (e.g. architectural) that are not issues related to any specific line. -- You received this message

Re: Issue 3462 in reviewboard: Ability to take back a ship-it.

2014-07-24 Thread reviewboard
Comment #4 on issue 3462 by vlov...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 Also, someone may mark all the single line issues as fixed/dropped without addressing larger issues that may be raised that invalidate the ship-it. --

Issue 3499 in reviewboard: on submitting the RB request, i am seeing internal server error 500 (my username sushilk)

2014-07-24 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3499 by sushilku...@gmail.com: on submitting the RB request, i am seeing internal server error 500 (my username sushilk) http://code.google.com/p/reviewboard/issues/detail?id=3499 *** READ THIS BEFORE POSTING! *** *** You