Re: New user of review board here, I'm having trouble attaching diffs
Review Board is configured to point to a repository though. I need details on that to be able to help further. Perhaps you can point your administrator to this thread? - Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 15, 2014 at 2:35:01 PM, Usama Ahmed (usama.ahme...@gmail.com) wrote: In response to your question about the set-up of the repository, I was told that a repository is not configured on Reviewboard. My clone of the central repository is on my computer. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Authentication - Subversion
Upgrade to 2.0.6. It should fix this issue. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On July 14, 2014 at 4:21:32 PM, Kevin Norton (kevin.nor...@gmail.com) wrote: It might be because of certificate. Have you tried saving sssl cert for your repo. You can force this I believe by executing and SVN command via command line. On Monday, July 7, 2014 11:45:52 PM UTC-7, shravanthi s wrote: I am facing a similar issue. But my login credentials are correct and am able to access the svn repo link directly. However its not letting me add a repository and gives an authentication failed error. Any idea what is going wrong here? My review board log is as follows 'ERROR - - SVN: Failed to get repository information for https://test.com/svn/adis: callback_get_login required' On Wednesday, 14 September 2011 21:20:36 UTC+5:30, hs_etd wrote: I am trying to add a repository in Subversion. After entering in the path to the repository which looks like svn://xxx.yyy.net/zzz, I click Save but I always get the error Authentication failed. I look at the /etc/httpd/logs/error_log file and it says Failed to get repository information for svn://xxx.yyy.net/zzz: callback_get_login required Thanks for any pointers on what I need to do. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: problem with sending email in reviewboard 2.0.5
What mail server are you using? Can you check its log files? (You may have to bump up the logging level, depending on the server.) At this point, it’s going to be a mail server configuration issue rather than a Review Board issue, so there’s not a lot we can do to address the problem. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 20, 2014 at 9:03:26 PM, Arjun s v (arjunsv@gmail.com) wrote: On Thursday, August 21, 2014 9:28:36 AM UTC+5:30, Arjun s v wrote: Hi I m unable to send email through SMTP , i have installed reviewboard setup with the domain name 10.113.57.61 and my email settings are as follows sender email address: reviewboard@10.113.57.61 Mail server :localhost port :25 i m not getting any error in the logs and i m unable to send mail i m using apache httpd server my logs in apache are getting generated with wrong timestamp -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue Migrating Database from 1.5.5 to 2.0.5 (model updates fail)
Hey Christian, Have you had a chance to look into this? Is there any other information I can get you? -Zach On Fri, Aug 15, 2014 at 10:11 PM, Zach Auclair zach...@gmail.com wrote: Hi Chris, The output of the list-evolutions command is actually included in my last paragraph in the original post - see *... in list-evolutions form.* I have attached the current schema generated by `pg_dump --schema-only ...`. On Fri, Aug 15, 2014 at 4:37 PM, Christian Hammond christ...@beanbaginc.com wrote: Hmm, that shouldn’t be happening. Can you run this and show me what you see: $ rb-site manage /path/to/site list-evolutions Also, can you dump the schema of your database and attach it? - Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 15, 2014 at 12:11:45 PM, Zach (zach...@gmail.com) wrote: I'm trying to rb-site upgrade an old 1.5.5 database to 2.0.5. *This fails with:* Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: The application markup has been deleted In model reviews.DefaultReviewer: In field 'repository': Property 'null' has changed In model reviews.ReviewRequest: In field 'repository': Property 'null' has changed CommandError: Your models contain changes that Django Evolution cannot resolve automatically. *The suggested --hint's are:* #- Evolution for auth from django_evolution.mutations import ChangeMeta, DeleteModel MUTATIONS = [ ChangeMeta('Permission', 'unique_together', ((u'content_type', u'codename'),)), DeleteModel('Message') ] #-- #- Evolution for contenttypes from django_evolution.mutations import ChangeMeta MUTATIONS = [ ChangeMeta('ContentType', 'unique_together', (('app_label', 'model'),)) ] #-- #- Evolution for sessions from django_evolution.mutations import ChangeField MUTATIONS = [ ChangeField('Session', 'expire_date', initial=None, db_index=True) ] #-- #- Evolution for accounts from django_evolution.mutations import AddField, ChangeMeta, DeleteField from django.db import models from djblets.db.fields import JSONField MUTATIONS = [ AddField('Profile', 'should_send_email', models.BooleanField, initial=True), AddField('Profile', 'timezone', models.CharField, initial=u'UTC', max_length=30), AddField('Profile', 'open_an_issue', models.BooleanField, initial=True), AddField('Profile', 'extra_data', JSONField, null=True), AddField('Profile', 'show_closed', models.BooleanField, initial=True), AddField('Profile', 'is_private', models.BooleanField, initial=False), DeleteField('Profile', 'show_submitted'), ChangeMeta('ReviewRequestVisit', 'unique_together', ((u'user', u'review_request'),)) ] #-- #- Evolution for changedescs from django_evolution.mutations import AddField from django.db import models MUTATIONS = [ AddField('ChangeDescription', 'rich_text', models.BooleanField, initial=True) ] #-- CommandError: Cannot use hinted evolution: AddField or ChangeField mutation for 'FileDiff.status' in 'diffviewer' requires user-specified initial value. *The completed evolutions are:* reviewboard= select * from django_evolution; id | version_id | app_label |label ++-+- 1 | 4 | diffviewer | add_parent_diffs 2 | 4 | reviews | change_descriptions 3 | 4 | scmtools| bugzilla_url_charfield 4 | 5 | attachments | file_attachment_orig_filename 5 | 5 | attachments | file_attachment_file_max_length_512 6 | 5 | attachments | file_attachment_repo_info 7 | 5 | attachments | file_attachment_repo_path_no_index 8 | 5 | attachments | file_attachment_repo_revision_max_length_64 9 | 5 | site
Re: Issue Migrating Database from 1.5.5 to 2.0.5 (model updates fail)
Hi Zach, Sorry, I haven’t had a chance yet. I just glanced through and the schema does look correct, as does the list of applied evolutions. Can you get me the contents of your django_project_version and django_evolution tables? That’ll give me a better understanding of how Django Evolution thinks the world looks. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 21, 2014 at 1:24:01 PM, Zach Auclair (zach...@gmail.com) wrote: Hey Christian, Have you had a chance to look into this? Is there any other information I can get you? -Zach On Fri, Aug 15, 2014 at 10:11 PM, Zach Auclair zach...@gmail.com wrote: Hi Chris, The output of the list-evolutions command is actually included in my last paragraph in the original post - see ... in list-evolutions form. I have attached the current schema generated by `pg_dump --schema-only ...`. On Fri, Aug 15, 2014 at 4:37 PM, Christian Hammond christ...@beanbaginc.com wrote: Hmm, that shouldn’t be happening. Can you run this and show me what you see: $ rb-site manage /path/to/site list-evolutions Also, can you dump the schema of your database and attach it? - Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On August 15, 2014 at 12:11:45 PM, Zach (zach...@gmail.com) wrote: I'm trying to rb-site upgrade an old 1.5.5 database to 2.0.5. This fails with: Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for contenttypes. There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: The application markup has been deleted In model reviews.DefaultReviewer: In field 'repository': Property 'null' has changed In model reviews.ReviewRequest: In field 'repository': Property 'null' has changed CommandError: Your models contain changes that Django Evolution cannot resolve automatically. The suggested --hint's are: #- Evolution for auth from django_evolution.mutations import ChangeMeta, DeleteModel MUTATIONS = [ ChangeMeta('Permission', 'unique_together', ((u'content_type', u'codename'),)), DeleteModel('Message') ] #-- #- Evolution for contenttypes from django_evolution.mutations import ChangeMeta MUTATIONS = [ ChangeMeta('ContentType', 'unique_together', (('app_label', 'model'),)) ] #-- #- Evolution for sessions from django_evolution.mutations import ChangeField MUTATIONS = [ ChangeField('Session', 'expire_date', initial=None, db_index=True) ] #-- #- Evolution for accounts from django_evolution.mutations import AddField, ChangeMeta, DeleteField from django.db import models from djblets.db.fields import JSONField MUTATIONS = [ AddField('Profile', 'should_send_email', models.BooleanField, initial=True), AddField('Profile', 'timezone', models.CharField, initial=u'UTC', max_length=30), AddField('Profile', 'open_an_issue', models.BooleanField, initial=True), AddField('Profile', 'extra_data', JSONField, null=True), AddField('Profile', 'show_closed', models.BooleanField, initial=True), AddField('Profile', 'is_private', models.BooleanField, initial=False), DeleteField('Profile', 'show_submitted'), ChangeMeta('ReviewRequestVisit', 'unique_together', ((u'user', u'review_request'),)) ] #-- #- Evolution for changedescs from django_evolution.mutations import AddField from django.db import models MUTATIONS = [ AddField('ChangeDescription', 'rich_text', models.BooleanField, initial=True) ] #-- CommandError: Cannot use hinted evolution: AddField or ChangeField mutation for 'FileDiff.status' in 'diffviewer' requires user-specified initial value. The completed evolutions are: reviewboard= select * from django_evolution; id | version_id | app_label | label ++-+- 1 | 4 | diffviewer | add_parent_diffs 2 | 4 | reviews | change_descriptions
se linux blocking review board
To the professionals who work with Review Board I'm eager to get started with Review Board, but it's not working out of the box. I have Fedora 20 installed, with RB 1.7.26 with httpd 2.4.10. I can only work ReviewBoard if I turn off selinux, i.e. setenforce off. We cannot do this on production. Here are the audit logs associated with accessing review board. Note there's more than just httpd in this mix, but also memcached. What access rights am I missing? type=AVC msg=audit(1408653306.680:2131): avc: denied { name_connect } for pid=17402 comm=httpd dest=11211 scontext=system_u:system_r:httpd_t:s0 tcontext=system_u:object_r:memcache_port_t:s0 tclass=tcp_socket type=SYSCALL msg=audit(1408653306.680:2131): arch=c03e syscall=42 success=no exit=-13 a0=e a1=7fffbe2e0db0 a2=10 a3=7f80d17c79c8 items=0 ppid=17356 pid=17402 auid=4294967295 uid=1152 gid=100 euid=1152 suid=1152 fsuid=1152 egid=100 sgid=100 fsgid=100 tty=(none) ses=4294967295 comm=httpd exe=/usr/sbin/httpd subj=system_u:system_r:httpd_t:s0 key=(null) type=PROCTITLE msg=audit(1408653306.680:2131): proctitle=2F7573722F7362696E2F6874747064002D44464F524547524F554E44 type=AVC msg=audit(1408653306.803:2132): avc: denied { write } for pid=17402 comm=httpd name=data dev=dm-8 ino=260102 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir type=SYSCALL msg=audit(1408653306.803:2132): arch=c03e syscall=21 success=no exit=-13 a0=7f80d63eb990 a1=2 a2=7f80c6223f88 a3=0 items=0 ppid=17356 pid=17402 auid=4294967295 uid=1152 gid=100 euid=1152 suid=1152 fsuid=1152 egid=100 sgid=100 fsgid=100 tty=(none) ses=4294967295 comm=httpd exe=/usr/sbin/httpd subj=system_u:system_r:httpd_t:s0 key=(null) type=PROCTITLE msg=audit(1408653306.803:2132): proctitle=2F7573722F7362696E2F6874747064002D44464F524547524F554E44 type=AVC msg=audit(1408653306.803:2133): avc: denied { write } for pid=17402 comm=httpd name=data dev=dm-8 ino=260102 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir type=SYSCALL msg=audit(1408653306.803:2133): arch=c03e syscall=21 success=no exit=-13 a0=7f80d65442c0 a1=2 a2=7f80c6223f88 a3=0 items=0 ppid=17356 pid=17402 auid=4294967295 uid=1152 gid=100 euid=1152 suid=1152 fsuid=1152 egid=100 sgid=100 fsgid=100 tty=(none) ses=4294967295 comm=httpd exe=/usr/sbin/httpd subj=system_u:system_r:httpd_t:s0 key=(null) type=PROCTITLE msg=audit(1408653306.803:2133): proctitle=2F7573722F7362696E2F6874747064002D44464F524547524F554E44 type=AVC msg=audit(1408653306.803:2134): avc: denied { write } for pid=17402 comm=httpd name=ext dev=dm-8 ino=260116 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir type=SYSCALL msg=audit(1408653306.803:2134): arch=c03e syscall=21 success=no exit=-13 a0=7f80d5c39120 a1=2 a2=7f80c6223f88 a3=0 items=0 ppid=17356 pid=17402 auid=4294967295 uid=1152 gid=100 euid=1152 suid=1152 fsuid=1152 egid=100 sgid=100 fsgid=100 tty=(none) ses=4294967295 comm=httpd exe=/usr/sbin/httpd subj=system_u:system_r:httpd_t:s0 key=(null) type=PROCTITLE msg=audit(1408653306.803:2134): proctitle=2F7573722F7362696E2F6874747064002D44464F524547524F554E44 type=AVC msg=audit(1408653306.803:2135): avc: denied { write } for pid=17402 comm=httpd name=ext dev=dm-8 ino=260116 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:httpd_sys_content_t:s0 tclass=dir type=SYSCALL msg=audit(1408653306.803:2135): arch=c03e syscall=21 success=no exit=-13 a0=7f80d5c39120 a1=2 a2=7f80c6223f88 a3=0 items=0 ppid=17356 pid=17402 auid=4294967295 uid=1152 gid=100 euid=1152 suid=1152 fsuid=1152 egid=100 sgid=100 fsgid=100 tty=(none) ses=4294967295 comm=httpd exe=/usr/sbin/httpd subj=system_u:system_r:httpd_t:s0 key=(null) type=PROCTITLE msg=audit(1408653306.803:2135): proctitle=2F7573722F7362696E2F6874747064002D44464F524547524F554E44 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: se linux blocking review board
On 2014-08-21 16:53, Tyler Mace wrote: I'm eager to get started with Review Board, but it's not working out of the box. I have Fedora 20 installed, with RB 1.7.26 with httpd 2.4.10. I can only work ReviewBoard if I turn off selinux, i.e. setenforce off. We cannot do this on production. This is similar to my setup, which is working, and *does* have SELinux in 'enforcing' mode. It was necessary for me to create some additional rules, however. Unfortunately, while I still have those rules installed, I don't have the files from which they were created, which as I understand are necessary to create them on other systems (or e.g. bundle with the .rpm). If you're willing to help work through these issues in order to get it working on your machine, and then contribute back the necessary files so that the rules can be set up automatically with the .rpm, I'm sure that would be greatly appreciated. You might also want to look at the audit2why and audit2allow commands. If you get it working, please don't make the mistake I made and delete the rule input files :-), but contribute them back. Stephen Gallagher (who usually reads this list, and is the Fedora packager for RB) may also be able to help out. However he seems to have a somewhat erratic schedule, so don't panic if he doesn't jump in right away. -- Matthew -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Warnings in server log
Greg, Sorry for the long lead time on this. Responses inline. 13:42:37 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848: RuntimeWarning: DateTimeField Review.timestamp received a naive datetime (2014-07-17 00:00:00) while time zone support is active. RuntimeWarning) I haven't seen this one. If you can figure out a reproduction case for this, it would be very helpful. 13:40:28 WARNING - Attempting to override delete count on FileDiffData 12a74691096148b5b997cfce58a970ad66a92bac from 0 to None (FileDiff None) 13:40:28 WARNING - Attempting to override insert count on FileDiffData 12a74691096148b5b997cfce58a970ad66a92bac from 4 to None (FileDiff None) Looks like maybe you guys have fixed these two already? Yep, these are fixed. 20:12:29 WARNING - Cache data for key ourserver.com:8081:/:diffviewer/diff_file_fragment.html-24-3-1634-collapsed-highlighting-en-1407960566 (length 2103714) may be too big for the cache. This one is a potential issue, but we haven't seen it before because usually fragments aren't so big. We'll get a fix in for this. 21:42:57 WARNING - /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.2-py2.7.egg/reviewboard/diffviewer/diffutils.py:97: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal if diff.strip() == : This is harmless, but we'll get a fix in to avoid the warning. 13:47:59 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) This can be ignored for now, but I'll do some investigation into how we can get rid of it. 13:48:00 WARNING - /usr/local/lib/python2.7/dist-packages/feedparser-5.1.3-py2.7.egg/feedparser.py:364: DeprecationWarning: To avoid breaking existing software while fixing issue 310, a temporary mapping has been created from `updated_parsed` to `published_parsed` if `updated_parsed` doesn't exist. This fallback will be removed in a future version of feedparser. This can be ignored. -David -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Warnings in server log
On August 21, 2014 at 2:45:51 PM, David Trowbridge (trowb...@gmail.com) wrote: Greg, Sorry for the long lead time on this. Responses inline. 13:42:37 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/db/models/fields/__init__.py:848: RuntimeWarning: DateTimeField Review.timestamp received a naive datetime (2014-07-17 00:00:00) while time zone support is active. RuntimeWarning) I haven't seen this one. If you can figure out a reproduction case for this, it would be very helpful. I’ve seen this when moving from an older database (pre-Django 1.4), back when timezone information wasn’t included in the database. If this was a recent upgrade from 1.6 or older, I think this will happen. 13:47:59 WARNING - /usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/http/response.py:327: DeprecationWarning: Using mimetype keyword argument is deprecated, use content_type instead super(HttpResponse, self).__init__(*args, **kwargs) This can be ignored for now, but I'll do some investigation into how we can get rid of it. I briefly looked into this. Basically, Django just deprecated an argument, so we need to update our calls. Should be pretty trivial, fortunately. - Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Is there a way to only allow some LDAP users to authenticate?
On Tuesday, August 19, 2014 4:39:04 AM UTC-7, Stephen Gallagher wrote: On 08/19/2014 03:52 AM, Ian wrote: I really don't want my entire organization to be able to log into my Review Board server, I only want to allow a few LDAP groups to connect. Is there any way to set up Review Board to do that? The Custom LDAP User Search Filter: looks like a possibility, or maybe there's some magic to be done in the LDAP Base DN? Restricting access by LDAP group is a complicated topic (and something that's not yet implemented in Review Board). There may be some shortcuts depending on how your LDAP environment is implemented, though. (For example, with Active Directory or FreeIPA, users have automatically-added attributes that can be used to determine whether they are members of a particular group). For a purely generic LDAP environment, this would require significant coding effort to accomplish. If you are using AD or FreeIPA as your LDAP environment, I can help you figure out what to put in the Custom LDAP User Search Filter. If you're using a custom environment, your better bet is to ask your LDAP admin to add a new attribute on the users that are allowed to access ReviewBoard which you can key off of. Of course, the other question is whether denying access completely is worthwhile vs allowing anyone to log in but using Review Board's own authorization system to determine who can see individual repo reviews. But IIRC that means managing the groups separately on the Review Board side (since right now it can't automatically retrieve LDAP groups). The main motivation is that search doesn't work if you use review-groups thing in Review Board. But also it's a pain to keep my review groups on Review Board in sync with the LDAP groups. I believe our organization uses OpenLDAP? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Is there a way to perform snapshot reviews?
Hi, I often get asked to perform a review after a project declares it's ready, which is potentially after weeks or even month of development. At this point, reviewing all the individual commits is not practical. Instead, I want to review the current snapshot/revision of the files. Is there a good way to support such a workflow? The best I could come up is to manually upload a diff between /dev/null and the current revision. /nk -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3540 in reviewboard: Add signals for when a draft is discarded, including a reason for why it was discarded
Status: Accepted Owner: Labels: Type-Enhancement Priority-Medium New issue 3540 by mike.d.c...@gmail.com: Add signals for when a draft is discarded, including a reason for why it was discarded http://code.google.com/p/reviewboard/issues/detail?id=3540 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 2.0.3alpha 0 (dev) What's the URL of the page this enhancement relates to, if any? n/a Describe the enhancement and the motivation for it. We've written an extension for Review Board that performs certain acts when publishing, closing and discarding review requests. Unfortunately, there wasn't a way of detecting when a draft for a review request is discarded. We ended up having to use Django's pre_delete model signal, which felt a little heavy-handed, since it will run for every model deletion. We also had to do a bit of checking to see if the draft is deleted when they're manually discarded, or when they're deleted when a review request is published. It'd be nice if the signal made this distinction for us. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3541 in reviewboard: Enable Gmail InApp action Buttons
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3541 by roopa...@gmail.com: Enable Gmail InApp action Buttons https://code.google.com/p/reviewboard/issues/detail?id=3541 What version are you running? 1.7.6 What's the URL of the page this enhancement relates to, if any? email Describe the enhancement and the motivation for it. So Gmail has a thing called in app actions. Basically, like the buttons they have for google calendar where you can click to accept an event right from gmail. If we add some detail to the email, gmail will auto render these buttons. I think it would be a great idea to have a button (for starters) which takes you directly to reviewboard/diffs Documentation for implementation : https://developers.google.com/gmail/actions/actions/actions-overview (This will not affect emails on mobiles or any other platform, and will simply enhance the desktop experience) What operating system are you using? What browser? Mac OS X - chrome Please provide any additional information below. This works on all desktop browsers, and does not cause issues when not using gmail as email client -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3541 in reviewboard: Enable Gmail InApp action Buttons
Updates: Labels: StudentProject Component-EMail Project-ReviewBoard Comment #1 on issue 3541 by trowb...@gmail.com: Enable Gmail InApp action Buttons https://code.google.com/p/reviewboard/issues/detail?id=3541 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3541 in reviewboard: Enable Gmail InApp action Buttons
Updates: Labels: -Priority-Medium -StudentProject Priority-Low Comment #2 on issue 3541 by chip...@gmail.com: Enable Gmail InApp action Buttons https://code.google.com/p/reviewboard/issues/detail?id=3541 I spent a bunch of time looking into this before. It's an awesome feature that we can't provide. First, there's a registration process required to allow Gmail to show those buttons for your app. This requires that you meet some criteria in your mail server DNS and how you're sending e-mails. The way we send e-mails directly conflicts with their requirements, though. All e-mails would have to come from the same user account, which breaks the way we try to handle mapping Review Board discussions to e-mail threads. Basically, while something I'd love to support, it's very unlikely to happen unless Google changes how this works. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3389 in reviewboard: 'rbt patch' should error out more gracefully if the patch doesn't apply cleanly.
Updates: Status: Fixed Owner: chip...@gmail.com Labels: Milestone-RBTools-Release0.6.x Comment #2 on issue 3389 by chip...@gmail.com: 'rbt patch' should error out more gracefully if the patch doesn't apply cleanly. https://code.google.com/p/reviewboard/issues/detail?id=3389 Fixed on release-1.6.x (fcdddb4). This will be in RBTools 0.6.3. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.