You are correct :)
Downloading all patches and filter by them is what i do today, but it's a
lot of patches to download in vain and a concept of projects/components as
a meta field for reviews could have helped in this usecase. I guess my
usecase isn't common enough for a change this big
We use an old version or rbtools, but a new version of reviewboard.
It would be great to know if these issues are something we might get rid of
by updating the rbtools.
1. When doing post-review (yes, we still use that) of a git commit, the
description that appear in reviewboard will be just
I'm using the jenkins-reviewbot plugin to fetch reviews of a specific
project, apply the review diff, run tests and post the result in
reviewboard.
The problem is that we can only fetch reviews by perforce server
(repository) and branch, but the project name isn't stored in any review
field.
I'm guessing from your other email that you're at VMware. In that case, the
branch name is parsed out of the changeset description using some custom
code (which includes the "merge to" lines). Perforce generally does not
force a //depot/branch/project layout, so it's not something that we at
Thanks for the info David!
On Sunday, October 4, 2015 at 6:18:11 PM UTC+3, David Trowbridge wrote:
>
> post-review at VMware does have some significant modifications (which we
> don't have much knowledge of), especially for git. Neither of those issues
> sound familiar to me. You can definitely
post-review at VMware does have some significant modifications (which we
don't have much knowledge of), especially for git. Neither of those issues
sound familiar to me. You can definitely try 'rbt post' / 'ruby post -g'
using a modern rbtools and see if it works for you.
-David
On Sun, Oct 4,
Alright. Thought it might be reasonable since there is already such search
for default reviewers (file regex
in
https://www.reviewboard.org/docs/manual/dev/admin/configuration/default-reviewers/
)
On Monday, October 5, 2015 at 12:31:38 AM UTC+3, David Trowbridge wrote:
>
> Querying diffs by
