Re: Review Board Ticket #4562: Review board 2.5.13.1 does not work with diffs from Bazaar 2.7.0dev1

[Darren Boden]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4562/
--

New update by ondrej
For Beanbag, Inc. > Review Board > Ticket #4562


Reply:

Not sure if it is related, with DEBUG loggin turned on the following 
warning is generated to the log file every now and then:
===
2017-09-14 05:10:42,666 - WARNING -  - py.warnings - 
/usr/local/lib/python2.7/dist-packages/feedparser.py:345: DeprecationWarning: 
To avoid breaking existing software while fixing issue 310, a temporary mapping 
has been created from `updated_parsed` to `published_parsed` if 
`updated_parsed` doesn't exist. This fallback will be removed in a future 
version of feedparser.
  DeprecationWarning)
===
(there are no other warnings in the log)

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4562: Review board 2.5.13.1 does not work with diffs from Bazaar 2.7.0dev1

[Darren Boden]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4562/
--

New update by ondrej
For Beanbag, Inc. > Review Board > Ticket #4562


Reply:

As always, forgot the attachment (facepalm)


Files:
- 12765.diff
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4562: Review board 2.5.13.1 does not work with diffs from Bazaar 2.7.0dev1

[Darren Boden]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4562/
--

New update by ondrej
For Beanbag, Inc. > Review Board > Ticket #4562


Reply:

Same issue for me.  Current production configuration server is [Ubuntu 
10.0.4 / Bazaar 2.5.1 / ReviewBoard 2.0.14].
New test server is built with [Ubuntu 16.04.3 / Bazaar 2.7.0 / ReviewBoard 
2.5.15] and the existing ReviewBoard has been migrated and upgraded.  I am 
seeing the same issue where the browser stays in the "loading" status.  I 
attempted to create reviews using existing diff files that worked as expected 
in the production system.
I set the ReviewBoard log level to DEBUG, no errors reported, the only 
output generated just prior to entering the "loading" state is as follows:
==
2017-09-07 03:41:50,302 - DEBUG -  - root - DiffParser.parse: Beginning 
parse of diff, size = 1658
2017-09-07 03:41:50,303 - DEBUG -  - root - DiffParser.parse: Finished 
parsing diff.
==
I also confirmed that:
  - I can raise non-bzr reviews by creating a simple review with a file 
attachment only
  - Existing BZR-based reviews appear OK: I can open them and view the 
comments and the code diff
Attached for ref is one of the diff files that causes the issue.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Guess-fields always overrides guess-summary and guess-description

[Darren Lo]

Thank you for posting this workaround. This has been bothering me for a 
long time, and used to work in older versions. Thankfully I always want 
both of these to be yes, so I can just use -g.

On Friday, November 18, 2016 at 8:50:24 AM UTC-8, Kayleigh Siejak wrote:
>
> I noticed that it doesn't matter if you specify that the summary and 
> description should have different update types (eg --guess-summary=no, 
> --guess-description=yes), both fields will always be set to auto (or 
> whatever --guess-fields is set to).  I found that this is due to the fact 
> that --guess-fields always overrides these values even if --guess-fields 
> isn't even set.  This seems to be due to line 119 in post.py, which sets 
> --guess-fields to auto if no other type is given by the user.   Commenting 
> out line 119 in post.py fixes this issue and everything works as described 
> on the rbtools post documentation. 
> 
>
> Has anyone else noticed this issue and are there any plans to implement a 
> fix for this?
>
> Thanks.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4481: View diffs of single file in separate independent browser tab

[Darren Moffat]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4481/
--

New ticket #4481 by darrenmoffat
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Enhancement


--
View diffs of single file in separate independent browser tab
==

# What version are you running?

2.5.3

# What's the URL of the page this enhancement relates to, if any?

r//diff/

# Describe the enhancement and the motivation for it.

When working on a review with a large set of changes spread across multiple 
files it would be very helpful to open the diffs for a single file in a new tab.
For large reviews using the original page with the list of files as just a 
navigator and not having it show the file diffs at all.

While it is possible to use the browsers "Open in New Tab" capability that just 
opens the whole review in the new tab scrolled to that point.
The motivation here is NOT to include the diffs for other files or the full 
review header area.

It isn't unusual for us to have reviews span 10s of files and are very large.  
They are often reviewed by a group of people and not every reviewer is viewing 
ever single change to every file.

One such open review we have at the moment is touching 160 files (we have 
pagination set at the defaults so we get 16 pages of files).

# What operating system are you using? What browser?

Server and most clients on Solaris.  Browser is usually Firefox.

# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4477: file name visibility while reviewing

[Darren Moffat]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4477/
--

New update by sschlmr
For Beanbag, Inc. > Review Board > Ticket #4477


Reply:

I would find this very useful as well.  Particularly when the diffs in a 
single file are large or spaced out.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4479: I sometimes want to view only one side of the diff. I find larger fonts more readable, but run out of screen width when viewing both sides of the diff.

[Darren Moffat]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4479/
--

New update by daniel
For Beanbag, Inc. > Review Board > Ticket #4479


Reply:

Sounds very similar to ticket  4159

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4159: expandable udiff view as alternate to side-by-side

[Darren Moffat]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4159/
--

New update by darrenmoffat
For Beanbag, Inc. > Review Board > Ticket #4159


Reply:

Rather than just saying you won't do it can you please explain why ?  There 
are some file types or styles of change that really don't review well when all 
you have is side by side diffs.
If patches for this feature were contributed would you change your stance 
on this ?

While I appreciate that others might not need this style of review it is a 
very important feature for us being able to deploy ReviewBoard and if we don't 
have it then that ends our current evaluation now and we will look for 
something else.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Uploading new diff that contains a new file

[Darren Burke]

Hi Christian,
Thanks for the reply. I have now actually been able to upload new
files with no problems. It turns out that the way I was generating the
diff was causing the problem!

I am not using post-review because I wanted to do some custom steps
when people were submitting reviews. By using my own script I can
ensure that what needs to be included in each review is included.

Cheers,
Darren

On Apr 30, 7:24 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Darren,

 I'd recommend looking at our post-review tool and what it does for diffs.
 You'll need to copy its logic for this. Though, I'm curious why you're not
 just using post-review?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Mon, Apr 30, 2012 at 4:22 AM, Darren Burke darren_bu...@yahoo.comwrote:







  Hi,
  I use clearcase to manage my code and want to upload a diff file to
  reviewboard that contains a new file. I use my own script to create
  new reviews and upload diff files but when I try to upload a diff that
  contains a new file I get the error The file was not found in the
  repository. Anyone know how to overcome this problem?

  I use the HTTP POST method to upload my diff files and this works fine
  for files that already exist in the repository so the problem is
  uniquely related to new files.

  What does reviewboard look for in the diff file to allow new files to
  be included? I guess I could hack the file to include this info to
  support my script.
  Thanks,
  Darren

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Uploading new diff that contains a new file

[Darren Burke]

Hi,
I use clearcase to manage my code and want to upload a diff file to
reviewboard that contains a new file. I use my own script to create
new reviews and upload diff files but when I try to upload a diff that
contains a new file I get the error The file was not found in the
repository. Anyone know how to overcome this problem?

I use the HTTP POST method to upload my diff files and this works fine
for files that already exist in the repository so the problem is
uniquely related to new files.

What does reviewboard look for in the diff file to allow new files to
be included? I guess I could hack the file to include this info to
support my script.
Thanks,
Darren

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reviewboard compared to Crucible

[Darren]

Hi all,

We just finished a comparison of reviewboard with Crucible and
CodeCollaborator.  Overall everyone was impressed with ReviewBoard as
it certainly holds its own against these commercial tools.

However, the users noted a few areas that could be improved.  Here are
the comments from the team:

The Dashboard doesn't keep track of reviews that you have completed.
Instead it shows all the reviews in a large list. It's quite difficult
to know if you have completed a review or not by just looking at the
list. I believe it just colorizes the Posted and Last Updated columns,
but I believe this doesn't directly indicate the status of the review,
and doesn't indicate which reviewers haven't completed. It's probably
just triggered by time from when the review was created.

Comments are hard to follow. I find that the way the list of comments
gets rendered that it's hard to follow. I realize they're sequential,
but I just find it confusing at times.

Having to click publish is a bit of a clunky workflow. Sometimes I
forget that the green strip is there with a publish on it. I just want
to say OK to a comment and have it publish. Having to click publish is
an extra step I feel the tool could do without.

There's no indication as to who has completed the review, and who has
yet to complete it. This would be helpful

It can't roll up revisions. Though this is because this tool is for
pre-checkins, it still makes it harder for the review to stay relevant
once you have made some further changes. You would have to start
another review with the new patch file, and that just makes the review
dashboard messier than it already is.


We'll continue to watch ReviewBoard closely -- it seems like it's on
its way to being a solid tool.

Darren.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Diff containing new file results in File not found error

[Darren]

Hi all,

Just tried uploading a diff based on changes to our instance of
reviewboard.

The diff contains a number of changes to existing code, plus the
addition of two new files.

When I click View Diff the changes to existing code display
correctly.  However, in the Files Changed summary the files that
were added have the following message: Diff currently unavailable.

If I scroll down to the file display, I can see the following error:

/OpenRoad.ThoughtFarmer.Core/Caching/ConfigSettingsCacheService.cs
Revision 12789  New Change
Diff currently unavailable.
Error: The file '/OpenRoad.ThoughtFarmer.Core/Caching/
ConfigSettingsCacheService.cs' (r12789) could not be found in the
repository: File not found: revision 12789, path '/projects/
ThoughtFarmer/trunk/OpenRoad.ThoughtFarmer.Core/Caching/
ConfigSettingsCacheService.cs'
Details


This seems like an odd error -- of course the file isn't in the
repository, it's a new file and hasn't been checked in yet.  I would
expect ReviewBoard to allow me to review the code, but no diff would
be necessary.

Is this a bug, or am I missing something?

Darren.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Diff containing new file results in File not found error

[Darren]

Repository is SVN, and the diff was created by TortiseSVN on windows.

Diff was uploaded by hand through the web UI.

Darren.

On Feb 13, 2:08 pm, Christian Hammond chip...@chipx86.com wrote:
 Sounds like the diff header didn't have the information we expected
 signifying that this was a new file. What repository type is this, and what
 did you use to create/upload the diff?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Feb 13, 2009 at 11:53 AM, Darren spaces...@gmail.com wrote:

  Hi all,

  Just tried uploading a diff based on changes to our instance of
  reviewboard.

  The diff contains a number of changes to existing code, plus the
  addition of two new files.

  When I click View Diff the changes to existing code display
  correctly.  However, in the Files Changed summary the files that
  were added have the following message: Diff currently unavailable.

  If I scroll down to the file display, I can see the following error:

  /OpenRoad.ThoughtFarmer.Core/Caching/ConfigSettingsCacheService.cs
  Revision 12789  New Change
  Diff currently unavailable.
  Error: The file '/OpenRoad.ThoughtFarmer.Core/Caching/
  ConfigSettingsCacheService.cs' (r12789) could not be found in the
  repository: File not found: revision 12789, path '/projects/
  ThoughtFarmer/trunk/OpenRoad.ThoughtFarmer.Core/Caching/
  ConfigSettingsCacheService.cs'
  Details

  This seems like an odd error -- of course the file isn't in the
  repository, it's a new file and hasn't been checked in yet.  I would
  expect ReviewBoard to allow me to review the code, but no diff would
  be necessary.

  Is this a bug, or am I missing something?

  Darren.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---