Re: need help to integrate post-review with Perforce

2009-06-10 Thread Joshua Slominski
There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond wrote: > There's a lot of documentation on this at > http://www.review-board.org/docs/manual/dev/users/tools/post-review

Re: How to create a pre-commit review with ReviewBoard and Perforce?

2009-02-20 Thread Joshua Slominski
All you need to do is move your change out if the default changelist and into a numbered one. On Fri, Feb 20, 2009 at 2:24 PM, Pierre Rouleau wrote: > > Hi all, > > First: many thanks for this great application!! > > This might be a newbie question, and I apologize if this is. I have > been look

Re: Trouble setting up ReviewBoard with perforce

2009-02-04 Thread Joshua Slominski
When i was setting up review bard with perforce i had this problem alot. If you run "post-review -d > output.html", you will get a nice HTML doc that will have a stack trace in it. I normally get the error 500 page when i need to update my perforce ticket number. I don't use my password i use th

Re: post-review error "Unable to parse diff header:"

2008-10-15 Thread Joshua Slominski
t; it can't execute the diff (per the original posts in this thread). > > Thanks, > > > > > On Oct 15, 2:01 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote: >> I seen that error when i forgot to put in my review board URL in >> post-review. Al

Re: post-review error "Unable to parse diff header:"

2008-10-15 Thread Joshua Slominski
> > > Looking at this further, it appears that the only real difference is > the way the execute command is created: > > v0.7 > data = execute('p4 info', ignore_errors=True) > > v0.8 > data = execute(["p4", &

Re: post-review error "Unable to parse diff header:"

2008-10-15 Thread Joshua Slominski
this would fix my problem? On Wed, Oct 15, 2008 at 2:50 PM, Joshua Slominski <[EMAIL PROTECTED]>wrote: > I am also getting this error my exact error is "Unable to parse diff > header: : No such file or directory" > > I put in some more debug functions and this is wha

Re: post-review error "Unable to parse diff header:"

2008-10-15 Thread Joshua Slominski
I am also getting this error my exact error is "Unable to parse diff header: : No such file or directory" I put in some more debug functions and this is what i get: >>> Repository info 'Path: isis.hoem.ad.harman.com:1666, Base path: None, Supports changesets: True' >>> Generating diff for changen

Re: Important: Who's running directly out of an SVN checkout?

2008-10-15 Thread Joshua Slominski
I am also running from the SVN checkout On Wed, Oct 15, 2008 at 9:58 AM, Florian Föbel <[EMAIL PROTECTED]>wrote: > Hi, > > I'm still using reviewboard directly via SVN checkout as I did not see > argument for changing that, yet. So if you make those changes it would be > nice to have a short tran

Re: Using Perforce and Pre-Reviews

2008-10-07 Thread Joshua Slominski
> to "c:\docume~1\marcosp\locals~1\temp\tmpvzainx" > > >>> p4 print -q //project/branches/my_branch/client/GUI/StartWindow.cpp#1 > > >>> p4 where //project/branches/my_branch/client/GUI/StartWindow.cpp > > >>> diff -urNp c:\docume~1\marcosp\lo

Re: Using Perforce and Pre-Reviews

2008-10-07 Thread Joshua Slominski
A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos <[EMAIL PROTECTED]> wrote: > > Greetings. > > I installed reviewboard, and it seems to work ok using post

Re: Perforce password (P4PASSWD) invalid or unset

2008-09-24 Thread Joshua Slominski
Wed, Sep 24, 2008 at 10:02 AM, 13Strider <[EMAIL PROTECTED]>wrote: > > can you be more descriptive ? > > On Sep 23, 5:59 pm, Joshua Slominski <[EMAIL PROTECTED]> wrote: > > I got this error when I was putting my p4 password in the repository > > list. I fixed it

Re: Perforce password (P4PASSWD) invalid or unset

2008-09-23 Thread Joshua Slominski
I got this error when I was putting my p4 password in the repository list. I fixed it buy using the p4 ticket. You can get that by running p4 login -a -p. Sent from my iPhone On Sep 23, 2008, at 2:27 PM, 13Strider <[EMAIL PROTECTED]> wrote: > > Any Idia why a i getting this error ? > > P4Ex

Re: Perforce Security

2008-09-21 Thread Joshua Slominski
This is how I have mine setup. I use my account in reviewboard and every time my ticket expires I use p4 login -a -p. I have found that I need the -a to allow my ticket to work from any computer. Sent from my iPhone On Sep 21, 2008, at 5:54 PM, "Christian Hammond" <[EMAIL PROTECTED]> wrote:

Re: post-review in perforce

2008-09-19 Thread Joshua Slominski
That is what you need. On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote: > > I have made the changes, this is what i have. > > # set the P4 enviroment: > if options.p4_client: > os.environ['P4CLIENT'] = options.p4_client > > if options.p4_port: > os.environ['P4PORT'] = option

Re: post-review in perforce

2008-09-19 Thread Joshua Slominski
I received comments from Christan to make changes to the argument names. So if you update your version of post-review you should be good to go On Fri, Sep 19, 2008 at 12:50 PM, 13Strider <[EMAIL PROTECTED]>wrote: > > Yes i've added it from http://reviews.review-board.org/r/467/ > > On Sep 19, 1:

Re: post-review for p4

2008-09-11 Thread Joshua Slominski
perforce that i will get an > extra icon? > > On Sep 11, 11:22 am, "Joshua Slominski" <[EMAIL PROTECTED]> wrote: > > I have never seen that before. If you run it with debug info on do you > see > > anything interesting? > > > > On Thu, Sep 11, 200

Re: post-review for p4

2008-09-11 Thread Joshua Slominski
id > > > On Sep 10, 5:54 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote: > > Ok, you are using the first submission that i made that used a wrapper > > executable to call post-review. If you look at revision 3, I have > modified > > post-review to

Re: post-review for p4

2008-09-10 Thread Joshua Slominski
ep 10, 2008 at 4:26 PM, 13Strider <[EMAIL PROTECTED]> wrote: > > yeah i can see that, im missing a file thought the direct.h thats > being used in p4Post-review.cpp > also where do i but the p4post-review.cpp, > sorry im a nob, thanks for the help/ > > On Sep 10, 5:2

Re: post-review for p4

2008-09-10 Thread Joshua Slominski
I have submitted a change to post-review to handle this. It is still pending review: http://reviews.review-board.org/r/467/ On Wed, Sep 10, 2008 at 4:01 PM, 13Strider <[EMAIL PROTECTED]> wrote: > > Where can i find a clear description on how to make post review work > with perforce? > > > --~-