Re: Extension is running multiple times
Sounds good. Thank you for your help! On Tuesday, May 5, 2020 at 12:29:10 PM UTC-4, David Trowbridge wrote: > > Travis, > > In theory, Apache threads should be relatively long-lasting. But if you've > just restarted the server, it will spin up a bunch of new threads and > processes all at once. I wouldn't expect a bunch of shutdowns, but it > depends on how your Apache workers are configured. I'd suggest that > initialize is probably not a great place to do long-running tasks, because > that can impact response times for all requests if a new thread is starting > up, and you probably don't want to affect the performance of other parts of > the application. > > David > > On Tue, May 5, 2020 at 10:21 AM Travis > wrote: > >> Thank you, David! >> >> I'm kicking myself over the shutdown override. That makes perfect sense. >> >> You are correct in that I am running this in a production apache >> environment. I had planned on doing some of the heavier lifting (service >> calls) in the initialize method assuming the results would be around for a >> while, but if this may be enabled/disabled multiple times per page render, >> it sounds like I am better off only executing these calls in the actual >> actions I am hooking into? >> >> Thanks, >> Travis >> >> On Tuesday, May 5, 2020 at 12:07:30 PM UTC-4, David Trowbridge wrote: >>> >>> There are slightly different issues here. >>> >>> >>> For Petr's code: you're instantiating a new SampleApprovalHook every >>> time a signal is fired. You'll want to just do it once in your extension's >>> initialize() method. >>> >>> >>> For Travis, it sounds like you're running your extension code in a >>> production setting with Apache. Apache has many processes and threads >>> serving pages, and initialize/shutdown will be called every time a new >>> thread spins up or shuts down, and all go into the same log file. As far as >>> needing to remove the hook yourself, it's because you're overriding >>> shutdown() without calling the superclass version. If you add >>> super(ApprovalRulesExtension, self).shutdown() it will disconnect all hooks >>> when shutting down. >>> >>> David >>> >>> On Thu, Apr 30, 2020 at 11:40 AM Travis wrote: >>> >>>> I am running into the same situation as Petr. I have noticed the same >>>> behavior plus some other concerns (that I believe Petr's logs also show). >>>> >>>> I put logging into my extension initialize, shutdown, and is_approved. >>>> When I enable my plugin and visit a RB page: >>>> >>>>- My extension's initialize() and shutdown() are logged numerous >>>>times. >>>> - This is contrary to the documentation which says that >>>> initialize should only fire when an extension is enabled and >>>> shutdown >>>> should only fire when disabled and/or the server is shut down. >>>>- My ReviewBoardApprovalHook is_approved is logged 1-3 times. >>>> - Expect that this should only fire 1x? >>>> >>>> The problem gets worse if I disable my extension. Once disabled, I >>>> continue to see logs related to my extension's shutdown and is_approved >>>> until I restart apache. If I toggle my extension on and off, the number of >>>> is_approved calls continues to grow. >>>> >>>> It seems as though these hooks are not getting properly removed when >>>> the extension is disabled (despite what the documentation says). Possibly >>>> made worse because the extension is being initialized/shutdown multiple >>>> times per page render? >>>> >>>> I did make one change to explicitly disable the >>>> ReviewRequestApprovalHook that I added in my extension's shutdown. This >>>> seemed to reduce the is_approved checks to only 1 per page render (and >>>> none >>>> once the extension is disabled), but I still see the extension being >>>> enabled/disabled multiple times and I suspect that is the true cause of >>>> this issue? >>>> >>>> Any help/thoughts are greatly appreciated. >>>> >>>> from reviewboard.extensions.base import Extension >>>> from reviewboard.extensions.hooks import ReviewRequestApprovalHook >>>> import logging >>>> >>>> class ApprovalRulesExtension(Extension): >>>>
Re: Extension is running multiple times
Thank you, David!
I'm kicking myself over the shutdown override. That makes perfect sense.
You are correct in that I am running this in a production apache
environment. I had planned on doing some of the heavier lifting (service
calls) in the initialize method assuming the results would be around for a
while, but if this may be enabled/disabled multiple times per page render,
it sounds like I am better off only executing these calls in the actual
actions I am hooking into?
Thanks,
Travis
On Tuesday, May 5, 2020 at 12:07:30 PM UTC-4, David Trowbridge wrote:
>
> There are slightly different issues here.
>
>
> For Petr's code: you're instantiating a new SampleApprovalHook every time
> a signal is fired. You'll want to just do it once in your extension's
> initialize() method.
>
>
> For Travis, it sounds like you're running your extension code in a
> production setting with Apache. Apache has many processes and threads
> serving pages, and initialize/shutdown will be called every time a new
> thread spins up or shuts down, and all go into the same log file. As far as
> needing to remove the hook yourself, it's because you're overriding
> shutdown() without calling the superclass version. If you add
> super(ApprovalRulesExtension, self).shutdown() it will disconnect all hooks
> when shutting down.
>
> David
>
> On Thu, Apr 30, 2020 at 11:40 AM Travis > wrote:
>
>> I am running into the same situation as Petr. I have noticed the same
>> behavior plus some other concerns (that I believe Petr's logs also show).
>>
>> I put logging into my extension initialize, shutdown, and is_approved.
>> When I enable my plugin and visit a RB page:
>>
>>- My extension's initialize() and shutdown() are logged numerous
>>times.
>> - This is contrary to the documentation which says that initialize
>> should only fire when an extension is enabled and shutdown should only
>> fire
>> when disabled and/or the server is shut down.
>>- My ReviewBoardApprovalHook is_approved is logged 1-3 times.
>> - Expect that this should only fire 1x?
>>
>> The problem gets worse if I disable my extension. Once disabled, I
>> continue to see logs related to my extension's shutdown and is_approved
>> until I restart apache. If I toggle my extension on and off, the number of
>> is_approved calls continues to grow.
>>
>> It seems as though these hooks are not getting properly removed when the
>> extension is disabled (despite what the documentation says). Possibly made
>> worse because the extension is being initialized/shutdown multiple times
>> per page render?
>>
>> I did make one change to explicitly disable the ReviewRequestApprovalHook
>> that I added in my extension's shutdown. This seemed to reduce the
>> is_approved checks to only 1 per page render (and none once the extension
>> is disabled), but I still see the extension being enabled/disabled multiple
>> times and I suspect that is the true cause of this issue?
>>
>> Any help/thoughts are greatly appreciated.
>>
>> from reviewboard.extensions.base import Extension
>> from reviewboard.extensions.hooks import ReviewRequestApprovalHook
>> import logging
>>
>> class ApprovalRulesExtension(Extension):
>>
>> def initialize(self):
>>
>> self.approval_hook = TestApprovalHook(self)
>> logging.debug("Enabling ApprovalRulesExtension")
>>
>> def shutdown(self):
>>
>> self.approval_hook.disable_hook()
>> logging.debug("Disabling ApprovalRulesExtension")
>>
>> class TestApprovalHook(ReviewRequestApprovalHook):
>> def is_approved(self, review_request, prev_approved, prev_failure):
>>
>> logging.debug('checking is_approved')
>> return True
>>
>>
>> Thanks,
>> Travis
>>
>> On Friday, April 17, 2020 at 5:59:24 AM UTC-4, Petr Grenar wrote:
>>>
>>> Hello,
>>>
>>> I have a running extension that is finally doing what I want :) But
>>> there is one thing that I don't understand. The extension is working with
>>> SignalHook review_request_closed and a SampleApprovalHook. So when someone
>>> put ship it and submitted on review request the extension is called. This
>>> is working. But when I go to the apache log I can see that the extension
>>> was called multiple times with the same result. Is this behavior normal or
>>> am I doing something wrong?
>>>
>>> The extension is calling other stuff but the log was the same even
&g
Re: Extension is running multiple times
I am running into the same situation as Petr. I have noticed the same
behavior plus some other concerns (that I believe Petr's logs also show).
I put logging into my extension initialize, shutdown, and is_approved. When
I enable my plugin and visit a RB page:
- My extension's initialize() and shutdown() are logged numerous times.
- This is contrary to the documentation which says that initialize
should only fire when an extension is enabled and shutdown should only
fire
when disabled and/or the server is shut down.
- My ReviewBoardApprovalHook is_approved is logged 1-3 times.
- Expect that this should only fire 1x?
The problem gets worse if I disable my extension. Once disabled, I continue
to see logs related to my extension's shutdown and is_approved until I
restart apache. If I toggle my extension on and off, the number of
is_approved calls continues to grow.
It seems as though these hooks are not getting properly removed when the
extension is disabled (despite what the documentation says). Possibly made
worse because the extension is being initialized/shutdown multiple times
per page render?
I did make one change to explicitly disable the ReviewRequestApprovalHook
that I added in my extension's shutdown. This seemed to reduce the
is_approved checks to only 1 per page render (and none once the extension
is disabled), but I still see the extension being enabled/disabled multiple
times and I suspect that is the true cause of this issue?
Any help/thoughts are greatly appreciated.
from reviewboard.extensions.base import Extension
from reviewboard.extensions.hooks import ReviewRequestApprovalHook
import logging
class ApprovalRulesExtension(Extension):
def initialize(self):
self.approval_hook = TestApprovalHook(self)
logging.debug("Enabling ApprovalRulesExtension")
def shutdown(self):
self.approval_hook.disable_hook()
logging.debug("Disabling ApprovalRulesExtension")
class TestApprovalHook(ReviewRequestApprovalHook):
def is_approved(self, review_request, prev_approved, prev_failure):
logging.debug('checking is_approved')
return True
Thanks,
Travis
On Friday, April 17, 2020 at 5:59:24 AM UTC-4, Petr Grenar wrote:
>
> Hello,
>
> I have a running extension that is finally doing what I want :) But there
> is one thing that I don't understand. The extension is working with
> SignalHook review_request_closed and a SampleApprovalHook. So when someone
> put ship it and submitted on review request the extension is called. This
> is working. But when I go to the apache log I can see that the extension
> was called multiple times with the same result. Is this behavior normal or
> am I doing something wrong?
>
> The extension is calling other stuff but the log was the same even before
> I was calling the other things.
>
> You can see the log output and extension on the attached images.
>
> [image: log.png]
>
> [image: extension.png]
>
>
> Thank you in advance.
>
> Petr Grenar
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard/115aa918-95e3-421c-923e-83684b7386cd%40googlegroups.com.
Unable to add Gitlab Repository with a Self Signed Cert
Hey all,
I'm trying to set up Review Board 3.0.15 and keep running into errors when
adding one of our self hosted gitlab repositories. On the "Add Repository"
form, I put in something along the lines of:
Input:
Name: repo_name
Hosting service: Gitlab
Service URL: Custom: https://repo_server
Account username: reviewboard_account
API Token:
Repository information:
Repo Type: Git
Repo Plan: Group
Gitlab group name: group
Repo name: repo_name
Output/error:
2019-10-30 15:18:28,321 - ERROR - - root - Unknown error linking hosting
account ID=None for hosting service='gitlab',
username=u'reviewboard_account', LocalSite=None
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/forms.py",
line 407, in authorize
**kwargs)
File
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", line
338, in authorize
credentials['private_token'].encode('utf-8'),
File
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", line
1272, in _try_api_versions
causes=errors,
GitLabAPIVersionError: Could not determine the GitLab API version for
https://repo_server due to an unexpected error (A verified SSL certificate
is required to connect to this repository.). Check to make sure the URL can
be resolved from this server and that any SSL certificates are valid and
trusted.
Additional info:
So we use an internal self signed cert for our gitlab server and I guess
reviewboard 3.0.15 doesn't like that. We currently have a reviewboard
2.5.1.1 server that is able to connect to gitlab fine. Seeing it is a large
upgrade, I thought it was somewhat releated to this issue:
https://reviews.reviewboard.org/r/9766/
Am I missing some config on the server? Is there a way we can ignore our
cert and connect anyway?
Thanks in advance,
Travis
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard/696a2400-91d1-4a9c-b580-9ea2de3712d4%40googlegroups.com.
Re: Javascript errors when clicking expand buttons in diff view
Oh my, that worked! I'm super happy that it turned out to be such a simple fix! Props to you Christian for the awesome support! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
No worries Christian. So I followed your instructions to get the fragment HTML and it strangely seems to include the tbody element as you are expecting (see attachment). I've also attached the html of the entire #diffs element after this fragment is inserted and you can see that the tbody elements do not make it through. My best guess is that whatever javascript handles inserting these fragments into the diff container is stripping the tbody element. Thanks again, Travis -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. 35 lines 36 volutpat. Nulla id sollicitudin odio. Aliquam elementum sollicitudin 36 volutpat. Nulla id sollicitudin odio. Aliquam elementum sollicitudin 37 nisl, sit amet sagittis augue. Vivamus accumsan erat sed sem 37 nisl, sit amet sagittis augue. Vivamus accumsan erat sed sem 38 convallis, sed bibendum sapien accumsan. Quisque pretium vestibulum 38 convallis, sed bibendum sapien accumsan. Quisque pretium vestibulum 39 risus et ultricies. Fusce turpis erat, dignissim id imperdiet ac, 39 risus et ultricies. Fusce turpis erat, dignissim id imperdiet ac, 40 pulvinar a eros. Nullam mattis lacus et augue feugiat, eleifend 40 pulvinar a eros. Nullam mattis lacus et augue feugiat, eleifend 41 blandit odio aliquet. Fusce tincidunt urna turpis, fermentum accumsan 41 blandit odio aliquet. Fusce tincidunt urna turpis, fermentum accumsan 42 ipsum facilisis commodo. Pellentesque pretium lectus volutpat sapien 42 ipsum facilisis commodo. Pellentesque pretium lectus volutpat sapien 43 ultrices tristique. 43 ultrices tristique. 44 44 45 Duis interdum diam eu elit lacinia auctor. Donec sed metus a risus 45 Duis interdum diam eu elit lacinia auctor. Donec sed metus a risus 46 maximus ullamcorper. Aenean faucibus viverra nulla, sed malesuada mi 46 maximus ullamcorper. Aenean faucibus viverra nulla, sed malesuada mi 47 pulvinar non. Vestibulum dolor erat, pharetra id nisi sed, vulputate 47 pulvinar non. Vestibulum dolor erat, pharetra id nisi sed, vulputate 48 iaculis mi. Suspendisse quis purus at nisl bibendum bibendum sit amet 48 iaculis mi. Suspendisse quis purus at nisl bibendum bibendum sit amet 49 sed leo. Nullam elementum hendrerit purus at dictum. Morbi auctor mi 49 sed leo. Nullam elementum hendrerit purus at dictum. Morbi auctor mi 50 diam, eu viverra urna dignissim at. Fusce pellentesque, eros a 50 diam, eu viverra urna dignissim at. Fusce pellentesque, eros a 51 malesuada tempor, neque nisi feugiat metus, id volutpat justo orci eu 51 malesuada tempor, neque nisi feugiat metus, id volutpat justo orci eu 52 libero. Aliquam vitae turpis et enim tempus aliquet et in sem. Nam 52 libero. Aliquam vitae turpis et enim tempus aliquet et in sem. Nam 53 purus orci, ultrices id vulputate ac, molestie vitae dui. Vestibulum 53 purus orci, ultrices id vulputate ac, molestie vitae dui. Vestibulum 54 rhoncus est vitae lorem pharetra euismod. Nam tempor non orci id 54 rhoncus est vitae lorem pharetra euismod. Nam tempor non orci id 55 luctus. Aenean ultricies turpis id ex ornare, quis dictum sapien 55 luctus. Aenean ultricies turpis id ex ornare, quis dictum sapien lorem_ipsum.txt Revision 80e3fca3ee8f282c83103fded5755fca4ba2c0a0 New Change 35 lines 36 volutpat. Nulla id sollicitudin odio. Aliquam elementum sollicitudin 36 volutpat. Nulla id sollicitudin odio. Aliquam
Re: Javascript errors when clicking expand buttons in diff view
I've attached a few screenshots with the results of evaluating those lines.
I really appreciate your prompt help with this!
On Saturday, February 13, 2016 at 1:34:16 AM UTC-8, Christian Hammond wrote:
>
> Thanks again.
>
> I'll need to have you try some things in your browser's JavaScript console
> (Chrome is fine here). Open that first.
>
> Refresh the page and scroll until the first expand buttons are in view.
> Then type the following:
>
>
> RB.PageManager.getPage()._diffReviewableViews[0]._$collapseButtons.length;
>
> RB.PageManager.getPage()._diffReviewableViews[0]._$collapseButtons;
>
> $('.diff-collapse-btn').length;
>
> $('.diff-collapse-btn');
>
>
> Then expand, and then do the previous lines again.
>
> Then do:
>
>
> $('.diff-collapse-btn').eq(0).parents('tbody');
>
> $('.diff-collapse-btn').eq(0).parents('tbody').offset();
>
>
> Show me a screenshot (or two) of all that. That will give me some
> (hopefully) useful info I can work with.
>
> Thanks!
>
> Christian
>
>
> --
> Christian Hammond - chri...@beanbaginc.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Sat, Feb 13, 2016 at 1:25 AM,
> wrote:
>
>> Oh, and I can confirm that there are no other javascript errors in the
>> console before clicking the buttons.
>>
>> On Saturday, February 13, 2016 at 1:22:42 AM UTC-8, tra...@apptimize.com
>> wrote:
>>>
>>> You said you checked each of the expansion buttons. Did you reload the
page after each one? JavaScript errors can affect future operations. I'd
love to find out if there's some specific button that's problematic.
>>> I just tried each of the buttons I highlighted in my screenshot again,
>>> refreshing in between each attempt, and the same error occurs for each.
>>>
>>>
Can you also try another browser? Firefox, perhaps?
>>> Sure thing! I just downloaded and installed the latest Firefox to test
>>> this and I am still seeing the same error, though the wording is slightly
>>> different:
>>>
>>> TypeError: parentOffset is undefined
>>> RB.DiffReviewableView<._updateCollapseButtonPos()
>>> reviews.min.44ba9ef6d795.js:11
>>> RB.DiffReviewableView<._expandOrCollapse/<.success()
>>> reviews.min.44ba9ef6d795.js:11
>>> m.Callbacks/j()
>>> jquery-1.11.1.min.8101d596b2b8.js:2
>>> m.Callbacks/k.fireWith()
>>> jquery-1.11.1.min.8101d596b2b8.js:2
>>> x()
>>> jquery-1.11.1.min.8101d596b2b8.js:4
>>> .send/b()
>>> jquery-1.11.1.min.8101d596b2b8.js:4
>>> reviews.min.44ba9ef6d795.js:11:20064
>>>
>>>
Also, what browser extensions are you running? Any other console errors
higher up when you first load the page?
>>> The only plugin I am running is Adblock Plus. I just tried disabling it
>>> for my review board site but it seems to make no difference.
>>>
>>
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
No worries, and thank you for the speedy troubleshooting. It's past 2am here as well so I will try to get you some HTML tomorrow. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
Hi Christian, thanks so much for the reply! I have been able to reproduce this error with every diff I have tried it on so far. My browser is the latest version of Chrome (48.0.2564.109 m) and I used Bitnami's review board AMI to set up my environment on an EC2 instance on AWS. Here is some more information about that: AMI: bitnami-reviewboard-2.5.2-1-r02-linux-ubuntu-14.04.3-x86_64-hvm-ebs Review Board: 2.5.2 Apache: 2.4.18 MySQL: 5.5.47 Python: 2.7.11 Memcached: 1.4.25 On Saturday, February 13, 2016 at 12:44:41 AM UTC-8, Christian Hammond wrote: > > Hi Travis, > > This isn't something I've seen or can reproduce. > > What browser are you using? > > Does this happen on all diffs, or one particular diff? > > Also, can you tell me more about how you installed Review Board, and what > your environment is like? > > Thanks, > > Christian > > > -- > Christian Hammond - chri...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > On Fri, Feb 12, 2016 at 12:29 PM, <tra...@apptimize.com > > wrote: > >> I forgot to mention, I am using reviewboard v2.5.2-1 >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
Oh, and I can confirm that there are no other javascript errors in the console before clicking the buttons. On Saturday, February 13, 2016 at 1:22:42 AM UTC-8, tra...@apptimize.com wrote: > > You said you checked each of the expansion buttons. Did you reload the >> page after each one? JavaScript errors can affect future operations. I'd >> love to find out if there's some specific button that's problematic. >> > I just tried each of the buttons I highlighted in my screenshot again, > refreshing in between each attempt, and the same error occurs for each. > > >> Can you also try another browser? Firefox, perhaps? >> > Sure thing! I just downloaded and installed the latest Firefox to test > this and I am still seeing the same error, though the wording is slightly > different: > > TypeError: parentOffset is undefined > RB.DiffReviewableView<._updateCollapseButtonPos() > reviews.min.44ba9ef6d795.js:11 > RB.DiffReviewableView<._expandOrCollapse/<.success() > reviews.min.44ba9ef6d795.js:11 > m.Callbacks/j() > jquery-1.11.1.min.8101d596b2b8.js:2 > m.Callbacks/k.fireWith() > jquery-1.11.1.min.8101d596b2b8.js:2 > x() > jquery-1.11.1.min.8101d596b2b8.js:4 > .send/b() > jquery-1.11.1.min.8101d596b2b8.js:4 > reviews.min.44ba9ef6d795.js:11:20064 > > >> Also, what browser extensions are you running? Any other console errors >> higher up when you first load the page? >> > The only plugin I am running is Adblock Plus. I just tried disabling it > for my review board site but it seems to make no difference. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
> > You said you checked each of the expansion buttons. Did you reload the > page after each one? JavaScript errors can affect future operations. I'd > love to find out if there's some specific button that's problematic. > I just tried each of the buttons I highlighted in my screenshot again, refreshing in between each attempt, and the same error occurs for each. > Can you also try another browser? Firefox, perhaps? > Sure thing! I just downloaded and installed the latest Firefox to test this and I am still seeing the same error, though the wording is slightly different: TypeError: parentOffset is undefined RB.DiffReviewableView<._updateCollapseButtonPos() reviews.min.44ba9ef6d795.js:11 RB.DiffReviewableView<._expandOrCollapse/<.success() reviews.min.44ba9ef6d795.js:11 m.Callbacks/j() jquery-1.11.1.min.8101d596b2b8.js:2 m.Callbacks/k.fireWith() jquery-1.11.1.min.8101d596b2b8.js:2 x() jquery-1.11.1.min.8101d596b2b8.js:4 .send/b() jquery-1.11.1.min.8101d596b2b8.js:4 reviews.min.44ba9ef6d795.js:11:20064 > Also, what browser extensions are you running? Any other console errors > higher up when you first load the page? > The only plugin I am running is Adblock Plus. I just tried disabling it for my review board site but it seems to make no difference. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbt set-repo retruns error
I was experiencing a similar issue when trying to use RBTools on OSX last week. My team ended up patching RBTools to use a different cert validation library which solved the issue for us. https://github.com/reviewboard/rbtools/pull/53 -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Javascript errors when clicking expand buttons in diff view
I forgot to mention, I am using reviewboard v2.5.2-1 -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: More information
I'm having the same problem. I tried to import reviewboard from the python interpreter and it was successful. Any other ideas? On Dec 3, 6:53 pm, Christian Hammond chip...@chipx86.com wrote: Thanks for the information. Nothing stands out as being immediately wrong. Try running the Python interpreter (python.exe) and typing: import reviewboard See if that succeeds or fails. If it fails, then your Python Path isn't correct, somehow. If it succeeds, well, hard to say what's wrong. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Dec 3, 2010 at 5:19 AM, T.O.AFN torsten.ockenf...@assfinet.de wrote: Thanks for the fast answers, here are the informations you asked for: ReviewBoard egg Loacation: --- C:\Python27\Lib\site-packages\ReviewBoard-1.5.1-py2.7.egg === C:\Program Files (x86)\Apache Software Foundation\Apache2.2\conf \httpd.conf: --- # # This is the main Apache HTTP server configuration file. It contains the # configuration directives that give the server its instructions. # See URL:http://httpd.apache.org/docs/2.2 for detailed information. # In particular, see # URL:http://httpd.apache.org/docs/2.2/mod/directives.html # for a discussion of each configuration directive. # # Do NOT simply read the instructions in here without understanding # what they do. They're here only as hints or reminders. If you are unsure # consult the online docs. You have been warned. # # Configuration and logfile names: If the filenames you specify for many # of the server's control files begin with / (or drive:/ for Win32), the # server will use that explicit path. If the filenames do *not* begin # with /, the value of ServerRoot is prepended -- so logs/foo.log # with ServerRoot set to C:/Program Files (x86)/Apache Software Foundation/Apache2.2 will be interpreted by the # server as C:/Program Files (x86)/Apache Software Foundation/ Apache2.2/logs/foo.log. # # NOTE: Where filenames are specified, you must use forward slashes # instead of backslashes (e.g., c:/apache instead of c:\apache). # If a drive letter is omitted, the drive on which httpd.exe is located # will be used by default. It is recommended that you always supply # an explicit drive letter in absolute paths to avoid confusion. # # ServerRoot: The top of the directory tree under which the server's # configuration, error, and log files are kept. # # Do not add a slash at the end of the directory path. If you point # ServerRoot at a non-local disk, be sure to point the LockFile directive # at a local disk. If you wish to share the same ServerRoot for multiple # httpd daemons, you will need to change at least LockFile and PidFile. # ServerRoot C:/Program Files (x86)/Apache Software Foundation/ Apache2.2 # # Listen: Allows you to bind Apache to specific IP addresses and/or # ports, instead of the default. See also the VirtualHost # directive. # # Change this to Listen on specific IP addresses as shown below to # prevent Apache from glomming onto all bound IP addresses. # #Listen 12.34.56.78:80 Listen 80 # # Dynamic Shared Object (DSO) Support # # To be able to use the functionality of a module which was built as a DSO you # have to place corresponding `LoadModule' lines at this location so the # directives contained in it are actually available _before_ they are used. # Statically compiled modules (those listed by `httpd -l') do not need # to be loaded here. # # Example: # LoadModule foo_module modules/mod_foo.so # LoadModule actions_module modules/mod_actions.so LoadModule alias_module modules/mod_alias.so LoadModule asis_module modules/mod_asis.so LoadModule auth_basic_module modules/mod_auth_basic.so #LoadModule auth_digest_module modules/mod_auth_digest.so #LoadModule authn_alias_module modules/mod_authn_alias.so #LoadModule authn_anon_module modules/mod_authn_anon.so #LoadModule authn_dbd_module modules/mod_authn_dbd.so #LoadModule authn_dbm_module modules/mod_authn_dbm.so LoadModule authn_default_module modules/mod_authn_default.so LoadModule authn_file_module modules/mod_authn_file.so #LoadModule authnz_ldap_module modules/mod_authnz_ldap.so #LoadModule authz_dbm_module modules/mod_authz_dbm.so LoadModule authz_default_module modules/mod_authz_default.so LoadModule authz_groupfile_module modules/mod_authz_groupfile.so LoadModule authz_host_module modules/mod_authz_host.so #LoadModule authz_owner_module modules/mod_authz_owner.so LoadModule authz_user_module modules/mod_authz_user.so LoadModule autoindex_module modules/mod_autoindex.so #LoadModule cache_module
Re: ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.
Trouble is I can't find a build for Python 2.7.
On Dec 12, 3:59 pm, Christian Hammond chip...@chipx86.com wrote:
The one thing that is consistent with all the reports I've seen so far
is mod_wsgi. Maybe try using mod_python or something to verify.
mod_python no longer comes with Apache, but I believe you can download
it separately.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Sun, Dec 12, 2010 at 3:50 AM, Dan birb...@gmail.com wrote:
Have you found solution to this problem,
I have the same problem now.
Could anyone give some hints?
Any help will be highly appreciated.
On Dec 1, 3:59 am, Travis dahlke.tra...@gmail.com wrote:
Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.
Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Encoding Error for ReviewBoard 1.5 on Windows XP
I've just installed the lastest Review Board on my computer today by
following the url ''http://www.reviewboard.org/docs/manual/1.5/admin/
installation/windows/'.
Everything is fine until I got a 500 error while adding a new
repository.
I chose the Custom+SVN, and input all the necessary fields. Here is
the message I got:
--
Something broke! (Error 500)
It appears something broke when you tried to go to here. This is
either a bug in Review Board or a server configuration error. Please
report this to your administrator.
--
And here is the traceback I got from log file:
--
'utf8' codec can't decode bytes in position 17-18: invalid data. You
passed in 'DLL load failed: \xd5\xd2\xb2\xbb\xb5\xbd
\xd6\xb8\xb6\xa8\xb5\xc4\xb3\xcc\xd0\xf2\xa1\xa3' (type 'str')
Traceback (most recent call last):
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\core\handlers\base.py, line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\contrib\admin\sites.py, line 512, in root
return self.model_page(request, *url.split('/', 2))
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\views\decorators\cache.py, line 69, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\contrib\admin\sites.py, line 531, in model_page
return admin_obj(request, rest_of_url)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\contrib\admin\options.py, line 1190, in __call__
return self.add_view(request)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\utils\decorators.py, line 21, in _wrapper
return decorator(bound_func)(*args, **kwargs)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\utils\decorators.py, line 76, in _wrapped_view
response = view_func(request, *args, **kwargs)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\utils\decorators.py, line 17, in bound_func
return func(self, *args2, **kwargs2)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django\db
\transaction.py, line 299, in _commit_on_success
res = func(*args, **kw)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\contrib\admin\options.py, line 777, in add_view
if form.is_valid():
File D:\Python25\lib\site-packages\reviewboard-1.5-py2.5.egg
\reviewboard\scmtools\forms.py, line 578, in is_valid
return (super(RepositoryForm, self).is_valid() and
File D:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\forms\forms.py, line 121, in is_valid
return self.is_bound and not bool(self.errors)
File D:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\forms\forms.py, line 112, in _get_errors
self.full_clean()
File D:\Python25\lib\site-packages\reviewboard-1.5-py2.5.egg
\reviewboard\scmtools\forms.py, line 500, in full_clean
return super(RepositoryForm, self).full_clean()
File D:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\forms\forms.py, line 268, in full_clean
self._clean_form()
File D:\Python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\forms\forms.py, line 296, in _clean_form
self.cleaned_data = self.clean()
File D:\Python25\lib\site-packages\reviewboard-1.5-py2.5.egg
\reviewboard\scmtools\forms.py, line 520, in clean
self._verify_repository_path()
File D:\Python25\lib\site-packages\reviewboard-1.5-py2.5.egg
\reviewboard\scmtools\forms.py, line 684, in _verify_repository_path
raise forms.ValidationError(e)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\core\exceptions.py, line 55, in __init__
message = force_unicode(message)
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\utils\encoding.py, line 96, in force_unicode
errors) for arg in s])
File d:\python25\lib\site-packages\django-1.2.3-py2.5.egg\django
\utils\encoding.py, line 88, in force_unicode
raise DjangoUnicodeDecodeError(s, *e.args)
DjangoUnicodeDecodeError: 'utf8' codec can't decode bytes in position
17-18: invalid data. You passed in 'DLL load failed: \xd5\xd2\xb2\xbb
\xb5\xbd\xd6\xb8\xb6\xa8\xb5\xc4\xb3\xcc\xd0\xf2\xa1\xa3' (type
'str')
--
The hex string of '\xd5\xd2\xb2\xbb\xb5\xbd
\xd6\xb8\xb6\xa8\xb5\xc4\xb3\xcc\xd0\xf2\xa1\xa3' here is Chinese
words which means 'The specified program is not found', but its not
utf-8 encoded.
My environment is Windows XP in Chinese version + RB 1.5 + Python 2.5
+ Apache(Mod_Python) + SVN 1.6.13 + pySVN.
Anyone can help on this?
Thanks,
Travis
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http
Visual SourceSafe
Is it possible to add support for Visual SourceSafe? I'd be willing to help if someone could point me in the right direction to get started. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
