Re: About the view diff page of reviewboard
Thanks, Scott and Christian. We are making automation of ReviewRequest generation. since the diff file can be generated in the Reviewboard Server side, We want to change the post-review to prevent it from generating and sending diff contents to Reviewboard, So that post-review can be used anywhere without the CVS check out version. I am not sure its feasibility. But as out leader required, I will try. Best Regards! On Jan 29, 4:44 am, Scott Quesnelle scott.quesne...@gmail.com wrote: If you look into the scmtools directory you will see cvs.py All that occurs for diff viewing is the following. From the diff, a list of files and revisions are extracted. Based on that list, a series of cvs checkouts are done look for cvs co -r revision filename in the file. It then uses the patch utility to generate the 'after' file with the change. The 2 files are then given to the viewer which displays the files. So a key question for you then is does your cvs server actually enforce authentication? If it does not, then anyone can view the entire repository. The easy way to test this is to do a cvs logout then attempt to access the repository. If it doesn't force you to login then there is no authentication on your cvs server. Scott On Wed, Jan 27, 2010 at 12:15 AM, JohnHenry qhlonl...@163.com wrote: Hi, Christian. I just can't understand how does ReviewBoard get the basic source file with the help of diff file. Yes I have set Repository path on ReviewBoard webUI, and on the Authentication setting, I use my CVS Id and password. But I am an ordinary user on CVS, I can't access other directories on CVS except that cvs administrator give me the authentication. Then how does reviewboard get basic source files on CVS with the path and my CVS account? And I have made a test. When I changed my Authentication account on CVS Repository setting, I still can generate ReviewRequest and make Review successfully. So I think may be the Authentication setting is useless for ReviewBoard. But without any CVS account, how did ReviewBoard get those basic source files from CVS server? Does that means any one without CVS authentication can get source file through ReviewBoard? Best Regards! On Jan 27, 3:53 am, Christian Hammond chip...@chipx86.com wrote: No, there's not. That would be a *lot* of work and isn't planned. It's a fundamental change to the way that Review Board works, and would make things confusing in the future. All the code for talking to repositories is in scmtools/. All the code for handling diffs is in diffviewer/. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Jan 26, 2010 at 1:36 AM, qhlonline qhlonl...@163.com wrote: Hi, Christian. Is there any way to generate Diff Review with only diff file without the basic source file? We don't want reviewers to see the whole content of the basic source file, We want them see only the diff part. I can't find the RB source code that get the basic file from CVS server, Is it defined in Djblets files? Best Regards! 在2010-01-26 15:35:07，Christian Hammond chip...@chipx86.com 写道： This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the *Expand changes* link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~---
Re: About the view diff page of reviewboard
Hi, Christian. I just can't understand how does ReviewBoard get the basic source file with the help of diff file. Yes I have set Repository path on ReviewBoard webUI, and on the Authentication setting, I use my CVS Id and password. But I am an ordinary user on CVS, I can't access other directories on CVS except that cvs administrator give me the authentication. Then how does reviewboard get basic source files on CVS with the path and my CVS account? And I have made a test. When I changed my Authentication account on CVS Repository setting, I still can generate ReviewRequest and make Review successfully. So I think may be the Authentication setting is useless for ReviewBoard. But without any CVS account, how did ReviewBoard get those basic source files from CVS server? Does that means any one without CVS authentication can get source file through ReviewBoard? Best Regards! On Jan 27, 3:53 am, Christian Hammond chip...@chipx86.com wrote: No, there's not. That would be a *lot* of work and isn't planned. It's a fundamental change to the way that Review Board works, and would make things confusing in the future. All the code for talking to repositories is in scmtools/. All the code for handling diffs is in diffviewer/. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Jan 26, 2010 at 1:36 AM, qhlonline qhlonl...@163.com wrote: Hi, Christian. Is there any way to generate Diff Review with only diff file without the basic source file? We don't want reviewers to see the whole content of the basic source file, We want them see only the diff part. I can't find the RB source code that get the basic file from CVS server, Is it defined in Djblets files? Best Regards! 在2010-01-26 15:35:07，Christian Hammond chip...@chipx86.com 写道： This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the *Expand changes* link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+ unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at
About the view diff page of reviewboard
Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the Expand changes link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the view diff page of reviewboard
This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the *Expand changes* link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re:Re: About the view diff page of reviewboard
Thanks Christian, I will have a look at the source. Regards! 在2010-01-26 15:35:07，Christian Hammond chip...@chipx86.com 写道： This is where the repository information you provide in the administration UI comes into play. Review Board downloads each file from the diff from the repository. It then makes a copy of the file, applies the patch, and generates its own diff (which contains information beyond what a standard diff can provide). The result of that is what gets sent to the user's browser. That code all lives in reviewboard/scmtools/* and reviewboard/diffviewer/*. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com 2010/1/25 qhlonline qhlonl...@163.com Hi, all. I am using Reviewboard 1.0.5.1 and my code repository is CVS. I had previously thought the post-review tool had only passed a unified cvs diff file to Reviewboard server, So on the view diff page, users can only see part of the file (where change take place). And I found now, I can click the Expand changes link to see the whole file. But I don't know how did the basic code file was provided to Reviewboard server. I don't think the file was posted by post-review tool, because I can create ReviewRequest through WebUI, And there I can only upload an cvs diff' file. So, can any body told me how did Reviewboard get the basic file of the review reqeust? and where can I read the source code about it? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
