Re: SHIP IT countre is zero even if reviewer clicks ship it.
Ok. It looks like I found the issue. I am doing query on incorrect table.. Let me try this out. On Jan 29, 2:22 pm, Christian Hammond chip...@chipx86.com wrote: Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code has not changed since we introduced it. I'm not convinced the query is correct, though. That ship_it column is not a counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's not taking into account the sum of the values from those reviews. What you probably want to be querying is the shipit_count column on the reviewrequest itself. This is the actual number of published reviews marked Ship It for that review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Jan 29, 2010 at 2:13 PM, Kunjal kunjal.par...@gmail.com wrote: Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; ; From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
so, what is the diff between ship_it and shipit_count? If there is at-least one ship it marked, the value of ship_it should not be one? I understand that ship_it is providing 0 or 1 only. It is not the actual count. Just want to understand why if the review is approved, ship_it is still zero? Kunjal On Feb 1, 11:05 am, Kunjal kunjal.par...@gmail.com wrote: Ok. It looks like I found the issue. I am doing query on incorrect table.. Let me try this out. On Jan 29, 2:22 pm, Christian Hammond chip...@chipx86.com wrote: Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code has not changed since we introduced it. I'm not convinced the query is correct, though. That ship_it column is not a counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's not taking into account the sum of the values from those reviews. What you probably want to be querying is the shipit_count column on the reviewrequest itself. This is the actual number of published reviews marked Ship It for that review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Jan 29, 2010 at 2:13 PM, Kunjal kunjal.par...@gmail.com wrote: Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; ; From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hidequoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at
Re: SHIP IT countre is zero even if reviewer clicks ship it.
ship_it is a flag on a review indicating whether or not that particular review says that the review request is, in the reviewer's opinion, ready to be shipped. shipit_count on the Review Request is a counter of the total number of reviews made on that review request where ship_it=1. If the review itself is published and marked as Ship It, its ship_it field should definitely be 1. I've never see a case where it wasn't. You wouldn't be seeing the green Ship It! indicator if it was 0. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Feb 1, 2010 at 11:09 AM, Kunjal kunjal.par...@gmail.com wrote: so, what is the diff between ship_it and shipit_count? If there is at-least one ship it marked, the value of ship_it should not be one? I understand that ship_it is providing 0 or 1 only. It is not the actual count. Just want to understand why if the review is approved, ship_it is still zero? Kunjal On Feb 1, 11:05 am, Kunjal kunjal.par...@gmail.com wrote: Ok. It looks like I found the issue. I am doing query on incorrect table.. Let me try this out. On Jan 29, 2:22 pm, Christian Hammond chip...@chipx86.com wrote: Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code has not changed since we introduced it. I'm not convinced the query is correct, though. That ship_it column is not a counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's not taking into account the sum of the values from those reviews. What you probably want to be querying is the shipit_count column on the reviewrequest itself. This is the actual number of published reviews marked Ship It for that review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Jan 29, 2010 at 2:13 PM, Kunjal kunjal.par...@gmail.com wrote: Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; ; From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
Re: SHIP IT countre is zero even if reviewer clicks ship it.
Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; ; From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code has not changed since we introduced it. I'm not convinced the query is correct, though. That ship_it column is not a counter. It's a boolean flag, meaning that you'll get back a 1 or a 0. It's not taking into account the sum of the values from those reviews. What you probably want to be querying is the shipit_count column on the reviewrequest itself. This is the actual number of published reviews marked Ship It for that review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 29, 2010 at 2:13 PM, Kunjal kunjal.par...@gmail.com wrote: Chris. Here is what happening. Reviewer mark the review Ship It. In the night, I generate the report saying how many reviews are apprved or how many are pending etc. I create the query and get the data of SHIP IT counter: my $query = SELECT r1.id, submitter_id, r2.username, r2.first_name, r2.last_name, changenum ,time_added, description, ship_it FROM reviewboard.reviews_reviewrequest r1 LEFT OUTER JOIN diffviewer_diffset n1 on r1.diffset_history_id=n1.history_id LEFT OUTER JOIN diffviewer_filediff n2 on n1.id=n2.diffset_id LEFT OUTER JOIN reviewboard.reviews_review r ON r1.id=r.review_request_id LEFT OUTER JOIN reviewboard.auth_user r2 ON submitter_id=r2.id where description like '$uniqueKey'; ; From this query result, I found the value of SHIP IT counter and report whether reveiew is approved or pending. So, for few users we are observing that even if they click on Ship It, the value of ship_it counter is zero. We are having more of such issue now a days. Someone report one more issue and issue escalated to director level !! Can your team provide any patch release? We are using mySQL database. Kunjal On Jan 28, 2:46 pm, Christian Hammond chip...@chipx86.com wrote: So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
SHIP IT countre is zero even if reviewer clicks ship it.
Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SHIP IT countre is zero even if reviewer clicks ship it.
So, they click Ship It, publish the review, and you see the review with the Ship It but you don't see that on the dashboard? This sounds like the code for bumping up the Ship It counter (ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not working correctly. What database are you using? The last login time should be fine. I believe that's just storing when they actually performed the login, and the cookie has kept him logged in ever since. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 28, 2010 at 9:38 AM, Kunjal kunjal.par...@gmail.com wrote: Hello, For one of our user, he does have active account and when he approves the review, the ship it counter is still zero. Why this is happening? When I debug this, I found that the user did logged in RB today but in the Submitters list, it is showing his last login as 2009-12-17. Is this causing issue? Where should I debug for this? Kunjal -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
