Re: GitHub private repos?

2010-01-02 Thread splaice
Hello, I too am using the latest nightly with a github private repo with great success using post-review. Though I think I found a bug/problem with using the new review request submission via the web interface with a diff. I have created an issue for this problem at

Re: GitHub private repos?

2010-01-02 Thread Christian Hammond
Hi, I believe the problem is short SHA1s vs. full-length SHA1s. GitHub requires a full-length SHA1 in the diff files, whereas Git by default generates a short SHA1. You have two options: 1) Run `git diff --full-index` 2) Run post-review --output-diff Try that and upload the diff. It should

Re: GitHub private repos?

2010-01-02 Thread splaice
Awesome, works great with the full lenght SHA1s. Thanks for the help. I will close out the bug with a note. -- Sean On Jan 2, 1:08 pm, Christian Hammond chip...@chipx86.com wrote: Hi, I believe the problem is short SHA1s vs. full-length SHA1s. GitHub requires a full-length SHA1 in the diff

Re: GitHub private repos?

2009-12-27 Thread mik...@larkfarm.com
Replying to myself to document what actually worked. I do NOT guarantee that this is the best way, but: sudo easy_install -v http://downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_20091222-py2.6.egg Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a nightly.

Re: GitHub private repos?

2009-12-23 Thread Mike Gunderloy
Just installed the latest nightly, no joy with private GitHub repos. I tried both with one that I own and one that I'm a user on that's owned by someone else. In both cases I got A repository was not found at the specified path. I'm not a python guy; anything I can do to help chase this? It's

Re: GitHub private repos?

2009-12-23 Thread Christian Hammond
Are you using GitHub or GitHub (Private)? Can you check the log file and see which URL it tried to access, and compare that with the Your Clone URL? Christian On Wednesday, December 23, 2009, Mike Gunderloy larkw...@gmail.com wrote: Just installed the latest nightly, no joy with private GitHub

Re: GitHub private repos?

2009-12-23 Thread Mike Gunderloy
Aha, I don't even see GitHub (Private). So I'd guess that somewhere I missed a step in getting a nightly running. - I had a 1.1 developer release installed - easy_install -f http://downloads.reviewboard.org/nightlies/ -U ReviewBoard - rb-site upgrade /path/to/site - restarted apache -

Re: GitHub private repos?

2009-12-21 Thread Christian Hammond
Hi Mike, I just committed support for private GitHub repositories. It didn't make tonight's nightly, but it will be in tomorrow night's. I'd love it if you could give it a try and let me know how it works for you. Thanks, Christian -- Christian Hammond - chip...@chipx86.com Review Board -

GitHub private repos?

2009-12-19 Thread Mike Gunderloy
Playing with the 1.1 development alpha, I'm glad to see support for GitHub repos. However, I can't figure out a working combination of settings for a private repo at GitHub. Any advice? Mike -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy

Re: GitHub private repos?

2009-12-19 Thread Christian Hammond
Hi Mike, There's no official support for this today, but it should make it into Beta 1 (which I'm hoping to release by the end of the year, time permitting). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On