Re: Missing "View Diff" and another tab on the review request action bar

I forgot to say that the code repo is a GitLab server, exactly GitLab Community Edition 8.2.3. Regards, On Wednesday, 16 March 2016 17:40:40 UTC+1, David Trowbridge wrote: > > It's probably failing to download the diff correctly. > > What type of repository? Can you check in the server logs

Re: Missing "View Diff" and another tab on the review request action bar

Hi David, First of all, thanks for your quick reply! This is what the log is telling me: 2016-03-17 08:17:57,516 - ERROR - - Unable to update new review request from commit ID 4f14daa9cd22fc9af6853c710bb9552795132e92: 'ascii' codec can't decode byte 0xe1 in position 4872: ordinal not in

Re: Missing "View Diff" and another tab on the review request action bar

Hi all of you! I have exactly the same error, with the same messages in the log. I select the commit in the repo, but no diff tab displayed. If I upload manually instead, appears perfectly. And I checked the diff and I already have this lines because I have the 2.5.2 version. Do you have any

Re: Missing "View Diff" and another tab on the review request action bar

Created: https://hellosplat.com/s/beanbag/tickets/4372/ Thanks! Unai On Thursday, 17 March 2016 19:52:39 UTC+1, David Trowbridge wrote: > > Looks like a unicode handling bug. Can you file an issue at > https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard ? > > Thanks! > -David > >

Re: Missing "View Diff" and another tab on the review request action bar

It's probably failing to download the diff correctly. What type of repository? Can you check in the server logs after clicking on the commit and see if there are any errors? -David On Wed, Mar 16, 2016 at 7:11 AM Xepard wrote: > Hi all of you! > > I have exactly

Re: Missing "View Diff" and another tab on the review request action bar

Looks like a unicode handling bug. Can you file an issue at https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard ? Thanks! -David On Thu, Mar 17, 2016 at 2:14 AM Xepard wrote: > I forgot to say that the code repo is a GitLab server, exactly GitLab >

Re: Missing "View Diff" and another tab on the review request action bar

Thank you so much, David! I applied the patch you created. Now I can see those two missing tabs. And also, I am able to view code diff. I will do more tests. Again, thanks a lot for your help! Really appreciate! -- Supercharge your Review Board with Power Pack:

Re: Missing "View Diff" and another tab on the review request action bar

Hi, Could you try with the attached patch? Thanks, -David On Wed, Nov 11, 2015 at 5:36 PM, Californian wrote: > I checked the log again. After upgrading from 2.0.18 to 2.5.1.1, I created > a new request from a commit. There are errors. See error_1.txt. > Then I >

Re: Missing "View Diff" and another tab on the review request action bar

I checked the log again. After upgrading from 2.0.18 to 2.5.1.1, I created a new request from a commit. There are errors. See error_1.txt. Then I modified /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 299, replaced "message =

Re: Missing "View Diff" and another tab on the review request action bar

I again looked at the upgrade log closely. See below. This message "There are unapplied evolutions for diffviewer." does not look good. Do you thnk I might have something not install/configure properly? If yes, how to fix it? Thanks! *** Creating tables ... Creating table

Re: Missing "View Diff" and another tab on the review request action bar

Before all that, you'll notice it says to ignore any messages unless it fails. That mesage is simply part of the upgrade process. Further below, you'll see that it says the evolution was successful, so you're fine there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Missing "View Diff" and another tab on the review request action bar

Thank you for the message! I thought my original install might have some issue that is causing two tabs are missing from the review request action bar. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out

Re: Missing "View Diff" and another tab on the review request action bar

This is a known bug which is fixed in the 2.5 releases. We may do another 2.0.x release at some point, in which case it will be included there as well. -David On Wed, Nov 11, 2015 at 12:05 PM, Californian wrote: > Thank you for the quick reply. Really appreciate! > > Yes,

Missing "View Diff" and another tab on the review request action bar

Hi, I am setting up the Review Board for our team. I have installed and configured the Review Board v2.0.18 on a system with CentOS 7. We are using GitLab v7.1.1. I am able to link the repo from GitLab with Review Board. Under my repo, I am also able to see committed changes in "New Review

Re: Missing "View Diff" and another tab on the review request action bar

Thank you for the quick reply. Really appreciate! Yes, I created a request from the list of committed changes. And I checked the log. I think I might know what's going on here. We were unable to see the list of committed changes in the beginning. It's because we are running GitLab 7.1.1 (a

Re: Missing "View Diff" and another tab on the review request action bar

It is a new review request I created after the upgrade. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ ---

Re: Missing "View Diff" and another tab on the review request action bar

Are you creating this review request from the list of committed changes? If so, something is going wrong during that step and it's not downloading the diff correctly. Can you check the logs for errors? -David On Wed, Nov 11, 2015 at 11:12 AM Californian wrote: > Hi, > > I

Re: Missing "View Diff" and another tab on the review request action bar

Was this a review request you created from before the upgrade or after? -David On Wed, Nov 11, 2015 at 1:19 PM, Californian wrote: > Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U > ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I

Re: Missing "View Diff" and another tab on the review request action bar

Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I am still missing two tabs on the review request action bar. Please see the attached screenshot. I checked the log. No .py files related errors after