post-review fails to login / uses wrong URL

2010-06-03 Thread Joachim Worringen
Greetings, I've set up reviewboard 1.0.8 successfully (apache/mod_python/ postgresql). All on Linux (FC12). Now, post-review fails to work as expected: [joac...@testsrv perf]$ post-review --version RBTools 0.2 [joac...@testsrv perf]$ post-review -d --server=testsrv/reviews >>> svn info >>> git

Re: Review Board 1.5 Beta 2 Released

2010-06-03 Thread Stephen Gallagher
On 06/02/2010 08:50 PM, Christian Hammond wrote: Hi, Sorry, I missed this e-mail entirely. It's most likely that the origin of the central server is different between what Review Board has recorded and what your Git clone is using. The remote origin on your clone must match exactly the Path o

Re: Review Board 1.5 Beta 2 Released

2010-06-03 Thread Christian Hammond
There are, but not for 1.5. We absolutely have to get this release out and I'm only allowing a couple crucial things in. I'd like to see this done for 1.6 or 1.7. Right now, you have the following options: 1) Tell people to standardize on one or the other 2) If there's only two options available

Re: post-review fails to login / uses wrong URL

2010-06-03 Thread Christian Hammond
The value passed to --server must be a full URL, not just a file path. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jun 3, 2010 at 1:34 AM, Joachim Worringen wrote: > Greetings, > > I've set up revi

(issue 1668) line endings in 1.0.7

2010-06-03 Thread Aaron Sherman
I haven't seen any chatter about this, and I do have a helpful reproducer, now. Before I go diving into this to see if I can find anything on my own, I was wondering if this was something that had already been identified or if it's likely to be trivial for someone who knows / last touched the code?

Re: Every patch failing on new RB install w/Mercurial

2010-06-03 Thread Gordon Morehouse
On Jun 2, 5:40 pm, Christian Hammond wrote: > Can you look at that reject file and the other files in that directory and > see if anything stands out as being wrong there? If it is the file endings, > then that's something I'll be looking into shortly, but it would be nice to > know for sure. Cer

Re: Every patch failing on new RB install w/Mercurial

2010-06-03 Thread Gordon Morehouse
This is also happening with the 'hg postreview' plugin, so I'm fairly sure that it's something fundamental to RB that's broken. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~-

some post-review requests succeed, some fail -- same repository & user

2010-06-03 Thread Robert Cabacungan
Hi, everyone, For the same review board instance, same repository, same user, I get post-review errors for some review requests, but not for others. (I have included debug output below.) It seems like everything goes well until the actual uploading of the diff. Then it fails with a "Network con

Re: some post-review requests succeed, some fail -- same repository & user

2010-06-03 Thread Christian Hammond
Sounds like something is failing when Review Board talks to the repository. This is a Subversion repository? What happens if you do a `svn cat` on that file with that revision from the Review Board server? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard

Re: (issue 1668) line endings in 1.0.7

2010-06-03 Thread Christian Hammond
Hi Aaron, I've been looking into it. Trying to make sure we can fix this without breaking other files. As always, additional help fixing bugs is always appreciated. My time is limited right now as it is. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard

Re: (issue 1668) line endings in 1.0.7

2010-06-03 Thread Aaron Sherman
On Thu, Jun 3, 2010 at 2:12 PM, Christian Hammond wrote: > > As always, additional help fixing bugs is always appreciated. My time is > limited right now as it is. Trust me, that's going around ;-) I'll spend some time on it if I can. Please, do let me know if you find anything (via the ticket

Re: some post-review requests succeed, some fail -- same repository & user

2010-06-03 Thread Robert Cabacungan
I get: svn: Network connection closed unexpectedly Thank you! I kept debugging the post-review side of it, but it looks like something's wrong from the server's perspective. Thanks a lot! Rob On Jun 3, 1:50 pm, Christian Hammond wrote: > Sounds like something is failing when Review Board tal