Review Metrics

We would like to see if we can gather some metrics from Reviewboard, including: * *Inspection Rate:* The number of KLOC inspected per hour. * *Defect Identification Rate:* The number of defects found in one hour of inspection time. * *Defect Density:* The amount of defects found

Re: Marking review as "Submitted" using API

Attached is a snippet of Perl I came up with to set the ReviewRequest as "Submitted" using SQL. I know this is probably not a desired way to do it, but it worked for us. If there is any use for this, I can tidy it up a bit and submit it to the project. Hovanes Augie Fackler wrote: > On Oct 20

Re: Review Metrics

Sure, I think keeping track of time like you described won't be enough. At least in our case, our review policy requires the reviewer to actually download the code and see if there are any warnings, does it run as expected, etc... All this will be outside of ReviewBoard. Perhaps another solu

Re: Marking review as "Submitted" using API

Great! Thanks. Christian Hammond wrote: > There's an API command up for review that will be in today which > allows you to easily mark a review request as submitted. See > http://reviews.review-board.org/r/604/ > > Christian > > -- > Christian Hammond - [EMAIL PROTECTED]

Re: Review Metrics

an Hammond - [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > VMware, Inc. > > > On Wed, Oct 22, 2008 at 3:53 PM, H M <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > Sure, > > I think keeping track of time like you described won't b

Huge patch files

We have a review request that was recently submitted that touches around 200 source files (2-3 lines per file). Just a change in the copyright notice. Reviewboard's "View Diff" page hangs. I'm assuming that it is having a problem opening up 200 files to generate the HTML for the diff viewer.

Suggestion: Comment Type

se the addition of a "Comment Type" drop down list when adding a new comment. What do you think about this addition to the main line of code? Would this be something useful to others? Is this on the roadmap maybe? If not, then we may volunteer to do this in 3 months or so. H. M. --

Re: Review Metrics

I began thinking more about this and would like to return to the topic. I think that a tool should help MOST people do their work right while being flexible at the same time. I think the ideas below are flexible enough that they don't stop others from using reviewboard as they were already, but

Re: Using Review Board

Chris wrote: > Also unless code has been given the OK i dont want it to get into > trunk, is this possible? i.e. can we stop people committing to trunk, > or is that more something we need to deal with at a people level not > an automation level I don't think this is done out of the box. At least

Statistics posting

We'd like to create an automated process in RB where immediately after a review submission: * We calculate the total changed lines, per file. ( We have internal guidelines that state a change set should not be larger than X lines, so this would be an easy way to check by how much t

Comment type/severity

Hi All, I would like to urge you to view this enhancement suggestion and participate in the discussion. http://code.google.com/p/reviewboard/issues/detail?id=1277 I feel having a comment type/severity would greatly enhance the usability of RB at mature software development copmanies while it wo

Download diff

Is there a way to download a diff through the formal JSON api? I realize the diff could be downloaded through a GET call to http:///r//diff/raw But given that all of the REST API URLs begin with /api/json/, I'm wondering if there is something I'm missing. H.M. --~--~-~--~---