Re: GitHub private repos?
Awesome, works great with the full lenght SHA1s. Thanks for the help. I will close out the bug with a note. -- Sean On Jan 2, 1:08 pm, Christian Hammond wrote: > Hi, > > I believe the problem is short SHA1s vs. full-length SHA1s. GitHub requires > a full-length SHA1 in the diff files, whereas Git by default generates a > short SHA1. > > You have two options: > > 1) Run `git diff --full-index` > > 2) Run post-review --output-diff > > Try that and upload the diff. It should work :) > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Sat, Jan 2, 2010 at 12:33 PM, splaice wrote: > > Hello, > > I too am using the latest nightly with a github private repo with > > great success using post-review. Though I think I found a bug/problem > > with using the new review request submission via the web interface > > with a diff. > > > I have created an issue for this problem at > >http://code.google.com/p/reviewboard/issues/detail?id=1448. > > > If there is anything I can do to help debug let me know. > > -- > > Sean > > > On Dec 27 2009, 7:33 am, "mik...@larkfarm.com" > > wrote: > > > Replying to myself to document what actually worked. I do NOT > > > guarantee that this is the best way, but: > > > > sudo easy_install -vhttp:// > > downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_... > > > > Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a > > > nightly. > > > > Mike > > > > On Dec 23, 12:48 pm, Mike Gunderloy wrote: > > > > > Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I > > missed a step in getting a nightly running. > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Hi, I believe the problem is short SHA1s vs. full-length SHA1s. GitHub requires a full-length SHA1 in the diff files, whereas Git by default generates a short SHA1. You have two options: 1) Run `git diff --full-index` 2) Run post-review --output-diff Try that and upload the diff. It should work :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jan 2, 2010 at 12:33 PM, splaice wrote: > Hello, > I too am using the latest nightly with a github private repo with > great success using post-review. Though I think I found a bug/problem > with using the new review request submission via the web interface > with a diff. > > I have created an issue for this problem at > http://code.google.com/p/reviewboard/issues/detail?id=1448. > > If there is anything I can do to help debug let me know. > -- > Sean > > On Dec 27 2009, 7:33 am, "mik...@larkfarm.com" > wrote: > > Replying to myself to document what actually worked. I do NOT > > guarantee that this is the best way, but: > > > > sudo easy_install -vhttp:// > downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_... > > > > Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a > > nightly. > > > > Mike > > > > On Dec 23, 12:48 pm, Mike Gunderloy wrote: > > > > > > > > > Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I > missed a step in getting a nightly running. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Hello, I too am using the latest nightly with a github private repo with great success using post-review. Though I think I found a bug/problem with using the new review request submission via the web interface with a diff. I have created an issue for this problem at http://code.google.com/p/reviewboard/issues/detail?id=1448. If there is anything I can do to help debug let me know. -- Sean On Dec 27 2009, 7:33 am, "mik...@larkfarm.com" wrote: > Replying to myself to document what actually worked. I do NOT > guarantee that this is the best way, but: > > sudo easy_install > -vhttp://downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_... > > Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a > nightly. > > Mike > > On Dec 23, 12:48 pm, Mike Gunderloy wrote: > > > > > Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I > > missed a step in getting a nightly running. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Replying to myself to document what actually worked. I do NOT guarantee that this is the best way, but: sudo easy_install -v http://downloads.reviewboard.org/nightlies/ReviewBoard-1.1alpha2.dev_20091222-py2.6.egg Until I did that, RB was stubbornly stuck on the 1.1 alpha, not on a nightly. Mike On Dec 23, 12:48 pm, Mike Gunderloy wrote: > Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I > missed a step in getting a nightly running. > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Aha, I don't even see "GitHub (Private)". So I'd guess that somewhere I missed a step in getting a nightly running. - I had a 1.1 developer release installed - easy_install -f http://downloads.reviewboard.org/nightlies/ -U ReviewBoard - rb-site upgrade /path/to/site - restarted apache - restarted memcached Any easy way to check what version I have running? Mike On Dec 23, 2009, at 12:34 PM, Christian Hammond wrote: > Are you using GitHub or "GitHub (Private)"? Can you check the log file > and see which URL it tried to access, and compare that with the "Your > Clone URL?" > > Christian > > > On Wednesday, December 23, 2009, Mike Gunderloy wrote: >> Just installed the latest nightly, no joy with private GitHub repos. I tried >> both with one that I own and one that I'm a user on that's owned by someone >> else. In both cases I got "A repository was not found at the specified path." >> >> I'm not a python guy; anything I can do to help chase this? It's not >> impossible that I messed up the install (coming from the developer build) >> though I think I managed to follow all the steps correctly. >> >> Mike >> >> On Dec 21, 2009, at 5:45 AM, Christian Hammond wrote: >> >>> Hi Mike, >>> >>> I just committed support for private GitHub repositories. It didn't make >>> tonight's nightly, but it will be in tomorrow night's. I'd love it if you >>> could give it a try and let me know how it works for you. >>> >>> Thanks, >>> >>> Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Are you using GitHub or "GitHub (Private)"? Can you check the log file and see which URL it tried to access, and compare that with the "Your Clone URL?" Christian On Wednesday, December 23, 2009, Mike Gunderloy wrote: > Just installed the latest nightly, no joy with private GitHub repos. I tried > both with one that I own and one that I'm a user on that's owned by someone > else. In both cases I got "A repository was not found at the specified path." > > I'm not a python guy; anything I can do to help chase this? It's not > impossible that I messed up the install (coming from the developer build) > though I think I managed to follow all the steps correctly. > > Mike > > On Dec 21, 2009, at 5:45 AM, Christian Hammond wrote: > >> Hi Mike, >> >> I just committed support for private GitHub repositories. It didn't make >> tonight's nightly, but it will be in tomorrow night's. I'd love it if you >> could give it a try and let me know how it works for you. >> >> Thanks, >> >> Christian > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Just installed the latest nightly, no joy with private GitHub repos. I tried both with one that I own and one that I'm a user on that's owned by someone else. In both cases I got "A repository was not found at the specified path." I'm not a python guy; anything I can do to help chase this? It's not impossible that I messed up the install (coming from the developer build) though I think I managed to follow all the steps correctly. Mike On Dec 21, 2009, at 5:45 AM, Christian Hammond wrote: > Hi Mike, > > I just committed support for private GitHub repositories. It didn't make > tonight's nightly, but it will be in tomorrow night's. I'd love it if you > could give it a try and let me know how it works for you. > > Thanks, > > Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Hi Mike, I just committed support for private GitHub repositories. It didn't make tonight's nightly, but it will be in tomorrow night's. I'd love it if you could give it a try and let me know how it works for you. Thanks, Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Dec 19, 2009 at 10:25 AM, Mike Gunderloy wrote: > Excellent, thanks! I'll keep an eye on the nightlies and test when I can. > > Mike > > On Dec 19, 2009, at 12:15 PM, Christian Hammond wrote: > > > There's no official support for this today, but it should make it into > Beta 1 (which I'm hoping to release by the end of the year, time > permitting). > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Excellent, thanks! I'll keep an eye on the nightlies and test when I can. Mike On Dec 19, 2009, at 12:15 PM, Christian Hammond wrote: > There's no official support for this today, but it should make it into Beta 1 > (which I'm hoping to release by the end of the year, time permitting). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: GitHub private repos?
Hi Mike, There's no official support for this today, but it should make it into Beta 1 (which I'm hoping to release by the end of the year, time permitting). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Dec 19, 2009 at 5:45 AM, Mike Gunderloy wrote: > > Playing with the 1.1 development alpha, I'm glad to see support for GitHub > repos. However, I can't figure out a working combination of settings for a > private repo at GitHub. Any advice? > > Mike > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
GitHub private repos?
Playing with the 1.1 development alpha, I'm glad to see support for GitHub repos. However, I can't figure out a working combination of settings for a private repo at GitHub. Any advice? Mike -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
