Re: Missing "View Diff" and another tab on the review request action bar
I forgot to say that the code repo is a GitLab server, exactly GitLab Community Edition 8.2.3. Regards, On Wednesday, 16 March 2016 17:40:40 UTC+1, David Trowbridge wrote: > > It's probably failing to download the diff correctly. > > What type of repository? Can you check in the server logs after clicking > on the commit and see if there are any errors? > > -David > > > On Wed, Mar 16, 2016 at 7:11 AM Xepard > > wrote: > >> Hi all of you! >> >> I have exactly the same error, with the same messages in the log. I >> select the commit in the repo, but no diff tab displayed. >> If I upload manually instead, appears perfectly. And I checked the diff >> and I already have this lines because I have the 2.5.2 version. >> >> Do you have any idea about the problem? >> >> Thanks a lot, >> >> Xepard >> >> On Saturday, 14 November 2015 00:40:36 UTC+1, David Trowbridge wrote: >> >>> Sounds great. We'll get a fix in for the next release. >>> >>> -David >>> >>> On Fri, Nov 13, 2015 at 3:16 PM Californian wrote: >>> >> Thank you so much, David! I applied the patch you created. Now I can see those two missing tabs. And also, I am able to view code diff. I will do more tests. Again, thanks a lot for your help! Really appreciate! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >>> -- >>> -David >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Hi David, First of all, thanks for your quick reply! This is what the log is telling me: 2016-03-17 08:17:57,516 - ERROR - - Unable to update new review request from commit ID 4f14daa9cd22fc9af6853c710bb9552795132e92: 'ascii' codec can't decode byte 0xe1 in position 4872: ordinal not in range(128) Traceback (most recent call last): File "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/managers.py", line 150, in create review_request.update_from_commit_id(commit_id) File "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", line 220, in update_from_commit_id self.update_from_committed_change(commit_id) File "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/reviews/models/base_review_request_details.py", line 264, in update_from_committed_change commit = self.repository.get_change(commit_id) File "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/scmtools/models.py", line 450, in get_change return hosting_service.get_change(self, revision) File "/opt/bitnami/apps/reviewboard/htdocs/reviewboard/hostingsvcs/gitlab.py", line 326, in get_change diff = diff.rsplit('--\nlibgit', 2)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe1 in position 4872: ordinal not in range(128) What can I do? I don't see the problem. And it is a curious behavior, because in the beginning was working. The installation of ReviewBoard has around 2 months and in the beginning was working fine, Thanks a lot, Best, Xepard > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Hi all of you! I have exactly the same error, with the same messages in the log. I select the commit in the repo, but no diff tab displayed. If I upload manually instead, appears perfectly. And I checked the diff and I already have this lines because I have the 2.5.2 version. Do you have any idea about the problem? Thanks a lot, Xepard On Saturday, 14 November 2015 00:40:36 UTC+1, David Trowbridge wrote: > > Sounds great. We'll get a fix in for the next release. > > -David > > On Fri, Nov 13, 2015 at 3:16 PM Californian > wrote: > >> Thank you so much, David! I applied the patch you created. Now I can see >> those two missing tabs. And also, I am able to view code diff. I will do >> more tests. >> Again, thanks a lot for your help! Really appreciate! >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Created: https://hellosplat.com/s/beanbag/tickets/4372/ Thanks! Unai On Thursday, 17 March 2016 19:52:39 UTC+1, David Trowbridge wrote: > > Looks like a unicode handling bug. Can you file an issue at > https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard ? > > Thanks! > -David > > > On Thu, Mar 17, 2016 at 2:14 AM Xepard > > wrote: > >> I forgot to say that the code repo is a GitLab server, exactly GitLab >> Community Edition 8.2.3. >> >> Regards, >> >> >> On Wednesday, 16 March 2016 17:40:40 UTC+1, David Trowbridge wrote: >> >>> It's probably failing to download the diff correctly. >>> >>> What type of repository? Can you check in the server logs after clicking >>> on the commit and see if there are any errors? >>> >>> -David >>> >>> >>> On Wed, Mar 16, 2016 at 7:11 AM Xepard wrote: >>> Hi all of you! I have exactly the same error, with the same messages in the log. I select the commit in the repo, but no diff tab displayed. If I upload manually instead, appears perfectly. And I checked the diff and I already have this lines because I have the 2.5.2 version. Do you have any idea about the problem? Thanks a lot, Xepard On Saturday, 14 November 2015 00:40:36 UTC+1, David Trowbridge wrote: > Sounds great. We'll get a fix in for the next release. > > -David > > On Fri, Nov 13, 2015 at 3:16 PM Californian > wrote: > Thank you so much, David! I applied the patch you created. Now I can >> see those two missing tabs. And also, I am able to view code diff. I >> will >> do more tests. >> Again, thanks a lot for your help! Really appreciate! >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to reviewboard...@googlegroups.com. > > >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >>> -David >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
It's probably failing to download the diff correctly. What type of repository? Can you check in the server logs after clicking on the commit and see if there are any errors? -David On Wed, Mar 16, 2016 at 7:11 AM Xepard wrote: > Hi all of you! > > I have exactly the same error, with the same messages in the log. I select > the commit in the repo, but no diff tab displayed. > If I upload manually instead, appears perfectly. And I checked the diff > and I already have this lines because I have the 2.5.2 version. > > Do you have any idea about the problem? > > Thanks a lot, > > Xepard > > On Saturday, 14 November 2015 00:40:36 UTC+1, David Trowbridge wrote: > >> Sounds great. We'll get a fix in for the next release. >> >> -David >> >> On Fri, Nov 13, 2015 at 3:16 PM Californian wrote: >> > Thank you so much, David! I applied the patch you created. Now I can see >>> those two missing tabs. And also, I am able to view code diff. I will do >>> more tests. >>> Again, thanks a lot for your help! Really appreciate! >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >> To unsubscribe from this group and stop receiving emails from it, send an >>> email to reviewboard...@googlegroups.com. >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -David > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Looks like a unicode handling bug. Can you file an issue at https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard ? Thanks! -David On Thu, Mar 17, 2016 at 2:14 AM Xepard wrote: > I forgot to say that the code repo is a GitLab server, exactly GitLab > Community Edition 8.2.3. > > Regards, > > > On Wednesday, 16 March 2016 17:40:40 UTC+1, David Trowbridge wrote: > >> It's probably failing to download the diff correctly. >> >> What type of repository? Can you check in the server logs after clicking >> on the commit and see if there are any errors? >> >> -David >> >> >> On Wed, Mar 16, 2016 at 7:11 AM Xepard wrote: >> >>> Hi all of you! >>> >>> I have exactly the same error, with the same messages in the log. I >>> select the commit in the repo, but no diff tab displayed. >>> If I upload manually instead, appears perfectly. And I checked the diff >>> and I already have this lines because I have the 2.5.2 version. >>> >>> Do you have any idea about the problem? >>> >>> Thanks a lot, >>> >>> Xepard >>> >>> On Saturday, 14 November 2015 00:40:36 UTC+1, David Trowbridge wrote: >>> Sounds great. We'll get a fix in for the next release. -David On Fri, Nov 13, 2015 at 3:16 PM Californian wrote: >>> Thank you so much, David! I applied the patch you created. Now I can see > those two missing tabs. And also, I am able to view code diff. I will do > more tests. > Again, thanks a lot for your help! Really appreciate! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -David >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -David >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Sounds great. We'll get a fix in for the next release. -David On Fri, Nov 13, 2015 at 3:16 PM Californian wrote: > Thank you so much, David! I applied the patch you created. Now I can see > those two missing tabs. And also, I am able to view code diff. I will do > more tests. > Again, thanks a lot for your help! Really appreciate! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Thank you so much, David! I applied the patch you created. Now I can see those two missing tabs. And also, I am able to view code diff. I will do more tests. Again, thanks a lot for your help! Really appreciate! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Hi, Could you try with the attached patch? Thanks, -David On Wed, Nov 11, 2015 at 5:36 PM, Californian wrote: > I checked the log again. After upgrading from 2.0.18 to 2.5.1.1, I created > a new request from a commit. There are errors. See error_1.txt. > Then I > modified > /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", > line 299, replaced "message = commit['message']" with "message = > commit['title']". > > And then, I created another new request from another new commit. > Unfortunately, I am getting more errors. See error_2.txt. > > From what I got, I think the original gitlab.py file is incompatible with > the version of Gitlab we are using (7.1.1). > > Upgrading RB to 2.5.1.1 does not resolve the issue we have (missing view > diff tab on the review request action bar ). > > Any help will be appreciated. > > Thanks! > > > > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. diff --git a/reviewboard/hostingsvcs/gitlab.py b/reviewboard/hostingsvcs/gitlab.py index 3de8163..0ff93ad 100644 --- a/reviewboard/hostingsvcs/gitlab.py +++ b/reviewboard/hostingsvcs/gitlab.py @@ -296,7 +296,7 @@ class GitLab(HostingService): author_name = commit['author_name'] date = commit['created_at'] parent_revision = commit['parent_ids'][0] -message = commit['message'] +message = commit.get('message', '') # Step 2: Get the diff. The revision is the commit header in here. # Firstly, a diff url should be built up, which has the format of @@ -310,8 +310,9 @@ class GitLab(HostingService): path_with_namespace = project['path_with_namespace'] # Build up diff url and get diff. -diff_url = ('https://gitlab.com/%s/commit/%s.diff?private_token=%s' -% (path_with_namespace, revision, private_token)) +diff_url = ('%s/%s/commit/%s.diff?private_token=%s' +% (self.account.hosting_url, path_with_namespace, + revision, private_token)) diff, headers = self.client.http_get( diff_url, headers={'Accept': 'text/plain'})
Re: Missing "View Diff" and another tab on the review request action bar
I checked the log again. After upgrading from 2.0.18 to 2.5.1.1, I created a new request from a commit. There are errors. See error_1.txt. Then I modified /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 299, replaced "message = commit['message']" with "message = commit['title']". And then, I created another new request from another new commit. Unfortunately, I am getting more errors. See error_2.txt. >From what I got, I think the original gitlab.py file is incompatible with the version of Gitlab we are using (7.1.1). Upgrading RB to 2.5.1.1 does not resolve the issue we have (missing view diff tab on the review request action bar ). Any help will be appreciated. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. - Unable to update new review request from commit ID ede5d7e7298fcadc090469874911b6366e7b10df: HTTP Error 401: Unauthorized Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/managers.py", line 150, in create review_request.update_from_commit_id(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 220, in update_from_commit_id self.update_from_committed_change(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 264, in update_from_committed_change commit = self.repository.get_change(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/scmtools/models.py", line 450, in get_change return hosting_service.get_change(self, revision) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 317, in get_change headers={'Accept': 'text/plain'}) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/service.py", line 55, in http_get return self.http_request(url, method='GET', **kwargs) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/service.py", line 79, in http_request u = urlopen(r) File "/usr/lib64/python2.7/urllib2.py", line 127, in urlopen return _opener.open(url, data, timeout) File "/usr/lib64/python2.7/urllib2.py", line 410, in open response = meth(req, response) File "/usr/lib64/python2.7/urllib2.py", line 523, in http_response 'http', request, response, code, msg, hdrs) File "/usr/lib64/python2.7/urllib2.py", line 448, in error return self._call_chain(*args) File "/usr/lib64/python2.7/urllib2.py", line 382, in _call_chain result = func(*args) File "/usr/lib64/python2.7/urllib2.py", line 531, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 401: Unauthorized- Unable to update new review request from commit ID 57a759c8fd55b1ef44ca226e444c041321930431: u'message' Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/managers.py", line 150, in create review_request.update_from_commit_id(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 220, in update_from_commit_id self.update_from_committed_change(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py", line 264, in update_from_committed_change commit = self.repository.get_change(commit_id) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/scmtools/models.py", line 450, in get_change return hosting_service.get_change(self, revision) File "/usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 299, in get_change message = commit['message'] KeyError: u'message'
Re: Missing "View Diff" and another tab on the review request action bar
Thank you for the message! I thought my original install might have some issue that is causing two tabs are missing from the review request action bar. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Before all that, you'll notice it says to ignore any messages unless it fails. That mesage is simply part of the upgrade process. Further below, you'll see that it says the evolution was successful, so you're fine there. Christian -- Christian Hammond - chip...@chipx86.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Wed, Nov 11, 2015 at 3:30 PM, Californian wrote: > I again looked at the upgrade log closely. See below. > This message "There are unapplied evolutions for diffviewer." does not > look good. > Do you thnk I might have something not install/configure properly? If yes, > how to fix it? > > Thanks! > > *** > > Creating tables ... > > Creating table accounts_trophy > > Creating table attachments_fileattachmenthistory > > Creating table diffviewer_rawfilediffdata > > Creating table notifications_webhooktarget_repositories > > Creating table notifications_webhooktarget > > Creating table webapi_webapitoken > > Upgrading Review Board from 2.0.18 to 2.5.1.1 > > There are unapplied evolutions for accounts. > > There are unapplied evolutions for attachments. > > There are unapplied evolutions for diffviewer. > > There are unapplied evolutions for notifications. > > There are unapplied evolutions for reviews. > > There are unapplied evolutions for webapi. > > Adding baseline version for new models > > Evolutions in notifications baseline: webhooktarget_extra_state, > webhooktarget_extra_data_null > > Project signature has changed - an evolution is required > > Installing custom SQL ... > > Installing indexes ... > > Installed 0 object(s) from 0 fixture(s) > > Evolution successful. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
I again looked at the upgrade log closely. See below. This message "There are unapplied evolutions for diffviewer." does not look good. Do you thnk I might have something not install/configure properly? If yes, how to fix it? Thanks! *** Creating tables ... Creating table accounts_trophy Creating table attachments_fileattachmenthistory Creating table diffviewer_rawfilediffdata Creating table notifications_webhooktarget_repositories Creating table notifications_webhooktarget Creating table webapi_webapitoken Upgrading Review Board from 2.0.18 to 2.5.1.1 There are unapplied evolutions for accounts. There are unapplied evolutions for attachments. There are unapplied evolutions for diffviewer. There are unapplied evolutions for notifications. There are unapplied evolutions for reviews. There are unapplied evolutions for webapi. Adding baseline version for new models Evolutions in notifications baseline: webhooktarget_extra_state, webhooktarget_extra_data_null Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) Evolution successful. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
It is a new review request I created after the upgrade. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Was this a review request you created from before the upgrade or after? -David On Wed, Nov 11, 2015 at 1:19 PM, Californian wrote: > Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U > ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I am > still missing two tabs on the review request action bar. Please see the > attached screenshot. > > I checked the log. No .py files related errors after upgrading to 2.5.1.1. > Only see two warnings: > > 1. > > - /usr/lib/python2.7/site-packages/feedparser.py:364: DeprecationWarning: To > avoid breaking existing software while fixing issue 310, a temporary mapping > has been created from `updated_parsed` to `published_parsed` if > `updated_parsed` doesn't exist. This fallback will be removed in a future > version of feedparser. > DeprecationWarning) > > > 2. > > - > /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/markdown_utils.py:40: > DeprecationWarning: reviewboard.reviews.markdown_utils.markdown_escape is > deprecated. Please use djblets.markdown.markdown_escape. > DeprecationWarning) > > > I also see some debug message like this. Not sure it is an issue. > > - Cache miss for key jsi18n-djangojs-reviewboard_djblets-en-1447273457. > > > Any ideas why we are still missing "Download Diff" and "Diff" tabs after > upgrading to 2.5.1.1. > > > Thanks! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Just upgraded RB and Site to 2.5.1.1 by running "easy_install -U ReviewBoard" and "rb-site upgrade /path/to/site" w/o any errors. But I am still missing two tabs on the review request action bar. Please see the attached screenshot. I checked the log. No .py files related errors after upgrading to 2.5.1.1. Only see two warnings: 1. - /usr/lib/python2.7/site-packages/feedparser.py:364: DeprecationWarning: To avoid breaking existing software while fixing issue 310, a temporary mapping has been created from `updated_parsed` to `published_parsed` if `updated_parsed` doesn't exist. This fallback will be removed in a future version of feedparser. DeprecationWarning) 2. - /usr/lib/python2.7/site-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/reviews/markdown_utils.py:40: DeprecationWarning: reviewboard.reviews.markdown_utils.markdown_escape is deprecated. Please use djblets.markdown.markdown_escape. DeprecationWarning) I also see some debug message like this. Not sure it is an issue. - Cache miss for key jsi18n-djangojs-reviewboard_djblets-en-1447273457. Any ideas why we are still missing "Download Diff" and "Diff" tabs after upgrading to 2.5.1.1. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
This is a known bug which is fixed in the 2.5 releases. We may do another 2.0.x release at some point, in which case it will be included there as well. -David On Wed, Nov 11, 2015 at 12:05 PM, Californian wrote: > Thank you for the quick reply. Really appreciate! > > Yes, I created a request from the list of committed changes. And I checked > the log. I think I might know what's going on here. > > We were unable to see the list of committed changes in the beginning. It's > because we are running GitLab 7.1.1 (a little behind of the latest > version). We had to modify gitlab.py file under /usr/lib/python2.7/site- > packages/reviewboard/hostingsvcs. In the original gitlab.py, in line 249, > it had message=item['message'] which does not match our current > gitlab (7.1.1) has. So, we replaced message=item['message'] with > message=item['title']. > > After this modification, we are able to see the list of committed changes. > > I think we might need to change other Review Board related .py script as > well to match the change we made. Any suggestions? I understand changing > the original .py files in Review Board is not a good idea. But before we > upgrade to the new version of GitLab, this might be the only solution we > have. Any suggestion is appreciated. > > By the way, here are the errors I see in the log: > > - Unable to update new review request from commit ID > c4a817a2e2d48f6dea74903a1eb42efe8e6cd84b: u'message' > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/reviewboard/reviews/managers.py", > line 150, in create > review_request.update_from_commit_id(commit_id) > File > "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", > line 194, in update_from_commit_id > self.update_from_committed_change(commit_id) > File > "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", > line 238, in update_from_committed_change > commit = self.repository.get_change(commit_id) > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", > line 434, in get_change > return hosting_service.get_change(self, revision) > File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", > line 298, in get_change > message = commit['message'] > > KeyError: u'message' > > Thank you again for the help! > > > > On Wednesday, November 11, 2015 at 11:14:53 AM UTC-8, David Trowbridge > wrote: >> >> Are you creating this review request from the list of committed changes? >> If so, something is going wrong during that step and it's not downloading >> the diff correctly. Can you check the logs for errors? >> >> -David >> On Wed, Nov 11, 2015 at 11:12 AM Californian wrote: >> >>> Hi, >>> >>> I am setting up the Review Board for our team. I have installed and >>> configured the Review Board v2.0.18 on a system with CentOS 7. We are using >>> GitLab v7.1.1. >>> >>> I am able to link the repo from GitLab with Review Board. Under my repo, >>> I am also able to see committed changes in "New Review Request for Pending >>> Change": "master" branch (from the drop down menu). After creating a Review >>> Request, I can't find a way to view the diff. >>> >>> After reading the Review Board Manual/Doc closely, I realized in the >>> Review Request, two tabs are missing on the review request action bar. >>> According to the Doc, it has six tabs on the review request action bar. But >>> I only see four tabs: Close, Update, Review, and Ship It! Please see the >>> attached screenshot. >>> >>> Apparently, we are missing the most important tab "View Diff". It seems >>> something is wrong with the Diff Viewer in our Review Board system. >>> >>> Any ideas what we are missing in our installation or configuration? Any >>> info is appreciated. >>> >>> Thanks! >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -David > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Bo
Re: Missing "View Diff" and another tab on the review request action bar
Thank you for the quick reply. Really appreciate! Yes, I created a request from the list of committed changes. And I checked the log. I think I might know what's going on here. We were unable to see the list of committed changes in the beginning. It's because we are running GitLab 7.1.1 (a little behind of the latest version). We had to modify gitlab.py file under /usr/lib/python2.7/site- packages/reviewboard/hostingsvcs. In the original gitlab.py, in line 249, it had message=item['message'] which does not match our current gitlab (7.1.1) has. So, we replaced message=item['message'] with message=item['title']. After this modification, we are able to see the list of committed changes. I think we might need to change other Review Board related .py script as well to match the change we made. Any suggestions? I understand changing the original .py files in Review Board is not a good idea. But before we upgrade to the new version of GitLab, this might be the only solution we have. Any suggestion is appreciated. By the way, here are the errors I see in the log: - Unable to update new review request from commit ID c4a817a2e2d48f6dea74903a1eb42efe8e6cd84b: u'message' Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/reviewboard/reviews/managers.py", line 150, in create review_request.update_from_commit_id(commit_id) File "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", line 194, in update_from_commit_id self.update_from_committed_change(commit_id) File "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", line 238, in update_from_committed_change commit = self.repository.get_change(commit_id) File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", line 434, in get_change return hosting_service.get_change(self, revision) File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", line 298, in get_change message = commit['message'] KeyError: u'message' Thank you again for the help! On Wednesday, November 11, 2015 at 11:14:53 AM UTC-8, David Trowbridge wrote: > > Are you creating this review request from the list of committed changes? > If so, something is going wrong during that step and it's not downloading > the diff correctly. Can you check the logs for errors? > > -David > On Wed, Nov 11, 2015 at 11:12 AM Californian > wrote: > >> Hi, >> >> I am setting up the Review Board for our team. I have installed and >> configured the Review Board v2.0.18 on a system with CentOS 7. We are using >> GitLab v7.1.1. >> >> I am able to link the repo from GitLab with Review Board. Under my repo, >> I am also able to see committed changes in "New Review Request for Pending >> Change": "master" branch (from the drop down menu). After creating a Review >> Request, I can't find a way to view the diff. >> >> After reading the Review Board Manual/Doc closely, I realized in the >> Review Request, two tabs are missing on the review request action bar. >> According to the Doc, it has six tabs on the review request action bar. But >> I only see four tabs: Close, Update, Review, and Ship It! Please see the >> attached screenshot. >> >> Apparently, we are missing the most important tab "View Diff". It seems >> something is wrong with the Diff Viewer in our Review Board system. >> >> Any ideas what we are missing in our installation or configuration? Any >> info is appreciated. >> >> Thanks! >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Missing "View Diff" and another tab on the review request action bar
Are you creating this review request from the list of committed changes? If so, something is going wrong during that step and it's not downloading the diff correctly. Can you check the logs for errors? -David On Wed, Nov 11, 2015 at 11:12 AM Californian wrote: > Hi, > > I am setting up the Review Board for our team. I have installed and > configured the Review Board v2.0.18 on a system with CentOS 7. We are using > GitLab v7.1.1. > > I am able to link the repo from GitLab with Review Board. Under my repo, I > am also able to see committed changes in "New Review Request for Pending > Change": "master" branch (from the drop down menu). After creating a Review > Request, I can't find a way to view the diff. > > After reading the Review Board Manual/Doc closely, I realized in the > Review Request, two tabs are missing on the review request action bar. > According to the Doc, it has six tabs on the review request action bar. But > I only see four tabs: Close, Update, Review, and Ship It! Please see the > attached screenshot. > > Apparently, we are missing the most important tab "View Diff". It seems > something is wrong with the Diff Viewer in our Review Board system. > > Any ideas what we are missing in our installation or configuration? Any > info is appreciated. > > Thanks! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Missing "View Diff" and another tab on the review request action bar
Hi, I am setting up the Review Board for our team. I have installed and configured the Review Board v2.0.18 on a system with CentOS 7. We are using GitLab v7.1.1. I am able to link the repo from GitLab with Review Board. Under my repo, I am also able to see committed changes in "New Review Request for Pending Change": "master" branch (from the drop down menu). After creating a Review Request, I can't find a way to view the diff. After reading the Review Board Manual/Doc closely, I realized in the Review Request, two tabs are missing on the review request action bar. According to the Doc, it has six tabs on the review request action bar. But I only see four tabs: Close, Update, Review, and Ship It! Please see the attached screenshot. Apparently, we are missing the most important tab "View Diff". It seems something is wrong with the Diff Viewer in our Review Board system. Any ideas what we are missing in our installation or configuration? Any info is appreciated. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.