Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-21 Thread David Trowbridge
Can you file a bug? https://hellosplat.com/s/beanbag/tickets/new/ -David On Tue, Jun 21, 2016 at 10:01 AM Joe Cooper wrote: > I'm not sure how soon I'll be able to do that, but this problem is > reproducible with other commits. > > To Reproduce: > 1. Commit a change to git where the following

Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-21 Thread Joe Cooper
I'm not sure how soon I'll be able to do that, but this problem is reproducible with other commits. To Reproduce: 1. Commit a change to git where the following is true: a) a file is renamed & b) the same file is modified. Any file will do. 2. Create a review request for that commit Environment

Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-21 Thread David Trowbridge
Well, we should figure out what part of the diff file isn't being parsed correctly. If you're willing to jump into the code to make it save the diff so we can have a sample, we can get the bug fixed. -David On Tue, Jun 21, 2016 at 9:04 AM Joe Cooper wrote: > I've narrowed this problem down to i

Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-21 Thread Joe Cooper
I've narrowed this problem down to if the same file is modified and renamed in the same commit, no diffs are generated for any file when creating a review request and the 'could not be found in the repository' error is logged. Is there a work-around for this besides not committing a modificatio

Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-20 Thread Joe Cooper
David, Thank you for your prompt feedback. I've added the error details from the log below. I the commit I had a problem with a file was renamed to: ''/some/path/SomeFile.cs'. I'm not sure why there would be a problem because the file is indeed in the repository at that time. Unless the python

Re: No diffs to review when creating review request from commit (commit has plenty of diffs)

2016-06-20 Thread David Trowbridge
Are there any errors in the Review Board log file? -David On Mon, Jun 20, 2016 at 9:09 AM Joe Cooper wrote: > Hi, > > My team is using Review Board version 2.5.3. > > We are using a github hosted repo. We create review requests by selecting > a repo -> branch -> and then selecting the commit to