Regarding this issue on the 1.1 alpha nightlies, I believe it is
caused by the patch I submitted in this review:
http://reviews.reviewboard.org/r/1295/
It seems as though my fix for the New Review Request web UI broke the
diff upload mechanism. This affects both the web UI for uploading new
diff
On Tue, Dec 15, 2009 at 15:28, Thilo-Alexander Ginkel wrote:
> The question is, how can I calculate the length of this string in
> bytes, not characters, taking the wire encoding into account?
A patch is available at: http://reviews.reviewboard.org/r/1298/
Regards,
Thilo
--
Want to help the Re
On Mon, Dec 14, 2009 at 23:11, Christian Hammond wrote:
> It should just be the field constraints from those FileFields. We don't do
> any custom validation checks in those forms that I can see.
>
> It could potentially fail if the diff itself is empty, even though the name
> is populated. Are the
It should just be the field constraints from those FileFields. We don't do
any custom validation checks in those forms that I can see.
It could potentially fail if the diff itself is empty, even though the name
is populated. Are they uploading using post-review? Might be worth seeing
what post-rev
On Monday 14 December 2009 22:28:35 Christian Hammond wrote:
> Which version of Review Board is this running right now? I've seen this
> recently on the 1.1 alpha nightlies.
It's a slightly patched 1.0.5.1.
> Also, what repository type is this? It could indicate a missing dependency.
> The error
Which version of Review Board is this running right now? I've seen this
recently on the 1.1 alpha nightlies.
Also, what repository type is this? It could indicate a missing dependency.
The error checking/reporting for that on 1.0.x is pretty bad, but improved
in 1.1.
Is this only happening to som