Re: weird error in review-board and post-review in windows
On Oct 9, 5:56 am, Marcos <[EMAIL PROTECTED]> wrote: > You can use post-review on a windows client without cygwin. > You will need python and difftools on the client thought. > > By the way, how did you got sqlite to work on cygwin? I don't use sqlite under cygwin. The server is using ActiveState python with the sqllite that comes with the 2.5 version of python.I've instaled patch from gnuwin32, pysvn and the code highlighter. regards --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: weird error in review-board and post-review in windows
You can use post-review on a windows client without cygwin. You will need python and difftools on the client thought. By the way, how did you got sqlite to work on cygwin? On Oct 9, 12:45 am, Paulo Eduardo Neves <[EMAIL PROTECTED]> wrote: > On Oct 6, 9:17 pm, Chris <[EMAIL PROTECTED]> wrote: > > > On Oct 6, 4:58 pm, Paulo Eduardo Neves <[EMAIL PROTECTED]> wrote: > > > > I'm advocating the adoption of review-board in my company. The client > > > and the server must run in Windows. Subversion is our version control > > > system. I'm not using cygwin nor mingw. > > > > > > patch: malformed patch at line 51: \ No newline at end of file > > > I've been experimenting with Cygwin, so I can confirm using that is a > > good idea :-) All I did was add the Cygwin bin path to the regular > > Windows path. > > Thanks for the answer Chris and Christian, > > my problem with cygwin is that I'll have to deploy the client in > dozens of developer Windows machines. I don't want to force everybody > to install cygwin just to have diff. > > I've tried unxutils links but it still didn't work. I've tried cygwin > and the problem persists! Then I tried to delete the file where the > problem is happening... and it works! > > I don't know if it will be a common error or just really bad luck. > > regards, > Paulo Eduardo Neves --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: weird error in review-board and post-review in windows
On 10/8/2008 3:45 PM, Paulo Eduardo Neves wrote: > .. > my problem with cygwin is that I'll have to deploy the client in > dozens of developer Windows machines. I don't want to force everybody > to install cygwin just to have diff. > Don't forget that the patch requirement is only on the SERVER, it might be worth trying cygwin on the server only and using the standalone diffutils for the clients. I have to confess I've not tried using post-review with svn clients on Windows (so I'm not clear what the requirements are). BUT I am using cygwin patch on a Windows server (the scm tool I use on the client's has it's own diff built in). One thing I did come across a while back is that Tortoise SVN does support command line arguments, you may be able to simply generate the patch(es) using that without any other tools on the clients. > I've tried unxutils links but it still didn't work. I've tried cygwin > and the problem persists! Then I tried to delete the file where the > problem is happening... and it works! > > I don't know if it will be a common error or just really bad luck. > Doh! I'd be interested to hear if it occurs again. Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: weird error in review-board and post-review in windows
On Oct 6, 9:17 pm, Chris <[EMAIL PROTECTED]> wrote: > On Oct 6, 4:58 pm, Paulo Eduardo Neves <[EMAIL PROTECTED]> wrote: > > > I'm advocating the adoption of review-board in my company. The client > > and the server must run in Windows. Subversion is our version control > > system. I'm not using cygwin nor mingw. > > > > patch: malformed patch at line 51: \ No newline at end of file > > I've been experimenting with Cygwin, so I can confirm using that is a > good idea :-) All I did was add the Cygwin bin path to the regular > Windows path. Thanks for the answer Chris and Christian, my problem with cygwin is that I'll have to deploy the client in dozens of developer Windows machines. I don't want to force everybody to install cygwin just to have diff. I've tried unxutils links but it still didn't work. I've tried cygwin and the problem persists! Then I tried to delete the file where the problem is happening... and it works! I don't know if it will be a common error or just really bad luck. regards, Paulo Eduardo Neves --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: weird error in review-board and post-review in windows
Hi Paulo. Basically, when patches are generated and either the original or resulting file doesn't end in a newline, diff will append a "\ No newline at end of file" to the diff. Patch is supposed to understand this and treat it correctly. Now, we did have some bugs with this and they should have been fixed long ago, so perhaps it is the fact that you're running that version of patch. If you could try the Cygwin version (which is what most people use), then we'll know for sure. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 6, 2008 at 4:58 PM, Paulo Eduardo Neves <[EMAIL PROTECTED]>wrote: > > I'm advocating the adoption of review-board in my company. The client > and the server must run in Windows. Subversion is our version control > system. I'm not using cygwin nor mingw. > > My greatest obstacle is to make it easy to upload a "changeset" for > review. > > To make review-board run I installed patch,exe in the server. In the > client, I had to install diffutils for post-review. Downloaded both > from here: > http://gnuwin32.sourceforge.net/packages.html > > post-review worked after I've set the http_proxy environment variable > to nothing. It tried to access the review-board server in my local > network through my company proxy and it required authentication. > > I've successfully upload some patches for reviewing using TortoiseSVN > "create patch" menu option. Unfortunately the subversion client > doesn't include in the patch files that were added to my local copy. > > Then I tried to use post-review this way: > > C:\xxx>python E:\reviewboard\contrib\tools\post-review --revision- > range=15843:15844 --server=http://subversion-test:8000 -d > > The answer was: > > Review request #13 posted. > > http://subversion-test:8000/r/13 > > But when I try to click on 'view diff' (http://subversion- > test.sol.local:8000/r/13/diff/#index_header ), the following error > appears: > > Traceback (most recent call last): > File "D:\reviewboard\diffviewer\views.py", line 86, in view_diff >files = get_diff_files(diffset, None, interdiffset, highlighting) > File "D:\reviewboard\diffviewer\diffutils.py", line 651, in > get_diff_files >enable_syntax_highlighting) > File "D:\reviewboard\diffviewer\diffutils.py", line 567, in > generate_files >lambda: get_chunks(filediff.diffset, > File "D:\reviewboard\djblets\util\misc.py", line 55, in > cache_memoize >data = lookup_callable() > File "D:\reviewboard\diffviewer\diffutils.py", line 570, in >enable_syntax_highlighting)) > File "D:\reviewboard\diffviewer\diffutils.py", line 338, in > get_chunks >new = get_patched_file(old, filediff) > File "D:\reviewboard\diffviewer\diffutils.py", line 254, in > get_patched_file >return patch(filediff.diff, buffer, filediff.dest_file) > File "D:\reviewboard\diffviewer\diffutils.py", line 125, in patch >(filename, tempdir, patch_output)) > Exception: The patch to '/sac/trunk/xxx/xxx/x.html' didn't apply > cleanly. The temporary files have been left in 'c: > \docume~1\admini~1\locals~1\temp\reviewboard.5bnxay' for debugging > purposes. > `patch` returned: patching file c:\docume~1\admini~1\locals~1\temp > \reviewboard.5bnxay\tmpxptjxx > patch: malformed patch at line 51: \ No newline at end of file > > > The advice for similar error messages in the web tell me to upgrade > patch, but I'm already using version 2.5.9. > > There's no error messages in the manage.py server output. > > If I go to the temp dir above and try to manually apply the patch, the > same error message bites me: > > C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\reviewboard.2vsmde>patch tmpvvbvlu > ProcMensagem.html.diff > patching file tmpvvbvlu > patch: malformed patch at line 51: \ No newline at end of file > > Any idea how to fix it? > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: weird error in review-board and post-review in windows
On Oct 6, 4:58 pm, Paulo Eduardo Neves <[EMAIL PROTECTED]> wrote: > I'm advocating the adoption of review-board in my company. The client > and the server must run in Windows. Subversion is our version control > system. I'm not using cygwin nor mingw. > > patch: malformed patch at line 51: \ No newline at end of file I've been experimenting with Cygwin, so I can confirm using that is a good idea :-) All I did was add the Cygwin bin path to the regular Windows path. The other option would be to try another diff.exe that has less dependencies, I occasionally use http://unxutils.sourceforge.net/ but I've not tested it with svn patches (Cygwin works well enough for me). I vaguely remember seeing some comments about windows, newlines, and diffs in the reviewboard code so you could always try poking around in there. Good luck, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
