Re: Reviewboard + CentOS 5.3 + git -- problem with missing email notifications

2009-07-24 Thread Christian Hammond
Hi,

There's no logging of e-mail, but you could add it if you wanted to try.
You'd need to modify your reviewboard/reviews/email.py and at the top add:

import logging

And then in send_review_mail, before the message.send(), do:

logging.info("Sending e-mail with subject '%s' from '%s' to '%s', CC '%s'\n"
% (subject, from_email, to_field, cc_field)

Then restart your web server, go into your admin settings -> Logging and
specify a filename to log to that the web server can write to.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Jul 24, 2009 at 2:47 PM, joyjit  wrote:

>
> Hi Christian,
>
> Thank you for your response.
>
> Is there DEBUG flag or logging that I can enable that will provide me
> some visibility
> as to what review board is doing when it is supposed to send out email
> (but is not)?
>
> Currently, the only visibility I have is looking at my sendmail log
> file (/var/log/maillog)...
> and when I look at that file, I see reviewboard is just behaving
> erratically -- sometimes
> it sends email, and sometimes it doesnt.
>
> --Joyjit
>
>
> On Jul 24, 2:42 pm, Christian Hammond  wrote:
> > Hi,
> >
> > This is not a problem I've heard of before with Review Board. The only
> times
> > people have reported issues with sending e-mail, it turned out to be a
> > configuration problem on the mail server software. It's possible it's
> > rejecting those e-mails for some reasons (not trusting the From: we put
> in
> > or something).
> >
> > For all mail sending, we go through Django's mail API, which in turn uses
> > Python's built-in smtplib mail code. So any problem in actual
> transmission
> > would either have to be in Python (which I sort of doubt) or the mail
> > server.
> >
> > Unfortunately, I don't have any real ideas off-hand as to why you'd hit
> > this. Maybe somebody else has had this problem and will respond.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Fri, Jul 24, 2009 at 2:26 PM, joyjit  wrote:
> >
> > > Hi all,
> >
> > > I have managed to set up Review Board 1.0 on CentOS 5.3. We are using
> > > it with git.
> >
> > > It works great, except for one annoying problem -- it seems to be
> > > frequently (and apparently randomly) miss sending email messages.
> >
> > > For example, when one submits a patch for review (and publishes it),
> > > Review Board is supposed to send out an email message to all the
> > > reviewers. My installation of Review Board seems to be only doing this
> > > occasionally.
> >
> > > It is correctly configured to use sendmail. And it does occasionally
> > > send out the email notifications.
> >
> > > However, when I take a look at my servers mail log file (/var/log/
> > > maillog) I see that indeed, occasionally there is no trace of
> > > reviewboard to have even attempted to send out email messages.
> >
> > > -- Is anybody else seeing this problem?
> > > -- How can I help diagnose this problem ? (perhaps by turning on debug
> > > flags etc, but how?)
> >
> > > Thanks in advance!
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Reviewboard + CentOS 5.3 + git -- problem with missing email notifications

2009-07-24 Thread joyjit

Hi Christian,

Thank you for your response.

Is there DEBUG flag or logging that I can enable that will provide me
some visibility
as to what review board is doing when it is supposed to send out email
(but is not)?

Currently, the only visibility I have is looking at my sendmail log
file (/var/log/maillog)...
and when I look at that file, I see reviewboard is just behaving
erratically -- sometimes
it sends email, and sometimes it doesnt.

--Joyjit


On Jul 24, 2:42 pm, Christian Hammond  wrote:
> Hi,
>
> This is not a problem I've heard of before with Review Board. The only times
> people have reported issues with sending e-mail, it turned out to be a
> configuration problem on the mail server software. It's possible it's
> rejecting those e-mails for some reasons (not trusting the From: we put in
> or something).
>
> For all mail sending, we go through Django's mail API, which in turn uses
> Python's built-in smtplib mail code. So any problem in actual transmission
> would either have to be in Python (which I sort of doubt) or the mail
> server.
>
> Unfortunately, I don't have any real ideas off-hand as to why you'd hit
> this. Maybe somebody else has had this problem and will respond.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Fri, Jul 24, 2009 at 2:26 PM, joyjit  wrote:
>
> > Hi all,
>
> > I have managed to set up Review Board 1.0 on CentOS 5.3. We are using
> > it with git.
>
> > It works great, except for one annoying problem -- it seems to be
> > frequently (and apparently randomly) miss sending email messages.
>
> > For example, when one submits a patch for review (and publishes it),
> > Review Board is supposed to send out an email message to all the
> > reviewers. My installation of Review Board seems to be only doing this
> > occasionally.
>
> > It is correctly configured to use sendmail. And it does occasionally
> > send out the email notifications.
>
> > However, when I take a look at my servers mail log file (/var/log/
> > maillog) I see that indeed, occasionally there is no trace of
> > reviewboard to have even attempted to send out email messages.
>
> > -- Is anybody else seeing this problem?
> > -- How can I help diagnose this problem ? (perhaps by turning on debug
> > flags etc, but how?)
>
> > Thanks in advance!

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Reviewboard + CentOS 5.3 + git -- problem with missing email notifications

2009-07-24 Thread Christian Hammond
Hi,

This is not a problem I've heard of before with Review Board. The only times
people have reported issues with sending e-mail, it turned out to be a
configuration problem on the mail server software. It's possible it's
rejecting those e-mails for some reasons (not trusting the From: we put in
or something).

For all mail sending, we go through Django's mail API, which in turn uses
Python's built-in smtplib mail code. So any problem in actual transmission
would either have to be in Python (which I sort of doubt) or the mail
server.

Unfortunately, I don't have any real ideas off-hand as to why you'd hit
this. Maybe somebody else has had this problem and will respond.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Jul 24, 2009 at 2:26 PM, joyjit  wrote:

>
> Hi all,
>
> I have managed to set up Review Board 1.0 on CentOS 5.3. We are using
> it with git.
>
> It works great, except for one annoying problem -- it seems to be
> frequently (and apparently randomly) miss sending email messages.
>
> For example, when one submits a patch for review (and publishes it),
> Review Board is supposed to send out an email message to all the
> reviewers. My installation of Review Board seems to be only doing this
> occasionally.
>
> It is correctly configured to use sendmail. And it does occasionally
> send out the email notifications.
>
> However, when I take a look at my servers mail log file (/var/log/
> maillog) I see that indeed, occasionally there is no trace of
> reviewboard to have even attempted to send out email messages.
>
> -- Is anybody else seeing this problem?
> -- How can I help diagnose this problem ? (perhaps by turning on debug
> flags etc, but how?)
>
>
> Thanks in advance!
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Reviewboard + CentOS 5.3 + git -- problem with missing email notifications

2009-07-24 Thread joyjit

Hi all,

I have managed to set up Review Board 1.0 on CentOS 5.3. We are using
it with git.

It works great, except for one annoying problem -- it seems to be
frequently (and apparently randomly) miss sending email messages.

For example, when one submits a patch for review (and publishes it),
Review Board is supposed to send out an email message to all the
reviewers. My installation of Review Board seems to be only doing this
occasionally.

It is correctly configured to use sendmail. And it does occasionally
send out the email notifications.

However, when I take a look at my servers mail log file (/var/log/
maillog) I see that indeed, occasionally there is no trace of
reviewboard to have even attempted to send out email messages.

-- Is anybody else seeing this problem?
-- How can I help diagnose this problem ? (perhaps by turning on debug
flags etc, but how?)


Thanks in advance!

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---